GitLab

Detail:
  * Command line buffer for Wimp_StartTask (and anything that uses it,
    eg *WimpTask) increased from 256 bytes to 1024 bytes.
  * Top-bit-set message list pointers passed to Wimp_Initialise and
    Wimp_RemoveMessages now work (there was never a problem with
    Wimp_AddMessages!)
  * The fix for top-bit-set application name pointers in Wimp 4.65 actually
    only fixed lookup for "<application> may have gone wrong" lookups. They
    now work correctly in error window title construction, and when
    constructing an application sprite name if flag bit 8 is clear.
  * A pointer value of 0 is now accepted in addition to -1 for an
    "<application> may have gone wrong" lookup - this brings it into line
    with the other two places where the application name pointer is
    referenced.
  * When constructing an error window title, the Wimp would skip any leading
    backslash character. Now it does so when constructing "<application> may
    have gone wrong" too - this is a simple way to disable the application
    sprite in the error window.
Admin:
  Error box behaviour actually tested this time!

Version 4.67. Tagged as 'Wimp-4_67'

Detail:
        Added Martha directories to Resources/UK by directly coping and renaming Lazarus
        directory.

Admin:
      Work in progress on Martha build machine.

Version 4.66. Tagged as 'Wimp-4_66'

Detail:
  * Any top-bit-set sprite area pointer in a window definition was treated
    as a null pointer, and any top-bit-set program name pointer in
    Wimp_ReportError was similarly treated as a null pointer.
  * For 24-bit window colour builds, when the Wimp drew a title bar with
    the input focus, and there were sprite icons in the previously redrawn
    window, and the most recently plotted icon sprite was unpaletted and not
    selected or inverted, then the translation table for the icon sprite (in
    the RMA) would leak. I suppose that's what I get for re-using a bit of
    dead code without fully working out why it was bypassed in the first
    place...
  * The key handling code used to be over-eager to read bytes from the
    keyboard buffer: it would attempt to read up to 6 bytes ahead to ease
    the recognition of UTF-8 character sequences. This could cause problems,
    in particular if F12 was one of those 6 bytes, then any following bytes
    would be queued for use as Wimp keypresses, rather than being left in
    the keyboard buffer for use by ShellCLI. The Wimp now analyses the first
    byte read to make a sensible estimate of how many bytes it needs to read
    ahead.
  * Select-dragging (including Select-resizing) of windows with panes used
    to soak up all the processor time. This was because when the task
    received an Open_Window_Request, it would re-open the pane in front of
    the main window, but this would cause the Wimp to believe that it had to
    re-open the main window at the front of the stack again when Wimp_Poll
    was next called. The problem has been fixed so that the Wimp now
    examines all the windows in front of the drag window to see if they have
    the pane window flag bit set, and doesn't reshuffle the windows if they
    all do. (Actually, the test is performed such that foreground windows
    in front of the drag window are also ignored.)
Admin:
  Tested on a desktop machine.

Version 4.65. Tagged as 'Wimp-4_65'

  Updated to build using objasm instead of aasm.
  Sources changed to be objasm-compatible.
Admin:
  Requires Library 0.71 or later.
  Requires BuildSys 3.06 or later.
  Requires Env 0.65 or later.

Version 4.64. Tagged as 'Wimp-4_64'

Detail:
  1) The pointer to the module flags word wasn't made relative to the start
     of the module; because the linker bases an image at &8000 by default,
     this meant that the module flags pointer pointed at a word 32K too far
     into the image, and there were even chances whether a given build of
     the Wimp would appear to be 32-bit compatible.
  2) Due to a missing alignment directive in the Wimp's workspace layout, if
     you did a build of the Wimp where one or more of the ClickSubmenus,
     IconiseButton, StickyEdges or BounceClose switches were on but the
     PoppingIconBar one was off, you would end up with several word-sized
     locations being non-word-aligned. This affected embedded builds, where
     only the ClickSubmenus switch (new in Wimp 4.57) is typically set, but
     not desktop builds, where PoppingIconBar is typically set.
Admin:
  Only tested on a desktop machine so far, but this wouldn't have shown up
  either of the problems in the first place...

Version 4.63. Tagged as 'Wimp-4_63'

Detail:
  Instead of continually extending the menu windows icon by icon, this
    version calculates how many icons it is going to need, and claims
    them en bloc, marking all the icons as deleted so that as the menu
    code creates each icon, no more block extending needs to be done.
  int_create_multiple_icons does the extension work; the menu generation
    code in Wimp05 does the initialising before calling int_create_icon
    lots of times (3*number of items in menu)
Admin:
  Tested in a desktop build.

Version 4.62. Tagged as 'Wimp-4_62'

    Messages and CmdHelp files.
Admin:
  Required by BBE builds.

Version 4.61. Tagged as 'Wimp-4_61'

Detail:
  32-bitising introduced the bug: the routine copy_mode_specifier no longer
  preserves flags, but Wimp_SetMode was relying on it doing so. Wimp_SetMode
  has been changed to re-test the number of active tasks again after the flags
  have been corrupted.
Admin:
  Tested in a desktop build.

Version 4.60. Tagged as 'Wimp-4_60'

Version 4.59. Tagged as 'Wimp-4_59'

Detail:
  As soon as a menu or submenu that contains a writeable menu item is opened,
  the caret is placed in the (first) writeable menu item. Furthermore, you
  can highlight any other menu item in such a menu without losing the input
  focus from the writeable menu item.
  The initial reason for this change was to allow the use of writeable menu
  items on a touchscreen device, since they have no way for you to move the
  pointer over the writeable menu item without selecting it. But, on the
  basis that this change is actually useful for mouse users, and that it makes
  the behaviour of such submenus more consistent with dialogue boxes, it has
  been made unconditional.
Admin:
  Tested in a desktop build.

Version 4.58. Tagged as 'Wimp-4_58'

Detail:
  * Added new functionality for menu trees: submenus can now be opened by
    clicking on their parent menu item. This is particularly aimed at
    touchscreen devices, and is configurable via the new *Configure keyword
    WimpClickSubmenu.
  * Change to the menu inactivity timeout behaviour after auto-opening of
    submenus (either by hovering over the parent menu item or by the new
    click-to-open functionality): although all hover operations are still
    ignored for this period, any click operations *will* now be obeyed.
  * Corrected numerous misleading comments in the menu handling code.
  * Added some suspiciously absent ALIGNs in the *Configure keyword handlers.
  * Uses new ASCII case-forcing macros so there are now fewer warnings
    printed during assembly (and it should run faster now too).
  * Added an AREA directive so that objasm's -ABS switch is no longer needed.
  * Standardised ErrMem token across all Messages files that use English.
Admin:
  Tested on a desktop machine.
  Requires HdrSrc 1.06.

Version 4.57. Tagged as 'Wimp-4_57'

Detail:

  * Minor corrections applied to the Spanish sprites.  Affects the
    Lazarus resources only.

Admin:

  * Untested.

  * Similar changes applied to Bethany branch.

Version 4.56. Tagged as 'Wimp-4_56'

Admin:

  * Untested.  Fault noted in the Bethany project.

Version 4.55. Tagged as 'Wimp-4_55'

Detail:

  * Files changed include the Messages, Template and Sprite files, all of
    which now contain appropriate translated versions.

    This is a TRUNK version of the changes applied to the Bethany branch.

Admin:

  * Sprite files contain an equivalent set of sprites to those in the UK
    variant; these have been rationalised recently so as to remove duplicates
    contained in other software components.

  * New file structure preserved; this is NOT a direct copy from the Bethany
    branch version of the Wimp.

Version 4.54. Tagged as 'Wimp-4_54'

Detail:
  On previous Wimps, if you chose to disassociate the Wimp's physical colour
  mapping from the Wimp palette (using SWI Wimp_SetColourMapping), then
  subsequent calls to Wimp_SetPalette would write over the physical colour
  mapping instead of the Wimp palette. *WimpPalette, conversely, had the
  correct behaviour (ie it only ever affected the Wimp palette).
Admin:
  There are actually loads of remaining bugs in the Wimp regarding the
  subtle difference between the physical colour mapping and the palette. Some
  calls try to cause a screen redraw in some circumstances, generally the
  wrong circumstances, and without all the necessary internal Wimp variables
  having been reset (so for example, you might find that window borders end
  up ibeing rendered incorrectly). It probably hasn't all worked properly
  since RISC OS 3.1...

Version 4.53. Tagged as 'Wimp-4_53'

Detail:
  * The character codes returned from the Key_Pressed event were incorrect
    when the caret was in a writeable icon with Kd in the validation string,
    and either (a) the caret was not at the start and Delete or Backspace were
    pressed, or (b) the caret was not at the end and Copy was pressed. (This
    was because, in these cases, the writeable icon code exited through
    passbacktouser rather than exitprocess; the former expects the keycode to
    be preserved, but the UTF-8 extensions to key handling were corrupting it.)
    Shift-Copy, Ctrl-Copy and Ctrl-U were not affected.
  * The various checkhandle routines now preserve flags again, as they did
    before 32-bit support was added. This is crucial in a number of spots,
    because the flags are based upon a test of handle, and checkhandle
    corrupts the handle register. This fixes at least two bugs: you can now
    send messages to menus or dialogue boxes again, and Wimp_RedrawWindow
    called without a Redraw_Window_Request is back (so for example, the
    Desktop Welcome screen now works again).
  * Fixed a bit of errant 26-bitism in the multiple-window iconise code.
Admin:
  Tested briefly on an Ursula build.

Version 4.52. Tagged as 'Wimp-4_52'

Detail:
  When the last task closes, the Wimp tries to change to the configured screen
  mode (as determined using OS_ReadSysInfo 1). However, the Wimp was using
  VDU 22,x to set the screen mode, so results were undefined when the default
  screen mode was a pointer to a mode selector. The Wimp now uses OS_ScreenMode
  to change mode (except on RISC OS 3.1 builds where the SWI is not available).
Admin:
  Not tested.

Version 4.51. Tagged as 'Wimp-4_51'

Detail:
  Wimp 4.47-4.49 would die horribly if Wimp_CloseDown was passed an
    invalid task handle in R0 (the Repeat command in BootCommands does
    this!).  The pull is now unconditional.
Admin:
  Tested in Ursula build.

Version 4.50. Tagged as 'Wimp-4_50'

Detail:
  Title bar is not visible on the NC but it is still written to and must
  be indirected with 60 byte string.
  This fault was introduced in Wimp 4.48.

Admin:
  Should fix customer fault 075. Untested.

Version 4.49. Tagged as 'Wimp-4_49'

Detail:
  Removed palette from ptr_default and ptr_double srpites in
   NC2.UK resources.

Admin:
  Requires a boot structure that sets up the pointer colours
   as you want them.

Version 4.48. Tagged as 'Wimp-4_48'

Byrne.

Version 4.47. Not tagged

Detail:
  Lots of little changes throughout a lot of source.
Admin:
  Appears to work - not stress tested with things like lots of tasks, big
  transfers, and all the other things that tend to go wrong.

Version 4.47. Tagged as 'Wimp-4_47'

Detail:
  !WinEdit appears to have corrupted the Templates file when it was
  editted to change the Japanese translations.

  Hopefully rectified this by reapplying the translation changes using
  !FormEd.  Also changed the translation for the middle button in the
  error box back so that it reads "Cancel" (in Japanese of course).


Version 4.46. Tagged as 'Wimp-4_46'

Detail:
  Added Japanese translations received from customer into Messages
  and Templates files


Version 4.45. Tagged as 'Wimp-4_45'

Version 4.44. Tagged as 'Wimp-4_44'

Detail:
  The code that checked for a Wimp_Initialise version number of >= 380 before
  applying the new interpretation of title foreground colour &FF was broken:
  it was checking the current task handle instead of the task handle of the
  window's creator. A few other things needed tampering with in order to ensure
  that the window's task handle word is correctly set up at the time that the
  colour check is performed.
Admin:
  Tested in a desktop build, using STB resources.

Version 4.43. Tagged as 'Wimp-4_43'

Detail:
  * New STB Sprites, Templates and Tools files imported, based upon the
    Lazarus UI rather than the old STB UI.
  * STB build now includes WIMPSymbol.
  * No longer attempts to use WIMPSymbol font in UTF8 builds which didn't
    register the font in ResourceFS.
  * Simplified Resources directories by assigning only a single pair of
    Messages files to each locale, rather than for each UI directory within
    each locale directory. The only code change required is to make the Wimp
    error box always use the "Continue" token for NC/STB builds, rather than
    using one of "OK" and "Continue", as with desktop builds.
Admin:
  Not tested.

Version 4.42. Tagged as 'Wimp-4_42'

Detail:
  * New STB Sprites, Templates and Tools files imported, based upon the
    Lazarus UI rather than the old STB UI.
  * STB now includes WIMPSymbol.
  * No longer attempts to use WIMPSymbol font in UTF8 builds which didn't
    register the font in ResourceFS.
  * Simplified Resources directories by assigning only a single pair of
    Messages files to each locale, rather than for each UI directory within
    each locale directory. The only code change required is to make the Wimp
    error box always use the "Continue" token for NC/STB builds, rather than
    using one of "OK" and "Continue", as with desktop builds.
Admin:
  Not tested.

Version 4.42. Tagged as 'Wimp-4_42'

Detail:
  Removed Fresco sprites from sprite files.
Admin:
  Has yet to be tested in a ROM.


Version 4.41. Tagged as 'Wimp-4_41'

* NoCommandPrompt is disabled, so we'll get "Press SPACE or click mouse to
  continue" back again on exit from command windows
* UseAMBControl and StrongARM flags are no longer conditional, since the
  new STB kernel is guaranteed to support them

Version 4.40. Tagged as 'Wimp-4_40'

Version 4.39. Tagged as 'Wimp-4_39'

Detail:
  Removed onscreen keyboard sprites from a number of builds, these
  sprites are now held in NCKeyboard's resources.


Version 4.38. Tagged as 'Wimp-4_38'

Version 4.37. Tagged as 'Wimp-4_37'

Detail:

  * The top of the toolbar had a single pixel light-grey line along the
    edge.  This caused unpleasant twittering on TV displays.  Although
    the twittering is always going to be a problem, due to the boundary
    between the toolbar and the browser window, this small change to
    remove the light-grey line improves the situation.  A thick dark-grey
    line is now used instead which significantly reduces the effect of
    the twitter.

    (This change applied to NCFrescoRO also; I doubt whether the WIMP
    sprite pool version is actually used but I've changed this anyway
    just in case!)

Admin:

  * Tested as a softload on Lazarus hardware.

Version 4.36. Tagged as 'Wimp-4_36'

Detail:
  Title bars: one of the Ursula redraw optimisations was that if the title
  bar sprites had no mask, then the title bar is no longer filled in before the
  sprites are plotted. Lazarus' toolsprites were falling foul of this, because
  the title bar top and bottom sprites (tbarmidt/tbarmidb) had a lesser height
  than the end sprites (tbarlcap/tbarrcap). Because pre-Ursula Wimps filled
  in the title bar regardless, this may not have shown up in the past. The Wimp
  now has an additional check: if there is a gap between the title bar sprites,
  then it always fills in the title bar background before plotting the sprites.

  Error box buttons: the "illuminated" side of the 3D plinths have always been
  white, so they were getting lost against the white Lazarus UI background.
  Used Ursula Wimp icon colour validation string extension to colour the
  borders a uniform grey.

Admin:
  Tested on a desktop machine, soft-loading the Lazarus Wimp resources.
  Fixes faults 1115 and 1121.

Version 4.35. Tagged as 'Wimp-4_35'

Detail:
  * Added missing Resources/UK/Ursula/CmdHelp file.
  * Added missing Resources/UK/Ursula/Messages file.
Admin:
  * Tested on build 'Ursula'.

Version 4.34. Tagged as 'Wimp-4_34'

Detail:

  * Added the toolbar level indicator sprites; they were accidentally
    missed out of the previous set of sprites.

Admin:

  * Untested, but the new sprites should appear in the right location on
    the browser toolbars.

Version 4.33. Not tagged

Detail:

  * New WIMP sprites for the updated Lazarus user-interface.

Admin:

  * Tested on new LazarusUI and NCFresco as a softload on Lazarus hardware.

Version 4.33. Tagged as 'Wimp-4_33'

(This stops system font character 128 being reprogrammed to a tick, and also
stops the desktop font being switched to WimpSymbol when character 128 is
encountered.)

Version 4.32. Tagged as 'Wimp-4_32'

Detail:

  Changes made to Lazarus resources only in progressing towards the
  final UI for the IAC.  Affected files are:

    * Sprites: reduced-palette sprites used where possible to minimize
      memory usage.

    * Templates: the foreground colour of icon #0 in the error dialogue
      box has been altered to be colour 0 (black) in line with the
      other template changes made in previous versions.  (This icon
      was accidentally missed.)

Admin:

  Minor changes, but untested.

Version 4.31. Tagged as 'Wimp-4_31'