GitLab

Sprout from master 2015-01-16 01:01:12 UTC Jeffrey Lee <jlee@gitlab.riscosopen.org> 'Escape some dollars'
Cherrypick from master 2009-05-31 17:32:26 UTC Peter Naulls <pnaulls@gitlab.riscosopen.org> 'Rationalize C include path usage':
    rlib/EditIntern/h/message

Detail:
  s/modulewrap - Escape some dollars contained in strings to avoid warnings from objasm
Admin:
  Resulting binary unchanged (FilerAction)


Version 5.83. Retagged as 'RISC_OSLib-5_83'

Detail:
  kernel/s/k_body, s/initmodule - Escape some dollars contained in strings to avoid warnings from objasm
Admin:
  Resulting binary unchanged


Version 5.83. Retagged as 'RISC_OSLib-5_83'

dbox.c: address of cancelled by dereference
event.c: spelling
txtar.c: don't grab the caret when clicking toggle size
txtedit.c: use BOOL for a boolean
win.c: when looking at the behind window handle we want -1 not 'DUD' (which happens to be -1)
wimp.h: add comment about window handle -3
Retagged as RISC_OSLib-5_83.

Version 5.83. Not tagged

Detail:
  Makefile - Get the -depend option from ${STDTOOLOPTIONS}; also allows us to pull in the throwback flag. Fix all ${AS} calls to use ${AFLAGS} so that dependencies are tracked properly.
Admin:
  Identical to previous binary


Version 5.83. Retagged as 'RISC_OSLib-5_83'

Detail:
  rlib/s/rlibdata - Reduce RlibSpace by 1, to take into account the removal of a static from rlib/c/xfersend
Admin:
  Tested on BB-xM
  Fixes 'Static data size in library and stub disagree' error when running ROM apps


Version 5.83. Retagged as 'RISC_OSLib-5_83'

menu.c/menu.h:
Add a new menu_setcolours() function to allow the fore/background colour bits to be set on a menu entry.
colourmenu.c:
Use the new menu_setcolours() function instead of making assumptions about menu's internal structure layout.
dbox.c/dbox.h:
New functions dbox_hidefield and dbox_unhidefield added to complement the fade/unfade ones.
As dbox_findicon/findiconbefore are only ever used to find writables, rename them as such. Also, make them find writable (type 15) AND writable draggable (type 14) icons.
Allow navigation by tab/shift tab through icons like the Style Guide chapter 16 says we should. In fact it's a little odd that dbox is emulating 'Ktar' validation itself manually when the Wimp has done this since version 2.92, but maintaining it is less effort than going and checking all the templates.
Fix bug when looking for leading capital letter matches to complete a dbox, the previous code was looking at the cached copy of the icon flags in d->window rather than the ones the Wimp is actually showing on screen (as might have been modified by dbox_fadefield() for example), so it was possible to complete a dbox for an icon which wasn't visible or selectable.
Fix bug when looking for leading capital letter matches when the icon doesn't have any text - the template file format is defined as being 0x0D terminated. This would then lead to 'R' and 'S' being accepted as matches having run off the end of the text buffer and into the validation string (which usually contains an 'R' or 'S' validation first). Changed to accept any control terminator.
event.c:
When force closing the current menu, don't forget to set the two state variables back to 0.
fileicon.c/resspr.c/txt1.c/txtundo.c/wimp.c:
Use existing pointer type definitions.
flex.c:
Treat bools as bools and pointers as pointers.
Say something useful in an error box if flex fails its internal consistency check, rather than just data aborting.
font.c:
Remove ROM conditionals from around font_readdef() function, always include the function.
fontselect.c:
Use font_readdef() rather than local copies of the exact same function.
txtedit.c/txtfile.c/txtfind.c/txtedit.h:
Remove redundant 'deletepending' state variable, and confusion over 'selectrecent' being a bool.
Call os_byte directly rather than passing to os_cli("*FX").
Other minor tidy ups.
wimpt.c:
Mark messages list as a constant.
xferrecv.c:
Also preserve the size member while recycling the xferrecv_ack message block, rather than corrupting it as 256.
xfersend.c/xfersend.h:
Take out the leaf name formulator as a common function for the two places to use it. This also allows the function to return the length of the leaf name so the correct message block size can be used. Inspection with MsgMon/!Reporter was showing that all xfersend initiated saves were passing the leaf name padded to 256 with garbage.
Reindent a few functions.
Make the draggable sprite replacement follow the same validation string rules as the Wimp, previously only ";s" was accepted, so upper case 'S' and validation strings that start with the sprite validation didn't work.
xfersend_pipe() function prototype changed to match xfersend() more closely - not being able to respond to the context of a wimp_eventstr made this function practically unusable.
akbd.h:
Windows logo and menu keys defined.
flex.h/help.h/wimpt.h
Some typos in comments.
wimp.h:
Missing wimp message action codes and structure defs added for completeness.


Version 5.83. Not tagged

Edit-1_70 and SrcEdit-1_28 no longer require these private headers.

Version 5.83. Not tagged

Detail:
  These were previously languishing in the C compiler sources, but they
  belong in the C library. Note however that the library does not implement
  the functions described in these headers at the present time, so any
  attempt to use them will result in link-time errors.
Admin:
  Untested (known not working)

Version 5.83. Tagged as 'RISC_OSLib-5_83'

menu.c: if NULL return -1, this has the added advantage that a menu maker (see event_attachmenumaker) can return NULL to mean "no menu thanks" and not data abort in event.c
dbox.c: if NULL return 0, this is somewhat consistent with template_syshandle()
menu.h: typo in comment corrected

Version 5.82. Tagged as 'RISC_OSLib-5_82'

Detail:
  Large file support made use of long longs in various definitions. These
  were switched out in PCC mode, but no allowances were made for the fact
  that C90 doesn't define long long either.
  Remember that to force cc to use non-builtin standard headers, you need
  to point at these using the -j switch (e.g. -jC:). The only version of
  cc which featured the C90-incompatible stdio.h was 5.70.
Admin:
  Checked that the header now works when included in -pcc, -c90 and -c99 modes.

Version 5.81. Tagged as 'RISC_OSLib-5_81'

msgs.c: includes a MessageTrans parser that duplicates MessageTrans_Lookup (needed because the lookup function returns pointers to static C strings). However, did not allow '?' wildcards in the message token names.

Version 5.80. Tagged as 'RISC_OSLib-5_80'

Detail:
  kernel/s/k_body - At CopyUpDone in _kernel_system(), a big block of conditional code was converted to unconditional as part of the 32bit conversion process. However one line for setting up the error handler remained conditional, potentially preventing the correct error buffer pointer being set when about to start the child task.
Admin:
  Tested on BB-xM


Version 5.79. Tagged as 'RISC_OSLib-5_79'

Fix for problem passing long command lines via system(), while there are good arguments to leave the threshold at 255, non DDEUtils aware programs get brutally truncated command strings, and since the old threshold of 255 applied when the kernel handled 256 command lines, upping the limit to 1k is no worse than before.
Fix for Edit failing to draw lines of text longer than 192 characters (ticket #350). Several factors were conspiring here: on a mode change the window width in characters wasn't being clamped, whereas user entered limits in the menu were, then the internal buffer ("PAINTBUFSIZE") was too short so lines got truncated, and when larger than 256 got wrapped modulo 256 due to the use of an array of chars. Now set at compile time with BIG_WINDOW_SIZE_LIMIT with a new theoretical maximum of 8192. Currently limited to 480 since it uses stack variables.

In the C library:
 armsys.c: adapt the threshold at which to use DDEUtils based on the kernel version number
 scanf.c: squash a warning
 time.c: mark the table of month lengths as constant so we can claw back 13 words of static workspace without having to change the stubs

In RISC OS lib:
 bbc.c: remove local definitions of some SWI numbers
 template.c: squash a warning
 txt.c: delete Modula-2 support
 txt1.c: compare pointer with NULL not an integer
 txtar.c: introduce BIG_WINDOW_SIZE_LIMIT, rationalise a few sprintf's, mark private functions as static
 txtundo.c/txtedit.c: squash old style function warnings
 txtoptmenu.c: clamp the window width read from Edit$Options properly, delete long disabled code
 txtscrap.c: dead function deleted


Version 5.78. Tagged as 'RISC_OSLib-5_78'

Detail:
  SWIOptions,feb - Add BlendTable and InverseTable SWIs to the generated swis.h
Admin:
  Tested in OMAP3 ROM build


Version 5.77. Retagged as 'RISC_OSLib-5_77'

font.h: missing flags defined (those flags that can be used without needing to change the prototype of font_paint()
fontlist.h: comment typo
No code changes, retagged as RISC_OSLib-5_77

No code change, retagged as RISC_OSLib-5_77.

s/h_brazil: use Hdr:System instead of GETting them one at a time
c/scanf: type cast

Version 5.77. Tagged as 'RISC_OSLib-5_77'

In this situation, the conversion should fail.
Fixes ticket #252.

Version 5.76. Tagged as 'RISC_OSLib-5_76'

This is in the 'SprExtend' header, which messes up the alphabetical ordering a bit.

Version 5.75. Tagged as 'RISC_OSLib-5_75'

Detail:
  This change was first applied to the inbuilt headers in the C compiler at
  version 5.59 (07 Apr 2005), but was accidentally not copied into the
  RISC_OSLib version of math.h. Fortunately, this would only have affected
  anyone compiling software with the -jC: switch.
Admin:
  Untested, but should be a safe change.

Version 5.74. Tagged as 'RISC_OSLib-5_74'

While the txtedit part of RISC_OSLib has never been famed for its adherence this brings the delete operation (^K ref Style Guide p38, !ResEd, and the drag & drop protocol specification) into line.

Version 5.73. Tagged as 'RISC_OSLib-5_73'

Detail:
  Makefile - The symbols file that gets generated during the build now gets copied to the install folder for ROM builds. This allows it to be picked up easily by debugging tools.
Admin:
  Tested with BCM2835, OMAP3 & Disc builds


Version 5.72. Retagged as 'RISC_OSLib-5_72'

Detail:
  c/armsys - _desktop_report now always caches the error message in the local error block. This avoids the error potentially being overwritten with "Task not known" if TaskManager_TaskNameFromHandle fails.
Admin:
  Tested on Raspberry Pi


Version 5.72. Tagged as 'RISC_OSLib-5_72'

This is the other half of !Edit, which now uses the centralised awk script to insert its version number into about boxes.
Retagged as RISC_OSLib-5_71.

Detail:
  SWIOptions,feb - Added VCHIQ to SWI header list
  Makefile - Add SWIOptions as a dependency to s.swioptions, so exported swis.h will rebuild correctly if SWIOptions is changed
Admin:
  Tested briefly


Version 5.71. Tagged as 'RISC_OSLib-5_71'

Detail:
  kernel/s/k_body - Now ignores unaligned PC values, as they either indicate stack corruption or Thumb use (which the unwind handler doesn't support anyway)
Admin:
  Tested on Raspberry Pi with high processor vectors


Version 5.70. Tagged as 'RISC_OSLib-5_70'

Following an earlier fix, the logic of mktime() has turned out to need reviewing too.
To summarise
  time() -> a UTC time in seconds
  gmtime() -> breaks down a UTC time into components
  localtime() -> breaks down a UTC time into local components (tz + DST)
  mktime() -> converts local components back into UTC time, normalising
In mktime(), the current locale (via setlocale()) is considered and used to choose the timezone, assuming an appropriate territory module is loaded.
The value of the tm_isdst field is factored into the offset calculation.
However, mktime() is also defined as normalising the components of time and updating the caller's block with normalised values, in local time, so the local offset is reapplied at the end.

Moved time_to_tm up in the function so mktime() can use it.
Corrected/lined up some comments.
Also, mktime() no longer forces tm_isdst to -1, it preserves the user's value, so consecutive mktime()s are consistent.
Added test to "test/tzones...

  Ammended time() to match ISO9899 and just return UTC like it says.
  Inlined the single use of _bbctime() macro.
locale.c
  The timezone within a territory can now be specified as part of the setlocale() function.
  This uses a qualifier to the already accepted territory name, for an example see test/tzones.c
  Shock addition of some comments to the locale parsing function.
  To avoid needing to mess about with C library workspace the timezone and territory are encoded internally into 1 word, with 10 bits allowing up to 1024 territories worldwide.
  Ripple through to strftime().
time.c
  localtime() updated to respect locale selection.
test/file,gen_inputs,test64
  Copyright headers added.

Output compared with Windows XP using setlocale versus tzset to shift the program into Pacific time.

Version 5.68. Tagged as 'RISC_OSLib-5_68'

Detail:
  clib/s/cl_entries - Symbol names containing $'s are now wrapped in |'s to prevent potential unintended variable expansion
  s/h_modmacro, s/h_stubs - Modify Entry/Entry2 to not add their own vertical bars to symbol names (causing two sets of bars that cancel each other out)
Admin:
  Tungsten ROM version identical to before when built under objasm
  Needs Library-1_54 for ROM link symbol files to be generated correctly


Version 5.67. Retagged as 'RISC_OSLib-5_67'

Detail:
  kernel/s/k_body - NOP in Aborted2 is only needed if we're targeting StrongARM
  s/longlong - Make ReadCPUArch StrongARM & ARM2 safe
Admin:
  Tested in IOMD ROM softload


Version 5.67. Tagged as 'RISC_OSLib-5_67'

Detail:
  SWIOptions,feb - Now includes ZLib module SWIs
Admin:
  SWI export tested, seems OK


Version 5.66. Not tagged

Detail:
  s/longlong - Only look for ARMv5 support when deciding if CLZ is available, not ARMv5T
Admin:
  Tested in OMAP3 ROM


Version 5.66. Tagged as 'RISC_OSLib-5_66'

Was being used to conditionalise things which aren't really StrongARM related, now should be read as "support split I+D caches" switch.

Version 5.65. Tagged as 'RISC_OSLib-5_65'

Retagged as 5.64.

Detail:
  A minus sign was missing - this meant that any module built using stubs
  from the last 2 weeks would branch through zero at the end of initialisation.
Admin:
  Modules now work again!

Retagged as 'RISC_OSLib-5_64'

Version 5.64. Not tagged

Detail:
  * Added 64-bit file pointer API support, following the LFS spec v1.5
    (see Docs directory). Internally, now uses 64-bit file pointers
    exclusively. For now, the backend still limits you to 4GB-1 files, but
    clients of the C library won't need recompiling again to support larger
    files than this once they use the new API.
  * Fixed a large number of warnings produced in compilation, assembly and
    linking, many of them new and resulting from the improved checks in the
    latest toolchain.
  * Increased the maximum stream buffer size from 16MB to 1GB.
  * Added Hdr:SDFS and Hdr:SDIO to the list of headers used to build swis.h
    if they are present.
Admin:
  Verified that the new 64-bit file pointer buffering code works using a
  ROM build (since the toolchain makes extensive use of reading, writing
  and seeking internally).

Version 5.64. Tagged as 'RISC_OSLib-5_64'

Detail:
  Last revision broke _ll_mullu (the runtime support function for multiplying
  a 64-bit integer by an unsigned 32-bit integer) except for ROM builds that
  target CPUs with the M extension. So in practice, IOMD ROMs and softloadable
  C libraries both exhibited the bug.
Admin:
  Verified that the compiler will now run against this C library (previously
  it reported many non-sensical errors).

Version 5.63. Tagged as 'RISC_OSLib-5_63'

Be more quiet when cleaning.
STM/LDM changed to Push/Pull.
Moved an illegal instruction back into ARM's illegal instruction space.

Version 5.62. Tagged as 'RISC_OSLib-5_62'

Detail:
  s/longlong - The code has always had the ability to use CLZ & long multiply instructions, but it's never been enabled. The nonfunctional code to detect the CPU architecture at runtime has been disabled, and instead a fixed configuration is selected at compile time with the help of Hdr:CPU.Arch. Also added lots of ROUT's for safety.
  s/objmacs - Updated push/pop macros to make use of LDR/STR when only one register is to be transferred. This fixes a few objasm 4 warnings and should result in a speed boost where applicable.
Admin:
  Tested on rev A2 BB-xM.
  Different math code configurations tested briefly.


Version 5.61. Tagged as 'RISC_OSLib-5_61'