1. 28 Dec, 2022 1 commit
    • Jeffrey Lee's avatar
      Fix capturing of registers in ErrorHandler · fa1741d9
      Jeffrey Lee authored
      Back in RISCOS_Lib 5.35, a bug was introduced in ErrorHandler where it
      would try saving the registers to a garbage address for SCL builds where
      SASTMhatbroken is false. This bug has gone unnoticed until now because
      up until a few months ago, SASTMhatbroken was always true (commit
      3b7d39bd in RISCOS_Lib 6.13).
      Move the offending line of code out of the SASTMhatbroken block so that
      register capturing will work correctly for all build configs.
      Fixes issue reported on the forums (tested with a ROM build on Pi 4):
      Version 6.16. Tagged as 'RISC_OSLib-6_16'
  2. 21 Sep, 2022 1 commit
    • ROOL's avatar
      CLib header updates · 1ad41a2d
      ROOL authored
        Sync the disc copies of the compiler's internal headers from cc 5.89.
        Add <stdalign.h> and <stdnoreturn.h> and <uchar.h> in support of C18.
        Now the compiler sets __STDC_VERSION__ appropriately on the nightly builds it
        is no longer necessary to use predefine 'DDE' to enable those additions.
      Version 6.15. Tagged as 'RISC_OSLib-6_15'
  3. 20 Aug, 2022 4 commits
    • Jeffrey Lee's avatar
      More flexible handling of atomics on pre-ARMv6K · afa04ff1
      Jeffrey Lee authored
      For pre-ARMv6K, we generally have two sets of atomic routines available:
      * Fast routines which use a SWP spinlock, but are unsafe for use from
      interrupt handlers and the like
      * Safe routines which disable IRQs, but (in usermode) are much slower
      due to requiring SWI calls to enable/disable IRQs.
      Currently CLib decides which set of routines to use: modules get the
      slow & safe ones, while applications get the fast & unsafe ones.
      This change gives control of that choice to the program, by introducing
      the _kernel_init_flags variable. The stub code will (weakly) import this
      symbol and pass the value to CLib when calling the init SWI. CLib will
      then use the value to decide whether to fill the stubs with the safe or
      unsafe versions of the routines.
      With this change, the default is now to use the slow & safe routines,
      for both modules and applications. This is to ensure that code which is
      written/tested for ARMv6K+ machines won't run into unexpected issues
      when run on older machines (since the ARMv6K+ routines are safe for use
      from all execution contexts). The init flags are used to opt-in to the
      unsafe routines.
      Clients which are directly linked with CLib (ROM code, ANSILib) should
      be unaffected by this change, and will continue to use the safe
      routines, as before.
      Version 6.14. Tagged as 'RISC_OSLib-6_14'
    • Jeffrey Lee's avatar
      Remove ARMv8 atomic routines · 934d7520
      Jeffrey Lee authored
      They need more optimisation before they're worth using over the ARMv7
      routines; probably rewriting so that there are separate instances for
      barriers vs. non-barriers.
    • Jeffrey Lee's avatar
      Add C11/C18 stdatomic.h implementation · ba404a22
      Jeffrey Lee authored
      This implementation relies heavily on a new set of _kernel_atomic_*
      functions which implement all the atomic operations.
      Multiple different implementations of the functions are provided, to
      cater to all machines from ARMv2 to ARMv8.
      When targeting multiple CPU architectures, multiple variants will be
      compiled into the module, and the most appropriate variant will be
      selected at runtime when the client's stubs are filled in (using an
      extended version of the existing PickRoutineVariant system).
      Currently ROM clients will just use the variant for the oldest
      enabled architecture, to avoid the performance hit of runtime switching
      on every function call.
      The 40 new routines have been placed in a new library chunk (#6), so
      that old CLibs will properly reject any client that tries to use them,
      and to avoid ~500B of stubs bloat for programs that don't use them.
      Test & benchmark code is provided in the test/atomic folder.
    • Jeffrey Lee's avatar
  4. 16 Jun, 2022 1 commit
    • Ben Avison's avatar
      Tweak swis.h for older C standards · 98606082
      Ben Avison authored
      Prior to C18, you couldn't have duplicate typedefs (even if identical) so
      if you `#include` both `<stdio.h>` and `"swis.h"` the `typedef __va_list`
      conflicted if you specified `-c90` or `-c99`. (The header was already
      incompatible with `-pcc`.)
      Version 6.13. Not tagged
  5. 15 Jun, 2022 3 commits
    • Ben Avison's avatar
      Reduce _swi/_swix stack usage · 0e8e4385
      Ben Avison authored
      The (previously StrongARM-bracketed) code was overallocating stack space
      by 3 words in order to retain compatibility with the now-deleted dynamic
      code build variant.
      Version 6.13. Tagged as 'RISC_OSLib-6_13'
    • Ben Avison's avatar
      Add variants of _swi and _swix that take a va_list · 4ddb0942
      Ben Avison authored
      These are typically useful for wrapper functions that want to do something
      before and/or after a SWI call, and which therefore need to pass a pointer
      to their own variadic arguments into the guts of _swi or _swix.
      The pairs of functions _swi and _vswi, and _swix and _vswix, are almost
      identical, differing only in argument marshalling.
      There being only two additional entries, I didn't think it was worth
      introducing a whole new library chunk. Instead, I've tacked them onto the
      end of chunk 2 (the basic clib functions).
      Note that this means that any applications that use these new entries will
      need to take responsibility for RMEnsuring this version of the
      SharedCLibrary module and softloading a newer one if necessary.
    • Ben Avison's avatar
      Retire StrongARM build switch · 3b7d39bd
      Ben Avison authored
      Harvard caches are here to stay - can't conceive why we'd ever want to build
      binaries that didn't support them again.
      SASTMhatbroken is now conditional on the target (i.e. lowest supported)
      architecture being 4 or below - i.e. the workaround for the StrongARM bug
      isn't needed for ROMs targeting ARMv5 or above.
  6. 21 May, 2022 1 commit
  7. 16 May, 2022 3 commits
    • Ben Avison's avatar
      Enable GitLab CI/CD · 0c546b02
      Ben Avison authored
      * Enable GitLab CI
      * Address issues identified by CI jobs, excluding those related to cppcheck
      * Enable GitLab CD for stubs (used implicitly when linker is invoked by cc)
      Version 6.12. Tagged as 'RISC_OSLib-6_12'
    • Ben Avison's avatar
      Auto-create empty directories · 27fc5b5f
      Ben Avison authored
      * Remove empty directories and have the Makefiles create them
      * Consolidate and complete .gitignore
    • Ben Avison's avatar
      Cross-compilation support · a3bda86e
      Ben Avison authored
      * GNUmakefile: add translation of Makefile to GNU make / cross-compilation
        requirements (this component is too non-standard to make much use of the
        shared makefiles)
      * Makefile: comment out rules for objects that aren't used for any targets,
        for clarity; don't clean files that are never created
      * Various: change to using OS-agnostic filename path syntax
      * Various: ensure case matches for filename paths (don't assume host filing
        system is case-agnostic)
  8. 22 Nov, 2021 1 commit
    • Stuart Swales's avatar
      [535] fminf(x,y) / fmaxf(x,y) corrupt result for equal non-zero parameters · ebee6f7d
      Stuart Swales authored
        fminf(x,y) / fmaxf(x,y) corrupted the result when x==y and x!=0.0 due to
        ANDing/ORRing a single precision register with the high word of a double
        precision register pair when fixing up signs for mixed +/- 0 parameters
        in an analogous fashion to fmax/fmin (which are correct).
      Version 6.11. Tagged as 'RISC_OSLib-6_11'
  9. 13 Nov, 2021 2 commits
  10. 06 Feb, 2021 1 commit
  11. 05 Sep, 2020 1 commit
    • Ben Avison's avatar
      Enable modulewrapped applications to use ResGen · 073ebc25
      Ben Avison authored
      This utilises a weak symbol import so that if the symbol `Resources` resolves
      at link time, it is called to discover the address of the resource file data
      block(s) to be installed in ResourceFS. If this fails, it drops back to using
      the `s.ResFiles` source file as previously, thereby ensuring compatibility
      with components that have not yet been converted to use ResGen.
      Since `Resources` is the default area name (and thus discovery function name)
      used for ResGen in the shared makefiles, this makes it as simple as possible
      to utilise it.
      Version 6.08. Tagged as 'RISC_OSLib-6_08'
  12. 06 Jul, 2020 1 commit
    • Jeffrey Lee's avatar
      Adjust 26 vs. 32 bit mode checks · fa89c230
      Jeffrey Lee authored
      As noted in https://www.riscosopen.org/forum/forums/9/topics/15359, MRS
      instructions which are executed in user mode may return unknown values
      for the CPSR E, A, I, F and M fields on ARMv8 CPUs. At the moment the
      only observed deviation from normal behaviour is that CPUs which lack
      AArch32 privileged-mode support may return zero for the fields. This was
      found to confuse some 26 vs. 32 bit mode checks in CLib.
      Clearly we're a long way away from having a version of RISC OS which can
      run on a CPU that lacks AArch32 privileged mode support, but we can
      still try and make sure user-mode applications are compatible with them.
      So this change adjusts the mode checks in the stubs and overlay manager
      so that programs linked with them should function correctly (TEQ is now
      used instead of MRS)
      Note that once we do start porting RISC OS to one of the troublesome
      CPUs, there are many more potentially troublesome MRS's within the
      module code that will need adjusting, especially if CPUs start returning
      values other than zero.
      Version 6.07. Tagged as 'RISC_OSLib-6_07'
  13. 09 May, 2020 2 commits
    • Jeffrey Lee's avatar
      txtar: Support extended scroll requests · d3688b4c
      Jeffrey Lee authored
      Use extended scroll requests to handle mouse wheel scrolling, to avoid
      the "thumbing" code getting confused and thinking the user is dragging
      the scrollbar (the "thumbing" mode of scrolling isn't desirable for the
      mouse wheel, because it largely ignores the requested scroll distance)
      This change allows Edit & SrcEdit (and anything else using txtar) to
      handle the scroll wheel better, now that the WindowScroll module is
      controlling things.
      Version 6.06. Tagged as 'RISC_OSLib-6_06'
    • ROOL's avatar
      Extra rlib sprite function for ROM stubs · f41e4118
      ROOL authored
        Export sprite_put_mask_scaled when UROM.
        Also, delete sprite_put_greyscaled() which has been unimplemented in SpriteExtend since RISC OS 3.60.
        Required by Paint bounty.
      Version 6.05. Not tagged
  14. 06 May, 2020 4 commits
    • ROOL's avatar
      Fix switch to wrong mode in AbortFindHandler · ae6fe48b
      ROOL authored
        Was (trying to) clear the M32 flag in {CONFIG}=32.
        Ref: https://www.riscosopen.org/forum/forums/1/topics/15080?page=1#posts-99441
        Makefile updated to only pass rlib's txt switch when building rlib.
      Version 6.05. Tagged as 'RISC_OSLib-6_05'
    • ROOL's avatar
      Add C11/C18 library functions · eef62ec8
      ROOL authored
        alloc.c - Add aligned_alloc(). Since softloaded versions of the C library can't rely on OS_Module 24 being available there is a fallback implementation for older kernels.
        stdlib.c - Add quick_exit() and at_quick_exit(). Also fix bug in _Exit; a missing loop pre-decrement led to only checking a single (out of array bounds!) vector.
        time.c - Add timespec_get().
        cl_entry2 - 4 new functions added to the stubs.
        Reduce spare CLib static workspace to absorb the quick_exit() handlers, remove the unused words from armsys.c so they're all accounted for in one space.
        In order that the functions can be defined in the stubs now (despite not having a compiler to support C11/C18) they are enabled when 'DDE' is defined so that C library builds work.
    • ROOL's avatar
      CLib header updates · 948e0838
      ROOL authored
        assert.h - definition of static_assert
        complex.h - definition of CMPLX[F|L]
        float.h - various implementation defines
        stdio.h - hide gets() as it's been withdrawn
        wchar.h - guard mbstate_t as it can also be in uchar.h, fix missing __valist definition
        In order that the functions can be defined in the stubs now (despite not having a compiler to support C11/C18) they are enabled when 'DDE' is defined so that C library builds work.
    • ROOL's avatar
      Add fopen's exclusive mode · 68fc9d43
      ROOL authored
        Remove undocumented 't' mode which forcibly timestamped files, since other operating systems use this to denote a text file (as opposed to 'b' binary mode).
        Add 'x' mode per ISO9899:2018
        * only applies to 'w' mode files (not 'r' or 'a')
        * file must not exist prior to creation
        * beyond that we rely on RISC OS' policy of only allowing a file to be opened once for writing as our exclusivity
        Also fix bug in check for 'Protected disc' error, which only trigged for fsnumber_ADFS (8).
        Tested in a ROM build with a simple test harness.
  15. 22 Apr, 2020 1 commit
  16. 20 Jul, 2019 1 commit
  17. 29 Jun, 2019 2 commits
  18. 09 Jun, 2019 1 commit
    • ROOL's avatar
      Build fix · 20984a33
      ROOL authored
        Add missing function draw_create_diag() to the ROM version of RISC_OSLib, required by Paint-2_24 and later.
        To keep ROM footprint to a minimum, export only that function; this also avoids adding static workspace and needing to increase RlibSpace.
      Version 6.01. Tagged as 'RISC_OSLib-6_01'
  19. 17 Mar, 2019 1 commit
    • ROOL's avatar
      Build fix · 6982f5cc
      ROOL authored
        Add wimp_autoscroll to rlib entries.
      Version 6.00. Not tagged
  20. 16 Mar, 2019 1 commit
    • ROOL's avatar
      CLib and rlib header updates · 0c846685
      ROOL authored
        Export fenv.h (omitted in error).
        Add FP_FAST_FMAL and FP_FAST_FMA defines per C standard
        Submission for ARMv7 Compiler bounty.
        Add Wimp_AutoScroll supporting function to rlib.
        Export various related defines for autoscroll use.
        Submission for Clipboard Support bounty.
      Version 6.00. Tagged as 'RISC_OSLib-6_00'
  21. 09 Feb, 2019 1 commit
    • ROOL's avatar
      Fix to iconbar menu X offset · 2f520d7e
      ROOL authored
        The fix applied to all menus in event.c revision 4.6 didn't take into account the offset of -16 already applied to iconbar menus.
        Tested with Draw-1_31.
      Version 5.99. Tagged as 'RISC_OSLib-5_99'
  22. 26 Jan, 2019 1 commit
    • Robert Sprowson's avatar
      Various fixes · a8f233bb
      Robert Sprowson authored
      colourtran.c: Swap round arg names to colourtran_colournumbertoGCOL to match prototype.
      txtar.c: Avoid incorrect use of strncat buffer limit, and possible unterminated string after strncpy, by reexpressing using snprintf.
      txtedit.c: Avoid incorrect use of strncat buffer limit by reexpressing using snprintf. Avoid potential NULL pointer dereference by moving the filename copy inside the 'if' which confirms it's non-NULL.
      txtfind.c: Remove repeated check of repls being valid. Free repls on error. Free pat on error.
      xfersend.c: Fix potential out of bounds array access (of leaf[]) if the leafname length exceeds the space in the Wimp message.
      Found by cppcheck static analysis.
      txtopt.c/h: Sprinkle in some consts.
      event.c: Open menu at the Style Guide approved offset of 64.
      xfersend.c: Remove redundant check of xfersend__filename being NULL in xfersend__suggest_leaf() as all paths leading to it being called ensure the allocation exists (also, it would have strcpy'd garbage due to malloc not clearing the allocation).
      Removed unused header txtover.h.
      Version 5.98. Tagged as 'RISC_OSLib-5_98'
  23. 11 Jun, 2018 1 commit
    • Jeffrey Lee's avatar
      Fix to CopyError change · 0a8fe9be
      Jeffrey Lee authored
        kernel/s/k_body - CPSR_f is the correct field for the NZCV flags, not _c
      Version 5.97. Tagged as 'RISC_OSLib-5_97'
  24. 10 Jun, 2018 1 commit
    • Jeffrey Lee's avatar
      Try and avoid blocking callbacks · 73fd8884
      Jeffrey Lee authored
        The kernel has a 'callback postponement flag' which will be set whenever an X SWI, called from user mode, returns a pointer to an error (and the error block looks like it's in RAM).
        Although this flag will help prevent the error buffer from being overwritten by any errors generated by callbacks, it will also have the effect of blocking Alt-Break and CLib's Escape handler, due to them both being reliant on callbacks.
        Since the flag may persist for a long time, it can be dangerous to leave the OS in this state (the flag can only be cleared by a SWI call from user mode - which may never happen if the program is stuck in a bad state).
        So to combat this, CLib will now make some effort to try and avoid leaving the postponement flag in situations where it shouldn't be needed.
        File changes:
        - c/armsys:
          - Change _sys_flen to return 0 for TTY streams, since calling OS_Args for them isn't going to generate any useful result (previously it was generating an error, causing the postponement flag to be left set on entry to main())
          - Be extra vigilant when entering main() to make sure the callback postponement flag isn't set, just in case other checks don't resolve it
        - kernel/s/k_body:
          - Change CopyError to attempt to clear the callback postponement flag if we suspect it's set. We've just copied the error to our own buffer, so it should be our job to worry about preventing that buffer being prematurely overwritten, not the kernel's.
        Tested on BB-xM
        'while (1) {}' (and similar variants) now multitasks in task windows and is no longer unkillable
        Fixes issue reported on forums:
      Version 5.96. Tagged as 'RISC_OSLib-5_96'
  25. 14 Apr, 2018 1 commit
    • Jeffrey Lee's avatar
      Make abort handling more robust · e4577090
      Jeffrey Lee authored
        kernel/s/k_body - Update AbortFindHandler to check that SP & SL are both word aligned, especially because the code will attempt to load from SL to check for the stack chunk magic marker.
        Tested on BB-xM
        Avoids some "abort while in abort handler" type scenarios if an abort occurs while SP/SL are invalid
      Version 5.95. Tagged as 'RISC_OSLib-5_95'
  26. 29 Oct, 2017 1 commit
    • Robert Sprowson's avatar
      Put ctl in the attic · 91926745
      Robert Sprowson authored
      The ctl part of rlib has various memory leaks (ref https://www.riscosopen.org/forum/forums/4/topics/9503) reflecting its abandoned state. See the FrontEnd module for a more flexible implementation of the same GUI-in-a-text-file scripting language.
      The ctl API was not in C release 3 (it post dates that) nor in C release 4 manual, and the whole of rlib was removed from C release 5 in favour of the Toolbox.
      The change log at the top of rlib/s/rl_spare shows it was briefly added in early 1990 then removed in April 1991. 26 years later, cull it from the Makefile too.
      Version 5.94. Tagged as 'RISC_OSLib-5_94'
  27. 03 Sep, 2017 1 commit
    • Jeffrey Lee's avatar
      Eliminate some global OS_SynchroniseCodeAreas calls · d89ca652
      Jeffrey Lee authored
        kernel/s/k_body - Eliminate a couple of global OS_SynchroniseCodeAreas calls in _kernel_init and _kernel_system
        s/initmodule - Eliminate a global OS_SynchroniseCodeAreas call in _Shared_Lib_Module_SWI_Code
        Tested on iMx6
        Improves performance with SMP ROMs, where global D-cache clean isn't really possible
      Version 5.93. Tagged as 'RISC_OSLib-5_93'