- 06 Oct, 1998 1 commit
-
-
Andrew Hodgkinson authoredLazy clearing of backgrounds - pages with the same background image or colour won't be cleared to grey when going from one to the next anymore. BODY element onLoad script attribute implemented properly (beyond the Customer hackery). Images use independent flex blocks for URL and transient fetch data; greatly improved data throughput in image system as a result. Image renumbering implemented - speeds up closing of pages / frames with many images. Image xref is still rather slow though and images with a 0 width or height specified in the HTML still cause an incorrectly formatted page to appear. Have, I think, fixed the "stops anti-aliasing" bug. Noticed that some background images are not being processed as Fast (e.g. at the Fibblesnork Lego Guide) - that old problem has reappeared, then. Background images would cross reference when two pages had the same background colour set in <body> elements but one was configured to use document colours and one wasn't (so xref should not occur). Code was looking at b->background_colour; corrected to call redraw_backcol(b). Titles were added to the history according to the fetch URL not the display URL, though the former is more likely to be in the history due to the code execution order in the fetcher; changed to see whether this improves upon the rather hit and miss addition of titles. The 'about:' page now gets entered into the history (makes for much more sensible behaviour if it is configured as a Home page, for example).
-
- 23 Sep, 1998 1 commit
-
-
Andrew Hodgkinson authored
Another intermediate check-in, resources may not be up to date; items most likely to be buildable are PhoenixJ and BrowseD. Done because I'm about to make some rather dodgy changes to code otherwise unchanged since the Customer browser and I may well have to back them out... In Handlers.c now set the HFlags_HasBeenVisited bit of a token at the point it is first clicked on. Means the link returns to a "visited" colour after the highlight flash immediately. This will persist for as long as the browser window is kept open on that page, though if the URL doesn't end up making it into the history for whatever reason it would "unhighlight" on reload; fair enough, really. The highlight is window-local, so there are no redraw worries for other open windows with links to the same URL (though other same-URL links on the same page aren't updated either). All forms submissions force a reload (principally for eudoramail.com, but many other sites have similar requirements). !MkClean and !MkClnAll didn't correctly call the utility to strip Makefile dependencies. Fixed. On fetch closedown, fetchpage_preprocess_token could be called on a token which had already been run through the preprocessor. Now checks the flags word before proceeding. Image RAM cache and garbage collection system implemented - see new Choices file entries CollectAfter, FreeRAMLimit and UnusedImageLimit to get an overview. This contains groundwork for JavaScript image array support. More JavaScript support improvements. Any one window object will know its parent, top, this, etc.; frames array working except for a frameset created via. multiple documents; opener for something created with window.open is currently not set and don't know why (property is being created, pointer to valid object is held, but JS engine returns 'null'. Ho hum) - JSChain won't work yet, then.
-
- 07 Sep, 1998 1 commit
-
-
Andrew Hodgkinson authored
Everyone else seems to be checking lots of stuff in lately, so I've decided to join in. This is an intermediate check-in and so not all resources etc. will be up to date. You should be able to make Phoenix and a debug build out of it. As a reminder, to make a JavaScript build: * Build JSLib and NSPRLib. Recommend you leave -DUSEMEMLIB in there (as used by default) so you can watch it leak into a dynamic area... :-) If you do this, you'll need to build MemLib too, of course. If you do NOT use MemLib, *undefine JS_USING_MEMLIB in Main.c*! * Run !MkClean. This now strips dynamic dependencies from the MakeFile automatically, to save you having to do it yourself. * Run one of the TaskObey files with the "J" suffix, e.g. !DeskBrwsJ - this uses the same .o directory for object files and exports to the same position in the Targets directory as the non-JavaScript build, but it does produce a unique binary in 'abs' and symbols table in 'syms'. * Sourcing an appropriate !Run (with increased WimpSlot value), !Boot and About resource is done automatically. * Some, but not all of the !xxxD (debug) TaskObey files will make JavaScript versions in passing - check the JSUFFIX value on the Make command line parameters in the file. This'll only work on RISC OS 3.1 due to the use of MemLib. Here's the change list: Included MNG icons in sprites files; added Sprites23 for some builds. Added in ANT URL file icon (b28) derived from URI file icon, because the Save dialogue can need it. No, you do *not* need to define the same keyboard shortcuts in each frame since the ancestor keeps the input focus and we've basically dropped non-nested Wimp support. Maintaining no less than 4 lists of identical shortcuts was a pain. Some Res files now only have the lists in the main browser window and button bar objects (these two are both required still). Ursula build Markers button arrangement changed from 1x3 horizontal to 2x2 tilted, as in Phoenix, by popular demand. Couple of hotlist bugs fixed; dragging an item and deleteing it with Ctrl+X didn't terminate the drag, and deleteting an item underneath a menu opened for it didn't close the menu. 'SendReferer' option added to all Choices files, all set to 'always'. Put just beneath 'Clone' as it refers to header items, though really, both Clone and SendReferer should probably be in the "Fetch controls" section rather than "Multiuser environments and proxying"! Front-end control of this is available. In image_export_original, save_save_source, save_transfer_source and save_save_object, flex_set_budge(0) was called to lock the heap but the return value wasn't stored. flex_set_budge(1) was then used to unlock the heap. All calls now remember and restore the old value, which is both safer in case one calls another and allows the flex_set_budge call in Main.c to have an application-wide meaning, as intended. Some restructuring to the data load and RAM transfer sections of Protocols.c; remote hotlist builds wouldn't allow files to be loaded to browser windows before, and can now drop URL, URI or text files to the Open URL dialogue. New option "MinimumFontSize", lets the 'size' attribute of the 'font' element be overridden. Default value is 1, to allow the full range of values for the attribute. Setting to 7, for example, would give font size 7 text at all times. Another new option, "ToggleOnXOnly", to make Toggle Size only extend the window vertically (with Ctrl then being used to toggle to genuine full size, rather than vice versa). All Choices files updated to hold both of these options; only the first has front-end control available (see debug build Res file). JavaScript Document object exists; frames array etc. working. Can now just about use "http://www.acorn.com/~ahodgkin/jschain/" but it does abort after a bit - problems with frames again, I suspect. Is is pretty slow, too. Can now press Escape to terminate a script. Main.c erroneously referred to Controls file entry "StopWebServe" as "StopWebProxy". Fixed. Keyboard shortcuts to raise SaveFile are now possible in a general sense; the code before was in the ToBeShown handler and just checked for a parent component of -1. It then assumed "save frame HTML source". Now there's the savefile_raise_from_shortcut function, which together with the seven new event codes in SaveFile.h allows saving of HTML source and frame location, export of links, images, backgrounds and the page as text or draw, to all be invoked by keyboard shortcuts. Some Res files have some of these defined. In reformat_check_height, the first check to see if setpara should be set references a field in tpLast without checking if it is NULL. Whilst the 'line > 0' check should mean that tpLast wasn't NULL anyway, a direct call to the function from outside of the reformatter might have tripped up on this - the check for tpLast != NULL is now made. Adjust-click on close icon in window showing file: URL attempts to open the parent Filer window. Reformatter used to try and find a selectable token if keyboard control was enabled in a really stupid place - could make reformatting become very slow if no selectables were present, especially if the page had a few tables on it. Preprocessor now does this (since it goes through all of the tokens anyway), the reformatter just doing a last check to ensure no frames have obscured the selectable and if so, it tries to move it. Done in the reformatter as generating a line array implies the data really is visible. Ctrl+Tab URL completion now builds a full list of matches from the hotlist and history and can cycle through them (Ctrl+Shift+Tab stepping backwards). Will give a real error rather than just "Data Abort" if it goes wrong now. Someone somewhere is setting bit 30 of the error which confused the replacement signal handler. Flag bits are now masked off (as they should've been to start with).
-
- 09 Jul, 1998 1 commit
-
-
Andrew Hodgkinson authored
CVS crashing. Some of the Resources may well be out of date due to CVS locks being in place after earlier server-end core dumps, which I can't remove myself. I'll try and check one file in at the end with the full change log so people know what's happened (it's reached about 16K...) - I'll make that the TaskObey file '!All' in the top level directory. So for the full log, look for the changes on this file.
-
- 21 Apr, 1998 1 commit
-
-
Andrew Hodgkinson authored
MIDI themes is unreachable, Hensa has been restructured. For table cells where the line or chunk data totals less than Flex_256_Point bytes (see top of Memory.c, current value is 8192) there would be an over- allocation of 1 byte per cell due to a (now fixed) bug in the granular allocator. This would translate into 4 bytes wastage of course, and may represent a small speed penalty depending on how flex works out block word alignment. Several entries in the Choices file were missing from save_save_choices in its new form (see last check-in). Added back in. Ursula and Phoenix Res files contained an incorrect component ID in pane 3 that was stopping the 'no scroll bars' option in pane 7 working correctly (duplicate component ID). Res files corrected; TRACE builds will now spot such errors and give a warning when they occur (in choices_find_component). Table widthing code fixes: * Very wide table cell specifiers (e.g. TD WIDTH="2000") were ignored, but this isn't what Navigator / MSIE 4 do. This code was present because of other bugs in the widther, long since fixed. The code has been commented out - if the problem reappears the use of the code can be re-investigated, but as far as I can tell it isn't needed. * If two pixel specified cells appear one above the other, the first would always have been taken for use in the final width calculation even if it specified a smaller width than the second. The check was made to ensure that pixel specifiers were chosen in preference to other cells, which is OK, but it didn't notice if the current cell was also a pixel specifier! Fixed; you now get the widest. * The TRACE build 'Colspan cell xxx would have been width yyy, below minimum width of zzz' error should no longer happen. In a manner similar to the bug mentioned above, two cells above each other spanning the same columns with the lower cell narrower than the upper would end up with the narrower width. The code that trapped and corrected the error was not compiled out of release builds, even though the error message generation was, because the rendering would fail otherwise. The widther has now been fixed not to make this mistake and the final check is now strictly TRACE build only, thereby speeding up table widthing for non-TRACE builds. * Another use of MSIE4StyleTables option, for cellspacing; it's based on the actual used cells, rather than the maximum cell width caused by COLSPAN etc. So if you've a cell with a big COLSPAN but as a heading but the rest of the table only uses, say, 4 columns, you won't get a gap to the right which adds up to the spacing for all of the cells that the COLSPAN attribute in the heading implied. The option was actually intended as 'bad things when switched on', and though in this case it makes for a better rendering, it does hide an error in the HTML. Note Navigator 4 acts as Browse with MSIE4StyleTables off in this particular case. Oh, it works in both ways of course, so the table height routine had to be updated too. A new function, tables_find_actual_size, exists to support the feature in general. Messages files updated to v2.05 (21-Apr-98). Help menu items renamed a bit in Ursula, Phoenix and Customer Res files, but entries still point to the same URLs. Phoenix button bar markers have been brought closer together to stop them being visible when only the URL bar is meant to be present.
-
- 16 Apr, 1998 1 commit
-
-
Andrew Hodgkinson authored
RefoKeep and RefoHold options added to, respectively, try and maintain the line at the top of the visible area when reformatting, and not shrink the vertical extent at the start of a reformat to try and avoid flicker to the top of the page and back down again when RefoKeep is on. Choices front-end implemented, which also allows RefoWait and RefoTime to be set. Unfortunately for various reasons this doesn't help the page jumping when unsized images come in (but RefoHold can improve matters...) - roll on the image history. DragToScroll and NoScrollBars options added for frames; included new pointer type, Mouse_Shape_DTS, so relevant Controls file entries done and Sprites[22] files updated as required. Noticed some builds have a low-res ptr_link with a mask - mask removed. Named anchor following fixed up somewhat - anchors near the bottom of the page shouldn't be displayed, and then pulled down when the fetcher releases null polls and ensures the y extent is correct (this through implementing the min_height field in the browser_data structure). RefoHang was never implemented and there seems little point to it now, so the entry for it has been removed from the global choices structure and all Choices files. Markers menus should work properly now (in last check-in they would not update correctly if Adjust was used on the entries). URI handler usage now a lot more sensible, with configuration of how the browser uses the module from both a Utils menu submenu (sic) and the Choices dialogue. Slightly dodgy 'hang around waiting for user input' stuff for the Cookies dialogue box: All fetches are suspended; the fetcher remembers some info about its state at the time the cookie came in, and restores it later; it will only do this for one fetch at a time. It's necessary to single-thread the fetcher at this point anyway, since other fetches may have a dependency on the cookie that is hanging in mid-air at that point. As part of this, some of the fetcher code has been split out into separate functions (to try and 'black box' the code a bit). Anyway, Cookie Query dialogue box now implemented with appropriate Choices file entry and UI work in the Choices dialogue box. Phoenix build Choices rearranged. Can now choose when the image history is saved from the front end. Added also MSIE 4-style table option menu for JPEG support (OS only, OS if it can handle it, internal only). Should be a bit faster at loading the history - though 95% of the time is spent in SWI URL_ParseURL. URL descriptions are stored more efficiently as part of this - one malloc block instead of several small blocks. The minimum block size for malloc blocks typically leads to a significantly smaller startup wimpslot depending on the visit history size. Nasty bug in image system fixed. If an image size came in and a reformat was to take place, the line the image lies in is found and the reformat progresses from there. Unforunately, this didn't check to see if the token can't be found in the line list, so it'd reformat from the top of the page...! This would happen if, for example, an image halfway down the page came in whilst a reformat for an image higher up had just begun. In Choices.c, made choices_set_timetype_field, choices_set_uri_field, choices_set_plugin_field, choices_set_cookie_field, and choices_set_jpeg_field static (so they're not declared in Choices.h now). Two memory leaks plugged in URL comparison routines in URLutils.c (calling free() url_description instead of urlutils_free_descripton()). Client pull reload handler was setting the reload flag if reloading the same page, but forgetting to turn on reload_lock so fetchpage_postprocessed was clearing the reload state... Similarly, Ctrl+Shift+SELECT-Click on a link when the Controls file 'UseSmall' entry is 'no' would not have reloaded as it should. Both fixed. Frames shouldn't be so keen on acquiring horizontal scroll bars and never letting them go when their width is decreased now. Frames set up for 'scrolling="yes"' will not start with no scroll bars and then gain them shortly afterwards, causing flicker and two reformats - they'll start with, and continue to hold, both scroll bars. Pointer shouldn't flicker when over a frame border whilst other fetches are progressing now.
-
- 26 Mar, 1998 1 commit
-
-
Andrew Hodgkinson authored
This is NOT a 'final' version of anything in particular. I'm checking it in as I'm about to start playing around with low level window handling (as part of the thing mentioned at the bottom of this log) - this could screw things up quite badly if it goes wrong! =8*P Consequently, I advise you not to check this out over your working sources, and preferably not to check this out at all. Markers system - events defined in MiscEvents.h will make Browse remember where it is on the page. This position can be jumped back to later. Some builds will have defined keyboard shortcuts Ctrl+Shift+F5 through F8 to set a marker, and Ctrl+F5 through F8 to jump to a marker. The front-end for the above now has gadgets 0x80 upwards on the Toolbar or a set of menus (see Menus.h). Noticed an omission in copy_toolaction_info() (didn't copy the gadget state) in passing; fixed. browser_top_line() now works properly, as part of the above, but it'll be slower than before. If flagged to only find a complete line, it'll do just that, but whereas before this would require any tables that it looked inside to be wholly visible, tables can now be partially visible and have lines inside that are fully visible. This should help the Find function too. There is a new call, browser_top_line_offset, which works as browser_top_line but also returns a vertical scroll offset in the found line (used for more accurate marker position). browser_bottom_line[_r] turn out to never be used, even by the keyboard control routines, so they have been removed from Browser.c (rather than spend a lot of time and effort fixing them). browser_show_token erroneously subtracted 1 from a particular coordinate when calculating the y scroll position, which could lead to single pixel page creep using the markers system. Corrected. The View Resources button (see Toolbars.h) has been finally implemented, insofar as it fetches the resources file to the current browser page (or to a new window if Adjust is used, Controls file settings permitting). menus_toggle_bars did not take account of the toolbar lower window border edge correctly. It does now. The reformatter has a prototype system to keep the vertical page position when reformatting. This was coded about 5 minutes ago, and is not likely to be reliable...
-
- 20 Mar, 1998 1 commit
-
-
Andrew Hodgkinson authored
Some compile-time hacks in place to use MemLib, a dynamic area based malloc replacement which shrinks its heap when possible. All builds have these switched off at the moment. Seemed to work with just Browse, though there would be problems with message blocks stored in dynamic areas because of the Wimp's '&3800000' check - however, it failed when HTMLLib was made to use it, too. Don't know why yet. ItemInfo.[c/h] source added, with Res file additions for testbed Browse and Phoenix. Small fetch windows now work properly regardless of toolbar settings in the Choices. Reload now reloads all images too, rather than only reloading them for as long as the main page was being fetched. Added a simple 'Find' facility. Realised that event handlers in eventlib are called in reverse order of registration, so the miscellaneous event handler is now registered first rather than last. Multiuser code added (most only active if SINGLE_USER is undefined). As part of this, hotlist code now knows about read-only items (done for the Customer-style 'Resources' file, but works generally anyway). handle_add_hotlist doesn't try to save the hotlist itself anymore (the hotlist_add function does all that through hotlist_modified anyway). Customer build Choices and Controls updated slightly (e.g. ClaimHelp off, hotlist to save on quit only). Customer build now uses Phoenix-style buttons. Sprites files which worked at the time (but will probably be out of date now) and included most of the original Customer-style sprites are in 'Utils.Icons.Customer'. Choices, Messages and Res files for all builds now stripped down to only single user items or single plus multiuser for Customer build and testbed build. Before, all contained a few multiuser bits in at least the Choices file if not more. Grammatical error ("Fetching frames contents" (sic.)) corrected in default message, Toolbars.c, and all of the Messages files. Customer build brought back to a servicable level (including implementation of the Find dialogue box with animation and fixing up authorisation and 'Stop' state in the tristate). Quite a few missing #ifndef REMOTE_HOTLIST bits from hotlist code added... Customer build will not use <Choices$Write> or Boot:Choices for any file finding now. UseProxy defaults to 'yes', MaxImages to 2. Res file includes Proxy Address setting (save_save_choices() now writes the ProxyAddress line).
-
- 13 Feb, 1998 1 commit
-
-
Andrew Hodgkinson authored
Precautions taken in table code to avoid divide by zero errors. Framesets defining more frames than the frameset implies, for whatever reason, should never cause a crash now - just report a 'Frames definition is badly nested' error (if STRICT_PARSER defined). Along the same lines, in a single document defining a set of nested frames, two /FRAMESETs in succession could cause a fairly nasty crash. Fixed. TIFFs do not get loaded by double-click now. If holding down SHIFT to save a link contents to disc, you can also hold down CTRL to bypass the cache (sets the browser's reloading flag). Noticed when testing this that windows_create_browser didn't take account of the Controls file 'UseSmall' entry when adjust-shift-clicking on links. It does now. There is now a complete and up to date set of interactive help messages built into the Ursula, Customer and Phoenix build Res files.
-
- 31 Jan, 1998 1 commit
-
-
Andrew Hodgkinson authored
Check for WindowManager 3.97 and ensure Unicode$Path is set in all !Run[D] files, don't set the Alias$@PrintType_FF4 variable, and updated Customer build ROM obey file variants. Various other changes to the Run files for new module versions, updated paths to support new positions of choices, hotlist and histories (see later), etc. !Sprites[22] files hold small !app icons for some variants, and an ic_browse sprite. Some variants now have a Sprites and Sprites22 file instead of just Sprites, with the former containing various mode 12 or 15 specific sprites. Text files dragged to the URL writable are treated as ANT URL files. This relies on URLBarWrit (Toolbars.h) being a unique ID, which it should be, but beware of the Hotlist and Choices numberspaces... INPUT TYPE=BUTTON supported. Form items without a FORM tag are now shown (as MSIE 4, but not NN 4). '*', '-', '@', '_' and '.' are not escaped when submitting forms now. The Web interface to the IMDb now works. INPUT TYPE=HIDDEN items will not affect the line height anymore - so http://www.hotmail.com/ now has correctly aligned writable icons, for example. Similarly, TAG_FORM and TAG_FORM_END items could push up line height and don't anymore. HRs with a specified pixel width will now influence the size of a table cell (they didn't before). BRs now checked by tagno field when the browser needs to know something was an actual BR tag rather than just a line break signal, and by the style bit entry when only the indication of a line break is required. Table widths of 0 or 0% are ignored. Trace.c updated to report height and background fields in a table_stream. fm_putsl() writes a terminator into the string; the Forms.c routines were calling this for displaying INPUT TYPE=PASSWORD fields using the FE_PassCode literal string (a line of stars). This write into a read only data area would make the debugger fault the access. A local char array is now used instead, to get round this (note the use of var[]=literal rather than var[sizeof(literal)]; strcpy(var, literal) due to some weird compiler bug that copies the wrong thing into 'var' under some (undefined...) circumstances). Text areas don't scroll back to the top line when clicked in anymore; single line writables don't scroll back to the left either. When reentering a text area from 'above', the caret appears at the top line rather than 'somewhere further down'... ARROWS_MOVE_OUT compile time option at the top of Forms.c defines whether you must press Tab/Shift+Tab to move between writable fields in forms or if up/down will drop out of them, though if keyboard control is on this is enforced (or you get trapped inside the form!). urlutils_filetype_from_url now uses MimeMap module. If fetcher is told a page is text, it'll check for a filename extension and may choose to use this instead (e.g. it may find it's HTML instead). This is to try and get around duff servers... (e.g. http://www.batalarms.co.uk/). Save dialogues shouldn't flicker when options that don't change the filetype are selected (before, the draggable sprite was always reset for each selection). Noticed the erroneous setting of a static variable in SaveFile.c by a call to this by SaveObject.c, and so added a flag to savefile_set_filetype to deal with this - would have been possible to get the wrong filetype sent to applications or at best the wrong filetype sprite in the dialogue without that. The caret shouldn't jump out of a form back to the URL writable if the page reformats now. Table background colours now supported (as in the colour you see in the border space if the cellspacing is large enough; this is as in MSIE, not as in Navigator). Drawfile output routines updated accordingly. Corrected erroneous use of wimpt_dx() / wimpt_dy() in a couple of places in Images.c, which meant that (say) 1x1 images didn't work correctly in medium resolution display modes. Now have support for save as text (component ID and event 0x12) and save as Draw (component ID and event 0x13) buttons. Dubious conditions for greying and ungreying the print, save source and view source buttons and menu options sorted out as part of implementing the same for the two new buttons; added greying out of their associated menu items in passing. Turned kerning on in draw file objects (does mean a rather heinous increase in file size, but this is the only way to ensure the draw file matches the visible page). Comments before functions in SaveDraw.c are now complete and up to date. Image and visit histories now generate a crude hash number to speed up searching for items. It does give a speed increase, though it's a disappointingly small one. Issue of left/right margins and cellpaddings sorted out. Now have redraw_left/right_margin for finding out the basic gap you must leave. redraw_left/right_gap then gives any extra indentation for LI, BLOCKQUOTE or whatever. The last two can be subtracted from the display width to get an available page width for any section of text. Note that redraw_left_gap replaces redraw_margin. The redraw_start_x function uses the above to work out where a line's left hand edge should be, taking account of left/right/centre alignment. HRs have been fixed now (they were quite broken in v1.30, I think) based on this new model and the behaviour of MSIE/NN 4. Fixed width of cells with no contents - cell padding values wouldn't have worked properly as the reformatter returns 0 rather than the left hand margin size if given no stream. Removed FM_Absolute flags for Font_Paint (spotted by DBrown) - sets bit 2, which is reserved...? IMG width and height in % terms now works correctly; a % of available width (after margins and indents) or height on the main page or for a table cell, if the image lies in one. Because of the chicken-and-egg problem with the latter, the cell must specify a width and/or height for things to work properly. If this is not done, you'll usually end up with a 1:1 scaled image (as in Navigator 4, rather than ending up with no image or even no cell (!), as in MSIE 4). HEIGHT attribute on a TABLE tag is supported, but only in a crude fashion; the extra height (if there is any) is distributed over the rows in a linear fashion. This is probably all you have to do in practice, but I haven't checked. To maintain a notion of min/max height as well as width would of course require a great deal more work... If using client pull to reload a page with a fragment ('...#name') specified, then the reload wouldn't work on the same page; it'd just jump to the fragment position. This won't happen if b->reloading is set now (so works in conjunction with client pull on the same page forcing a non-cached fetch). Similarly, if POSTing to such a URL, a fetch will proceed (both these fixes done originally for http://jupiter.beseen.com/chat/rooms/g/1678/). browser_inherit split to browser_inherit and browser_inherit_post_data; the code for the latter didn't clear any post_data in the child before copying from the parent either, and could cause flex errors (now fixed). Res file for Ursula ('Desktop' Browse) build tweaked - bits in the font choices dialogue renamed, and button bar rearranged to hold the new Save As Draw button. Other builds have had Save As Draw and Save As Text buttons added, or not, depending upon availability of suitable sprites, required UI simplicity, etc. Now have: Browse$ChoicesFile Browse$ControlsFile Browse$ChoicesSave Browse$ControlsSave (the last two are new) for loading and saving of the Choices or Controls files. If unset, <App$Dir>.Choices or <App$Dir>.Controls will be set. E.g., you could set Browse$ChoicesFile to be: <App$Dir>.Choices,Choices:WWW.(app).Choices for loading and <Choices$Write>.WWW.(app).Choices for saving. (The browser never saves Controls at the moment, so the relevant variable above isn't effectively implemented, but could be in future). Similarly, to support asymetric loading/saving of the Hotlist, there are HotlistSave, HistorySave and ImageHistorySave entries in Choices to complement HotlistPath, HistoryPath and ImageHistoryPath (which are used for loading). save_save_choices will create directories as needed to obtain the given path (and has also been fixed in various areas that hadn't been tested out until now; e.g. zero termination of the AppName$ChoicesFile variable expansion...). !Run[D] files updated appropriately. Table widthing code rewritten. Slower, but a lot better on the whole. Still has some problems - still needs a final 'make sure nothing is below minimum width' scan, which it should be possible to do without. No time to fix this at present! The reformatter will now 'glue together' an LI token followed by any non-LI token; so a bullet point followed by an item should not be able to have a line break inserted after the bullet because of very tight width constraints (it could before - yuk...). 'about:' brings up a page about the browser and any Plug-Ins, as with Navigator (for example). URI files support titles, as per spec. version 8. Saving a current location to the Hotlist will thus give a sensible title now (unless you're in a frame, so there's no title to get...). Of course, v1.00 files without a title still work. Note that NOBR is *not* supported in this build and this combined with the new table widther may cause problems on some sites (e.g. Microsoft's home page!).
-
- 12 Dec, 1997 1 commit
-
-
Andrew Hodgkinson authored
There are a few known significant problems with this code but it's being checked in so the Choices can be worked on. Note that Res files etc. are not up to date across all builds. Progress is as follows... Bug report prompted me to do this - now ignore <p> tags straight after <li> tags, so '<ul><li><p>Some text' works as the author (or automatic generator, more commonly) intended. A <p> tag before a table will be acted upon now (it was ignored before). Something like <li><p><table...> will give a line break and paragraph space after the <li> despite the changes mentioned above, as in other browsers. Both browsers differ from Navigator, where the table appears alongside the <li> tag. Multiple BR tags work as in MSIE / Navigator (they don't collapse to zero height anymore). For the above, line height (and so, <br><br> or <p> spacing) is now calculated inside reformat_text_line_height, and is used with either a token to get the text height at a given size (e.g. for general line spacing or multiple BR tags) or NULL for normal size text (e.g. for P spacing, though this value is in practice later scaled by 7/8ths in reformat_check_height). Note this behaviour is exhibited by MSIE 4; v3 gave two BRs the same spacing as one P (i.e. not font size dependent). Save dialogues can have an option button or couple of radios to switch between various formats (e.g. URI or URL, sprite or original format). See 'Docs.Notes' for more. The back-end to this is now implemented (i.e. at the moment, save as URI or URL, save as original image format). Note that when saving background images, a leafname based on the original fetch URL is now offered rather than a generic 'Background'. Internal URL scheme changed to be all lower case, so relativisation through URL_Fetcher still makes sense... :-/ Holding down 'shift' when clicking on stop reverses the interpretation of the Controls file 'StopWebServe' entry. Fixed row / column count for exporting tables as text; fixed a few bits and pieces of internal URL scheme stuff which got broken when HTMLLib started using URL_Fetcher's relativisation.
-
- 04 Dec, 1997 1 commit
-
-
Andrew Hodgkinson authored
Fixed some glitches in the modified status bar code (e.g. status inference wasn't working properly). Shift+Toggle size always opened to not obscure the icon bar. If CMOS is set to always show the icon bar, then Shift+Toggle size is meant to reverse sense and open to absolute full size. It now does this. !Run[D] files now require URL 0.22, HTTP 0.64, FTP 0.22, Gopher 0.08 and File 0.32. Minor overhaul of 'Docs.Notes' (with 'Docs.User' similarly updated) to include a few new bits and pieces. Timeout values of 0 now mean 'forever'. Plug-in status messages now have their own timeout setting. New Messages token 'Actv' for extra info when a status message times out and the status line drops to 'Viewing' or 'Ready' when there is still a Busy state registered by the Plug-in. Small Fetch windows don't become visible briefly for Plug-in fetches when the fetch is complete (for SeeFetches:no, where these windows should be hidden all the time). WebServe may be controlled through the Browse front-end via. Wimp_MAppControl reason code 4 (Wimp_MAppControl_Configure). Note the renaming internally of 'WebServ' or 'WebServe' has been changed to 'Proxy' (with lower case equivalents where relevant); proxy name and starting details come from the Messages file 'ProxyName' and 'ProxyComm' tokens. More in 'Docs.Notes'. Res files updated for image history and PRE/TT font aspect ratio choices. 'Don't expire' labels changed to 'Expire' (oops, didn't notice the change in the development Browse's Res file when I updated all of the others until now...). When printing, Wimp_PlotIcon appears to ignore R4 and R5, plots 'somewhere' on the page, and tries to get the sprite from the global pool. This latter part normally causes an error to be raised; though on my machine I just get a corrupted error message. The Desktop font gets lost at this point too. All have yet to be fixed; as an interim work around, Wimp_PlotIcon objects are never drawn at all if the global 'printing' flag is set.
-
- 02 Dec, 1997 1 commit
-
-
Andrew Hodgkinson authored
Message_PlugIn_Busy. Plug-in code more robust when given invalid browser instance handles by the plug-in. Line spacing is now calculated on the basis of the normal style base serif font, with all other fonts being forced into that line height. This does mean that an unusually tall (say) sans serif font may get clipped. It appears to be the only way to get around wildly different baseline depths returned from the font metrics - you can't work out line spacing based on each different font style; the line spacing will vary. Table heighting (as opposed to widthing...) improved considerably; rowspan can no longer cause very tall cells in odd places. Having trouble getting rid of the single pixel breaks between vertically adjacent cells, though I've not tried too hard. Widthing, though, seems fairly badly broken at present... :-/ Set/clear of page_is_text flag made more robust (it looked as though there was the potential for this to get stuck in a set state, though I've never see the front-end behave in a manner which indicates this is the case). The reformatter will now decrease leading if this flag is set (plain text pages look daft with a line spacing that is OK for 'rich' text pages). No reformatting is done if the page width changes by dragging on the resize icon, though toggle size / full screen will still reformat even if the contents are only text (browser needs to sort out various width flags at this point). Cut down on excessive redrawing when reformatting due to a change in window dimensions is not done. If display_width hasn't changed, then no redraw is needed. If this causes redraw problems, then whatever is changing display_width needs investigating. It shouldn't be kludged (basically) by forcing a redraw instead of a reformat. TT/PRE/etc. text can now have a non-100% aspect ratio. 80-90% looks best (ArcWeb, for example, uses 86%). New option 'TTAspect' in the Choices files. Debug builds link to a non-debug Unicode library now; stops stderr being dumped to the bottom left of the screen if you've not redirected it in the Run file. RISC OS 3.1 seems to need more initial WimpSlot than later OS versions. The 64 deep nested table set gives a 'No stack for trap handler' error (which it really means in this case!) without 800K, even though 3.71 is happy with just 640K. So, the !Run file checks if Boot$OSVersion is exactly 300, 310 or 311, and sets the WimpSlot accordingly. !Run[D] files now require latest fetcher module versions (URL 0.21, File 0.31, HTTP 0.58).
-
- 20 Nov, 1997 1 commit
-
-
Andrew Hodgkinson authored
Adjust-click on forwards/backwards buttons did not work in the intermediate build, and now does. Adjust-click on form submission buttons where the submit method is POST will now work correctly, as the new view inherits the extradata block of the old. Failure of this is signalled through make_no_fetch_memory_error, code 16 (see updated Errors file in Docs). Note the name change of extradata in this context; more details below. The passing of forms POST data and extra headers for sending in an HTTP request via. the URL module was all done through pointers into flex blocks, and was therefore very unsafe. All relevant functions now use pointers to pointers to the data. To remove confusion on the umpteen uses of the word 'extradata', the field in browser_data has been renamed to 'post_data'. The 'extradata' parameters used within FetchPage.c were all disconnected from the extra header info / form POST data stuff that extradata is usually associated with, and have thus also been renamed, in this case to 'appnddata' (Append Data). As well as X-NoProxy, the browser sends the 'proper' HTTP headers Pragma:no-cache and Cache-Control:no-cache. A redirection from a POST request was not handled correctly; despite what HTTP specs say, you're supposed to use GET for the new URL. The browser was, but when it chopped off the redundant header data in the request didn't terminate it and left Content-Type in anyway...! Fixed. Ctrl+Tab implemented - URL completion. Comes from the hotlist URLs, hotlist titles, history hosts, paths, full URLs and lastly titles. See code comments for more (history_find_match, hotlist_find_match). TableSupport option added to Choices; it is read, can be set by the front-end, but doesn't actually do anything else yet. Reversed Choices' semantics on 'don't expire by...' for History. Added 'needs_redraw' flag to choices_get_contents so that, for example, if the table border types change, browsers get redrawn.
-
- 19 Nov, 1997 1 commit
-
-
Andrew Hodgkinson authored
This is an intermediate check-in to allow work on Choices for the new table options and History choices as detailed below. Res files are not up to date except where indicated and there are several known bugs that will be fixed before the 'final' v1.27 is created. Any work on resources should only be done for the testbed !Browse. Client side image maps implemented. There is code to draw highlighted borders in CSIM.c, but this is not wired in yet; other than that, the implementation is functionally complete. As part of this, centralised the fetching of a targetted URL taking into account user request of a new view and full screen mode, in fetchpage_fetch_targetted. The forms library now uses this too, so form buttons respond to both adjust-clicks and TARGET attributes. Fixed APPLET handling where '.class' isn't present in the CODE attribute. Paragraphs squashed at the top of cells/pages - browser would insert white space before. Now append a ' ' to the end of History menu items to prevent the Wimp thinking the end of entries represents a keyboard shortcut (e.g. 'Home'). Netscape's handling of 'meta http-equiv="refresh"' is to start counting when the fetch has completed and everything else has died down. The browser will now not start counting until the animation handler is deregistered (so formatting is complete) to show similar behaviour (note that this checks the main handler, not the 'idle but returning to first frame' drift handler). URLs from requests for fetches by Plug-Ins are now relativised. Page width change tolerance prior to reformat upped from 16 to 32 OS units. Hoping to provoke a loosely connected bug with this change! TableOuter, TableInner and SeeFetches choices added to all Choices files, with appropriate loading and saving code in Main.c and Save.c. AuthorFTP and AuthorFSh messages added for FTP authentication, and dialogue handling code (the component in FetchHTML.c) updated to recognise an FTP fetch and alter the dialogue presentation appropriately. All Messages file version numbers taken up to 1.27 (20 Nov 1997). Following a UseNet suggestion, Ctrl+Toggle Size will increase the window size to fill the screen vertically only; horizontal size/positioning is not changed. Shift+Tab in the URL writable will cycle through alternative fetcher protocols (from both the Controls file and checking the fetcher modules are actually present). Hotlist doesn't require '://' in URLs when loading HTML, just ':/' - so 'file:/' URLs now will be reloaded correctly. History system rewritten completely. GHistSize and VHistSize options removed, and replaced by MaxSize and ExpiryAge. Now have global history menus with most recently visited items at the top, and local history menus which reflect the path that forward/back buttons would take. Browsers are robust to background expiry of the History though this is not implemented - date expiry and size checks are carried out on history_record only. This does mean that with two windows open one could have the history expired underneath it whilst another fetched, though; the code handles this and update toolbars (greying items) as necessary. It is possible to have the history limits so tight that even one entry will not fit and again the code copes with this, though values read from Choices are limit checked to ensure rather more useful results! Implemented 'Save' button in save dialogues. Remembers pathnames and just replaces the leaf now (hard coded exceptions for <Wimp$Scrap>... and <Wimp$ScrapDir>...) - it did before, but only if you'd typed the path in. Not many people did, given that you couldn't press Return or click on a Save button to use that path... In a similar vein, files of type Data or DOS will be checked for a '/xxx' type extension and the MimeMap module will be used to find a more meaningful filetype. If this can be handled, the file is loaded. This only works for files dragged to the browser - the behaviour with inline data in web pages will depend on the File module, and similarly, if File doesn't spot what is going on and claims that the object is data, the browser will just open a save dialogue for it. !RunD files taken up to 3072K WimpSlot. Hotlist's saved HTML page title wasn't internationalised - is now. This opened up a significant can of worms; on file write error, the file would never be closed, and if a caller of the save or load functions passed in a filename held in the global Messages lookup buffer then subsequent lookups in the callees would corrupt that filename. All sorted out now. Local (not very useful) or global (useful) histories can be saved as HTML, which opens up the possibility of sending your history to the hotlist by saving to it. Local and global histories can also be emptied, though this is probably not a feature that current release Desktop browsers need. Inheritance of local history and certain UI features is now done more or less for all cases where one browser window spawns another, too. Vertical alignment on images is rather less ropey than it was (e.g. ALIGN=TOP stands half a chance of working) but is still far from perfect. This was part of fixing a nasty little bug in Redraw.c's setting of an image position via. image_set_token_image_position, which was making (amongst possibly many other things) client side image maps fail. Image update where images had large borders was affected by a similar problem too (more cans with more worms...). Fixed image background filler functions; two problems. When cross referenced images were replaced by base images in a browser because the original owner was closing down, the original owner browser would stay registered with ImageLib. Fixed; secondly, when images were deleted from the image array causing those above to be renumbered, images registered with ImageLib did not have their numbers updated (this was the one that lead to the visible drop out of background images with PNGs on the Acorn Internet home page when there were two views of the page and the first was closed). This is now also sorted out.
-
- 30 Oct, 1997 1 commit
-
-
Andrew Hodgkinson authored
Removed 'The Onion' link from some Hotlist files. Time showed that the site wasn't entirely Family Friendly (TM)... Removed Shift Control (it's gone offline now), and corrected the Telegraph URL from ...the-telegraph... to just ...telegraph... StrongHelp manual generator now tries to work out the number of lines in the table on the root page more intelligently. Plug-in support extended to handle Shockwave. Quite a lot of underlying work for this, including a pseudo cache system for temporary files. Bug in redraw routines: they plotted background images within table cells, when nothing should have been drawn. Oops. When background images in cells are properly supported, this can get sorted out. Tweaked vertical plot position of HRs (up to 4 OS units too high before due to rounding). Various Res file bits and pieces, Ursula build taken up to v1.26 beta for release on the Browser site. *Note* not all resources are up to date! This will be done after AW97.
-
- 18 Oct, 1997 1 commit
-
-
Andrew Hodgkinson authored
Sorted out Res files, including fixing position of 'bytes' label in one of the Choices dialogues (I'd missed it out of a selection when everything else got moved down a bit). Unfaded Enc_Chinese menu entries, made sure text labels were wide enough for system font, changed 'Apply' on Choices dialogue to 'Set', and added ^K to hotlist keyboard shortcut lists. Print Setup (i.e. Print dialogue) buttons all set to 'local', so the stupid Toolbox doesn't close the dialogue and lose the caret before I can see if it was in there to start with... 256 colour hotlist sprites taken back to standard 16 colour versions, since there's a significant speed penalty on slower machines. The testbed browser still has the 256 colour versions so the designs aren't completely lost. Changed access settings to exported builds to wr/r - lr/r was really getting on my nerves whenever I wanted to try something temporary out. View source, save source and print handlers would all try to work if there was no source to act on - despite the fact that toolbar buttons would be greyed out form them. This is fixed. The Navigate menu has components greyed to match the toolbar state, when opened. It isn't kept up to date dynamically, though this shouldn't really be a problem (reopen the submenu...). As part of this, finally sorted out conditions for the Stop button to be greyed, or the GoTo/Go/Stop tristate to be at 'Stop' versus 'GoTo'. Deferred reformatting is now disabled for external image fetches. Browser-local client pull flag removed; hitting the Stop button simply cancels any null handlers working for it. That way, client pull switches back on in passing at the next fetch (it was never really switched off). So to stop client pull, hit the stop button at any point. Done CELLPADDING attribute; cellpadding field in reformat_cell (Global.h) is redundant since the table token is accessible from there, and so it has been removed. CELLSPACING support also added.
-
- 16 Oct, 1997 1 commit
-
-
Andrew Hodgkinson authored
Now handles PARAM tags. Sorted out Plug-In bug that was related to Java setting a 0 by 0 graphics window before calling Wimp_Poll (fixed in Java). Implemented queue for Plug-Ins so multiple broadcasts aren't sent for several Objects in one data chunk. Added Docs directory with some documentation in it. More things to keep checking for stylistic consistency, horray ;-) Corrected !Run[D] for Ursula build to need AcornURI but not TaskModule (URI handler needed for !Mail to pick up mailto: links). Added display_height field to browser_data, analogous to display_width, to cope with % sized objects by width and height (see how HRs are handled in Redraw.c for an example of how it was always fairly easy with width, but not height until this addition). Though you do have to reload to get a new size; reformat isn't enough. Must see to this some time... Fixed bug where basic typefaces were claimed *before* the Choices file had been read. For unusual Choices settings, this could create some 'interesting' problems now and again. This was part of narrower scope work in the Choices code to allow font changing without leaking font handles (now done; fm_shutdown only ditches fonts, it keeps internal structures - must then call fm_lose_fonts for all browsers to get the bitfields up to date, then rewrite the typeface definitions and reclaim basic fonts). Noticed that fm_claim_basic_typefaces would claim multiple instances of the same font if there were several cases of the same font mapped to different typeface styles - fixed. Implemented PlugInControl settings, but not SupportObject (fully).
-
- 13 Oct, 1997 1 commit
-
-
Andrew Hodgkinson authored
More reformatter code bugs fixed; this one regarding width of items. Any kerned string was overestimated (causing redraw bugs and caret position problems in forms, apart from other minor bits elsewhere) and the default size of a writable icon wasn't especially clever. Crude Plug-In support; just about manages Java, but can't fetch on behalf of Plug-In (for example). Had to change the default file access URL construction to be 'file:/' instead of 'file://', or local file fetches that reference Java applets won't work. This is in its very early stages, and is being checked in mostly so that various Choices issues can be worked on.
-
- 22 Sep, 1997 1 commit
-
-
Andrew Hodgkinson authored
Now working on source merged with Kevin Bracey's internationalisation support. UNIFONT is undefined in the Make File for now. All Res and Choices files updated appropriately. Having sorted out the old Choices and Messages to form Choices, Controls and Messages, this build has had the same cleaning up done internally. This includes greater consistency in naming schemes and the removal of the inconsitent choices items - e.g. Choices file entries saying 'delay images' and 'plain backgrounds' where internally all the flags say 'show images' and 'show backgrounds'. ChoiceDefs.h and CtrlDefs.h added to clarify the meaning of some fields, though usage of these is not 100% in the source (there are cases where parameters are passed through to functions as ints, and those functions still check these against hard coded values rather than the #define stuff). Fetcher status return bits (connected, sent request, etc.) now reflected in status bar. Progress during fetchs to files are reported by %, where the size of the object is known. Exceeding 100% drops back to a byte counter, in case the estimated size was wrong. The progress counter may be updated after specific delays, rather than 'as often as possible', to reduce flicker (as requested by D.Brown some time ago). I've done a small rewrite of the fetch prioritisation scheme in FetchPage.c; how well this performs in general use across different processor speeds remains to be tested, but certainly it has some advantages. For each small fetch window before the rewrite, a 4cs tight loop was entered - this gave a noticable and substantial drain to the Desktop performance if more than one was opened. Now, several can be up at once with little hit. The actual file fetch is on half the priority it was before, with all others taken back just a bit - e.g. from 20cs per poll to 15cs per poll for flat out reformatting. You don't seem to lose much time on the format in practice, and the Desktop feels quite a bit lighter at the same time. There's the potential for smoother frameset loading in this scheme, too. When Shift+Clicking on a link meant you still fetched inside the main browser window, several fetches could occur in a frameset - one per frame. However, now that you can only do this by clicking on a link that leads to non-displayable data - or by turning off the small fetch windows by setting UseSmall to 'no' in Choices - a bug where fetchpage_preprocessed would stop such fetches as new ones were started was revealed. The API to frames_abort_fetching has now been extended to include a 'stop file spooling too' flag, allowing a fix to be made by having fetchpage_preprocess's calls not set this (and it doesn't check the savelink flag is unset before proceeding, since frames_abort_fetching does that implicitly now). Had left the RAM transfer buffer at 16 bytes (from testing) accidentally... Oops. Upped it to 4K. In addition, when loading data by RAM transfer, the browser didn't notice if a RAMFetch bounced during the transfer. It would be treated as a 'first' RAMFetch bounce, basically, and try to go to file transfer - oops. Fixed.
-
- 18 Sep, 1997 2 commits
-
-
Kevin Bracey authored
Encoding support added: if UNIFONT is defined then the browser will attempt to use the system font to render Unicode characters (new International module required). If not defined, the browser will just handle Acorn Latin-1 characters, but HTMLLib will convert other encodings into Latin-1. Must keep the UNIFONT define in sync with HTMLLib (if defined HTMLLib outputs UTF-8, otherwise Acorn Latin-1). Still needed: Reverse encoding (converting form input etc back into the server's character set). Reparse when encoding changes. Setting of charset from an attribute on the <A> tag.
-
Andrew Hodgkinson authored
Image deletion routines rewritten; nasty animated GIF bug now gone (it kept trying to update the cross-referenced image in the browser that no longer existed, and I've no idea how animated GIFs ever managed to *not* blow up if a cross referencing browser was shut down; and I've tested this...). There are now as many image structures as there are total images in the visible browsers, and no more; cross referenced images in the to-be-deleted browser have their ownership moved to the cross referencer before the cross referencee is wiped, with any required fetches being transferred with them. Reformatter sped up a bit by getting rid of strlen on the main text field of tokens in all places bar one, where it is called extremely rarely. This means direct app-to-app transfer of, say, a 359K text file to the browser won't run like a drain as it tries to do strlen on a 359K string over and over again! Most of the time the performance benefits won't really be noticable, but on the above text file, formatting time went down from 290 seconds before the change to just under 7 seconds, a 41 fold speed increase or thereabouts (SA110 228MHz). MakeFile changed to force function name compilation on for debug builds (-fn in the DD...FLAGS); useful for certain functions such as register_null_handler, which can now output the name of the function being registered. ...Which helped show up some nasties in the animation handler and animation drift handler registration/deregistration process, which have been fixed (callers of fetchpage_release_nulls were unaware that the drift handler could be installed, and fragments of old code checking choices.anim_drift had a value other than 1 or 0 were still hanging around - bit tricky for a single bit item). Added support for VALIGN in table cells. Spotted a bug or two in the 'what token is the pointer over' routines as a result, and fixed them - the worst was in browser_line_at_y, which checked the y coordinate was below the given one [the mouse], but didn't check the line height to see if the given y coordinate was *within* the line, rather than just above it. Never used to matter pre-tables, but a definite concern once multiple line arrays can exist on one page.
-
- 14 Sep, 1997 1 commit
-
-
Andrew Hodgkinson authored
Got the deferred reformatter working properly. It doesn't do that 'OK, the page is fetched and reformatted, but just to annoy you, I'm going to wait 5 seconds and then suddenly reformat the whole thing again' trick anymore. The fetcher was calling the reformatter in a delayed form even when the reformatter was already running, so it would carry on past the reformat point or from below what had become and invalidated line, and some time later, get back to the delayed reformat. Now, reformatting is only delayed by the fetcher when the reformatter is not running. In practice this means body text reformats as it fetches, but large tables will show delayed reformatting - which was exactly the intended behaviour of the feature when it was originally thought of. fetch_token_data_address removed; it was only needed in two places, both of which already knew when to read tp->text and when to ignore it. Its functionality is duplicated in an 'if' involving reformat_istext, anyway. !Run[D] files taken back to requiring HTTP 0.33, since 0.36 introduces many weird and wonderful problems. Typo in Messages files, 'All current images (sic.) fetches finished' - 'images' is now 'image'. Shift+Click saving - you could save to an application. No problem. But the equivalent (just clicking on a link that led to an unknown datatype and getting the save dialogue that way) didn't work. It does now. Another problem was saving to an application that didn't support the datatype - oops, the dialogue would close but the fetch would sit there waiting to be told where to save. It doesn't close now (as expected). NB, doing several simultaneous fetches to a text editor may have problems as the editors are too clever for their own good. Despite receiving DataLoad messages for <Wimp$Scrap> for files of different types, sizes and datestamps, the editors can decide it's still the same file and: Zap - Hats off, it gets it right, almost. You do get warned 'Multiple copies - one on disc is newer' as everything after the first text loads, but they do load, and in separate windows. StrongED - Does not load the subsequent files, so the browser gives 'Data transfer failed' errors and opens up Scrap. Turning off 'Don't load same file twice' fixes it - each file is loaded in a new window with no warnings. At least in the first case, you don't lose data, since the files are kept in Scrap. Edit - Each time it loads the file, it *replaces* the other one in memory, using the same window for each. This is the worst behaviour as it isn't configurable (well, I don't know of a way to change it...) and results in data loss as successive texts get trounced by the new data. I can't see how I can fix this in the browser as it's basically silly behaviour on behalf of the editors. Other applications which don't try to work out if it's a new file or not are fine! When conducting image fetches, proxying is allowed unless reloading. When conducting page fetches, proxying was never allowed - so web cache stuff would have been, er, interesting. It now sets X-NoProxy: in the request header when reloading, but otherwise this is not included. AnimSpeed is, at last, independent of browser poll speed. They used to be tied together. Guess how the animation code used to work ;-) 'Can't handle this datatype' - deprecated now that save dialogues can be popped up. The 'can't save objects in full screen mode' error would never be shown due to a bug, anyway; this now replaces 'can't handle', which has been removed from all Messages files. RefoWait, RefoHang and RefoTime moved from Controls back to Choices. Trying to get rid of strlen in the reformatter - it can get very slow (e.g. strlen of 8K chunks of text, or if a 330K text file is transferred from a text editor straight to the browser, strlen of a 330K string...). There will be unfinished bits of code in the reformatter that may seem unnecessary - they've just not been plugged in yet (since they don't actually work). Don't remove them!
-
- 12 Sep, 1997 1 commit
-
-
Andrew Hodgkinson authored
As warned in the last log, pretty much all event codes and component IDs have now changed along with many of the names, to provide a consistent name and numberspace for events and components. This also minimises number clashes (e.g. as was, the Save File origin when opened from a Hotlist menu with an already-used component ID). To get full details on this, please carefully read through TBEvents.h. Res files, Sprites files and Messages files have been updated again both due to the above, and routine additions (e.g. message support for a few Hotlist bits and pieces). !Run[D] files updated for FTP 0.11 and HTTP 0.36. In the Makefile, the Customer objects list was missing Save - must have moved something when I should've copied it, when adding in SaveFile or SaveObject in all probability. Now fixed. Couple of other bits and bobs fixed in the build environment (e.g. stuff saying !Argo instead of !Customer). Oh, and I've altered the MakeFile copy options again to the best compromise I can come up with. Newer is turned on for everything except !Run[D] and !RunImage, since both of those change between debug builds - otherwise if you'd built debug and non-debug versions, it was not possible to switch between them - one version would have the newer timestamp and thus never get overwritten. The default hotlist has had a few items added - that'll be about the end of it, I think; there's more than enough stuff in there now. Saving of the hotlist from the document menu and of URI files, directories and selections from the hotlist menu tree is now implemented - this new save system rocks... Oh, and you can save all images and backgrounds as sprites. Saving of items with Shift+Click to other applications directly now works, and is robust. Unique Scrap filenames are used, with data load bounces (e.g. if some pra - er, person quits the app they're sending to) working correctly - that is, give an error, keep the file, rename it to something safe, and open the directory it lies in. As opposed to normal app-to-app bounces, where the scrap file is deleted (see PRM 3-254). This means you can now look at README files in FTP sites, say, without using a disc intermediate. Or you can send pictures straight to ChangeFSI, fetch HTML links into editors, and so-on, and so-on - it's all very funky. Known problems include the ambiguous 'invalid component ID' instead of 'file open' for *normal* (straight to disc) shift+click saves, and I think I'll introduce a unique name guarantee of some sort to stop 'file open' in the first place. Odd that the really tricky part (app-to-app) should be least likely to suffer from this!
-
- 02 Sep, 1997 1 commit
-
-
Andrew Hodgkinson authored
This version is being checked in because the Hotlist manager in the test build provokes a Wimp bug. All the variant resource files are out of sync and there are several outstanding bugs in the main code, so I'd personally avoid this build like the plague unless you're mad enough to want to examine the Wimp problem ;-)
-
- 31 Aug, 1997 1 commit
-
-
Andrew Hodgkinson authored
Created Protocols source file and moved a lot of message handling from handle_messages - the latter now serves as a high level distributor to lower level functions in Protocols. Incidentally, URL files (as used by the ANT suite) can be loaded by dragging to the browser in the same way as URI files - Not A Lot Of People Know That, etc. Merged new hotlist display type Res file to existing resources, added support for DataSave message so items can be dragged from the hotlist to a specific window (RAM transfer for URI and URL files; ScrapFile for HTML and Text but deleted afterwards and there are appropriate guards to stop Reload just saying 'not found'; images run through ScrapFile and there is no choice but to leave them there and do a conventional fetch). All !RunD files now give a WimpSlot of 2304K. Some small changes to the Argo and Ursula build Res files to make the menu trees more sensible. Controls files now take 'file:/' instead of 'file://' in Protocols section. Definitions at top of URLutils.c *not* altered, as then you end up with invalid URLs - so it will accept 'file:/', but always generate 'file://'. This is because some browsers exports 'file:/'. Sigh. make_no_[..._]memory_error functions now return a _kernel_oserror * rather than void. It's always &erb returned, but it enables users to use a more elegant 'return make_no_memory_error(1);', say, rather than something like 'make_no_memory_error(1); return &erb;'. I obviously should've written it like that at the outset, but never mind. All callers have been appropriately updated. The urlutils_leafname_from_url function now replaces illegal characters (A7000 Welcome Guide p54...) in the leaf with legal alternatives. Internal URL scheme is now a bit cleaner, with everything properly defined in URLutils.h. All references to http:, file: and ftp:, with or without a following '//' use the definitions in here now. More tidying and some reorganising of Hotlist source. Auto-open delay is now a Choices item. Some dependencies on statics removed (e.g. the counting functions don't accumulate into the global item_number now). The redraw functions used Wimp_TextOp - oops, so this has been amended to use whatever is supported on your Wimp. This is now in a new function (utils_text_width()), which the History menu routines also use (there was a bug in the width routine there anyway, which is therefore fixed in passing). Several other routines used Wimp_TextOp directly too, and they have been altered to use the new function as well. In hotlist code, one of the larger changes is in the API to hotlist_draw_r() (formerly _hotlist_draw()) which now takes item widths and heights as parameters - discovering these is quite slow, so doing it every time the function calls itself recursively is a little less efficient than passing the values in from elsewhere. Note that underscore prefixed functions are being slowly renamed to _r suffixed functions, to match the convention established by Tony Cheal with is table routines. This makes it much more obvious when something is recursive, as the same naming convention is used in every browser source file. Finally, note that I intend to ditch SaveDBox and use an alternate window with manual control of the messaging in Protocols.c. This will allow various improvements which at present the SaveDBox operational methods preclude. I'm going to have to do at least an alternate Window object for the SaveDBox module to use soon in any case. Getting rid of SaveDBox will help reduce, if only slightly, demands on the RMA.
-
- 28 Aug, 1997 1 commit
-
-
Andrew Hodgkinson authored
Open URL implementation more or less complete, though may undergo UI revision at a later date to allow named frames to be targetted. Hope to use the ideas in this code as the foundation for other general dialogues. In token stream dump for TRACE builds, table head items were not indented as far as they should have been - this is fixed; and manual toolbar redraw routines have been removed. They never worked, were commented out, and would never be used in that form anyway. DragBox source added, but it isn't at all complete and won't work - this is an 'in spare time' thing. We need custom drag boxes constrained to windows for the hotlist, and unconstrained for frame border resizing... Hey ho. Ancestor window extents match visible areas if there are frames (no more scrolling framesets...!). Frame resizing works whilst new documents fetch without pulling the extent down now. However, frame horizontal extents never shrink until a reload which is nasty, and this is all due for a rewrite. Frames border redrawing routine moved out of Redraw.c and into Frames.c. Bug regarding the mouse rectangle and frame border widths (rectangle was too large, so you could squash the edges) for edge-drag frame resizes fixed. Window width change reformat tolerance fixed; you could creep the window width down or up forever without any reformat, and centred objects would move but not be redrawn (thereby giving rise to subsequent redraw errors). Filetype on objects saved through Shift+Click correct. Save Source dialogue recognises if that source is plain text, rather than assuming HTML. A browser that fetches a file remembers the old store size it had before the save, so even though the data is now ditched, it reports the same amount of data fetched afterwards (looked awful when this could, for example, suddenly say '0' after a file save). Progress indicator is now fully aware of one or many file saves inside a frameset and reports the number of saves, a colon, and the cumulative saved data count, instead of reporting the sum total of fetched data in all frames, including non-file save stuff (note that for just 1 save, '1:' is not shown as a special case for the most common condition). A bug related to this, where you could in fact only do one fetch per frame*set*, has been corrected (only one fetch allowed per frame still, this is unlikely to ever change). Hotlist support added (D.Brown's source), with various bits of integration and modification still in progress there. Note additions to the Messages files. On the subject of Messages, the whole mucky business about what goes in Messages or Choices (and a few bugs where lookup_choice was used instead of lookup_token or vice versa) has been sorted out. Messages contains, more or less, just that. Choices contains user configurable stuff which generally can't mess things up too badly. A new file, Controls, is a Messages file holding the non-user configurable choices, which can generally make things go badly wrong if misused. A lot of these are tied to the Res file. StrongED users can get these to automatically fold out the various sections (EMail me for details). Sorry, but at the time of writing, Zap doesn't do folding... =8*P Two bugs with images. Asking for images to be shown in browser B when browser A uses the same ones and was loaded first didn't work correctly, and now does (a bit weird - browser A does the fetch and browser B does the display...). Second one occurred when the background image was also used on the page as a foreground image. This has been fixed by flagging background images in the image_info structure, and checking this before cross referencing. This bit also allowed the image_restart_fetches API to be extended, so that just background or foreground images may be fetched if they weren't already and the user asked the browser to show them. Before, the whole lot had to be fetched together (so turning on 'display backgrounds' will now kick off an image fetch if required, you don't need to reload the page anymore). Makefile copy options tweaked to be 'newer' (so if you're testing with some temporary Choices file or something, it won't write over it at the end of every export), and REMOTE_HOTLIST flag added for Customer builds - means the Hotlist.c functions aren't needed; the old, hotlist-by-file method is used. Added support for Customer build (see later), though there were very few additions needed in practice. Table printing fixed - in many ways it wasn't broken, it was image printing causing the oddities ever since the global image pool was introduced (this is, again, fixed). The 'reformat to fit page' option didn't work as coded any more; tables store cell addresses in the HStreams, so you can't then do a background reformat in a different browser. Hence, it now has to reformat to the page width, print, then put the page back again, all in the actual displayed browser. This doesn't feel as slow in use as it perhaps should, considering what is going on... Note that a line of a defined fraction (see Print.h) of page height will now split over page boundaries, so tall images or tall tables don't cause problems now (aside from the obvious problem of having the line split over a page at all!). There was a bug in the routine to print from a given start point until 'n' pages had been filled, in that it always filled 'n + 1' - now fixed. Finally, as part of the printing tweaks, a new dialogue exists - PrintStyle - with a similarly named source file added to deal with it. Global history auto save / load done, but only to the Choices file path - the whole browser is still strictly single user at present, with all the extra work for a multiuser Customer environment yet to be done. This has shown up a global history corruption problem which I haven't fixed yet. Rationalising TBEvents.h - things are migrating out of it, and into more appropriate sources (e.g. definitions relating to the Open URL dialogue are going into OpenURL.h, etc.). Event codes were at one stage deliberately diverged in numberspace from the component IDs of typical gadgets raising the events, to avoid anyone getting confused and thinking the IDs and event codes must match. However, this is in fact unlikely and it is much easier to remember the fewer numbers that result from tying the two together where possible. This has resulted in changes to event codes raised in the following objects of all Res files: Authorise, Find, OpenURL, and PrintStyle. And finally - !Run[D] files for all variants updated to require the latest toolbox and fetcher modules. All Res files updated for hotlists etc. and sprites files updated appropriately. All Messages, Choices and Controls files brought in sync., and an Customer build has been added (based on the Desktop build binary with different resources). That's all for now...
-
- 18 Aug, 1997 1 commit
-
-
Andrew Hodgkinson authored
Limits.h, and ensured consistent comment styling throughout all sources. Fetch.c/h split to Fetch, FetchHTML and URLveneer. URLstat.c/h produced to cope with this. OpenURL and Find sources created from bits in the Windows source file that shouldn't have been there... These will get filled out shortly. Note that a few functions in Fetch are due to be renamed and moved; probably to Tokenutils.
-
- 12 Aug, 1997 1 commit
-
-
Andrew Hodgkinson authored
Quite a few general source changes throughout many files to sort out swapped toolbars. There will be more work on this shortly. svcprint.c has been modified to allow it to output to a file in PipeFS, so TML-less machines can still use the standard browser debug routines (albeit in a less than elegant fashion). Comments in that source file give more details. Plus a few more bug fixes.
-
- 08 Aug, 1997 1 commit
-
-
Andrew Hodgkinson authored
(adding up to a greater whole), which include removal of the dastardly 'invalid image number' errors that trace builds would raise from time to time. Frame highlights are now better controlled (releaseably so). Generally, this build represents the first genuinely promising version of the browser for quite some time, despite the known library problems with comment handling etc.
-
- 05 Aug, 1997 1 commit
-
-
Andrew Hodgkinson authored
Fixed problems with unsourced images in tables and a couple of other bugs here and there - nothing earth shattering... Just wanted to keep the CVS source up to date.
-
- 25 Jul, 1997 1 commit
-
-
Andrew Hodgkinson authored
-
- 24 Jul, 1997 1 commit
-
-
Andrew Hodgkinson authored
Altered dialler status reporting to be more efficient (only installs the null handler when it needs the online time)
-
- 18 Jul, 1997 1 commit
-
-
Ben Laughton authored
-
