1. 12 Sep, 2020 1 commit
    • Robert Sprowson's avatar
      Add minimalist Wimp_ReadSysInfo 21 implementation · 56afccc6
      Robert Sprowson authored
      Since our text selection model follows the Style Guide and there's no means to configure it to the contrary, this subreason can just return fixed values to allow applications to query the state compared with running on a non-Cut-n-Paste Wimp.
      56afccc6
  2. 20 Jul, 2020 1 commit
    • Robert Sprowson's avatar
      Rename clashing CLI macro · 85171512
      Robert Sprowson authored
      The name clashes with the recently added clear IRQ flag macro, CLI, but is only used in a debug case.
      
      Version 5.77. Not tagged
      85171512
  3. 18 Jan, 2020 1 commit
    • Andy Vawer's avatar
      Fix zero page access looking for ptr_ sprite validation · 384a1ec5
      Andy Vawer authored
      On mouse click, check for icon type was incorrect, so trying to apply tests for 'P' validation string/ptr_write on inappropriate icons (eg. sprites), leading to invalid validation string accesses. Correct the test performed.
      Also add 3 further AcceptLoosePointer checks to validation string pointers.
      
      Version 5.69. Tagged as 'Wimp-5_69'
      384a1ec5
  4. 04 Jan, 2020 1 commit
    • Jeffrey Lee's avatar
      Add Wimp_Extend 15, "read slot size" · 4610877c
      Jeffrey Lee authored
      Wimp_Extend 15 is equivalent to Wimp_SlotSize,-1,-1, with the exception
      that the sizes returned in R0-R2 are now measured in pages instead of
      bytes. This allows code to accurately read the amount of free memory on
      machines with >2GB of RAM, and provides some future-proofing should we
      ever wish to support tasks with >2GB of RAM (e.g. via a future
      super-jumbo wimpslot, or more likely via sparse/PMP wimpslots, where
      the physical size is larger than the logical size).
      
      Currently there's no need to provide a page-based call to set the slot
      size (~2GB is fine for the forseeable future), so this call only
      focuses on reading the sizes.
      
      Version 5.67. Tagged as 'Wimp-5_67'
      4610877c
  5. 14 Dec, 2019 1 commit
    • ROOL's avatar
      Add copy & paste and drag & drop operations to the Wimp · 0fb14a00
      ROOL authored
      Detail:
        The text in writable icons can now be manipulated using the familiar keyboard shortcuts, or using Drag and Drop in conjunction with any compliant applications.
        Further details are in Doc/DragAndDrop along with information on API extensions which are implemented.
      Admin:
        Submission for Clipboard Support bounty.
      
      Version 5.65. Tagged as 'Wimp-5_65'
      0fb14a00
  6. 24 Jul, 2017 1 commit
    • Jeffrey Lee's avatar
      Remove startup delay from power saving code · 74a6db0a
      Jeffrey Lee authored
      Detail:
        s/Wimp02 - Get rid of the magic ~30 second delay before the Portable_Speed/Portable_Idle power saving kicks in. The fast/slow thresholds are self-adjusting, and any non-null poll event will kick the system into high speed, so removing the startup delay isn't likely to have any adverse affect on desktop startup time.
        s/Wimp01 - MaxIdleEvents is now redundant, remove it
      Admin:
        Tested on Raspberry Pi 3
        Should resolve issue reported on the forums where RPCEmu thrashes the hosts's CPU for 30 seconds after entering the desktop:
        https://www.riscosopen.org/forum/forums/10/topics/8990
      
      
      Version 5.59. Tagged as 'Wimp-5_59'
      74a6db0a
  7. 11 Apr, 2017 1 commit
    • Robert Sprowson's avatar
      Gate the recache of currentmode · 50eea7b2
      Robert Sprowson authored
      The operations at module init and at Service_PreReset are both implicitly pre desktop, however it is valid to have Service_ModeFileChanged while in the desktop (for example, if selecting a different MDF from !ScrnSetup).
      Gate the one hanging off Service_ModeFileChanged to only act when there are no tasks active (ie. outside the Wimp).
      Fixes problem reported https://www.riscosopen.org/forum/forums/4/topics/9206 with NetSurf redraw.
      
      Version 5.58. Tagged as 'Wimp-5_58'
      50eea7b2
  8. 08 Apr, 2017 1 commit
    • ROOL's avatar
      Recache currentmode at the right time · 121acd27
      ROOL authored
      Detail:
        Modification to make the Wimp reread 'currentmode' by calling OS_ReadSysInfo 1 in the following circumstances
        1. On module init (accounts for being softloaded off disc)
        2. At Service_Reset (accounts for any graphics driver starting after it in ROM module order)
        3. When Service_ModeFileChange (new, this catches the new mode selected by an MDF or EDID during !Boot)
        Commoned up these 3 cases into 1 function.
        This restores the design intent that to get the monitor's native resolution it is *not* required to configure the MonitorType=EDID, indeed doing so wouldn't have helped loading EDID off disc if the monitor's data is found to be incorrect and needing overriding.
      Admin:
        Tested on a Pandaboard with MonitorType=Auto and resolution chosen as "Native", resulting in a desktop at the panel resolution.
      
      Version 5.57. Tagged as 'Wimp-5_57'
      121acd27
  9. 25 Mar, 2017 1 commit
    • Jeffrey Lee's avatar
      Fix use of uninitialised pointer · 4d355e68
      Jeffrey Lee authored
      Detail:
        s/Wimp01 - initwcfda tries to look up the dynamic area name using MsgTrans, so make sure the 'messages' pointer is initialised before we call it
      Admin:
        Tested on iMx6
      
      
      Version 5.56. Tagged as 'Wimp-5_56'
      4d355e68
  10. 16 Sep, 2016 1 commit
    • Robert Sprowson's avatar
      Fix for crashes loading sprites on RISC OS 3.10 · 2de3bc5f
      Robert Sprowson authored
      A register fumble (revision 4.43 of this file) meant the pointer to the error block from OS_ReadSysInfo not existing was being cached as IRQsema, so later any attempts to resize the RMA would be skipped believing it to be unsafe (because the error pointer would point to an error block whose first word is mostly non zero).
      Tested on a real A5000 and emulated via ArcEm.
      2de3bc5f
  11. 08 May, 2016 1 commit
    • Jeffrey Lee's avatar
      Avoid unnecessary remainder calculations · ace2e66f
      Jeffrey Lee authored
      Detail:
        s/Wimp01, s/Wimp02, s/Wimp05, s/Wimp08s, s/Wimp10 - Avoid unnecessary remainder calculations in DivRem macro. Also make more use of DivRem's ability to accept a constant (not a register) as the divisor.
      Admin:
        Tested on Cortex-A15
      
      
      Version 5.52. Tagged as 'Wimp-5_52'
      ace2e66f
  12. 29 Nov, 2015 1 commit
  13. 10 Oct, 2015 1 commit
    • Jeffrey Lee's avatar
      Reinstate Wimp_ClaimFreeMemory · 503570de
      Jeffrey Lee authored
      Detail:
        This restores support for Wimp_ClaimFreeMemory, via having the Wimp manage a small-ish (4MB) DA that is used to satisfy Wimp_ClaimFreeMemory requests. The Wimp will only ever grow the DA, but the DA is shrinkable, so the system should shrink it as necessary should the free pool run too low.
        Options/s/!Default, Options/s/32, Options/s/Ursula - Add DynamicAreaWCF option to control support for the Wimp_ClaimFreeMemory DA. Enable the option for any builds of the module destined for RISC OS 5.
        Options/s/!Debug - New debug option for Wimp_ClaimFreeMemory debugging (mainly DynamicAreaWCF code path)
        Wimp/s/Wimp01 - Add calls to create/destroy DA on startup/shutdown
        Wimp/s/Wimp08s - DA create/destroy implementation. DA is only used if the free pool is a PMP or the Wimp expects kernel free pool locking but the kernel doesn't support it. Modify Wimp_ClaimFreeMemory to use the DA if it's present.
      Admin:
        Tested on Raspberry Pi
        Restores compatibility with software which relies on Wimp_ClaimFreeMemory, e.g. GDraw module (cause of "No free memory" errors reported by many)
        Note that Wimp_ClaimFreeMemory is still considered deprecated and support may be removed in future OS versions.
      
      
      Version 5.50. Tagged as 'Wimp-5_50'
      503570de
  14. 20 Jul, 2014 1 commit
    • Robert Sprowson's avatar
      Add definitions of button types 11/14/15 · 2ddbcbf5
      Robert Sprowson authored
      Button type 11 was added in 1988 so is about time it had a symbol to refer to it in the sources. Added & used said symbols.
      Removed 'DoubleIcon' switch, prototype button type 12.
      Built binary identical module, not tested.
      
      Version 5.43. Not tagged
      2ddbcbf5
  15. 18 Apr, 2014 1 commit
    • Jeffrey Lee's avatar
      Fix *WimpMode/Wimp_SetMode to return an error when given a bad mode selector... · fe39094e
      Jeffrey Lee authored
      Fix *WimpMode/Wimp_SetMode to return an error when given a bad mode selector block. Re-read configured mode on Sevice_Reset.
      
      Detail:
        s/Wimp01 - Reinitialise currentmode on Service_Reset in order to get the correct mode in the case of a GraphicsV driver overriding it (driver may not have been initialised at the time of the first call in module init). Add a bit more mode debugging and ensure ValidateAddress code completely removed under Medusa.
        s/Wimp02 - Issue OS_CheckModeValid in validatemode so we can detect cases where a valid looking mode selector block doesn't actually map to a mode definition. Add more mode debugging code.
      Admin:
        Tested on Raspberry Pi
        Fixes issue where "F12 -> *BASIC -> MODE 0 -> QUIT -> return" wouldn't restore screen mode correctly if currentmode had been set to a bad mode selector (e.g. after a CMOS reset nukes the LoadModeFile command), due to WimpMode's lack of error checking
        Note that this merely prevents currentmode being set to a bad mode at the time of *WimpMode/Wimp_SetMode - if a mode which is valid suddenly becomes invalid (e.g. due to loading a new MDF but not reselecting a valid wimp mode) then the Wimp will still fail to set a sensible mode on return to the desktop.
      
      
      Version 5.40. Tagged as 'Wimp-5_40'
      fe39094e
  16. 27 Mar, 2014 1 commit
    • Jeffrey Lee's avatar
      Disallow Wimp_SpriteOp 38 (create/remove alpha) · d3034221
      Jeffrey Lee authored
      Detail:
        - s/Wimp01 - Add OS_SpriteOp 38 (create/remove alpha) to the list of banned SpriteOp's for Wimp_SpriteOp. OS_SpriteOp 38 is almost always guaranteed to modify the target sprite, and so in keeping with other sprite modification ops it shouldn't be allowed via Wimp_SpriteOp.
      Admin:
        Tested on BB-xM
      
      
      Version 5.38. Tagged as 'Wimp-5_38'
      d3034221
  17. 09 Mar, 2014 1 commit
    • Jeffrey Lee's avatar
      Fix to build with HdrSrc-2_42. Use OS_SpriteOp 65 where possible. · 41cb4f23
      Jeffrey Lee authored
      Detail:
        s/Wimp01 - Update Wimp_SpriteOp handler to cope with the new SpriteReason_BadReasonCode value. Initialise unused bits of spritebits to 1 so that it acts as a whitelist, only allowing through operations that we know are safe.
        s/Tiling3D - Use OS_SpriteOp 65 for drawing tiled window backgrounds. Softload versions will fall back to using the old manual tiling code if OS_SpriteOp 65 is unavailable.
        s/Wimp10 - Use OS_SpriteOp 65 for drawing the tiled sprites that make up scrollbar wells and bars. Falls back to manual tiling in softload versions.
      Admin:
        Tested on Iyonix, BB-xM
        Requires HdrSrc-2_42
      
      
      Version 5.37. Tagged as 'Wimp-5_37'
      41cb4f23
  18. 01 Mar, 2014 1 commit
    • Jeffrey Lee's avatar
      Implement sprite translation table caching · 9187a060
      Jeffrey Lee authored
      Detail:
        This set of changes allows the Wimp to cache the last-used translation table, and cleans up some instances where translation tables were being generated and then not used
        s/Wimp01 - Expand selecttable_args to store all 8 registers needed by ColourTrans_GenerateTable. Add 1K of space for caching the palette that the cached translation table was generated from. Remove unused spriteX, spriteY variables.
        s/Wimp04 - Split cachespritedata in two. cachespritedata now only caches the basic information, while the new cachespritepixtable rotuine will generate a translation table (shaded/inverted if required). This allows table generation to be deferred until we're just about to render the sprite, ensuring that the table isn't generated only to not be used. Also updated icon sprite rendering to check the sprite is within the graphics window before attempting to render it, allowing removal of one more case where tables can be needlessly generated.
        s/NewSWIs, s/Wimp09 - Change ADR to ADRL
        s/Tiling, s/Tiling3D - Use cachespritepixtable when needed
      Admin:
        Tested on Iyonix, BB-xM, StrongARM RiscPC
      
      
      Version 5.36. Tagged as 'Wimp-5_36'
      9187a060
  19. 01 Jan, 2014 1 commit
    • Jeffrey Lee's avatar
      Change Wimp_ReadSysInfo 2 to not return alpha sprite names. Add... · 8913591b
      Jeffrey Lee authored
      Change Wimp_ReadSysInfo 2 to not return alpha sprite names. Add Wimp_ReadSysInfo 29 and Wimp_Extend 257.
      
      Detail:
        s/Wimp01 - Change romspr_suffix initialisation so that it won't store alpha sprite suffixes. This has the knock-on effect of making Wimp_ReadSysInfo 2 no longer return alpha sprite suffixes, without affecting any of the sprite search code
        hdr/Wimp, s/Wimp01 - Add Wimp_ReadSysInfo 29 to read the alphaspriteflag value - i.e. whether alpha sprites are supported by the OS/Wimp and *IconSprites, Wimp_Extend 13, etc. will look for them
        hdr/Wimp - Document the private Wimp_Extend reason codes and add a couple of ROL's reason codes
        s/NewSWIs - Tidy up Wimp_Extend implementation to use a jump table instead of a load of tests and branches. Add an implementation of ROL's Wimp_Extend 257, which just acts as a wrapper around Wimp_Extend 13
      Admin:
        Tested on Raspberry Pi
        Wimp_ReadSysInfo 2 change should fix issue reported on forums with software unexpectedly using low-res sprites or failing altogether:
        http://www.riscosopen.org/forum/forums/4/topics/2274
      
      
      Version 5.35. Tagged as 'Wimp-5_35'
      8913591b
  20. 30 Nov, 2013 2 commits
    • Jeffrey Lee's avatar
      Fix alpha sprite support · 9f37c9dd
      Jeffrey Lee authored
      Detail:
        s/Wimp01 - An ill-advised last minute edit would leave the Wimp in an infinite loop looking for ROM sprites if it tried to enable alpha sprite support
      Admin:
        Tested on BB-xM
      
      
      Version 5.34. Retagged as 'Wimp-5_34'
      9f37c9dd
    • Jeffrey Lee's avatar
      Add support for *iconspriting of alpha-masked sprites. Fix icon... · 03e27cbe
      Jeffrey Lee authored
      Add support for *iconspriting of alpha-masked sprites. Fix icon shading/inverting to work with true colour sprites.
      
      Detail:
        Options/s/!Default, s/NewSWIs, s/Wimp01:
      
        Updated ROM sprite find code, *IconSprites and Wimp_Extend 13 to understand a new spritefile suffix.
        If the Wimp detects that RISC OS Select style alpha masked sprites are supported, and we're not using the mode 23 sprites, then the code will enable support for alpha masked sprites of the form !SpritesA1, !SpritesA2, !SpritesA, etc. Alpha-masked sprites are only looked for when looking for square pixel sprites or just before looking for the default sprites. This means the full search pattern for (e.g.) a !Sprites21 mode would be as follows:
      
        !Sprites21  (original mode)
        !SpritesA2  (next squarer mode, alpha sprites)
        !Sprites22  (next squarer mode)
        !SpritesA   (default alpha sprites)
        !Sprites    (default sprites)
      
        Like with !Sprites11 support, this feature can be toggled off via the SpritesA option if necessary.
      
        s/Wimp01, s/Wimp04:
      
        Updated icon plotting code (wimp_SpriteOp_putsprite and calculateinverse) to allow true colour sprites/icons to be rendered shaded/inverted.
        For this to work the Wimp needs a version of SpriteExtend which supports colour mapping (specifically it checks for the relevant ROOL version number).
        The colour mapping function which is used to build the translation tables used for shading/inverting palettised sprites is too slow to be sensibly used on a per-pixel basis, so the first time a shaded/inverted true colour sprite is requested the Wimp will generate a set of lookup tables which can be used by a much simpler colour mapping routine.
        To keep memory usage down these lookup tables only use 4K colours each; however the quality isn't always that great and so this may need revising in future.
      
      Admin:
        Tested on BB-xM
      
      
      Version 5.34. Tagged as 'Wimp-5_34'
      03e27cbe
  21. 07 Oct, 2013 1 commit
    • Jeffrey Lee's avatar
      Fix logic which decides whether to plot sprites using the Kernel or... · b5280514
      Jeffrey Lee authored
      Fix logic which decides whether to plot sprites using the Kernel or SpriteExtend to take into account the new sprite modes
      
      Detail:
        s/Wimp01 - Add NColour mode variable to the list of variables cached for the current screen mode. Add modeflags & ncolour to the sprite & tool sprite variables.
        s/Wimp04, s/Wimp10 - Update cachespritedata and cachetoolspritedata to look at the modeflags, ncolour and alpha mask flag when deciding if sprite_needsfactors should be set or not (i.e. whether the code ultimately uses OS_SpriteOp 52 or 34). This should allow the Wimp to correctly detect if a sprite can safely be rendered by the Kernel or not (except for double pixel vs. non-double pixel - but presumably nobody's using double pixel mode sprites for icons/tool sprites, otherwise it would be fixed by now?)
        s/Wimp04 - Add an extra safety check to icon text rendering after a crash was seen when calling Wimp_PlotIcon outside of a redraw loop
      Admin:
        Tested on BB-xM
        Fixes problem reported on forums with 32bpp, alpha...
      b5280514
  22. 08 Sep, 2013 1 commit
    • Robert Sprowson's avatar
      3 minor fixes, 2 minor enhancements · a9c3b548
      Robert Sprowson authored
      Makefile:
      * Conditionally copy the disc resources, saving a little build time.
      Wimp10.s; hdr/Wimp:
      * Issue Service_WimpToolSpritesChanged when the tool sprite area is changed.
      Wimp05:
      * Fix bug in softloaded versions of the Wimp where menus would randomly lose the keyboard shortcut text. This was caused by use of an LDR to retrieve a byte wide variable. This specifically affected some softloads because the Wimp gets squeezed, and during unsqueezing the Wimp's workspace ends up being allocated from the same bit of RMA that used to contain the squeezed copy of the module (=lots of random numbers).
      Wimp09:
      * Fix bug where configuring WimpSpritePrecedence to ROM when a theme is loaded would cause redrawing of window textures to fail. This is because the Wimp intersects the ROM and RAM sprite areas and deletes any duplicates from the RAM area when remaking the fast lookup sprite list. So if the RAM sprites include the "tile_1" (etc) sprite on redrawing the desktop the Wimp points to this, then intersects the lists and deletes the sprite, leaving the pointers pointing at junk. Now, on deleting something, the window tile pointers are invalidated. Fixes ticket #346.
      Wimp02:
      * Fix bug where the title bar text, when the desktop font is the system font, is incorrectly rendered in the colour selected by WimpVisualFlag -WindowOutlineColour. The Wimp now restores the text colour if -WOC has set the graphics colour to something other than black.
      
      Administrative -
      In Wimp01, swap a couple of SpriteReasons from magic numbers. In the init of variables use the common reset_all_tiling_sprite function.
      In Tiling3D, more SpriteReasons, and rationalise the registers used in reset_all_tiling_sprites.
      
      Version 5.32. Tagged as 'Wimp-5_32'
      a9c3b548
  23. 06 Aug, 2013 1 commit
    • Jeffrey Lee's avatar
      Replace OS_SpriteOp reason code magic numbers with definitions. Add support for new screen modes. · fa42b0ad
      Jeffrey Lee authored
      Detail:
        s/Tiling, s/Tiling3D, s/Watchdog, s/Wimp05, s/Wimp07, s/Wimp09 - Replaced OS_SpriteOp reason code magic numbers with symbolic definitions.
        s/Wimp01 - Update *WimpMode / Wimp_SetMode to use OS_ScreenMode 13 (mode string to specifer) in place of its own code if a mode specifier string has been given. Note - mode number handling is unchanged, so a mode specifier string which begins with a mode number will currently have the specifier part ignored.
        s/Wimp01, s/Wimp02 - Flag_* -> ModeFlag_* renaming
        s/Wimp02 - Fix mode specifier copying to only stop copying when we hit a mode variable of -1. Previous code would also stop if the variable value was -1. Update mode set code to apply the Wimp's special greyscale palettes if the greyscale mode flag is set (i.e. greyscale mode was set via specifier generated by OS_ScreenMode 13)
      Admin:
        Tested on BB-xM
      
      
      Version 5.31. Tagged as 'Wimp-5_31'
      fa42b0ad
  24. 01 Jun, 2013 3 commits
    • Robert Sprowson's avatar
      Add flexible scheme to allow non-grey/opaque toolsprites · 2137a784
      Robert Sprowson authored
      The Wimp can now accept toolsprite sets which have precalculated (non default) colour translation tables supplied by the designer.
      This allows the link between window template colour and displayed tool colour to be reestablished when the tools aren't grey (previously, the Ursula Wimp would only tint greys).
      For full design details see Doc/ToolTables.
      An example test set, TestO/TTTTest is provided. This is the 'Newlook' set but with a splotch in the corner of each sprite which is then replaced by the hex of the Wimp colour being requested.
      Detail:
       Wimp01.s: New workspace requirements
       Wimp04.s: Pull out the RGB to greyscale function so it can be used elsewhere
       Wimp10.s: New tool table support code
      
      Fixes ticket #323.
      Also introduces a disc variant (with the extra EX0 EY0 resolution) of the 'Steel' theme, thus making it generally available.
      
      Version 5.30. Tagged as 'Wimp-5_30'
      2137a784
    • Robert Sprowson's avatar
      Change to method of window highlighting · d137f7ac
      Robert Sprowson authored
      The change made in Wimp-5_02 to Wimp-5_03 (to permit 'f' prefixed toolsprites) introduced a set of interesting boundary cases not covered by that scheme.
      This commit restores the former behaviour, while retaining its simplification of H/V scrollbar plotting (beefed up with a few ASSERTs).
      Part of fix for ticket #323.
      
      Tagged as Wimp-5_30-pre4.
      d137f7ac
    • Robert Sprowson's avatar
      Don't try freeing the tool pixel trans table twice · 1f206e86
      Robert Sprowson authored
      In deallocptrs a call to freetoolarea is made, then much the same code repeated inline.
      Excess code deleted.
      
      Tagged as Wimp-5_30-pre2
      1f206e86
  25. 21 May, 2013 1 commit
  26. 18 May, 2013 1 commit
  27. 11 May, 2013 1 commit
  28. 09 May, 2013 1 commit
    • Robert Sprowson's avatar
      Change to RMA shrinkage in *ICONSPRITES pre Medusa · 46989188
      Robert Sprowson authored
      On completing the sprite area merge the Wimp would try to minimise the RMA by -256MB (to account for the fact that during the merge the RMA is enlarged to hold both the existing sprites and the new ones to be merged, in the case of duplicates).
      However, this meant that the common construct
      
        IconSprites MySprites
        Run MyApp
      
      where MyApp wanted to use more than a teaspoon of RMA would fail due to the lack of free pool and that the RMA can't be resized when an application is running as a result.
      
      Now, the Wimp notes the free space in the RMA, does the -256MB shrink, then ensures there's still the same free space after the event (ie. overall it may have grown by the size of any extra sprites added during the command).
      Tested on RISC OS 3.10.
      
      Version 5.26. Tagged as 'Wimp-5_26'
      46989188
  29. 06 May, 2013 1 commit
    • Robert Sprowson's avatar
      Refinements to disc based targets especially · a30a2489
      Robert Sprowson authored
      Previous attempt to disable Sprites11 support for 3.10 and 3.50 hadn't spotted it was reenabled in the common options, also the Sprites11 switch was also tied up in Wimp$IconTheme support.
      Title bars would flicker when picked up when using a tool sprite set with no 'p' pushed equivalents on RISC OS 4.0x due to screen cache.
      Makefile now installs a default set of tools & sprites when target is ThemeDefs.
      CLI limit reduced to 256 pre Ursula to save RAM.
      
      Options/!Common:
        Promote Sprites11 switch into !Default
        Remove fixrmatools
      Options/!Default:
        Sprites11 true by default
        LongCommandLines true by default, false on targets pre Ursula
        Remove ServiceCallTable (harmless to have it in all cases)
      NewSWIs.s:
        Enable Wimp_Extend 13 all the time
      Wimp01.s:
        Reduce RMA use by vital 1.5k for non long command line case
        Change sense of Sprites11 switch to adopt all its previous functionality, but not look for '11' suffix when the switch is false
        Adopt ServiceCallTable switch permanently
      Wimp02.s:
        Comments ammended
      Wimp07.s:
        Range of ADR
      Wimp10.s:
        Change sense of Sprites11 switch to adopt all its previous functionality, but not look for '11' suffix when the switch is false
        Adopt :LNOT: fixrmatools switch permanently
        Supress title bar sprite plotting when none of the sprites exist
      
      Version 5.25. Tagged as 'Wimp-5_25'
      a30a2489
  30. 03 May, 2013 1 commit
    • Robert Sprowson's avatar
      Slacken pointer checks · 42e284a3
      Robert Sprowson authored
      The pointer comparison checking required when running in a system with > 64M memory was tightened up from Wimp-4_75 to Wimp-4_76, but to allow the module to target pre RISC OS 5 systems an option to relax those checks is required.
      Each check has been revisited and where appropriate demarked with a "AcceptLoosePointer" macro, which just remaps the pointer into the stricter form and carries on. In the strict checking case, the macro reduces to nothing.
      
      Detail:
      Add AcceptLoosePointers switch.
      Retire singular use of StrongARM switch (calling XOS_SynchroniseCodeAreas is harmless pre StrongARM anyway).
      Rename Ursula_RPC options to RO400.
      Put duplicate documentation in the attic.
      Allow -2 or -1 as the iconbar handle in Wimp_ResizeIcon (ticket #203).
      Tighten up the list terminator check in the DebugMemory switch of Memory.s
      
      Tested on RISC OS 3.10 (emulated), 3.50, 3.60, 3.70, 4.02.
      
      Version 5.24. Tagged as 'Wimp-5_24'
      42e284a3
  31. 27 Apr, 2013 1 commit
  32. 10 Apr, 2013 1 commit
    • Robert Sprowson's avatar
      Build fixes for variants pre RISC OS 5 · fc22d68f
      Robert Sprowson authored
      Minor fixups as part of univeral !Boot work.
      Options no longer ASSERT on International_Help (which is a definition exported by the kernel, rather than a build switch), and instead define a switch which is true for > 3.50.
      Non UTF8 supporting case has simple substitutes for Wimp_TextOp.
      Legacy_DomainId and LegacyIRQsema no longer cause NULL pointer dereference.
      MOVeQ => MOVEQ to placate ObjAsm.
      
      Ursula_RPC version built and used briefly on RISC OS 4.02 host. No other run time testing.
      
      Version 5.22. Tagged as 'Wimp-5_22'
      fc22d68f
  33. 28 Mar, 2013 1 commit
    • Robert Sprowson's avatar
      Add support for wide translation tables for window tool furniture · cd1be707
      Robert Sprowson authored
      With the introduction of 16bpp/32bpp modes it became possible to request tables from ColourTrans which used > 1 byte per colour, but the Wimp wasn't using this extension. Therefore tool sprites designed in 8bpp or less would be quantised horribly when plotted in a 16bpp or 32bpp mode.
      The Wimp now requests and plots with a wide table, and to avoid thrashing ColourTrans so much with the prevalence of individually paletted icon sprites, keeps the table seperately to the icon sprites ones. At worst (in 32bpp) this uses an extra 256x4 bytes of RAM.
      Trace.s: Split out the tracing routines from Wimp10 as it was getting a bit big.
      Tiling.s: Namespace change for the icons versus tools distinction. Removed some unnecessary PC+8/PC+12 confused NOPs.
      Tiling3D.s: Namespace change for the icons versus tools distinction.
      Wimp01.s: New set of variables to track the tool translation tables separately. Various jiggling to keep ADRs in range.
      Wimp02.s: Namespace change. Remove some double handling in Wimp_SetColourMapping.
      Wimp04.s: Namespace change. Made factor rationalisation common to both the icon and tool grinding code. Removed dual use of cachespritedata for both icons and tools. The tintfunc moves to Wimp10. Service_InvalidateCache confusion resolved by adding a new flag to remember that the tools need regenerating rather than just marking the tool list as missing (which subsequently got restored in Tool_SpriteOp without actually doing any palette work.
      Wimp10.s: Label tools_area renamed as it was immensely confusing to have that (which was actually holding the RMA allocation of the tool_list) and tool_area (which contains the sprite area) hanging around. Changed references to use tools-only cachetolspritedata routine. Added 'wide' flags to sprite op and colour trans calls. Tool_SpriteOp changed to actually regenerate the colour tables when they're known invalid (previously the tools list pointer was merely restored and no colour tables used). Trace functions extracted. Resolved confusion as to what recache_tools_trans and recache_tools_trans2 should be doing.
      
      Tested with 4bpp "NewLook" sprites in 4bpp/8bpp/16bpp/32bpp and 8bpp smooth greyscaled "Steel" tool sprites in same modes.
      Also ran a task window doing repeated Service_InvalidateCache calls while monitoring the RMA for leaks.
      Generally navigated around some directories to ensure that inverse icons (during double click) and filer windows (with individually paletted sprites) were being rendered.
      
      Version 5.20. Tagged as 'Wimp-5_20'
      cd1be707
  34. 16 Jul, 2012 1 commit
  35. 24 Jun, 2012 1 commit
  36. 23 Jun, 2012 1 commit
    • Robert Sprowson's avatar
      Preset Wimp$IconTheme on initialisation to UserIF if not already set · 5283be1f
      Robert Sprowson authored
      Therefore, when in ROM, the ROM theme can be inferred. When a different theme is selected by the user in the boot sequence, that is respected.
      Restore a lost error message for *ICONSPRITES when the file doesn't exist even after trying all the 11/22/23 suffix and prefixes. This seems to have been lost post RISC OS 3.10 when Sprites22 support was added, but it is an error for the file given to not exist at all (cf. *TOOLSPRITES).
      Typos in docs ammended.
      
      Version 5.15. Tagged as 'Wimp-5_15'
      5283be1f
  37. 10 Mar, 2012 1 commit