1. 20 Nov, 1997 2 commits
    • Andrew Hodgkinson's avatar
      Following the last check-in - all build resources brought up to date. · cc9d8863
      Andrew Hodgkinson authored
      Adjust-click on forwards/backwards buttons did not work in the intermediate
      build, and now does.
      
      Adjust-click on form submission buttons where the submit method is POST
      will now work correctly, as the new view inherits the extradata block
      of the old. Failure of this is signalled through
      make_no_fetch_memory_error, code 16 (see updated Errors file in Docs).
      Note the name change of extradata in this context; more details below.
      
      The passing of forms POST data and extra headers for sending in an
      HTTP request via. the URL module was all done through pointers into
      flex blocks, and was therefore very unsafe. All relevant functions now
      use pointers to pointers to the data.
      
      To remove confusion on the umpteen uses of the word 'extradata', the field
      in browser_data has been renamed to 'post_data'. The 'extradata' parameters
      used within FetchPage.c were all disconnected from the extra header info /
      form POST data stuff that extradata is usually associated with, and have
      thus also been renamed, in this case to 'appnddata' (Append Data).
      
      As well as X-NoProxy, the browser sends the 'proper' HTTP headers
      Pragma:no-cache and Cache-Control:no-cache.
      
      A redirection from a POST request was not handled correctly; despite
      what HTTP specs say, you're supposed to use GET for the new URL. The
      browser was, but when it chopped off the redundant header data in the
      request didn't terminate it and left Content-Type in anyway...! Fixed.
      
      Ctrl+Tab implemented - URL completion. Comes from the hotlist URLs,
      hotlist titles, history hosts, paths, full URLs and lastly titles.
      See code comments for more (history_find_match, hotlist_find_match).
      
      TableSupport option added to Choices; it is read, can be set by the
      front-end, but doesn't actually do anything else yet.
      
      Reversed Choices' semantics on 'don't expire by...' for History. Added
      'needs_redraw' flag to choices_get_contents so that, for example, if the
      table border types change, browsers get redrawn.
      cc9d8863
    • David Brown's avatar
      b6e800c2
  2. 19 Nov, 1997 2 commits
    • Andrew Hodgkinson's avatar
      MaxSize is in K now, not bytes... · 8061802a
      Andrew Hodgkinson authored
      8061802a
    • Andrew Hodgkinson's avatar
      This is an intermediate check-in to allow work on Choices for the new table... · 7caf92e2
      Andrew Hodgkinson authored
      This is an intermediate check-in to allow work on Choices for the new table options and History choices as detailed below. Res files are not up to date except where indicated and there are several known bugs that will be fixed before the 'final' v1.27 is created. Any work on resources should only be done for the testbed !Browse.
      
      Client side image maps implemented. There is code to draw highlighted
      borders in CSIM.c, but this is not wired in yet; other than that,
      the implementation is functionally complete. As part of this, centralised
      the fetching of a targetted URL taking into account user request of a
      new view and full screen mode, in fetchpage_fetch_targetted. The forms
      library now uses this too, so form buttons respond to both adjust-clicks
      and TARGET attributes.
      
      Fixed APPLET handling where '.class' isn't present in the CODE attribute.
      
      Paragraphs squashed at the top of cells/pages - browser would insert white
      space before.
      
      Now append a ' ' to the end of History menu items to prevent the Wimp
      thinking the end of entries represents a keyboard shortcut (e.g. 'Home').
      
      Netscape's handling of 'meta http-equiv="refresh"' is to start counting
      when the fetch has completed and everything else has died down. The browser
      will now not start counting until the animation handler is deregistered
      (so formatting is complete) to show similar behaviour (note that this
      checks the main handler, not the 'idle but returning to first frame'
      drift handler).
      
      URLs from requests for fetches by Plug-Ins are now relativised.
      
      Page width change tolerance prior to reformat upped from 16 to 32 OS
      units. Hoping to provoke a loosely connected bug with this change!
      
      TableOuter, TableInner and SeeFetches choices added to all Choices
      files, with appropriate loading and saving code in Main.c and Save.c.
      AuthorFTP and AuthorFSh messages added for FTP authentication, and
      dialogue handling code (the component in FetchHTML.c) updated to
      recognise an FTP fetch and alter the dialogue presentation
      appropriately.
      
      All Messages file version numbers taken up to 1.27 (20 Nov 1997).
      
      Following a UseNet suggestion, Ctrl+Toggle Size will increase the window
      size to fill the screen vertically only; horizontal size/positioning is
      not changed.
      
      Shift+Tab in the URL writable will cycle through alternative fetcher
      protocols (from both the Controls file and checking the fetcher modules
      are actually present).
      
      Hotlist doesn't require '://' in URLs when loading HTML, just ':/' - so
      'file:/' URLs now will be reloaded correctly.
      
      History system rewritten completely. GHistSize and VHistSize options
      removed, and replaced by MaxSize and ExpiryAge. Now have global history
      menus with most recently visited items at the top, and local history
      menus which reflect the path that forward/back buttons would take.
      Browsers are robust to background expiry of the History though this is
      not implemented - date expiry and size checks are carried out on
      history_record only. This does mean that with two windows open one could
      have the history expired underneath it whilst another fetched, though;
      the code handles this and update toolbars (greying items) as necessary.
      It is possible to have the history limits so tight that even one entry
      will not fit and again the code copes with this, though values read
      from Choices are limit checked to ensure rather more useful results!
      
      Implemented 'Save' button in save dialogues. Remembers pathnames and just
      replaces the leaf now (hard coded exceptions for <Wimp$Scrap>... and
      <Wimp$ScrapDir>...) - it did before, but only if you'd typed the path
      in. Not many people did, given that you couldn't press Return or click on
      a Save button to use that path...
      
      In a similar vein, files of type Data or DOS will be checked for a '/xxx'
      type extension and the MimeMap module will be used to find a more meaningful
      filetype. If this can be handled, the file is loaded. This only works for
      files dragged to the browser - the behaviour with inline data in web pages
      will depend on the File module, and similarly, if File doesn't spot what is
      going on and claims that the object is data, the browser will just open a
      save dialogue for it.
      
      !RunD files taken up to 3072K WimpSlot.
      
      Hotlist's saved HTML page title wasn't internationalised - is now. This
      opened up a significant can of worms; on file write error, the file would
      never be closed, and if a caller of the save or load functions passed
      in a filename held in the global Messages lookup buffer then subsequent
      lookups in the callees would corrupt that filename. All sorted out now.
      
      Local (not very useful) or global (useful) histories can be saved as HTML,
      which opens up the possibility of sending your history to the hotlist
      by saving to it. Local and global histories can also be emptied, though
      this is probably not a feature that current release Desktop browsers need.
      Inheritance of local history and certain UI features is now done more or
      less for all cases where one browser window spawns another, too.
      
      Vertical alignment on images is rather less ropey than it was (e.g.
      ALIGN=TOP stands half a chance of working) but is still far from perfect.
      This was part of fixing a nasty little bug in Redraw.c's setting of
      an image position via. image_set_token_image_position, which was making
      (amongst possibly many other things) client side image maps fail.
      Image update where images had large borders was affected by a similar
      problem too (more cans with more worms...).
      
      Fixed image background filler functions; two problems. When cross
      referenced images were replaced by base images in a browser because the
      original owner was closing down, the original owner browser would stay
      registered with ImageLib. Fixed; secondly, when images were deleted from
      the image array causing those above to be renumbered, images registered
      with ImageLib did not have their numbers updated (this was the one that
      lead to the visible drop out of background images with PNGs on the Acorn
      Internet home page when there were two views of the page and the first
      was closed). This is now also sorted out.
      7caf92e2
  3. 05 Nov, 1997 1 commit
    • Kevin Bracey's avatar
      Added system font option to choices. · 702eb5d8
      Kevin Bracey authored
      Stopped UNIFONT forcing system font use and added calls to Font_WideFormat.
      Made sure the system font option is read before fm_init is called!
      
      User agent string now set if Netscape faking is disabled (format used is
      "Acorn Browse/1.26 (RISC OS 3.71)".
      702eb5d8
  4. 30 Oct, 1997 2 commits
    • Andrew Hodgkinson's avatar
      Removed 'The Onion' link from some Hotlist files. Time showed that the site... · 62293187
      Andrew Hodgkinson authored
      Removed 'The Onion' link from some Hotlist files. Time showed that the site wasn't entirely Family Friendly (TM)... Removed Shift Control (it's gone offline now), and corrected the Telegraph URL from ...the-telegraph...
      
      to just ...telegraph...
      
      StrongHelp manual generator now tries to work out the number of lines in
      the table on the root page more intelligently.
      
      Plug-in support extended to handle Shockwave. Quite a lot of underlying
      work for this, including a pseudo cache system for temporary files.
      
      Bug in redraw routines: they plotted background images within table
      cells, when nothing should have been drawn. Oops. When background images
      in cells are properly supported, this can get sorted out.
      
      Tweaked vertical plot position of HRs (up to 4 OS units too high before due
      to rounding).
      
      Various Res file bits and pieces, Ursula build taken up to v1.26 beta
      for release on the Browser site. *Note* not all resources are up to date!
      This will be done after AW97.
      62293187
    • Kevin Bracey's avatar
      b8ed8c22
  5. 27 Oct, 1997 1 commit
  6. 24 Oct, 1997 2 commits
    • Andrew Hodgkinson's avatar
      Forgot to add RMA last time. · 1b243ebb
      Andrew Hodgkinson authored
      Res files sorted out a bit, to add the Proxy option to the Choices dialogues
      and fix the position of the menu popup in the Others pane.
      
      Bogus comment in Global.h showed up when trying to build the Customer
      variant (SINGLE_USER undefined); fixed.
      1b243ebb
    • Andrew Hodgkinson's avatar
      Various fixes in the code required for Shockwave support (many invalid... · 7b1aa501
      Andrew Hodgkinson authored
      Various fixes in the code required for Shockwave support (many invalid assumptions about the OBJECT tag structure). Not finished yet though.
      
      Played around with signal handling 'n' all that to try and get sensible
      errors reported for aborts etc. using code by KBracey. Need a ROM patch
      for _swix on RISC OS 3.7 upwards (or a local fixed copy of _swix),
      otherwise should sort out most of the problems seen (mostly 'no stack
      for trap handler' errors and a distinct lack of a register dump).
      
      Plug-In view on redraw / ASAP choices now work as they should (ASAP
      was previously broken).
      
      Version numbers in Messages incremented to 1.25 (23 Oct 1997).
      
      For Plug-In support, created new source file RMA.c/h to handle RMA
      claims and releases, in an attempt to ensure leakage never happens.
      As such, this source is *slightly* more advanced than that in the 1.25
      AW '97 build, though functionally identical. Well, that is, at least
      you can confirm zero RMA leakage with '-debug LMem' in TRACE builds now!
      
      Intend to do a consistency check on comment syntax in all sources
      shortly - I need to rebuild my StrongHelp manuals; can't keep track
      of all of these new functions...
      7b1aa501
  7. 22 Oct, 1997 3 commits
    • Kevin Bracey's avatar
      c405993d
    • Andrew Hodgkinson's avatar
      4cca62eb
    • Andrew Hodgkinson's avatar
      fetch_get_raw_data will notice if up->fetching is zero and return a 'finished'... · 3a920561
      Andrew Hodgkinson authored
      fetch_get_raw_data will notice if up->fetching is zero and return a 'finished' status rather than trying to continue reading data for the fetch. Fetches should never fall through that far but at least it will cope if they do.
      
      3D table borders are now supported. 2D borders are used if the
      inter-cell spacing is too small to fit the borders in (display resolution
      dependent) - the external table border is 2D if the internal borders are,
      else 3D. For cellspacing of 0, internal table borders must plot over the
      outer edge of pixels inside the cell; for all greater spacings, the
      borders take up all or part of the gap between them. The external border
      will always fit around the outside of the cells, including the
      cellspacing value in the gap between the outer cells and the border.
      
      Anti-alias colour for placeholder ALT text was incorrect. Fixed.
      
      I'd changed 'point' to 'points' in some of the Font Choices dialogues;
      now changed back to 'point'.
      
      The routine to find out how large an otherwise unsized object or image
      placeholder based on its ALT text has been centralised in Reformat.c,
      so that the image and object routines can both access it without
      code duplication (this means non-image objects will now have the correct
      size if they contain ALT text, rather than assuming a standard default
      size as before). ALT text in images that were also objects was never
      plotted either, though the placeholder size would have been correct.
      This has been fixed.
      3a920561
  8. 20 Oct, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Weird - the line registering the ENavigateToBeShown event disappeared from · 211492c2
      Andrew Hodgkinson authored
      Main.c, so the last log was incorrect; Navigate menu items wouldn't have
      been greyed out. Probably a(nother?) CVS update screw up on my part; now
      fixed. This sort of thing is happening far too often...
      
      Font manager would crash in system font or if a font face was not found
      in the previous release - that hacky business of returning weird font
      handles when system font is to be used instead ensured a rather less than
      valid array reference on behalf of fm_claim_basic_typefaces.
      
      Added in a few more calls to the 'check the button bar' routines, to
      ensure that things like Stop are greyed/ungreyed when needed.
      
      Cellpadding code could lead to rmarg overlapping lmarg, or the sum
      being greater than dwidth, or something like that (!) in the reformatter.
      Anyway the results were unpleasant; this has been sorted out by range
      checking right and left margins w.r.t. display width in the relevant
      section of the code.
      
      People who specify 'td width = 2000' in tables expecting to get something
      sensible now do, though I was half inclined to leave it alone... I can
      only assume that they don't know about % specification or it didn't
      work in their browser at authorship time, and the huge width served as
      an attempt to get the table to fill the available window width. Anyway,
      the table reformatter spots when the maximum width a cell requires is
      less than half of what it asks for, and ignores the width specifier if
      this is the case.
      211492c2
  9. 18 Oct, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Sorted out Res files, including fixing position of 'bytes' label in one of the... · 20f5e4ab
      Andrew Hodgkinson authored
      Sorted out Res files, including fixing position of 'bytes' label in one of the Choices dialogues (I'd missed it out of a selection when everything else got moved down a bit). Unfaded Enc_Chinese menu entries, made sure text labels were wide enough for system font, changed 'Apply' on Choices dialogue to 'Set', and added ^K to hotlist keyboard shortcut lists.
      
      Print Setup (i.e. Print dialogue) buttons all set to 'local', so the
      stupid Toolbox doesn't close the dialogue and lose the caret before I
      can see if it was in there to start with...
      
      256 colour hotlist sprites taken back to standard 16 colour versions,
      since there's a significant speed penalty on slower machines. The
      testbed browser still has the 256 colour versions so the designs aren't
      completely lost.
      
      Changed access settings to exported builds to wr/r - lr/r was really getting
      on my nerves whenever I wanted to try something temporary out.
      
      View source, save source and print handlers would all try to work if
      there was no source to act on - despite the fact that toolbar buttons
      would be greyed out form them. This is fixed.
      
      The Navigate menu has components greyed to match the toolbar state,
      when opened. It isn't kept up to date dynamically, though this shouldn't
      really be a problem (reopen the submenu...). As part of this, finally
      sorted out conditions for the Stop button to be greyed, or the
      GoTo/Go/Stop tristate to be at 'Stop' versus 'GoTo'.
      
      Deferred reformatting is now disabled for external image fetches.
      
      Browser-local client pull flag removed; hitting the Stop button simply
      cancels any null handlers working for it. That way, client pull switches
      back on in passing at the next fetch (it was never really switched off).
      So to stop client pull, hit the stop button at any point.
      
      Done CELLPADDING attribute; cellpadding field in reformat_cell (Global.h)
      is redundant since the table token is accessible from there, and so it has
      been removed. CELLSPACING support also added.
      20f5e4ab
  10. 17 Oct, 1997 3 commits
  11. 16 Oct, 1997 3 commits
    • David Brown's avatar
      Altered new directory handler to create new directories at the end of the list... · b8e8bb1f
      David Brown authored
      Altered new directory handler to create new directories at the end of the list if the pointer was past the end of the list of items.
      b8e8bb1f
    • Andrew Hodgkinson's avatar
      Now handles PARAM tags. Sorted out Plug-In bug that was related to Java... · 2093c108
      Andrew Hodgkinson authored
      Now handles PARAM tags. Sorted out Plug-In bug that was related to Java setting a 0 by 0 graphics window before calling Wimp_Poll (fixed in Java).
      
      Implemented queue for Plug-Ins so multiple broadcasts aren't sent for
      several Objects in one data chunk.
      
      Added Docs directory with some documentation in it. More things to keep
      checking for stylistic consistency, horray ;-)
      
      Corrected !Run[D] for Ursula build to need AcornURI but not TaskModule
      (URI handler needed for !Mail to pick up mailto: links).
      
      Added display_height field to browser_data, analogous to display_width,
      to cope with % sized objects by width and height (see how HRs are
      handled in Redraw.c for an example of how it was always fairly easy
      with width, but not height until this addition). Though you do have
      to reload to get a new size; reformat isn't enough. Must see to this
      some time...
      
      Fixed bug where basic typefaces were claimed *before* the Choices file
      had been read. For unusual Choices settings, this could create some
      'interesting' problems now and again. This was part of narrower scope
      work in the Choices code to allow font changing without leaking font
      handles (now done; fm_shutdown only ditches fonts, it keeps internal
      structures - must then call  fm_lose_fonts for all browsers to get the
      bitfields up to date, then rewrite the typeface definitions and reclaim
      basic fonts). Noticed that fm_claim_basic_typefaces would claim multiple
      instances of the same font if there were several cases of the same font
      mapped to different typeface styles - fixed.
      
      Implemented PlugInControl settings, but not SupportObject (fully).
      2093c108
    • Kevin Bracey's avatar
      Places where ModeChange should be called in image_fill_background marked, but... · 780e09dc
      Kevin Bracey authored
      Places where ModeChange should be called in image_fill_background marked, but commented out (because of problems with flex moving when redirected to a sprite).
      
      A few more tags added to Trace.
      780e09dc
  12. 15 Oct, 1997 1 commit
  13. 13 Oct, 1997 4 commits
  14. 10 Oct, 1997 1 commit
  15. 09 Oct, 1997 2 commits
    • Andrew Hodgkinson's avatar
    • Andrew Hodgkinson's avatar
      !Run[D] files updated for new fetchers and GopherFetcher; protocols list in... · 91cb9e09
      Andrew Hodgkinson authored
      !Run[D] files updated for new fetchers and GopherFetcher; protocols list in Controls updated for Gopher. Debug builds now require 2760K rather than 2560K. Font$... variables set if not already, in anticipation of font
      
      Choices work.
      
      Additional bits in Choices section of Res file tidied and some name
      changes (e.g. Netscape -> Navigator(TM)). Frames support option added
      to Choices.
      
      Grouped 'support_frames' under the Fetch Controls section and added
      support_object in Global.h; appropriate entries placed in the Choices
      files, and are read at startup. At present, though, only the frames
      support flag is implemented.
      
      For some reason, Menu was the button to use on history popups if you
      wanted to show URLs instead of descriptions (or vice versa, depending
      on Choices settings). Now, Select and Menu will show the Choices
      defined setting, and Adjust will show the opposite.
      
      History menus are built backwards, so local histories have the most
      recently visited pages at the top. Global history has still no real
      order to it, but this may be arranged later.
      
      Customer name changed to Customer by request.
      
      Customer browser now gets its own resources (SYSTEM=Customer), but
      otherwise is unchanged, with the Ursula build now giving the
      'spinning acorn' with a Bookworm-style toolbar. This is used for the
      Desktop !Browse build.
      
      !Sprites[22] files updated to include GIF, JPEG and PNG sprites;
      !Run[D] files and !Boot files set appropriate File$Type_xxx variables.
      Sprites in all sprites files have been checked for unnecessary palettes,
      which have been removed where present.
      91cb9e09
  16. 08 Oct, 1997 3 commits
  17. 07 Oct, 1997 7 commits
  18. 06 Oct, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Calling HtmlEndParse at the end of html_get_next_token and setting up->context... · 2e86b9d4
      Andrew Hodgkinson authored
      Calling HtmlEndParse at the end of html_get_next_token and setting up->context to NULL was wrong; fetch_fetcher would end up recalling html_get_next_token later which would then call HtmlParse even though the document parse had just finished! The HtmlEndParse call has now been moved to fetch_stop.
      
      Altered reformatter to claim fonts inside a browser, rather than
      claiming them for nothing and losing them afterwards.
      
      Got rid of TAG == TABLE and ISBODY tests, replacing with tagno == TAG_TABLE.
      Removed all references to TD, TH, TR and TABLE in the style word.
      2e86b9d4