1. 21 Nov, 1997 1 commit
    • Andrew Hodgkinson's avatar
      All hotlist_find_match calls wrapped in '#ifndef REMOTE_HOTLIST' compile time... · 559ba764
      Andrew Hodgkinson authored
      All hotlist_find_match calls wrapped in '#ifndef REMOTE_HOTLIST' compile time option, for Customer builds.
      
      Cross referencing of images when the background colour is different - should
      not do it for backgrounds, for e.g. alpha transparent PNGs would then fail.
      This was implemented, but it turns out it affects *all* cross referencing!
      Fixed for just background images.
      
      As described in Docs.TagNames, the tag name "ahodgkin_127beta2" associated
      with this checkin applies to everything *except* Choices.c. v1.27 beta 2
      was build with the Choices file tagged "ahodgkin_127beta". The confusion
      arises because Choices.c got independently updated and checked back in
      before I checked in the v1.27 beta 2 changes myself.
      559ba764
  2. 19 Nov, 1997 1 commit
    • Andrew Hodgkinson's avatar
      This is an intermediate check-in to allow work on Choices for the new table... · 7caf92e2
      Andrew Hodgkinson authored
      This is an intermediate check-in to allow work on Choices for the new table options and History choices as detailed below. Res files are not up to date except where indicated and there are several known bugs that will be fixed before the 'final' v1.27 is created. Any work on resources should only be done for the testbed !Browse.
      
      Client side image maps implemented. There is code to draw highlighted
      borders in CSIM.c, but this is not wired in yet; other than that,
      the implementation is functionally complete. As part of this, centralised
      the fetching of a targetted URL taking into account user request of a
      new view and full screen mode, in fetchpage_fetch_targetted. The forms
      library now uses this too, so form buttons respond to both adjust-clicks
      and TARGET attributes.
      
      Fixed APPLET handling where '.class' isn't present in the CODE attribute.
      
      Paragraphs squashed at the top of cells/pages - browser would insert white
      space before.
      
      Now append a ' ' to the end of History menu items to prevent the Wimp
      thinking the end of entries represents a keyboard shortcut (e.g. 'Home').
      
      Netscape's handling of 'meta http-equiv="refresh"' is to start counting
      when the fetch has completed and everything else has died down. The browser
      will now not start counting until the animation handler is deregistered
      (so formatting is complete) to show similar behaviour (note that this
      checks the main handler, not the 'idle but returning to first frame'
      drift handler).
      
      URLs from requests for fetches by Plug-Ins are now relativised.
      
      Page width change tolerance prior to reformat upped from 16 to 32 OS
      units. Hoping to provoke a loosely connected bug with this change!
      
      TableOuter, TableInner and SeeFetches choices added to all Choices
      files, with appropriate loading and saving code in Main.c and Save.c.
      AuthorFTP and AuthorFSh messages added for FTP authentication, and
      dialogue handling code (the component in FetchHTML.c) updated to
      recognise an FTP fetch and alter the dialogue presentation
      appropriately.
      
      All Messages file version numbers taken up to 1.27 (20 Nov 1997).
      
      Following a UseNet suggestion, Ctrl+Toggle Size will increase the window
      size to fill the screen vertically only; horizontal size/positioning is
      not changed.
      
      Shift+Tab in the URL writable will cycle through alternative fetcher
      protocols (from both the Controls file and checking the fetcher modules
      are actually present).
      
      Hotlist doesn't require '://' in URLs when loading HTML, just ':/' - so
      'file:/' URLs now will be reloaded correctly.
      
      History system rewritten completely. GHistSize and VHistSize options
      removed, and replaced by MaxSize and ExpiryAge. Now have global history
      menus with most recently visited items at the top, and local history
      menus which reflect the path that forward/back buttons would take.
      Browsers are robust to background expiry of the History though this is
      not implemented - date expiry and size checks are carried out on
      history_record only. This does mean that with two windows open one could
      have the history expired underneath it whilst another fetched, though;
      the code handles this and update toolbars (greying items) as necessary.
      It is possible to have the history limits so tight that even one entry
      will not fit and again the code copes with this, though values read
      from Choices are limit checked to ensure rather more useful results!
      
      Implemented 'Save' button in save dialogues. Remembers pathnames and just
      replaces the leaf now (hard coded exceptions for <Wimp$Scrap>... and
      <Wimp$ScrapDir>...) - it did before, but only if you'd typed the path
      in. Not many people did, given that you couldn't press Return or click on
      a Save button to use that path...
      
      In a similar vein, files of type Data or DOS will be checked for a '/xxx'
      type extension and the MimeMap module will be used to find a more meaningful
      filetype. If this can be handled, the file is loaded. This only works for
      files dragged to the browser - the behaviour with inline data in web pages
      will depend on the File module, and similarly, if File doesn't spot what is
      going on and claims that the object is data, the browser will just open a
      save dialogue for it.
      
      !RunD files taken up to 3072K WimpSlot.
      
      Hotlist's saved HTML page title wasn't internationalised - is now. This
      opened up a significant can of worms; on file write error, the file would
      never be closed, and if a caller of the save or load functions passed
      in a filename held in the global Messages lookup buffer then subsequent
      lookups in the callees would corrupt that filename. All sorted out now.
      
      Local (not very useful) or global (useful) histories can be saved as HTML,
      which opens up the possibility of sending your history to the hotlist
      by saving to it. Local and global histories can also be emptied, though
      this is probably not a feature that current release Desktop browsers need.
      Inheritance of local history and certain UI features is now done more or
      less for all cases where one browser window spawns another, too.
      
      Vertical alignment on images is rather less ropey than it was (e.g.
      ALIGN=TOP stands half a chance of working) but is still far from perfect.
      This was part of fixing a nasty little bug in Redraw.c's setting of
      an image position via. image_set_token_image_position, which was making
      (amongst possibly many other things) client side image maps fail.
      Image update where images had large borders was affected by a similar
      problem too (more cans with more worms...).
      
      Fixed image background filler functions; two problems. When cross
      referenced images were replaced by base images in a browser because the
      original owner was closing down, the original owner browser would stay
      registered with ImageLib. Fixed; secondly, when images were deleted from
      the image array causing those above to be renumbered, images registered
      with ImageLib did not have their numbers updated (this was the one that
      lead to the visible drop out of background images with PNGs on the Acorn
      Internet home page when there were two views of the page and the first
      was closed). This is now also sorted out.
      7caf92e2
  3. 30 Oct, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Removed 'The Onion' link from some Hotlist files. Time showed that the site... · 62293187
      Andrew Hodgkinson authored
      Removed 'The Onion' link from some Hotlist files. Time showed that the site wasn't entirely Family Friendly (TM)... Removed Shift Control (it's gone offline now), and corrected the Telegraph URL from ...the-telegraph...
      
      to just ...telegraph...
      
      StrongHelp manual generator now tries to work out the number of lines in
      the table on the root page more intelligently.
      
      Plug-in support extended to handle Shockwave. Quite a lot of underlying
      work for this, including a pseudo cache system for temporary files.
      
      Bug in redraw routines: they plotted background images within table
      cells, when nothing should have been drawn. Oops. When background images
      in cells are properly supported, this can get sorted out.
      
      Tweaked vertical plot position of HRs (up to 4 OS units too high before due
      to rounding).
      
      Various Res file bits and pieces, Ursula build taken up to v1.26 beta
      for release on the Browser site. *Note* not all resources are up to date!
      This will be done after AW97.
      62293187
  4. 27 Oct, 1997 1 commit
  5. 22 Oct, 1997 1 commit
    • Andrew Hodgkinson's avatar
      fetch_get_raw_data will notice if up->fetching is zero and return a 'finished'... · 3a920561
      Andrew Hodgkinson authored
      fetch_get_raw_data will notice if up->fetching is zero and return a 'finished' status rather than trying to continue reading data for the fetch. Fetches should never fall through that far but at least it will cope if they do.
      
      3D table borders are now supported. 2D borders are used if the
      inter-cell spacing is too small to fit the borders in (display resolution
      dependent) - the external table border is 2D if the internal borders are,
      else 3D. For cellspacing of 0, internal table borders must plot over the
      outer edge of pixels inside the cell; for all greater spacings, the
      borders take up all or part of the gap between them. The external border
      will always fit around the outside of the cells, including the
      cellspacing value in the gap between the outer cells and the border.
      
      Anti-alias colour for placeholder ALT text was incorrect. Fixed.
      
      I'd changed 'point' to 'points' in some of the Font Choices dialogues;
      now changed back to 'point'.
      
      The routine to find out how large an otherwise unsized object or image
      placeholder based on its ALT text has been centralised in Reformat.c,
      so that the image and object routines can both access it without
      code duplication (this means non-image objects will now have the correct
      size if they contain ALT text, rather than assuming a standard default
      size as before). ALT text in images that were also objects was never
      plotted either, though the placeholder size would have been correct.
      This has been fixed.
      3a920561
  6. 20 Oct, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Weird - the line registering the ENavigateToBeShown event disappeared from · 211492c2
      Andrew Hodgkinson authored
      Main.c, so the last log was incorrect; Navigate menu items wouldn't have
      been greyed out. Probably a(nother?) CVS update screw up on my part; now
      fixed. This sort of thing is happening far too often...
      
      Font manager would crash in system font or if a font face was not found
      in the previous release - that hacky business of returning weird font
      handles when system font is to be used instead ensured a rather less than
      valid array reference on behalf of fm_claim_basic_typefaces.
      
      Added in a few more calls to the 'check the button bar' routines, to
      ensure that things like Stop are greyed/ungreyed when needed.
      
      Cellpadding code could lead to rmarg overlapping lmarg, or the sum
      being greater than dwidth, or something like that (!) in the reformatter.
      Anyway the results were unpleasant; this has been sorted out by range
      checking right and left margins w.r.t. display width in the relevant
      section of the code.
      
      People who specify 'td width = 2000' in tables expecting to get something
      sensible now do, though I was half inclined to leave it alone... I can
      only assume that they don't know about % specification or it didn't
      work in their browser at authorship time, and the huge width served as
      an attempt to get the table to fill the available window width. Anyway,
      the table reformatter spots when the maximum width a cell requires is
      less than half of what it asks for, and ignores the width specifier if
      this is the case.
      211492c2
  7. 16 Oct, 1997 2 commits
    • Andrew Hodgkinson's avatar
      Now handles PARAM tags. Sorted out Plug-In bug that was related to Java... · 2093c108
      Andrew Hodgkinson authored
      Now handles PARAM tags. Sorted out Plug-In bug that was related to Java setting a 0 by 0 graphics window before calling Wimp_Poll (fixed in Java).
      
      Implemented queue for Plug-Ins so multiple broadcasts aren't sent for
      several Objects in one data chunk.
      
      Added Docs directory with some documentation in it. More things to keep
      checking for stylistic consistency, horray ;-)
      
      Corrected !Run[D] for Ursula build to need AcornURI but not TaskModule
      (URI handler needed for !Mail to pick up mailto: links).
      
      Added display_height field to browser_data, analogous to display_width,
      to cope with % sized objects by width and height (see how HRs are
      handled in Redraw.c for an example of how it was always fairly easy
      with width, but not height until this addition). Though you do have
      to reload to get a new size; reformat isn't enough. Must see to this
      some time...
      
      Fixed bug where basic typefaces were claimed *before* the Choices file
      had been read. For unusual Choices settings, this could create some
      'interesting' problems now and again. This was part of narrower scope
      work in the Choices code to allow font changing without leaking font
      handles (now done; fm_shutdown only ditches fonts, it keeps internal
      structures - must then call  fm_lose_fonts for all browsers to get the
      bitfields up to date, then rewrite the typeface definitions and reclaim
      basic fonts). Noticed that fm_claim_basic_typefaces would claim multiple
      instances of the same font if there were several cases of the same font
      mapped to different typeface styles - fixed.
      
      Implemented PlugInControl settings, but not SupportObject (fully).
      2093c108
    • Kevin Bracey's avatar
      Places where ModeChange should be called in image_fill_background marked, but... · 780e09dc
      Kevin Bracey authored
      Places where ModeChange should be called in image_fill_background marked, but commented out (because of problems with flex moving when redirected to a sprite).
      
      A few more tags added to Trace.
      780e09dc
  8. 13 Oct, 1997 1 commit
    • Andrew Hodgkinson's avatar
      More reformatter code bugs fixed; this one regarding width of items. Any... · 0cdc76df
      Andrew Hodgkinson authored
      More reformatter code bugs fixed; this one regarding width of items. Any kerned string was overestimated (causing redraw bugs and caret position problems in forms, apart from other minor bits elsewhere) and the default size of a writable icon wasn't especially clever.
      
      Crude Plug-In support; just about manages Java, but can't fetch on
      behalf of Plug-In (for example). Had to change the default file access
      URL construction to be 'file:/' instead of 'file://', or local file
      fetches that reference Java applets won't work. This is in its very
      early stages, and is being checked in mostly so that various Choices
      issues can be worked on.
      0cdc76df
  9. 10 Oct, 1997 1 commit
  10. 07 Oct, 1997 1 commit
  11. 26 Sep, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Added support for HTMLLib HttpEndParse call. · 8c9a9091
      Andrew Hodgkinson authored
      Text items with no VALUE specified in the HTML were not cleared on
      hitting a Reset button as the text field of the token is NULL; fixed.
      SELECT lists with no default selection item were not being changed
      on hitting a Reset button; fixed. In radio groups with no default
      selection specified, no item will be selected. This goes against
      the HTML 2 spec but allows broken Navigator-esque forms behaviour.
      In consequence, radios can be deselected by clicking on the same
      one twice. I'd fixed the flickering experienced when doing this
      recently, but that, now, is irrelevant, since the state of a radio
      must always change.
      
      Reformatter's new 'find width of a SELECT field' didn't account for
      the width of <none> and <many> items, and now does (particularly
      important for broken items with no OPTION contents).
      
      Under certain circumstances, illegally named targets would open in the
      ancestor rather than a new window - a deliberate decision in the code,
      but now reversed due to a test suite failure; they'll open in a new
      window instead.
      
      Altered the left hand indent handling for lists so that headings and
      body text follow the Navigator 48 pixel indent and the bullet point
      items drop to the left of the left hand margin, rather than sitting
      on the margin with the text indented to the right.
      
      Tightened up the hotlist_load_directory checking of URLs, so that
      only those with '://' in - i.e. look fully specified - are accepted.
      HTML files are loaded into a new directory now.
      
      Items without a descriptive title in hotlist_new_url will have the URL
      substituted in instead. White space before and after descriptions and
      after URLs is stripped. Directories with zero length names or null
      strings (after white space is stripped) will still be created, with a
      generic name (see Messages, token 'HotlistUntitled').
      8c9a9091
  12. 24 Sep, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Tidied up Hotlist source a bit more, mostly so PSI can use the automatic · 26e079aa
      Andrew Hodgkinson authored
      StrongHelp generator on it. Revealed a spurious toolbox_hide_object call
      that would always fault and never do anything, and a few heinous uses
      of show_error which have all been removed.
      
      When dragging hotlist items, directories will now be highlighted whenever
      the item would be added to them, rather than just over the sprite. In
      practice this only changes if the item is open and has contents...
      
      Drag box selections had broken in the hotlist; fixed (uninitialised
      variable in hotlist_select_box). Adjust-drags now close the window on
      completion. Minor problem with Shift+Drag (copy) reversing order of items
      sorted out. Added hotlist_add_html_file and implemented loading of HTML.
      DO NOT add broken HTML files, this has not been coded for and URLs of the
      form http:///this/that (no host name) will hang the machine (bug in the
      cookie code of the HTTP module up to at least version 0.39).
      
      Made SELECT list items only as wide as the widest entry actually appears
      (using fm_get_string_width), rather than as wide as the widest character
      BBox in the font multiplied by the string length of the longest entry.
      
      Updated !Run[D] files to require HTTP 0.39, FTP 0.12 and File 0.23.
      26e079aa
  13. 22 Sep, 1997 2 commits
    • Andrew Hodgkinson's avatar
      Choices and Controls files are now loaded into malloc space (use chf and cof... · 32e27d71
      Andrew Hodgkinson authored
      Choices and Controls files are now loaded into malloc space (use chf and cof to address them). Previously only in Main.c, task_dir is now globally visible.
      
      Choices updated to allow 16ths of a point in the font size specification
      and the System font face has been removed - it isn't used. The use of
      serif and sans serif fonts has been rationalised across builds (e.g. Desktop
      builds use what they say, but the Customer build uses Homerton as the
      default body (serif, so to speak) font as it matches the box's look and
      feel better).
      
      Font loading altered a bit to work properly! Font library defines some
      standard startup fonts without using Choices, which Choices can then
      override.
      32e27d71
    • Andrew Hodgkinson's avatar
      Now working on source merged with Kevin Bracey's internationalisation support.... · f61afadd
      Andrew Hodgkinson authored
      Now working on source merged with Kevin Bracey's internationalisation support. UNIFONT is undefined in the Make File for now. All Res and
      
      Choices files updated appropriately.
      
      Having sorted out the old Choices and Messages to form Choices, Controls
      and Messages, this build has had the same cleaning up done internally.
      This includes greater consistency in naming schemes and the removal of
      the inconsitent choices items - e.g. Choices file entries saying 'delay
      images' and 'plain backgrounds' where internally all the flags say 'show
      images' and 'show backgrounds'. ChoiceDefs.h and CtrlDefs.h added to
      clarify the meaning of some fields, though usage of these is not 100%
      in the source (there are cases where parameters are passed through to
      functions as ints, and those functions still check these against hard
      coded values rather than the #define stuff).
      
      Fetcher status return bits (connected, sent request, etc.) now reflected
      in status bar. Progress during fetchs to files are reported by %, where
      the size of the object is known. Exceeding 100% drops back to a byte
      counter, in case the estimated size was wrong. The progress counter
      may be updated after specific delays, rather than 'as often as possible',
      to reduce flicker (as requested by D.Brown some time ago).
      
      I've done a small rewrite of the fetch prioritisation scheme in FetchPage.c;
      how well this performs in general use across different processor speeds
      remains to be tested, but certainly it has some advantages. For each small
      fetch window before the rewrite, a 4cs tight loop was entered - this gave a
      noticable and substantial drain to the Desktop performance if more than one
      was opened. Now, several can be up at once with little hit. The actual file
      fetch is on half the priority it was before, with all others taken back
      just a bit - e.g. from 20cs per poll to 15cs per poll for flat out
      reformatting. You don't seem to lose much time on the format in practice,
      and the Desktop feels quite a bit lighter at the same time. There's the
      potential for smoother frameset loading in this scheme, too.
      
      When Shift+Clicking on a link meant you still fetched inside the main
      browser window, several fetches could occur in a frameset - one per frame.
      However, now that you can only do this by clicking on a link that leads to
      non-displayable data - or by turning off the small fetch windows by
      setting UseSmall to 'no' in Choices - a bug where fetchpage_preprocessed
      would stop such fetches as new ones were started was revealed.
      The API to frames_abort_fetching has now been extended to include a
      'stop file spooling too' flag, allowing a fix to be made by having
      fetchpage_preprocess's calls not set this (and it doesn't check the
      savelink flag is unset before proceeding, since frames_abort_fetching
      does that implicitly now).
      
      Had left the RAM transfer buffer at 16 bytes (from testing) accidentally...
      Oops. Upped it to 4K. In addition, when loading data by RAM transfer,
      the browser didn't notice if a RAMFetch bounced during the transfer. It
      would be treated as a 'first' RAMFetch bounce, basically, and try to go to
      file transfer - oops. Fixed.
      f61afadd
  14. 18 Sep, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Support for ANT URL broadcast message added. · 5a494095
      Andrew Hodgkinson authored
      Image deletion routines rewritten; nasty animated GIF bug now gone
      (it kept trying to update the cross-referenced image in the browser that
      no longer existed, and I've no idea how animated GIFs ever managed to *not*
      blow up if a cross referencing browser was shut down; and I've tested
      this...). There are now as many image structures as there are total images
      in the visible browsers, and no more; cross referenced images in the
      to-be-deleted browser have their ownership moved to the cross
      referencer before the cross referencee is wiped, with any required fetches
      being transferred with them.
      
      Reformatter sped up a bit by getting rid of strlen on the main text field
      of tokens in all places bar one, where it is called extremely rarely. This
      means direct app-to-app transfer of, say, a 359K text file to the browser
      won't run like a drain as it tries to do strlen on a 359K string over and
      over again! Most of the time the performance benefits won't really be
      noticable, ...
      5a494095
  15. 12 Sep, 1997 1 commit
    • Andrew Hodgkinson's avatar
      As warned in the last log, pretty much all event codes and component IDs have... · e6b771f8
      Andrew Hodgkinson authored
      As warned in the last log, pretty much all event codes and component IDs have now changed along with many of the names, to provide a consistent name and numberspace for events and components. This also minimises number clashes (e.g. as was, the Save File origin when opened from a
      
      Hotlist menu with an already-used component ID). To get full details on
      this, please carefully read through TBEvents.h.
      
      Res files, Sprites files and Messages files have been updated again both
      due to the above, and routine additions (e.g. message support for a few
      Hotlist bits and pieces). !Run[D] files updated for FTP 0.11 and
      HTTP 0.36.
      
      In the Makefile, the Customer objects list was missing Save - must have
      moved something when I should've copied it, when adding in SaveFile or
      SaveObject in all probability. Now fixed. Couple of other bits and bobs
      fixed in the build environment (e.g. stuff saying !Argo instead of
      !Customer). Oh, and I've altered the MakeFile copy options again to the
      best compromise I can come up with. Newer is turned on for everything
      except !Run[D] and !RunImage, since both of those change between debug
      builds - otherwise if you'd built debug and non-debug versions, it was
      not possible to switch between them - one version would have the newer
      timestamp and thus never get overwritten.
      
      The default hotlist has had a few items added - that'll be about the end
      of it, I think; there's more than enough stuff in there now.
      
      Saving of the hotlist from the document menu and of URI files,
      directories and selections from the hotlist menu tree is now implemented
      - this new save system rocks... Oh, and you can save all images and
      backgrounds as sprites.
      
      Saving of items with Shift+Click to other applications directly now
      works, and is robust. Unique Scrap filenames are used, with data load
      bounces (e.g. if some pra - er, person quits the app they're sending
      to) working correctly - that is, give an error, keep the file, rename
      it to something safe, and open the directory it lies in. As opposed
      to normal app-to-app bounces, where the scrap file is deleted (see
      PRM 3-254). This means you can now look at README files in FTP
      sites, say, without using a disc intermediate. Or you can send pictures
      straight to ChangeFSI, fetch HTML links into editors, and so-on, and
      so-on - it's all very funky. Known problems include the ambiguous
      'invalid component ID' instead of 'file open' for *normal* (straight to
      disc) shift+click saves, and I think I'll introduce a unique name
      guarantee of some sort to stop 'file open' in the first place. Odd
      that the really tricky part (app-to-app) should be least likely to
      suffer from this!
      e6b771f8
  16. 09 Sep, 1997 1 commit
    • Andrew Hodgkinson's avatar
      First a minor warning - the various Res files are out of sync in this build. · 7656a1b3
      Andrew Hodgkinson authored
      Only the Browse resources are currently valid.
      
      Added Utils.Icons - has a few archives inside containing the resources
      (well, some of them) used to build various UI sprites for various builds.
      Archived because these are unlikely to change much, and putting them on
      CVS was a move to, well, archive the stuff...
      
      SaveDBox objects vanquished and requirements in !Run[D] files removed. The
      data save code fits much more neatly in amongst the data load protocol
      stuff now (with the slight exception of having to split the SaveObject
      source into SaveObject and SaveFile - the former handles multiple persistent
      dialogues for Shift+Click on links and the like, the latter handles 'one at
      a time' transient dialogues for save source and similar). Export Link is now
      supported, too, and writes a 'proper' version URI file. You'll find that
      double-clicking on old URI files will work as the URI handler picks them up,
      whilst new version ones don't; however, dragging onto the browser will only
      work with new version files. Note that support for saving and loading URL
      files (ANT suite stuff) is present too, so old URI files can be typed as URL
      files if you want to keep them working without modification - the URI
      handler itself will hopefully support the defined URI file format soon;
      double-clicking on old URI files will stop working at that point. Note
      there are *lots* of changes in every Res file to support all this. This may
      all seem a bit pointless to some, but the changes do in fact make it very
      easy to add new save dialogues all over the place. Certainly much easier
      than with the previous system, anyway. In fact, post script, image
      'save as sprite' took about half an hour, which I hope proves the worth
      of the new system.
      
      Merged in newer hotlist code with support for drag cancelling with Escape
      (all relevant Res files appropriately updated) and cancelling scrolling
      when you've reached the window scroll limit. Had to move some of the
      Wimp message handling stuff to the central Protocols source, as clashes
      were occuring, and also the hotlist routines were using independent saving
      code - a lot of duplicated effort. This was fair enough as at the time the
      Hotlist code was written, the Save code couldn't be used in the way it is
      now.
      
      New Save Source and Print buttons on the toolbar of some builds.
      
      Phoenix Sprites file made more efficient - the Acorn base section has been
      split from the animated upper region. Browse build has a new grey fade
      sprite at the back, which is less grainy than the previous one and only
      uses 16 colours (with a 16 greyscale palette).
      
      Not really a bug, bug the routine to start an image fetch for INPUT
      TYPE=IMAGE forms items only did so if the src field (or equivalent, for
      this tag type) was non-NULL. In fact, you should always call image_new_image
      and let that handle the rest, otherwise other sections of the code will fail
      as they try to obtain an image number for a given HStream and get -1 back.
      This problem only generally manifested itself when loading an HTML file to
      the browser straight from an application, as many src fields become NULL
      when the relativisation routines find nothing to relativise to...
      
      Authentication got broken somewhere along the line - this has been fixed
      (in HTMLLib and the browser).
      
      Ctrl+Click on a cross referenced image updates *all* copies, not just the
      one with the image data attached.
      
      Next big step: Rip up TBEvents.h and rebuild that whole approach somewhat.
      To all those working on the code, my apologies but this means all Res files
      will receive a very large number of alterations and there will be extensive
      code changes too (mostly naming convention stuff), in more or less all
      source files. I am endeavouring to ensure that the new numberspace
      convention does not clash with the work being done by Kevin on
      internationalisation.
      7656a1b3
  17. 28 Aug, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Very long log entry alert - but hey, beats 'Bug fixed' (sorry, Richard) ;-) · 532155bd
      Andrew Hodgkinson authored
      Open URL implementation more or less complete, though may undergo UI
      revision at a later date to allow named frames to be targetted. Hope to use
      the ideas in this code as the foundation for other general dialogues.
      
      In token stream dump for TRACE builds, table head items were not indented
      as far as they should have been - this is fixed; and manual toolbar redraw
      routines have been removed. They never worked, were commented out, and
      would never be used in that form anyway.
      
      DragBox source added, but it isn't at all complete and won't work - this is
      an 'in spare time' thing. We need custom drag boxes constrained to windows
      for the hotlist, and unconstrained for frame border resizing... Hey ho.
      
      Ancestor window extents match visible areas if there are frames (no more
      scrolling framesets...!). Frame resizing works whilst new documents fetch
      without pulling the extent down now. However, frame horizontal extents
      never shrink until a reload which is nasty, and this is all due for a
      rewrite. Frames border redrawing routine moved out of Redraw.c and into
      Frames.c. Bug regarding the mouse rectangle and frame border widths
      (rectangle was too large, so you could squash the edges) for edge-drag
      frame resizes fixed.
      
      Window width change reformat tolerance fixed; you could creep the window
      width down or up forever without any reformat, and centred objects would
      move but not be redrawn (thereby giving rise to subsequent redraw errors).
      
      Filetype on objects saved through Shift+Click correct. Save Source dialogue
      recognises if that source is plain text, rather than assuming HTML. A
      browser that fetches a file remembers the old store size it had before the
      save, so even though the data is now ditched, it reports the same amount of
      data fetched afterwards (looked awful when this could, for example,
      suddenly say '0' after a file save). Progress indicator is now fully aware
      of one or many file saves inside a frameset and reports the number of
      saves, a colon, and the cumulative saved data count, instead of reporting
      the sum total of fetched data in all frames, including non-file save stuff
      (note that for just 1 save, '1:' is not shown as a special case for the
      most common condition). A bug related to this, where you could in fact only
      do one fetch per frame*set*, has been corrected (only one fetch allowed per
      frame still, this is unlikely to ever change).
      
      Hotlist support added (D.Brown's source), with various bits of integration
      and modification still in progress there. Note additions to the Messages
      files. On the subject of Messages, the whole mucky business about what
      goes in Messages or Choices (and a few bugs where lookup_choice was used
      instead of lookup_token or vice versa) has been sorted out. Messages
      contains, more or less, just that. Choices contains user configurable
      stuff which generally can't mess things up too badly. A new file, Controls,
      is a Messages file holding the non-user configurable choices, which can
      generally make things go badly wrong if misused. A lot of these are tied
      to the Res file. StrongED users can get these to automatically fold out
      the various sections (EMail me for details). Sorry, but at the time of
      writing, Zap doesn't do folding... =8*P
      
      Two bugs with images. Asking for images to be shown in browser B when
      browser A uses the same ones and was loaded first didn't work correctly,
      and now does (a bit weird - browser A does the fetch and browser B does the
      display...). Second one occurred when the background image was also used on
      the page as a foreground image. This has been fixed by flagging background
      images in the image_info structure, and checking this before cross
      referencing. This bit also allowed the image_restart_fetches API to be
      extended, so that just background or foreground images may be fetched if
      they weren't already and the user asked the browser to show them. Before,
      the whole lot had to be fetched together (so turning on 'display
      backgrounds' will now kick off an image fetch if required, you don't
      need to reload the page anymore).
      
      Makefile copy options tweaked to be 'newer' (so if you're testing with some
      temporary Choices file or something, it won't write over it at the end of
      every export), and REMOTE_HOTLIST flag added for Customer builds - means
      the Hotlist.c functions aren't needed; the old, hotlist-by-file method is
      used. Added support for Customer build (see later), though there were very
      few additions needed in practice.
      
      Table printing fixed - in many ways it wasn't broken, it was image printing
      causing the oddities ever since the global image pool was introduced (this
      is, again, fixed). The 'reformat to fit page' option didn't work as coded
      any more; tables store cell addresses in the HStreams, so you can't then do
      a background reformat in a different browser. Hence, it now has to reformat
      to the page width, print, then put the page back again, all in the actual
      displayed browser. This doesn't feel as slow in use as it perhaps should,
      considering what is going on... Note that a line of a defined fraction (see
      Print.h) of page height will now split over page boundaries, so tall images
      or tall tables don't cause problems now (aside from the obvious problem of
      having the line split over a page at all!). There was a bug in the routine
      to print from a given start point until 'n' pages had been filled, in that
      it always filled 'n + 1' - now fixed. Finally, as part of the printing
      tweaks, a new dialogue exists - PrintStyle - with a similarly named source
      file added to deal with it.
      
      Global history auto save / load done, but only to the Choices file path -
      the whole browser is still strictly single user at present, with all the
      extra work for a multiuser Customer environment yet to be done. This has
      shown up a global history corruption problem which I haven't fixed yet.
      
      Rationalising TBEvents.h - things are migrating out of it, and into more
      appropriate sources (e.g. definitions relating to the Open URL dialogue are
      going into OpenURL.h, etc.). Event codes were at one stage deliberately
      diverged in numberspace from the component IDs of typical gadgets raising
      the events, to avoid anyone getting confused and thinking the IDs and event
      codes must match. However, this is in fact unlikely and it is much easier
      to remember the fewer numbers that result from tying the two together where
      possible. This has resulted in changes to event codes raised in the
      following objects of all Res files: Authorise, Find, OpenURL, and
      PrintStyle.
      
      And finally - !Run[D] files for all variants updated to require the latest
      toolbox and fetcher modules. All Res files updated for hotlists etc. and
      sprites files updated appropriately. All Messages, Choices and Controls
      files brought in sync., and an Customer build has been added (based on the
      Desktop build binary with different resources).
      
      That's all for now...
      532155bd
  18. 18 Aug, 1997 4 commits
  19. 12 Aug, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Quite a few general source changes throughout many files to sort out swapped... · b5ed816d
      Andrew Hodgkinson authored
      Quite a few general source changes throughout many files to sort out swapped toolbars. There will be more work on this shortly. svcprint.c has been modified to allow it to output to a file in PipeFS, so TML-less machines can still use the standard browser debug routines (albeit in a less than elegant fashion). Comments in that source file give more details. Plus a few more bug fixes.
      b5ed816d
  20. 05 Aug, 1997 1 commit
  21. 01 Aug, 1997 1 commit
  22. 25 Jul, 1997 1 commit
  23. 24 Jul, 1997 1 commit
  24. 18 Jul, 1997 1 commit