Commits (39)
-
Steve Revill authored
This should be considered beta-quality work-in-progress code that gives us a new *command (ReadEDID) that attempts to read the list of supported display mode information from a connected monitory and configure the system for it, as if an MDF file had been loaded containing that information. Admin: Community testing is required for this feature. Please try replacing the LoadModeFile line in your !Boot.Choices.Boot.PreDesk.Configure.Monitor file with a line saying "ReadEDID". If you get a sensible looking list of modes when the machine boots, then things should be OK. If you see an error, please get in touch with ROOL on the "Bounties - ReadEDID" topic. You'll clearly need to be running a ROM with this version of ScreenModes in it! Version 0.39. Tagged as 'ScrModes-0_39'
d893357d -
John Ballance authored
Detail: For field support it is extremely helpful to determine what a customer's monitor reports. Whilst (hopefully) this module will correctly produce modes the monitor can handle and the computer generate, when that doesn't happen support types need to be able to find out why, ideally using the same exact information that is generated. So: The ReadEDID command, if called with a full file name, will now save the discovered mdf information to that file instead of loading it. The resultant mdf can be used directly, or used as the basis for further modifications. It exports additional information in the header section which may prove helpful to 'mdf tweakers'. Admin: Tested in imx rom. In 'advertised' use it is the same code as before. It is only when the filename is given to the readedid command that different paths are invoked. Further enhancements may be desirable. Version 0.40. Tagged as 'ScrModes-0_40'
f2073d25 -
John Ballance authored
Detail: Added several things 1) Readedid routine not called in module initialise. 2) Flag added to determine whether old loadmodefile usage, or new readedid usage. Defaults to loadmodefile mode until a readedid command with no parameters, then swirches to edid reading mode. Reverts again if loadmodefile command is used. 3) Tidied up error message when graphicsv fails to read the edid due to connectivity issues. 4) Added hex dump of edid data blocks read to end of a saved mdf file. 5) Implemented read of second ans subsequent 128 byte edid blocks, if required. Admin: tested in imx rom Version 0.41. Tagged as 'ScrModes-0_41'
36800dfd -
John Ballance authored
Detail: Admin: Version 0.42. Tagged as 'ScrModes-0_42'
f828611b -
Jeffrey Lee authored
Detail: c/ScrModes: - Double-checked all the DMT timings against the spec and corrected a few mistakes in both the DMT timings list and the established timings list. - Tidied up DMT & established timing formatting a bit, made static data arrays const - Fixed preferred mode handling so that it'll forget the preferred mode if you load an MDF after reading EDID (preferred_mode->bit0 used as a cheeky flag, in preference over malloc/free). Fixes crash/bad behaviour on startup caused by returning a duff preferred mode from Service_MonitorLeadTranslation on startup. - Added sanity checks to avoid null pointer dereferences if preferred_mode or new_preferred_mode are null - Fixed preferred mode handling to work correctly with interlaced modes (fixed it to use the frame width & height instead of the field width & height) - Tweaked CVT extension block handling - swapped the "- 17" with "- 18" in order to take into account the presence of the checksum byte - Tweaked GTF calculation to round pixel_khz to nearest when calculating it. I don't think this is mentioned in the spec, but when comparing some timings against the GTF spreadsheet this fixes ScreenModes being off by 1kHz in a few cases - When outputing an MDF, don't output display range parameters if the block wasn't found - Fix MDF output of interlaced modes (frame width/height vs. field width/height), use more accurate mHz frame rate value instead of Hz one - Make GraphicsV_IICOp calls use the correct GraphicsV driver number; current_graphicsv_driver() function added to replace ad-hoc code in a couple of other places - Fix reading of extension blocks. Also tweak logic to avoid re-reading the first block. - Initialise 'thefilename' when calling parseedid so that ERR_NOMODES will display something vaguely sensible Admin: Tested on Raspberry Pi (ROM), Pandaboard (ROM), Iyonix (softload) Appears to read EDID correctly from test monitors (BenQ FP737s, BenQ FP241W, ADI TD-523N), but there are some minor discrepancies in MDF output for some modes Version 0.43. Tagged as 'ScrModes-0_43'
d29ddabe -
Jeffrey Lee authored
Detail: c/ScrModes - Make sure compute_modedescription is used to initialise frame_mhz (and line_hz). Fixes bogus vertical bounds in MDF comments, and will fix order of modes as defined by sorting function modes_inorder. Also change horizontal bounds comment to use stored line_hz value instead of computing it on the fly Admin: Tested on Pandaboard Version 0.44. Tagged as 'ScrModes-0_44'
97cb9b7c -
John Ballance authored
Added 'CreateModeFile' instead of optional file name on ReadEDID now needs a file path for where to save the created mdf. It'll use the name in the EDID for the file name Admin: tested in iMx6 Version 0.45. Tagged as 'ScrModes-0_45'
16d50f7d -
Jeffrey Lee authored
Detail: c/ScrModes - Fix a bad merge causing a compute_modedescription() call to go missing. Fix Get_DTD_ASCII to avoid reading one byte too many, and to ensure the buffer is null terminated. Also strip any control characters. Improve MDF saving to return an error if the file couldn't be created, and to substitute various unsafe characters with underscores Admin: Tested on Pandaboard Version 0.46. Tagged as 'ScrModes-0_46'
92a69868 -
Jeffrey Lee authored
Detail: c/ScrModes, h/modex - Added support for CVT 3 byte codes & VTB-EXT blocks. Add framework for sorting modes by EDID priority. Move CEA extension block handling into its own function & increase error checking. Resources/Germany/CmdHelp, Resources/UK/CmdHelp - Fix missing message token & incorrect syntax of syntax message Admin: Code submission from William Harden Tested on Raspberry Pi Version 0.47. Tagged as 'ScrModes-0_47'
ca1955a4 -
Jeffrey Lee authored
Detail: c/ScrModes - Swap 'return;' for 'return NULL;' in the (currently unused) DERIVE_CVT3_FROM_DMT code to ensure the function has a sensible return value Admin: Untested Version 0.47. Retagged as 'ScrModes-0_47'
d4ee2737 -
Jeffrey Lee authored
Detail: c/ScrModes - Reorder while loop conditions to ensure the DTD offset is checked before we try reading any data; prevents potential data abort if initial offset is too large to be valid. Admin: Builds, untested Version 0.47. Retagged as 'ScrModes-0_47'
020db416 -
Jeffrey Lee authored
Detail: c/ScrModes - Fixed decoding of DTD polarties in dtd_block_to_modedesc. Add support for some missing established timings (generated by GTF/CVT as we don't have any known-good values to use as a reference) Admin: Tested on Pandaboard Submission from William Harden Version 0.47. Not tagged
8f3400df -
Jeffrey Lee authored
Detail: c/ScrModes - Replace magic numbers used for sync polarities with HSync_Positive, VSync_Negative, etc. #defines. Fix GTF2 polarity to be correct. Fix CVT/CVT RB polarities to be correct (+ some incorrect code indentation). Make dtd_block_to_modedesc return true/false for success/failure so we can reject stereoscopic 3D modes. Admin: Tested on Pandaboard Version 0.48. Tagged as 'ScrModes-0_48'
2accbe62 -
Jeffrey Lee authored
Detail: Makefile - Export a C version of hdr/ScrModes Resources/Germany/Messages, Resources/UK/Messages, h/errors - Add new error message cmhg/ScrModesv, hdr/ScrModes - Declare existence of ScreenModes_EnumerateAudioFormats SWI. Declare ScreenModes_ReadInfo reason codes. h/modex - Extend MonitorDefinition struct to allow it to store the speaker mask & audio format information that's extracted from the EDID c/ScrModes - Extend support for processing of CEA extension blocks. All block revisions > 0 should now be accepted, and rudimentary parsing of CEA data block collections is implemented (currently, only extracts information from audio related blocks). Add SWI ScreenModes_EnumerateAudioFormats to allow details of the supported formats to be returned in either "raw" or "friendly" forms. Add ScreenModes_ReadInfo reason code 1 to allow reading of the speaker mask (+ validity bits). Also fix *LoadModeFile to allow EDID blocks to be loaded without first having to issue *ReadEDID first (EDIDEnabled flag issue). Admin: Tested on iMX6 with assorted EDID blocks German messages file in need of translation Version 0.49. Tagged as 'ScrModes-0_49'
9a30976a -
Jeffrey Lee authored
Detail: c/ScrModes: - Added established timings for 720x400 @ 70Hz to be used in place of the auto-generated timings. For a BenQ FP737s-D, these match the expected timings listed in the manual, and they actually result in a picture displaying (auto-generated timings did not). - Split the guts of generate_dmt_mode out into a separate function so it can easily be used for adding the 720x400 @ 70Hz ModeDefinition - Fix established timing handling to only call generate_dmt_mode if the DMT defines timings for a given mode (old logic meant that only 720x400 @ 70Hz was falling through to the auto-generate case) - Fix established timing auto-generation to cope with the possibility of timings_byte being non-zero Admin: Tested on iMx6 on a variety of monitors 720x400 @ 70Hz now displays correctly on a FP737s-D 640x480 @ 67Hz now works too (albeit with a warning about being a non-preset mode, this one is listed in the EDID but not in the manual) Version 0.50. Tagged as 'ScrModes-0_50'
eeb8be91 -
Jeffrey Lee authored
Detail: c/ScrModes - When removing 'candidate' from the list of audio formats, it's the number of formats which we want to decrement, not the pointer to the start of the list. Admin: Tested on iMx6 Fixes "RMA allocation failed" and other issues when dealing with monitors with complex audio capabilities Version 0.51. Tagged as 'ScrModes-0_51'
7d5fe81e -
Jeffrey Lee authored
Fix *LoadModeFile not reporting errors when parsing EDID files. Fix another "RMA allocation failed" bug with audio format processing. Detail: c/ScrModes - Fix loadedid() not returning errors from parseedid() c/ScrModes - Fix bad use of realloc() in add_audio_format() - if audio_format_count hits zero then it's expected for realloc to return NULL. Admin: Tested on iMx6 Version 0.52. Tagged as 'ScrModes-0_52'
fc351291 -
Jeffrey Lee authored
Add support for parsing CEA Short Video Descriptors (SVDs). Fix loaded EDID files being overwritten with monitor EDID during Service_DisplayChanged. Detail: h/CEAModes - Table of CEA mode timings from CEA 861-D s/ScrModes - Implement process_cea_video_data_block() in order to support SVD parsing. Ensure loadedid() sets the EDIDEnabled flag to 0, to prevent the loaded EDID (potentially) being replaced during Service_DisplayChanged. Admin: Tested on iMx6 Version 0.53. Tagged as 'ScrModes-0_53'
55179bbd -
ROOL authored
Detail: Move the 500+ lines of tables into a new source file and remove storage inferred by former CEAModes.h. Tame some of the rampant style from various authors, even within 1 function, to something reasonably consistent. Uppercase the 'debug' macro to 'IFDEBUG'. Relocate ScrModes specific defines out of EDIDModes header, rename to edidmemory.h. Add monitor type 6 to monitors.h. Fix for unguarded debug printout "Can't allocate space for monitor list" in parseedid. Admin: Tested briefly, functionality unchanged. Submission for the EDID bounty. Tagged as ScrModes-0_53-tables
8a00983b -
ROOL authored
Detail: Main source file split into 3. Admin: Tested briefly, functionality unchanged. Submission for the EDID bounty. Tagged as ScrModes-0_53-split
9936b759 -
ROOL authored
Detail: Rounding the pixel clock to 0.25MHz was not correctly performed due to clock step division being outside the floor() function, so all times came out in steps of 1MHz. In GTF timing with interlacing v_lines_rqd specifies ROUND(v_lines/2,0) rather than ROUNDDOWN(v_lines/2,0). Abandon GTF calculations early if they result in a -ve duty cycle. Update margins to 1.8% from standard. Admin: Mode with non-multiple-of-1MHz clock tested, now matches VESA CVT spreadsheet. GTF change not tested since int_rqd = 0 the code wasn't called. Margin% change not tested since margins_rqd = 0 the code wasn't called. Submission for the EDID bounty. Version 0.54. Tagged as 'ScrModes-0_54'
ea866f88 -
ROOL authored
Admin: Line up braces missed in earlier tidying. Not tagged.
b2421153 -
ROOL authored
Detail: The dynamic range of the values being computed easily fit within integer types, so use these instead of doubles. This makes ScrModes independent of its position in intialisation with respect to FPEmulator once more, and saves 1k of code space too. Functions generate_mode_using_gtf(), generate_mode_using_cvt_rb(), generate_cvt3_timing() affected. Admin: Test added to brute force compare float and fixed point results. Submission for the EDID bounty. Version 0.55. Tagged as 'ScrModes-0_55'
862ea508 -
ROOL authored
Detail: Missing break statements (around line 790) would always have selected 50Hz frame rate regardless. Removed duplicate call to add_proposed_mode() which generate_mode_using_cvt_rb() already does, resulting in duplicated modes. Admin: CVT3 still untested, but less broken than before. Submission for the EDID bounty. Tagged as ScrModes-0_55-cvt3fix.
041d7311 -
ROOL authored
Detail: In various places the free() on error was the responsibility of the called function, and sometimes the calling function. Rationalise this by returning true/false so the free() is always done at the same level as malloc(). Likewise, add_proposed_mode() is now done at the level that generates the mode. Tidy up debug so that only successfully generated and added modes get debug printed with display_mode_parameters(), not discarded ones. Admin: Submission for the EDID bounty. Tagged as ScrModes-0_55-mallocfree.
11cf5235 -
ROOL authored
Detail: Now all generation steps end in compute_modedescription()/add_proposed_mode()/display_mode_parameters(), combine these steps into the add_proposed_mode() function. Fix for CVT and GTF generation steps never setting the 'priority' member of the descriptor. These are now set to 6 per Table 5.1 of EDID spec 1.4. Admin: Submission for the EDID bounty. Version 0.56. Tagged as 'ScrModes-0_56'
faff5d05 -
ROOL authored
Detail: Save 4k of ROM space by not storing the mode name string; always generate it at run time. Split the ModeDefinition struct into the timings part (ModeDef) and full definition (ModeDefinition). Admin: Submission for the EDID bounty. Tagged as ScrModes-0_56-smalltables.
d0b58c2a -
ROOL authored
Detail: Don't ignore the monitor's power saving features for EDID; fill in the DPMS value properly. Admin: Submission for the EDID bounty. Version 0.57. Tagged as 'ScrModes-0_57'
e1d639d1 -
Jeffrey Lee authored
Detail: Some cross-checking against the RISC OS Select documentation revealed that ScreenModes_ReadInfo 1 had already been claimed by ROL for the purpose of reading the monitor's supported DMPS state, causing a clash with our recently-introduced usage of reading the monitor speaker mask. Implement ScreenModes_ReadInfo 1 as per ROL's spec, and change the "read speaker mask" call to ScreenModes_ReadInfo 2. File changes: - c/ScrModes, hdr/ScrModes - as above Admin: Tested on Raspberry Pi Version 0.58. Tagged as 'ScrModes-0_58'
41b0cd05 -
Jeffrey Lee authored
Detail: c/tables - 540 != 640 Admin: Tested on Raspberry Pi Version 0.59. Tagged as 'ScrModes-0_59'
c5af75ad -
ROOL authored
Detail: Define MAXDMTMODENUM to guard against requesting DMT timing not in our table. Assert that the table size matches the define. Lowercased some 'X' (edidsupport.c), change to _swix (mdfsupport.c). Admin: Submission for the EDID bounty. Version 0.60. Tagged as 'ScrModes-0_60'
95d1dca9 -
ROOL authored
Detail: Export the EDID raw data as a file in ResourceFS. This allows the Screen Setup plugin to scan that directory to pick up the currently connected monitor, and similarly select it from !Boot.Choices.PreDesk. The EDID data can also be drag & drop copied or exported for offline analysis. Add SaveModeFile command. This differs in that it works on the current set, to be symmetrical with LoadModeFile which loads the current set. Also fixes issues of losing the original mode names given; NULL pointer dereference when the EDID block contains no modes (eg. VIDCDriver); and no long writes out malformed MDFs which can't be loaded into !MakeModes (this seems to be because the CreateModeFile command was based on a stale copy of EDIDDecode which fixed the same bug circa 2012). Query the current GraphicsV driver for the deepest colour depth for the preferred mode, rather than assuming 32bpp is always possible (eg. because of bandwidth or graphics con...
961adc98 -
John Ballance authored
Detail: Admin: tested on iMx6 Version 0.62. Tagged as 'ScrModes-0_62'
98ccc086 -
John Ballance authored
Detail: Admin: tested on iMx6 Version 0.62. Tagged as 'ScrModes-0_62'
d2e86f90 -
John Ballance authored
Detail: ReadEDID command removed. New subreason code added to reason code 0 of Service_DisplayChanged to oblige ScrModes to load the EDID based modes it discovered. Required because current behaviour would ignore any EDID based modes once a LoadModeFile command had been issued. Admin: Tested on iMx6 Version 0.64. Tagged as 'ScrModes-0_64'
f825c04b -
Jeffrey Lee authored
Detail: VetMode2 allows the driver to give the OS extra feedback about a proposed mode. In particular, it allows the driver to suggest a value for the ExtraBytes control list item, so by using the VetMode2 call ScreenModes is able to support modes where the video driver requires extra padding to be added to the framebuffer. h/modex - Remove local definitions of control list item numbers. Reserve space for one extra control list item in the VIDCList structure. c/ScrModes - Use Global/VIDCList.h for control list item numbers. Update mode_valid to make use of VetMode2 where available, and give it the ability to copy the resulting VIDCList into a caller-supplied buffer, allowing service_modeextension to easily use the correct ExtraBytes setting. Admin: Tested on Raspberry Pi 3 Requires Kernel-5_82 Version 0.65. Tagged as 'ScrModes-0_65'
94ffeea7 -
Jeffrey Lee authored
Detail: c/ScrModes - Re-introduce the using_edid check in the Service_DsiplayChanged handler, that was removed in ScreenModes 0.64. Removing the check completely breaks automatic EDID use (via MonitorType EDID), causing the kernel to panic and treat everything as mode 0 (due to no mode definitions being available). Admin: Tested on Raspberry Pi 3 Should fix issue reported on forums (bad screen mode during boot after upgrading from RC15): https://www.riscosopen.org/forum/forums/4/topics/9342 Version 0.66. Tagged as 'ScrModes-0_66'
f695ced1 -
Jeffrey Lee authored
Detail: c/edidsupport: - Make readedid() check that the EDID has a valid header. Previously only the checksum was checked, which is wholly insufficient (e.g. an EDID block full of null bytes would be considered valid). loadedid() also updated for consistency, although with the current code the header will have already been detected by loadmodefile(). - Add some extra checks to readedidblock() to cope with more situations in which the GraphicsV call could fail. Fix confusing comment/code ordering. h/errors, Resources/Germany/Messages, Resources/UK/Messages - Add new "Invalid EDID block" error, for use when no valid header is found Admin: Tested on Raspberry Pi 3 Booting an EDID-enabled Pi without a monitor (and with the broken BCMVideo 0.47) no longer results in an (unintelligible) error box on entry to the desktop + system stuck in mode 0 However, note that other issues in the boot sequence mean that booting with EDID enabled and no monitor still isn't 100% wor...
c3128e9b -
Robert Sprowson authored
There's no need to graft in a special sub-sub-reason for Service_DisplayChanged, since ScrModes always reads the EDID at power up the data blob is already there. To force it to be used (in situations where the user had selected a disc based textual MDF) simply load it with *LoadModeFile. Version 0.68. Tagged as 'ScrModes-0_68'
60419cc7
Showing
No preview for this file type
No preview for this file type
This diff is collapsed.
c/edidsupport
0 → 100644
This diff is collapsed.
c/mdfsupport
0 → 100644
This diff is collapsed.
c/tables
0 → 100644
This diff is collapsed.
doc/BootStates
0 → 100644
doc/EDIDGoals
0 → 100644
doc/testfp
0 → 100644
This diff is collapsed.
h/edidmemory
0 → 100644
h/edidsupport
0 → 100644
h/mdfsupport
0 → 100644