GitLab

From SCSI standard MMC-2 onwards the read/write error recovery parameters page has been defined with a page length of 10, however earlier editions (and drafts) used a page length of 6.
Rather than rejecting drives built on these standards, since we only want the read retry count at offset 3, permit page 1 responses of either 10 or 6 bytes, reject < 6.

driver.c
 - change length check to 6
 - adjust comments/debug to remind the reader why
cmodule.c
 - fix bug which led to a data abort in MessageTrans, when RAM loaded and the number of CD drives is configured as 0 (or CDDriver is unplugged) and so registration fails, the messages file would be deregistered without first closing the file, leaving MessageTrans' descriptor linked list pointing at non existant messages

Tested with a Ricoh MP7040S on the Acorn SCSI podule.

Version 0.04. Tagged as 'SCSI-0_04'

Detail:
  c/driver - Disabled DAP in driver_ReadAudio() to avoid issues caused by drives which complain about it. Fixed driver_PlayTrack() to work properly when playing to the end of the track.
Admin:
  Softload tested on Iyonix
  TS-H552 still a bit dodgy, but seems to mostly be due to bugs elsewhere


Version 0.03. Tagged as 'SCSI-0_03'

Detail:
  c/cmodule - Don't allow module finalisation to fail due to errors returned by CD_Unregister. This ensures the module can still be killed if CDFSDriver has been killed.
  c/driver, h/cdfsbits - Rename SUPPORTED_AUDIOCONTROL_* #defined to be just SUPPORTED_*
  c/driver - Assorted tweaks and fixes:
    - Add DumpBlock function for printing SCSI command blocks, repsonses, etc.
    - Correct response size checks to only complain if the response is under the expected size instead of not equal to it. This should ensure the driver works OK if the response data structures grow in size in the future.
    - Correct READ TRACK INFORMATION size checks to use the MMC 1 size instead of the MMC 2 size
    - Correct read-write error recovery mode page size check in driver_SetParameters
    - Correct driver_SetParameters to not return an error for parameters which are read-only
    - Correct volume level checks in driver_SetAudioParms_VolumeLevels
Admin:
  Softload version tested on Iyonix & BB-xM.
  Driver now seems to work OK with most drives.


Version 0.02. Tagged as 'SCSI-0_02'

Detail:
  New CDFS driver module that aims to support all SCSI CD/DVD drives that conform to the MMC SCSI specification. This includes USB attached ones, assuming SCSISoftUSB is loaded.
  Known issues:
  - Only supports MODE SENSE/SELECT 10, so drives which only work with MODE SENSE/SELECT 6 won't work
  - CD speed get/set currently unsupported
  - Inactivity timer multiplier get/set not supported on some drive types
Admin:
  Tested with softload on Iyonix, ROM build on OMAP3
  Only confirmed to work with one drive model so far - expect a few tweaks to be needed to cope with non-conformant drives


Version 0.01. Tagged as 'SCSI-0_01'