GitLab

A hardwired 18 in reset_all_tiling_sprites meant that one slot was never cleared, so a change in the Wimp's sprite pool could leave a cached sprite pointer pointing to something invalid.
Ref https://www.riscosopen.org/forum/forums/5/topics/16708

Version 5.83. Tagged as 'Wimp-5_83'

During destruction of the menu tree, if set caret position fails when resetting the caret to the old position (ie. illegal window handle as the window has been deleted) then destroying the menu tree also fails with catastrophic results.
Therefore
* Do not fault SetCaretPosition to invalid window handle, just change it to -1
* Do not try to redraw areas of an invalid window when moving caret

Version 5.82. Not tagged

Save around 50KB of ROM space by converting the icon sprites to use RISC
OS 3.5 mode words instead of numbered modes, reducing the size of the
mask data to around a quarter of its old value.

Tested in IOMD ROM, with boot sequence disabled (to ensure the ROM
sprites get used).

Version 5.82. Tagged as 'Wimp-5_82'

Message_TaskInitialise was reporting that MemoryLimit was the slot size
of the application, which was resulting in the task manager showing the
wrong slot size if for some reason MemoryLimit had been artificially
reduced below ApplicationSpaceSize (e.g. due to the task being a child
of a C system() call). And because MemoryLimit is lower than
ApplicationSpaceSize, any attempt the task makes to grow/shrink its wimp
slot is denied, so task manager will be stuck showing the wrong value
for the entire lifetime of the task.

Fix Message_TaskInitialise to use ApplicationSpaceSize instead, so that
the total size of the slot is reported instead of just the usable area.

This fixes task manager incorrectly showing that Fat32Fs has a slot size
of 0 on some of my Raspberry Pis, when really it has a size of 256K.
This discrepancy was also causing the "System memory allocation" numbers
to not total up correctly (the sum was 256K lower than the displayed
total).

Allow theme designers to use a different sprite for the background tile of the iconbar, distinct from the other windows. This looks for 'tile_i' before falling back to 'tile_1' as before, in addition to the existing 'tile_m' for menus.

Version 5.81. Tagged as 'Wimp-5_81'

WimpVisualFlags gains -ButtonColour -ButtonWellColour -ButtonHighlightColour to allow a theme designer to set the button/well/pressed colours for R1-R7 slabbing to some other colour, and -ButtonBorderFaceColour -ButtonBorderOppColour -ButtonBorderShallowColour for the outlines.
The given colours are only used when there is no 'C' validation.

* If dragging text from a writable icon and the source text or selection disappears during the drag, an ofla error occurs. Change to abort quietly (ie no text copied as nothing to copy) and remove the ghost caret from view.
* Remove ghost caret on invalid dropped drags
* Either use correct insert point from ghost caret when receiving a drag, or use current mouse coords for the destination if no ghost caret present.
* Change datasave handling to check ghost caret presence for the destination rather than trying to check the enhanced datasave state.
* Use window X coord for drop rather than screen Xcoord to ensure correct insert point.

Fixes dragging multiline text areas from Draw leaving a ghost caret when it failed, and dragging a basic text object from Draw now inserts at the correct place.

Version 5.80. Tagged as 'Wimp-5_80'

Version 5.79. Tagged as 'Wimp-5_79'

Since our text selection model follows the Style Guide and there's no means to configure it to the contrary, this subreason can just return fixed values to allow applications to query the state compared with running on a non-Cut-n-Paste Wimp.

When the preferred list of types is exhausted, Clipboard Manager should at least respond with the native type (per DnD spec 5.3.1). Since only text is supported, this translates to always replying.

Version 5.78. Tagged as 'Wimp-5_78'

The name clashes with the recently added clear IRQ flag macro, CLI, but is only used in a debug case.

Version 5.77. Not tagged

Force writeable icons to have a filled background on redraw, similar to behaviour in pre-clipboard Wimp.  Prevents corrupted redraw in non-filled writeables.

Version 5.77. Tagged as 'Wimp-5_77'

When clicking in window to move caret to another icon, remove any selection from other icons in the window to prevent unwanted user deletion of text in the selected icon.

Display caret/selection even if icon type is not 14 or 15.

Version 5.76. Tagged as 'Wimp-5_76'

Detail:
  Send correct DataSaveAck message in response.

Version 5.75. Tagged as 'Wimp-5_75'

Check there is actually a selection present in the window before cutting/deleting any text.

Version 5.74. Tagged as 'Wimp-5_74'

Extended scroll requests and regular scroll requests share the same
reason code, but are different sizes. Update calcmessagesize to
calculate the size of extended scroll messages correctly, so that the
icon number won't get chopped off when the message is being passed to
the target task.

Version 5.73. Tagged as 'Wimp-5_73'

Check destination window handle and add destination icon handle if sending message to window handle -2.
Improve window handle validation (not assuming all -ve handles are invalid, should the RMA move to have top bit set).

Version 5.72. Tagged as 'Wimp-5_72'

When releasing claim, use of stale register meant that the foreground task wasn't correctly bouncing Message_Dragging when the pointer moved out of range. Also added a sanity check in get_selected_text so that if for some reason the selection window disappears mid action it will be caught and not cause a crash.

Version 5.71. Tagged as 'Wimp-5_71'

Version 5.70. Tagged as 'Wimp-5_70'

On mouse click, check for icon type was incorrect, so trying to apply tests for 'P' validation string/ptr_write on inappropriate icons (eg. sprites), leading to invalid validation string accesses. Correct the test performed.
Also add 3 further AcceptLoosePointer checks to validation string pointers.

Version 5.69. Tagged as 'Wimp-5_69'

Detail:
  Don't trap menu clicks on icons when the window isn't fully on-screen.
  Ref https://www.riscosopen.org/forum/forums/4/topics/14961?page=1
Admin:
  Submission for Clipboard Support bounty.

Version 5.68. Tagged as 'Wimp-5_68'

Detail:
  Menu windows don't store the task handle in their datablock, so an incorrect one was used as part of the data transfer sequence.
  Also, minor fix for Message_ClaimEntity when bit 2 was clear (bits 0,1 set). The response meant that, for example, Alt-click to rename, select text in writeable and press ^C - copied to clipboard, but writeable is removed.
Admin:
  Submission for Clipboard Support bounty.

Detail:
  If R0=valid window handle, R1<0 (not an icon) and R4=-1 then R4 is internally set to 'invisible caret' to ensure that we get the full input focus event and visible cues.
  Ref: https://www.riscosopen.org/forum/forums/5/topics/14945?page=2#posts-97886
Admin:
  Submission for Clipboard Support bounty.

Detail:
  Summary of how non-CnP Wimp treats the window handle for Wimp_SetCaretPosition
  R0 = valid window handle
    or invalid window handle (mapped to -1)
    or any negative number or 0 (mapped to -1)

  With this change, the CnP Wimp does
  R0 = valid window handle
    or invalid window handle (throws error)
    or any negative number or 0 if pre RISC OS 5 (mapped to -1)
    or 0 for RISC OS 5 (mapped to -1)

  Noting the use of AcceptLoosePointer macro if built for a 26 bit target.

Wimp_Extend 15 is equivalent to Wimp_SlotSize,-1,-1, with the exception
that the sizes returned in R0-R2 are now measured in pages instead of
bytes. This allows code to accurately read the amount of free memory on
machines with >2GB of RAM, and provides some future-proofing should we
ever wish to support tasks with >2GB of RAM (e.g. via a future
super-jumbo wimpslot, or more likely via sparse/PMP wimpslots, where
the physical size is larger than the logical size).

Currently there's no need to provide a page-based call to set the slot
size (~2GB is fine for the forseeable future), so this call only
focuses on reading the sizes.

Version 5.67. Tagged as 'Wimp-5_67'

Detail:
  In CnPCaret.s
    * Clear any invalid window handles currently stored in caret blocks on Wimp_SetCaretPosition entry
    * Clear R2 on exit if R0=-1,R2=TASK on entry to Wimp_SetCaretPosition
    * If window is not open or able to receive a focus, then return WimpFocus error rather than causing an alignment exception
  In CBTask.s
    A drag to writeable with invalid (eg.rejection due to validation string mismatch or overlong insert) caused ghost caret to be left behind and still deletes the source text.
    * Changed LDR R2,=cbtask_TASK to LDR r2,cbtask3_TASK
    * Ensure cbtask_insert_text_into_icon returns V set on error
    Drag and drop text from icon to non-d&d application, the last message was erroneously sent as DataSaveAck, not Dataload
Admin:
  Submission for Clipboard Support bounty.

Version 5.66. Tagged as 'Wimp-5_66'

Detail:
  The text in writable icons can now be manipulated using the familiar keyboard shortcuts, or using Drag and Drop in conjunction with any compliant applications.
  Further details are in Doc/DragAndDrop along with information on API extensions which are implemented.
Admin:
  Submission for Clipboard Support bounty.

Version 5.65. Tagged as 'Wimp-5_65'

Detail:
  3 extra tokens in support of clipboard operations.
Admin:
  Submission for Clipboard Support bounty.

This solves difficulty in handling on other operating systems,
including being an illegal filename in macOS.

Fixes https://www.riscosopen.org/tracker/tickets/473


Version 5.64. Not tagged

Admin:
  Submission for Clipboard Support bounty.

Version 5.64. Not tagged

Detail:
  Subreason 14 gives a means to read the validation string from a window/icon that is not in the current task. This is useful for determining whether clipboard operations should be allowed.
Admin:
  Submission for Clipboard Support bounty.

Version 5.64. Tagged as 'Wimp-5_64'

The pointer left/entered window logic calls int_get_pointer_info which can return a window (and/or icon) handle of -1 if the pointer is over no window, such as might occur if the window has been deleted.
The check for a duff window handle (in R3) was unfortunately made *after* it'd been dereferenced. Move this check up beforehand.

Fixes issue reported on Usenet https://groups.google.com/forum/#!topic/comp.sys.acorn.programmer/iR0_TNekiKg

Version 5.63. Tagged as 'Wimp-5_63'

Detail:
  s/Wimp10 - Update mastertoactive to force the palette/translation table to be sent through ColourTrans if either &RGB component ordering or alpha blending is in use for the current screen mode. Otherwise, for alpha modes, the alpha channel would typically be left at zero.
Admin:
  Tested on Raspberry Pi 3


Version 5.62. Tagged as 'Wimp-5_62'

Doing *WimpKillSprite _not_there_  had the following behaviour

Priority   | Sprite exists  Sprite doesn't  Sprite is ROM
Lo then Hi | Deletes        Bad error ptr   Silence
Hi then Lo | Deletes        Silence         Silence

The bad error pointer was caused by an early return if the high priority pool is the ROM sprites (because the earlier failure to find it in the low priority pools set V, and the early return used TEQ, so the error pointer in R0 was the SpriteOp reason code).
Proceed to try to look up the sprite, even if there's no hope of deleting it, in order to get a valid error message.

Version 5.61. Tagged as 'Wimp-5_61'

Fix crashes when a Wimp_Poll post-filter causes the Wimp to postpone switching to a VFP-enabled task

Detail:
  s/Wimp07 - In ExitPoll, swap around the order of restoring the FP context and calling the poll post-filter so that the FP context is restored after the post-poll filter has been invoked. Previously, the VFP(+FPA) context would be restored, then the post-poll filter would be invoked. If the post-poll filter was claimed, the Wimp would then scan the pollwords again and most likely decide to switch to a different task. The appslot will then be switched over, and ExitPoll will be invoked again, attempting to restore the VFP/FPA context for that task - potentially causing a crash or other bad things because the VFP context used by the original choice of task is no longer paged in. For FPA this was never really a problem, since the context is stored in the RMA rather than being potentially stored in appspace.
  s/Wimp03 - Add some extra debug out for tracking VFP context management
Admin:
  Tested on wandboard
  Fixes issue reported on forums, where using the numpad in VFP SciCalc would cause a crash if KeyExtend was loaded:
  https://www.riscosopen.org/forum/forums/4/topics/10293


Version 5.60. Tagged as 'Wimp-5_60'

Detail:
  s/Wimp02 - Get rid of the magic ~30 second delay before the Portable_Speed/Portable_Idle power saving kicks in. The fast/slow thresholds are self-adjusting, and any non-null poll event will kick the system into high speed, so removing the startup delay isn't likely to have any adverse affect on desktop startup time.
  s/Wimp01 - MaxIdleEvents is now redundant, remove it
Admin:
  Tested on Raspberry Pi 3
  Should resolve issue reported on the forums where RPCEmu thrashes the hosts's CPU for 30 seconds after entering the desktop:
  https://www.riscosopen.org/forum/forums/10/topics/8990


Version 5.59. Tagged as 'Wimp-5_59'