GitLab

Detail:
  s/Wimp10 - cachetoolspritedata was using two slightly different ColourTrans calls for reading the table size and then filling the table in. This was resulting in the 'generate wide table' flag sometimes being ignored when the table size was checked, resulting in too little memory being allocated and so heap corruption when the table generation call overflowed the end.
Admin:
  Tested on Pandora
  Fixes "not a heap block" errors when entering desktop


Version 5.21. Tagged as 'Wimp-5_21'

With the introduction of 16bpp/32bpp modes it became possible to request tables from ColourTrans which used > 1 byte per colour, but the Wimp wasn't using this extension. Therefore tool sprites designed in 8bpp or less would be quantised horribly when plotted in a 16bpp or 32bpp mode.
The Wimp now requests and plots with a wide table, and to avoid thrashing ColourTrans so much with the prevalence of individually paletted icon sprites, keeps the table seperately to the icon sprites ones. At worst (in 32bpp) this uses an extra 256x4 bytes of RAM.
Trace.s: Split out the tracing routines from Wimp10 as it was getting a bit big.
Tiling.s: Namespace change for the icons versus tools distinction. Removed some unnecessary PC+8/PC+12 confused NOPs.
Tiling3D.s: Namespace change for the icons versus tools distinction.
Wimp01.s: New set of variables to track the tool translation tables separately. Various jiggling to keep ADRs in range.
Wimp02.s: Namespace change. Remove some double handling in Wimp_SetColourMapping.
Wimp04.s: Namespace change. Made factor rationalisation common to both the icon and tool grinding code. Removed dual use of cachespritedata for both icons and tools. The tintfunc moves to Wimp10. Service_InvalidateCache confusion resolved by adding a new flag to remember that the tools need regenerating rather than just marking the tool list as missing (which subsequently got restored in Tool_SpriteOp without actually doing any palette work.
Wimp10.s: Label tools_area renamed as it was immensely confusing to have that (which was actually holding the RMA allocation of the tool_list) and tool_area (which contains the sprite area) hanging around. Changed references to use tools-only cachetolspritedata routine. Added 'wide' flags to sprite op and colour trans calls. Tool_SpriteOp changed to actually regenerate the colour tables when they're known invalid (previously the tools list pointer was merely restored and no colour tables used). Trace functions extracted. Resolved confusion as to what recache_tools_trans and recache_tools_trans2 should be doing.

Tested with 4bpp "NewLook" sprites in 4bpp/8bpp/16bpp/32bpp and 8bpp smooth greyscaled "Steel" tool sprites in same modes.
Also ran a task window doing repeated Service_InvalidateCache calls while monitoring the RMA for leaks.
Generally navigated around some directories to ensure that inverse icons (during double click) and filer windows (with individually paletted sprites) were being rendered.

Version 5.20. Tagged as 'Wimp-5_20'

Not tagged.

Version 5.19. Tagged as 'Wimp-5_19'

Derived from the 'Steel' theme these are 90x90dpi toolsprites for the Raspberry UserIF. Their use of continuous tones has highlighted some deficiencies in the Wimp's translation table generation which are yet to be addressed, at which point the other resolutions and disc based copy will be more generally available.
For now, ROM only keeps the distribution more controllable.

Was erroneously 90x90dpi. Retagged as Wimp-5_18.

* Re tinted 'floppydisc'

* Re tinted 'floppydisc'
* New 'floppyscsi' and 'floppysd' for USB and SD card media
* Removed !Scrap, the only boot resources that are seen by humans are !Boot !Fonts and !System, the others can rely on their private copies
* Removed 3rd party applications, avoids bias towards particular vendor while not polluting the pool with stuff that isn't actually part of the OS (specifically !aemulor !arcfax !sparkfs !sprinter)

Stopgap only pending final artworks, this will merely check the machinery for rogue spanners.

Also enable the mask on said cog in Sprites11.
Reported by eagle eyed viewer Frederick Bambrough.
Retagged as Wimp-5_18.

In Sprites, the taskmanager was too high up.
In Sprites11, the taskmanager has some scaling artefacts.
Retagged as Wimp-5_18.

Version 5.18. Tagged as 'Wimp-5_18'

* ROM sprite sets for Ursula and Morris4 brought in sync with Iyonix and Sovereign, including creating new sprites where missing
* Disc sprite sets created for Ursula, Morris4, and Sovereign. These may not be coherent yet, but are the superset
* Shelved the crusty 2D templates and tools
No code changes, nor resource changes to active ROM builds, retagged as Wimp-5_17.

Avoids restriction of 10 letter filenames on short name media. Idea supplied by Ben-cunning-fox-Avison.

Detail:
  s/Wimp04 - in SWIWimp_ReadPixTrans, check whether we've got a pixtable before trying to read from it
Admin:
  Tested on BB-xM with high processor vectors
  Although I was unable to reproduce the issue myself, judging by the address given in the bug report this should fix an abort when dragging certain files in the filer
  See here for bug report: http://www.riscosopen.org/forum/forums/2/topics/226?page=2#posts-13500


Version 5.17. Tagged as 'Wimp-5_17'

Detail:
  s/Wimp10 - Corrected interrogation of icon flag word IST bits to avoid trying to parse the sprite area pointer of an indirected sprite as a validation string
Admin:
  Tested on BB-xM with high processor vectors
  Fixes crash when dragging file icons in saveas dialogs


Version 5.16. Tagged as 'Wimp-5_16'

Messages updated to be more specific/helpful.
Magic numbers for OS_File swapped to use names from Hdr:HighFSI.

Version 5.15. Not tagged

Therefore, when in ROM, the ROM theme can be inferred. When a different theme is selected by the user in the boot sequence, that is respected.
Restore a lost error message for *ICONSPRITES when the file doesn't exist even after trying all the 11/22/23 suffix and prefixes. This seems to have been lost post RISC OS 3.10 when Sprites22 support was added, but it is an error for the file given to not exist at all (cf. *TOOLSPRITES).
Typos in docs ammended.

Version 5.15. Tagged as 'Wimp-5_15'

Retagged as Wimp-5_14.

Retagged as Wimp-5_14.

RISC OS Select has added reasons 18-27 and this change implements those that map directly to features that already exist (unimplemented ones return an error as before).
One additional reason, 28, permits the reading of the flags collected from the *WimpVisualFlags command so that applications can discover if the cheesy 3D borders are on or not.

Version 5.14. Tagged as 'Wimp-5_14'

Derived from the Iyonix ones, but with a cog instead of a jellybean.
Other variants unchanged, tag Wimp-5_13 applied.

Detail:
  s/Wimp, s/Wimp01, s/Wimp02, s/Wimp07, s/Wimp08 - Try using OS_ReadSysInfo 6 to get IRQsema & DomainId locations before falling back on legacy values. Store the pointers in module workspace for speedy access.
Admin:
  Tested on rev A2 BB-xM


Version 5.13. Tagged as 'Wimp-5_13'

Detail:
  These utilise SpriteExtend 1.42 to set the pointer active point from the
  sprite mask.

Version 5.12. Tagged as 'Wimp-5_12'

Detail:
  s/Wimp03, s/Wimp07 - When saving the VFP context the Wimp now uses lazy context switching where possible, via a combination of the Lazy & AppSpace flags
Admin:
  Tested on rev A2 BB-xM
  Requires VFPSupport 0.02


Version 5.11. Tagged as 'Wimp-5_11'

Detail:
  s/Wimp04 - The checkhandle* routines now checks that the window pointer is word aligned before attempting to load any data from it.
  This prevents alignment faults on ARMv6+, and should result in more accurate sanity checks in general.
Admin:
  Tested on rev C2 beagleboard.
  Fixes issue reported on forums:
  http://www.riscosopen.org/forum/forums/5/topics/517


Version 5.10. Tagged as 'Wimp-5_10'

Detail:
  s/Wimp, s/Wimp01, s/Wimp02, s/Wimp03, s/Wimp07 - The Wimp now uses the VFPSupport module to switch VFP contexts when performing task switches.
  Each task begins with the null context active (i.e. no VFP/NEON access). When paging out a task the ID of the active context is saved in the Wimp's per-task workspace. This context is then restored when the task is about to be resumed.
  Context save/restore is performed while the right task's memory is paged in, so it's safe to use with contexts located in application space.
Admin:
  Tested with Iyonix & Beagle ROM builds.


Version 5.09. Tagged as 'Wimp-5_09'

Detail:
  s/Wimp05 (setcaretcoords_fancy), s/Wimp07 - Fix some dodgy comments that had trailing backslashes, causing the next line of code to be gobbled by objasm and omitted from the compiled code. The code in question has been around for a long time, so I guess a recent objasm change (or the switch from aasm) has caused the dodgy comments to turn malicious. The setcaretcoords_fancy bug was the cause of bug #241 in the ROOL tracker.
  s/Wimp05 (int_set_caret_position) - While testing the #241 fix, I found that opening the filer 'rename' menu, typing text (enough to cause the icon to scroll), and then clicking away to close the menu would cause an infinite abort loop. The cause seemed to be int_set_caret_position mistakenly setting the caret window ptr to 0 instead of nullptr (-1), which would then cause setwindowptrs to die when it tried dereferencing what it thought was a valid pointer. Although initially confused about how this bug has gone unnoticed so far, I've now realised the abort was just down to alignment exceptions being turned on and the code would have "worked" on <=ARMv5.
Admin:
  Tested on rev C2 beagleboard.
  Fixes bug #241.


Version 5.08. Tagged as 'Wimp-5_08'

Detail:
  The "pointer leaving window" code now checks that ptrtask != nullptr before attempting to use it as an offset to the workspace pointer. This is required when alignment exceptions are enabled because nullptr is -1.
Admin:
  Tested on rev C2 beagleboard


Version 5.07. Tagged as 'Wimp-5_07'

Version 5.06. Tagged as 'Wimp-5_06'

Detail:
  CPU version is no longer specified in the makefile - it's better to inherit
  it from the build environment now that we actually set it appropriately.
Admin:
  Built and briefly tested. Binary should be unchanged - this only affects
  the warnings generated during assembly.

Version 5.05. Not tagged

Detail:
  Uses suffixed file extensions for compatiblity with both objasm and asasm.
Admin:
  Supplied by Peter Naulls, tested at ROOL

Version 5.05. Not tagged

Detail:
  Wimp found to have ininitialised WindowOutlineColour until the
  WimpVisualFlags had been run. Now initialised at module startup.
Admin:
  Tested in ROM build. J Ballance, Castle


Version 5.05. Tagged as 'Wimp-5_05'

  Allow the outline to be plotted over the window tools.
Detail:
  The options available through WimpVisualFlags have been extended with two
  new options that control how the window outline is plotted.

  WimpVisualFlags -WindowOutlineColour <&RRGGBB> -WindowOutlineOver

  WindowOutlineColour defines the colour to be used for the window outline.
  It allows theme designers to choose a window outline colour that fits
  in with a theme's general colour scheme. Default value is black.

  WindowOutlineOver controls if the window outline is plotted over the
  toolicons. It can be used to ensure that there is a window outline
  visible even when the toolicons are borderless. Default value is off.
Admin:
  Tested on RO 5.11
Author:
  Fred Graute

Version 5.04. Tagged as 'Wimp-5_04'

Detail:
  Previous versions of the Window Manager required toolicons to have pixels
  that were transparent so that the background colour could be used to indicate
  whether a window had input focus or not. This means that new sets of toolicons
  either have to have transparent pixels or lose indication of input focus.
  To remove this limitation the support for toolicons has been extended so
  that a different set of toolicons can be used for the window with the input
  focus.

  The new icons have the prefix 'f' added to their names as follows:
    <toolname>    standard version of toolicon
    p<toolname>   pressed version of toolicon
    f<toolname>   focus version of toolicon
    pf<toolname>  pressed+focus version of toolicon

  Code has been added to ensure that all toolicons are represented.
  This is done in two stages; first the pressed icons are checked and for any
  missing its non-pressed equivalent will be filled in. Next the focus icons
  are checked and for missing ones its non-focus equivalent will be used.
Admin:
  Tested on Iyonix RO5.11
Author:
  Fred Graute

Version 5.03. Tagged as 'Wimp-5_03'

  Fixed corruption of table with characters to be mapped to WimpSymbol.
Detail:
  There was an ALIGN statement missing just above the code for WimpWriteDir

  The table used to map characters to the WimpSymbol font had become corrupted
  which prevented the mapping from working correctly. This resulted in keyboard
  shortcuts disappearing in menus when using fonts that don't have definitions
  for the required characters, in particular the up-arrow representing shift.
Admin:
  Tested on RO 5.11
Author:
  Fred Graute

Version 5.02. Tagged as 'Wimp-5_02'

Detail:
  Unnecessarily complex code in Watchdog for killing tasks other than the
  currently active task ended up corrupting the environment handlers for
  the current task.
Admin:
  Fixes the test case of running a BASIC program consisting of
    REPEAT UNTIL FALSE
  which previously caused random errors or complete crashes if you ran it
  and then Al-Breaked and tried to kill a different task.

Version 5.01. Tagged as 'Wimp-5_01'

Added a test harness that may be useful if anyone fancies finishing off drag and drop in writeable icons.

Version 5.00. Not tagged

Detail:

Admin:


Version 5.00. Tagged as 'Wimp-5_00'