1. 12 Dec, 1997 1 commit
    • Andrew Hodgkinson's avatar
      There are a few known significant problems with this code but it's being... · b36c2bb4
      Andrew Hodgkinson authored
      There are a few known significant problems with this code but it's being checked in so the Choices can be worked on. Note that Res files etc. are not up to date across all builds. Progress is as follows...
      
      Bug report prompted me to do this - now ignore <p> tags straight after
      <li> tags, so '<ul><li><p>Some text' works as the author (or automatic
      generator, more commonly) intended.
      
      A <p> tag before a table will be acted upon now (it was ignored before).
      Something like <li><p><table...> will give a line break and paragraph
      space after the <li> despite the changes mentioned above, as in other browsers.
      Both browsers differ from Navigator, where the table appears alongside
      the <li> tag.
      
      Multiple BR tags work as in MSIE / Navigator (they don't collapse to
      zero height anymore).
      
      For the above, line height (and so, <br><br> or <p> spacing) is now
      calculated inside reformat_text_line_height, and is used with either
      a token to get the text height at a given size (e.g. for general line
      spacing or multiple BR tags) or NULL for normal size text (e.g. for
      P spacing, though this value is in practice later scaled by 7/8ths in
      reformat_check_height). Note this behaviour is exhibited by MSIE 4;
      v3 gave two BRs the same spacing as one P (i.e. not font size
      dependent).
      
      Save dialogues can have an option button or couple of radios to
      switch between various formats (e.g. URI or URL, sprite or original
      format). See 'Docs.Notes' for more. The back-end to this is now
      implemented (i.e. at the moment, save as URI or URL, save as original
      image format). Note that when saving background images, a leafname
      based on the original fetch URL is now offered rather than a generic
      'Background'.
      
      Internal URL scheme changed to be all lower case, so relativisation
      through URL_Fetcher still makes sense... :-/
      
      Holding down 'shift' when clicking on stop reverses the interpretation
      of the Controls file 'StopWebServe' entry.
      
      Fixed row / column count for exporting tables as text; fixed a few
      bits and pieces of internal URL scheme stuff which got broken when
      HTMLLib started using URL_Fetcher's relativisation.
      b36c2bb4
  2. 02 Dec, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Implemented Message_PlugIn_ReshapeRequest, Message_PlugIn_Status and · 960e879c
      Andrew Hodgkinson authored
      Message_PlugIn_Busy. Plug-in code more robust when given invalid
      browser instance handles by the plug-in.
      
      Line spacing is now calculated on the basis of the normal style base serif
      font, with all other fonts being forced into that line height. This does
      mean that an unusually tall (say) sans serif font may get clipped. It
      appears to be the only way to get around wildly different baseline
      depths returned from the font metrics - you can't work out line spacing
      based on each different font style; the line spacing will vary.
      
      Table heighting (as opposed to widthing...) improved considerably; rowspan
      can no longer cause very tall cells in odd places. Having trouble getting
      rid of the single pixel breaks between vertically adjacent cells, though
      I've not tried too hard. Widthing, though, seems fairly badly broken at
      present... :-/
      
      Set/clear of page_is_text flag made more robust (it looked as though there
      was the potential for this to get stuck in a set state, though I've never
      see the front-end behave in a manner which indicates this is the case).
      The reformatter will now decrease leading if this flag is set (plain text
      pages look daft with a line spacing that is OK for 'rich' text pages).
      No reformatting is done if the page width changes by dragging on the
      resize icon, though toggle size / full screen will still reformat even
      if the contents are only text (browser needs to sort out various width
      flags at this point).
      
      Cut down on excessive redrawing when reformatting due to a change in
      window dimensions is not done. If display_width hasn't changed, then no
      redraw is needed. If this causes redraw problems, then whatever is
      changing display_width needs investigating. It shouldn't be kludged
      (basically) by forcing a redraw instead of a reformat.
      
      TT/PRE/etc. text can now have a non-100% aspect ratio. 80-90% looks
      best (ArcWeb, for example, uses 86%). New option 'TTAspect' in
      the Choices files.
      
      Debug builds link to a non-debug Unicode library now; stops stderr
      being dumped to the bottom left of the screen if you've not redirected
      it in the Run file.
      
      RISC OS 3.1 seems to need more initial WimpSlot than later OS versions.
      The 64 deep nested table set gives a 'No stack for trap handler' error
      (which it really means in this case!) without 800K, even though 3.71
      is happy with just 640K. So, the !Run file checks if Boot$OSVersion
      is exactly 300, 310 or 311, and sets the WimpSlot accordingly.
      
      !Run[D] files now require latest fetcher module versions (URL 0.21,
      File 0.31, HTTP 0.58).
      960e879c
  3. 26 Nov, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Image history - sizes of images are remembered for future reference (if the... · 2a2b2672
      Andrew Hodgkinson authored
      Image history - sizes of images are remembered for future reference (if the sizes aren't specified in the HTML, they can be looked for in the image history instead to minimise reformatting requirements). Choices file options ImageHistoryPath, ImageExpiryAge, ImageMaxSize and
      
      SaveImageHistory added to support this (all have a direct analogy to
      the global History items of the same name after removing 'Image').
      
      Text area items are now the correct height for the number of rows
      specified in the HTML, don't scroll a line too early, and have the
      caret placed at the start of the text when moved into from above
      or at the end when moved into from below (rather than always at
      the end, which was behaviour inherited from single line writables,
      where this is desirable). The top of the text area is aligned to
      the top of any line of text on the same line, with the text area
      dropping below the text, rather than the bottom of the area matching
      the text baseline and extending upwards.
      
      Filename extensions for download files are only stripped if an
      attempt to convert to a RISC OS filetype through the Mime Mapper module
      does not return an error or Data (0xffd) filetype. '.cgi' is a special
      case which is always stripped.
      
      Altered heading styles - all are bold, none are italic, H3 is as big
      as H2 was, H2 is a little larger, and others scale down to H6 being
      the size as normal text (but, as I say, bold).
      
      Sorted out tables and forms. We can just look for tagno=TAG_FORM, and
      get rid of the wobbly form_flag; also discarded the redundant
      reprocess_table flag in fetch_preprocess_token. Two separate forms
      in consecutive table cells (for example) which used to fail - they
      were submitted as one single form - will now work correctly.
      
      Fixed nasty bug in FontManage.c where font size 7 would intermittently
      fail. The stupid font sizes that it could ask the Font Manager for may
      be responsible for the occasional Font Manager crashes that have been
      noticed. Array for font sizes was declared as [Limits_FontSizes], but
      indices 1 to Limits_FontSizes are actually used - so needed a '+ 1'
      in the declaration... :-/
      
      Replaced the case insensitive string comparison functions in Utils.c
      with more efficient versions by S.Brodie.
      
      MAXLENGTH specifier in INPUT tags is now supported. If unspecified or
      specifically zero, the browser overrides and allows any length.
      2a2b2672
  4. 19 Nov, 1997 1 commit
    • Andrew Hodgkinson's avatar
      This is an intermediate check-in to allow work on Choices for the new table... · 7caf92e2
      Andrew Hodgkinson authored
      This is an intermediate check-in to allow work on Choices for the new table options and History choices as detailed below. Res files are not up to date except where indicated and there are several known bugs that will be fixed before the 'final' v1.27 is created. Any work on resources should only be done for the testbed !Browse.
      
      Client side image maps implemented. There is code to draw highlighted
      borders in CSIM.c, but this is not wired in yet; other than that,
      the implementation is functionally complete. As part of this, centralised
      the fetching of a targetted URL taking into account user request of a
      new view and full screen mode, in fetchpage_fetch_targetted. The forms
      library now uses this too, so form buttons respond to both adjust-clicks
      and TARGET attributes.
      
      Fixed APPLET handling where '.class' isn't present in the CODE attribute.
      
      Paragraphs squashed at the top of cells/pages - browser would insert white
      space before.
      
      Now append a ' ' to the end of History menu items to prevent the Wimp
      thinking the end of entries represents a keyboard shortcut (e.g. 'Home').
      
      Netscape's handling of 'meta http-equiv="refresh"' is to start counting
      when the fetch has completed and everything else has died down. The browser
      will now not start counting until the animation handler is deregistered
      (so formatting is complete) to show similar behaviour (note that this
      checks the main handler, not the 'idle but returning to first frame'
      drift handler).
      
      URLs from requests for fetches by Plug-Ins are now relativised.
      
      Page width change tolerance prior to reformat upped from 16 to 32 OS
      units. Hoping to provoke a loosely connected bug with this change!
      
      TableOuter, TableInner and SeeFetches choices added to all Choices
      files, with appropriate loading and saving code in Main.c and Save.c.
      AuthorFTP and AuthorFSh messages added for FTP authentication, and
      dialogue handling code (the component in FetchHTML.c) updated to
      recognise an FTP fetch and alter the dialogue presentation
      appropriately.
      
      All Messages file version numbers taken up to 1.27 (20 Nov 1997).
      
      Following a UseNet suggestion, Ctrl+Toggle Size will increase the window
      size to fill the screen vertically only; horizontal size/positioning is
      not changed.
      
      Shift+Tab in the URL writable will cycle through alternative fetcher
      protocols (from both the Controls file and checking the fetcher modules
      are actually present).
      
      Hotlist doesn't require '://' in URLs when loading HTML, just ':/' - so
      'file:/' URLs now will be reloaded correctly.
      
      History system rewritten completely. GHistSize and VHistSize options
      removed, and replaced by MaxSize and ExpiryAge. Now have global history
      menus with most recently visited items at the top, and local history
      menus which reflect the path that forward/back buttons would take.
      Browsers are robust to background expiry of the History though this is
      not implemented - date expiry and size checks are carried out on
      history_record only. This does mean that with two windows open one could
      have the history expired underneath it whilst another fetched, though;
      the code handles this and update toolbars (greying items) as necessary.
      It is possible to have the history limits so tight that even one entry
      will not fit and again the code copes with this, though values read
      from Choices are limit checked to ensure rather more useful results!
      
      Implemented 'Save' button in save dialogues. Remembers pathnames and just
      replaces the leaf now (hard coded exceptions for <Wimp$Scrap>... and
      <Wimp$ScrapDir>...) - it did before, but only if you'd typed the path
      in. Not many people did, given that you couldn't press Return or click on
      a Save button to use that path...
      
      In a similar vein, files of type Data or DOS will be checked for a '/xxx'
      type extension and the MimeMap module will be used to find a more meaningful
      filetype. If this can be handled, the file is loaded. This only works for
      files dragged to the browser - the behaviour with inline data in web pages
      will depend on the File module, and similarly, if File doesn't spot what is
      going on and claims that the object is data, the browser will just open a
      save dialogue for it.
      
      !RunD files taken up to 3072K WimpSlot.
      
      Hotlist's saved HTML page title wasn't internationalised - is now. This
      opened up a significant can of worms; on file write error, the file would
      never be closed, and if a caller of the save or load functions passed
      in a filename held in the global Messages lookup buffer then subsequent
      lookups in the callees would corrupt that filename. All sorted out now.
      
      Local (not very useful) or global (useful) histories can be saved as HTML,
      which opens up the possibility of sending your history to the hotlist
      by saving to it. Local and global histories can also be emptied, though
      this is probably not a feature that current release Desktop browsers need.
      Inheritance of local history and certain UI features is now done more or
      less for all cases where one browser window spawns another, too.
      
      Vertical alignment on images is rather less ropey than it was (e.g.
      ALIGN=TOP stands half a chance of working) but is still far from perfect.
      This was part of fixing a nasty little bug in Redraw.c's setting of
      an image position via. image_set_token_image_position, which was making
      (amongst possibly many other things) client side image maps fail.
      Image update where images had large borders was affected by a similar
      problem too (more cans with more worms...).
      
      Fixed image background filler functions; two problems. When cross
      referenced images were replaced by base images in a browser because the
      original owner was closing down, the original owner browser would stay
      registered with ImageLib. Fixed; secondly, when images were deleted from
      the image array causing those above to be renumbered, images registered
      with ImageLib did not have their numbers updated (this was the one that
      lead to the visible drop out of background images with PNGs on the Acorn
      Internet home page when there were two views of the page and the first
      was closed). This is now also sorted out.
      7caf92e2
  5. 13 Oct, 1997 1 commit
    • Andrew Hodgkinson's avatar
      More reformatter code bugs fixed; this one regarding width of items. Any... · 0cdc76df
      Andrew Hodgkinson authored
      More reformatter code bugs fixed; this one regarding width of items. Any kerned string was overestimated (causing redraw bugs and caret position problems in forms, apart from other minor bits elsewhere) and the default size of a writable icon wasn't especially clever.
      
      Crude Plug-In support; just about manages Java, but can't fetch on
      behalf of Plug-In (for example). Had to change the default file access
      URL construction to be 'file:/' instead of 'file://', or local file
      fetches that reference Java applets won't work. This is in its very
      early stages, and is being checked in mostly so that various Choices
      issues can be worked on.
      0cdc76df
  6. 05 Oct, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Big steps forward in vertical white space handling as a result of improvements... · 5db9badc
      Andrew Hodgkinson authored
      Big steps forward in vertical white space handling as a result of improvements in HTMLLib in this area ( -> all versions now 1.22 beta-2).
      
      As a result, the 'last_space' field in browser_data struct has been
      removed. Note that this relies quite heavily on setting of the PCDATA
      bit in the 'style' field of an HStream and the automatic collapsing
      of (for example) multiple P tags inside HTMLLib.
      
      Trace.c improved to recognise various bits in the 'style' field of an
      HStream structure.
      
      Phoenix defaults altered to a more 'standard' set of choices; Trinity
      as the serif font, with a slightly larger default font size. This is
      because there's a good chance it might get released to a wider audience
      than Acorn internal (though the animation and icon bar sprites will
      have to change before then...).
      
      MiscDefs updated for new SWI numbers in HTTP module; !Run[D] files thus
      updated to require HTTP 0.42 or later. At this point, all earlier
      modules are not backwards compatible in terms of direct calls to the
      HTTP module, though this only affects cookies_process_cookie at present.
      At the same time, checks for System$Path, InetDBase$Path, and setting
      of Inet$MimeMappings if not already defined have been added to the Run
      files along with RMEnsures of Resolver and MimeMap.
      
      Object and PlugIn c/h pairs created to handle OBJECT, EMBED and APPLET,
      and the RISC OS Plug-In interface respectively. Not part of the build
      process yet. Addition of 'odata' field in browser_data struct and
      definition of chunk CK_OBJB for memory_set_chunk_size() are in support
      of this.
      5db9badc
  7. 03 Oct, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Version in Messages taken to 1.22 (03 Oct). · 4d616ea4
      Andrew Hodgkinson authored
      Updated Res files in appropriate builds to hold various (similar) Choices
      designs.
      
      Choices related menus were flagged as Shared, but none of the dialogues
      (including ColourDBox) were - potential future problems, though shouldn't
      cause any leaks at present. This has been sorted out anyway.
      
      Encoding function encoding_init no longer returns an error from
      toolbox_create_object, so the Encoding menu and all those attached
      to it do not have to be present (e.g. the Customer build).
      
      SUB, SUP, STRIKE and U supported. U underlines the baseline of the body text
      font, whilst STRIKE will go through roughly the middle of the lower case
      chars even if the font is SUP or SUB. Note that Navigator appears to shift
      the underline point for SUB and SUP; it may be necessary to copy this
      behaviour, but testing on real sites must proceed before that. There could
      also be a problem with the automatic lowering of font size, which Navigator
      doesn't do, so any FONT SIZE = -n commands could make it too small. Again,
      this needs testing on real sites.
      
      'http://' is added to URLs with no protocol specified, unless they start with
      'ftp.', in which case the new behaviour is to add 'ftp://'.
      
      Choices code altered to do less error checking on components! They should be
      able to be missing without raising errors. Referencing of the subwindow
      array changed from *(subwindows + number) to subwindows[number].
      
      Made trace_tag_name code look pretty...
      
      reformat_useless_token now checks tagno is non-zero.
      
      User Agent string setting now done through URL_GetURL, on a per-session
      basis.
      
      Ellipsis character removed from all Messages files, replaced with '...'.
      There's little difference between the two in an outline font, and in System
      font the latter looks much better. Smart quotes left in, as they look
      better in all cases.
      4d616ea4
  8. 29 Sep, 1997 1 commit
  9. 22 Sep, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Now working on source merged with Kevin Bracey's internationalisation support.... · f61afadd
      Andrew Hodgkinson authored
      Now working on source merged with Kevin Bracey's internationalisation support. UNIFONT is undefined in the Make File for now. All Res and
      
      Choices files updated appropriately.
      
      Having sorted out the old Choices and Messages to form Choices, Controls
      and Messages, this build has had the same cleaning up done internally.
      This includes greater consistency in naming schemes and the removal of
      the inconsitent choices items - e.g. Choices file entries saying 'delay
      images' and 'plain backgrounds' where internally all the flags say 'show
      images' and 'show backgrounds'. ChoiceDefs.h and CtrlDefs.h added to
      clarify the meaning of some fields, though usage of these is not 100%
      in the source (there are cases where parameters are passed through to
      functions as ints, and those functions still check these against hard
      coded values rather than the #define stuff).
      
      Fetcher status return bits (connected, sent request, etc.) now reflected
      in status bar. Progress during fetchs to files are reported by %, where
      the size of the object is known. Exceeding 100% drops back to a byte
      counter, in case the estimated size was wrong. The progress counter
      may be updated after specific delays, rather than 'as often as possible',
      to reduce flicker (as requested by D.Brown some time ago).
      
      I've done a small rewrite of the fetch prioritisation scheme in FetchPage.c;
      how well this performs in general use across different processor speeds
      remains to be tested, but certainly it has some advantages. For each small
      fetch window before the rewrite, a 4cs tight loop was entered - this gave a
      noticable and substantial drain to the Desktop performance if more than one
      was opened. Now, several can be up at once with little hit. The actual file
      fetch is on half the priority it was before, with all others taken back
      just a bit - e.g. from 20cs per poll to 15cs per poll for flat out
      reformatting. You don't seem to lose much time on the format in practice,
      and the Desktop feels quite a bit lighter at the same time. There's the
      potential for smoother frameset loading in this scheme, too.
      
      When Shift+Clicking on a link meant you still fetched inside the main
      browser window, several fetches could occur in a frameset - one per frame.
      However, now that you can only do this by clicking on a link that leads to
      non-displayable data - or by turning off the small fetch windows by
      setting UseSmall to 'no' in Choices - a bug where fetchpage_preprocessed
      would stop such fetches as new ones were started was revealed.
      The API to frames_abort_fetching has now been extended to include a
      'stop file spooling too' flag, allowing a fix to be made by having
      fetchpage_preprocess's calls not set this (and it doesn't check the
      savelink flag is unset before proceeding, since frames_abort_fetching
      does that implicitly now).
      
      Had left the RAM transfer buffer at 16 bytes (from testing) accidentally...
      Oops. Upped it to 4K. In addition, when loading data by RAM transfer,
      the browser didn't notice if a RAMFetch bounced during the transfer. It
      would be treated as a 'first' RAMFetch bounce, basically, and try to go to
      file transfer - oops. Fixed.
      f61afadd
  10. 09 Sep, 1997 1 commit
    • Andrew Hodgkinson's avatar
      First a minor warning - the various Res files are out of sync in this build. · 7656a1b3
      Andrew Hodgkinson authored
      Only the Browse resources are currently valid.
      
      Added Utils.Icons - has a few archives inside containing the resources
      (well, some of them) used to build various UI sprites for various builds.
      Archived because these are unlikely to change much, and putting them on
      CVS was a move to, well, archive the stuff...
      
      SaveDBox objects vanquished and requirements in !Run[D] files removed. The
      data save code fits much more neatly in amongst the data load protocol
      stuff now (with the slight exception of having to split the SaveObject
      source into SaveObject and SaveFile - the former handles multiple persistent
      dialogues for Shift+Click on links and the like, the latter handles 'one at
      a time' transient dialogues for save source and similar). Export Link is now
      supported, too, and writes a 'proper' version URI file. You'll find that
      double-clicking on old URI files will work as the URI handler picks them up,
      whilst new version ones don't; however, dragging onto the browser will only
      work with new version files. Note that support for saving and loading URL
      files (ANT suite stuff) is present too, so old URI files can be typed as URL
      files if you want to keep them working without modification - the URI
      handler itself will hopefully support the defined URI file format soon;
      double-clicking on old URI files will stop working at that point. Note
      there are *lots* of changes in every Res file to support all this. This may
      all seem a bit pointless to some, but the changes do in fact make it very
      easy to add new save dialogues all over the place. Certainly much easier
      than with the previous system, anyway. In fact, post script, image
      'save as sprite' took about half an hour, which I hope proves the worth
      of the new system.
      
      Merged in newer hotlist code with support for drag cancelling with Escape
      (all relevant Res files appropriately updated) and cancelling scrolling
      when you've reached the window scroll limit. Had to move some of the
      Wimp message handling stuff to the central Protocols source, as clashes
      were occuring, and also the hotlist routines were using independent saving
      code - a lot of duplicated effort. This was fair enough as at the time the
      Hotlist code was written, the Save code couldn't be used in the way it is
      now.
      
      New Save Source and Print buttons on the toolbar of some builds.
      
      Phoenix Sprites file made more efficient - the Acorn base section has been
      split from the animated upper region. Browse build has a new grey fade
      sprite at the back, which is less grainy than the previous one and only
      uses 16 colours (with a 16 greyscale palette).
      
      Not really a bug, bug the routine to start an image fetch for INPUT
      TYPE=IMAGE forms items only did so if the src field (or equivalent, for
      this tag type) was non-NULL. In fact, you should always call image_new_image
      and let that handle the rest, otherwise other sections of the code will fail
      as they try to obtain an image number for a given HStream and get -1 back.
      This problem only generally manifested itself when loading an HTML file to
      the browser straight from an application, as many src fields become NULL
      when the relativisation routines find nothing to relativise to...
      
      Authentication got broken somewhere along the line - this has been fixed
      (in HTMLLib and the browser).
      
      Ctrl+Click on a cross referenced image updates *all* copies, not just the
      one with the image data attached.
      
      Next big step: Rip up TBEvents.h and rebuild that whole approach somewhat.
      To all those working on the code, my apologies but this means all Res files
      will receive a very large number of alterations and there will be extensive
      code changes too (mostly naming convention stuff), in more or less all
      source files. I am endeavouring to ensure that the new numberspace
      convention does not clash with the work being done by Kevin on
      internationalisation.
      7656a1b3
  11. 03 Sep, 1997 1 commit
    • Andrew Hodgkinson's avatar
      File fetches now set DEADDEAD during the fetch, Data if it is aborted, or an... · bece97ef
      Andrew Hodgkinson authored
      File fetches now set DEADDEAD during the fetch, Data if it is aborted, or an appropriate filetype when finished. If the fetcher routines return a zero or data filetype, the browser looks at a set of hard coded filename extensions to try and determine if there's a better filetype to use
      
      (urlutils_filetype_from_url) - since this is a centralised routine it can
      use a Mime mapping system (or be removed entirely) as and when one becomes
      available.
      
      You can now drag URI / URL files to the Hotlist window to add them to the
      list. They are added roughly where dragged to. (NB, note that I renamed
      the function to return the window ID - just being picky; it matches other
      similar functions now). Oh, and hotlist_add_position actually works now ;-)
      
      The global history will save when titles are added, as well as when a URL
      is added. Before, a browser crash could mean a title got dropped out
      of the history file even if SaveHistory was set to 'always'.
      
      SaveObject sources have been added but nothing references them or links
      them in yet - they're not finished. Mostly checking this one in because
      of the hotlist changes.
      bece97ef
  12. 02 Sep, 1997 1 commit
  13. 31 Aug, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Created Protocols source file and moved a lot of message handling from... · f3e8124f
      Andrew Hodgkinson authored
      Created Protocols source file and moved a lot of message handling from handle_messages - the latter now serves as a high level distributor to lower level functions in Protocols. Incidentally, URL files (as used by the ANT suite) can be loaded by dragging to the browser in the same way as URI files - Not A Lot Of People Know That, etc.
      
      Merged new hotlist display type Res file to existing resources, added
      support for DataSave message so items can be dragged from the hotlist
      to a specific window (RAM transfer for URI and URL files; ScrapFile for
      HTML and Text but deleted afterwards and there are appropriate guards
      to stop Reload just saying 'not found'; images run through ScrapFile and
      there is no choice but to leave them there and do a conventional fetch).
      
      All !RunD files now give a WimpSlot of 2304K. Some small changes to
      the Argo and Ursula build Res files to make the menu trees more sensible.
      Controls files now take 'file:/' instead of 'file://' in Protocols
      section. Definitions at top of URLutils.c *not* altered, as then you
      end up with invalid URLs - so it will accept 'file:/', but always generate
      'file://'. This is because some browsers exports 'file:/'. Sigh.
      
      make_no_[..._]memory_error functions now return a _kernel_oserror * rather
      than void. It's always &erb returned, but it enables users to use a more
      elegant 'return make_no_memory_error(1);', say, rather than something
      like 'make_no_memory_error(1); return &erb;'. I obviously should've written
      it like that at the outset, but never mind. All callers have been
      appropriately updated.
      
      The urlutils_leafname_from_url function now replaces illegal characters
      (A7000 Welcome Guide p54...) in the leaf with legal alternatives.
      
      Internal URL scheme is now a bit cleaner, with everything properly defined
      in URLutils.h. All references to http:, file: and ftp:, with or without
      a following '//' use the definitions in here now.
      
      More tidying and some reorganising of Hotlist source. Auto-open delay is
      now a Choices item. Some dependencies on statics removed (e.g. the
      counting functions don't accumulate into the global item_number now).
      The redraw functions used Wimp_TextOp - oops, so this has been amended
      to use whatever is supported on your Wimp. This is now in a new function
      (utils_text_width()), which the History menu routines also use (there was
      a bug in the width routine there anyway, which is therefore fixed in
      passing). Several other routines used Wimp_TextOp directly too, and
      they have been altered to use the new function as well.
      
      In hotlist code, one of the larger changes is in the API to hotlist_draw_r()
      (formerly _hotlist_draw()) which now takes item widths and heights as
      parameters - discovering these is quite slow, so doing it every time the
      function calls itself recursively is a little less efficient than
      passing the values in from elsewhere. Note that underscore prefixed
      functions are being slowly renamed to _r suffixed functions, to match
      the convention established by Tony Cheal with is table routines. This
      makes it much more obvious when something is recursive, as the same
      naming convention is used in every browser source file.
      
      Finally, note that I intend to ditch SaveDBox and use an alternate window
      with manual control of the messaging in Protocols.c. This will allow
      various improvements which at present the SaveDBox operational methods
      preclude. I'm going to have to do at least an alternate Window object for
      the SaveDBox module to use soon in any case. Getting rid of SaveDBox will
      help reduce, if only slightly, demands on the RMA.
      f3e8124f
  14. 28 Aug, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Very long log entry alert - but hey, beats 'Bug fixed' (sorry, Richard) ;-) · 532155bd
      Andrew Hodgkinson authored
      Open URL implementation more or less complete, though may undergo UI
      revision at a later date to allow named frames to be targetted. Hope to use
      the ideas in this code as the foundation for other general dialogues.
      
      In token stream dump for TRACE builds, table head items were not indented
      as far as they should have been - this is fixed; and manual toolbar redraw
      routines have been removed. They never worked, were commented out, and
      would never be used in that form anyway.
      
      DragBox source added, but it isn't at all complete and won't work - this is
      an 'in spare time' thing. We need custom drag boxes constrained to windows
      for the hotlist, and unconstrained for frame border resizing... Hey ho.
      
      Ancestor window extents match visible areas if there are frames (no more
      scrolling framesets...!). Frame resizing works whilst new documents fetch
      without pulling the extent down now. However, frame horizontal extents
      never shrink until a reload which is nasty, and this is all due for a
      rewrite. Frames border redrawing routine moved out of Redraw.c and into
      Frames.c. Bug regarding the mouse rectangle and frame border widths
      (rectangle was too large, so you could squash the edges) for edge-drag
      frame resizes fixed.
      
      Window width change reformat tolerance fixed; you could creep the window
      width down or up forever without any reformat, and centred objects would
      move but not be redrawn (thereby giving rise to subsequent redraw errors).
      
      Filetype on objects saved through Shift+Click correct. Save Source dialogue
      recognises if that source is plain text, rather than assuming HTML. A
      browser that fetches a file remembers the old store size it had before the
      save, so even though the data is now ditched, it reports the same amount of
      data fetched afterwards (looked awful when this could, for example,
      suddenly say '0' after a file save). Progress indicator is now fully aware
      of one or many file saves inside a frameset and reports the number of
      saves, a colon, and the cumulative saved data count, instead of reporting
      the sum total of fetched data in all frames, including non-file save stuff
      (note that for just 1 save, '1:' is not shown as a special case for the
      most common condition). A bug related to this, where you could in fact only
      do one fetch per frame*set*, has been corrected (only one fetch allowed per
      frame still, this is unlikely to ever change).
      
      Hotlist support added (D.Brown's source), with various bits of integration
      and modification still in progress there. Note additions to the Messages
      files. On the subject of Messages, the whole mucky business about what
      goes in Messages or Choices (and a few bugs where lookup_choice was used
      instead of lookup_token or vice versa) has been sorted out. Messages
      contains, more or less, just that. Choices contains user configurable
      stuff which generally can't mess things up too badly. A new file, Controls,
      is a Messages file holding the non-user configurable choices, which can
      generally make things go badly wrong if misused. A lot of these are tied
      to the Res file. StrongED users can get these to automatically fold out
      the various sections (EMail me for details). Sorry, but at the time of
      writing, Zap doesn't do folding... =8*P
      
      Two bugs with images. Asking for images to be shown in browser B when
      browser A uses the same ones and was loaded first didn't work correctly,
      and now does (a bit weird - browser A does the fetch and browser B does the
      display...). Second one occurred when the background image was also used on
      the page as a foreground image. This has been fixed by flagging background
      images in the image_info structure, and checking this before cross
      referencing. This bit also allowed the image_restart_fetches API to be
      extended, so that just background or foreground images may be fetched if
      they weren't already and the user asked the browser to show them. Before,
      the whole lot had to be fetched together (so turning on 'display
      backgrounds' will now kick off an image fetch if required, you don't
      need to reload the page anymore).
      
      Makefile copy options tweaked to be 'newer' (so if you're testing with some
      temporary Choices file or something, it won't write over it at the end of
      every export), and REMOTE_HOTLIST flag added for Customer builds - means
      the Hotlist.c functions aren't needed; the old, hotlist-by-file method is
      used. Added support for Customer build (see later), though there were very
      few additions needed in practice.
      
      Table printing fixed - in many ways it wasn't broken, it was image printing
      causing the oddities ever since the global image pool was introduced (this
      is, again, fixed). The 'reformat to fit page' option didn't work as coded
      any more; tables store cell addresses in the HStreams, so you can't then do
      a background reformat in a different browser. Hence, it now has to reformat
      to the page width, print, then put the page back again, all in the actual
      displayed browser. This doesn't feel as slow in use as it perhaps should,
      considering what is going on... Note that a line of a defined fraction (see
      Print.h) of page height will now split over page boundaries, so tall images
      or tall tables don't cause problems now (aside from the obvious problem of
      having the line split over a page at all!). There was a bug in the routine
      to print from a given start point until 'n' pages had been filled, in that
      it always filled 'n + 1' - now fixed. Finally, as part of the printing
      tweaks, a new dialogue exists - PrintStyle - with a similarly named source
      file added to deal with it.
      
      Global history auto save / load done, but only to the Choices file path -
      the whole browser is still strictly single user at present, with all the
      extra work for a multiuser Customer environment yet to be done. This has
      shown up a global history corruption problem which I haven't fixed yet.
      
      Rationalising TBEvents.h - things are migrating out of it, and into more
      appropriate sources (e.g. definitions relating to the Open URL dialogue are
      going into OpenURL.h, etc.). Event codes were at one stage deliberately
      diverged in numberspace from the component IDs of typical gadgets raising
      the events, to avoid anyone getting confused and thinking the IDs and event
      codes must match. However, this is in fact unlikely and it is much easier
      to remember the fewer numbers that result from tying the two together where
      possible. This has resulted in changes to event codes raised in the
      following objects of all Res files: Authorise, Find, OpenURL, and
      PrintStyle.
      
      And finally - !Run[D] files for all variants updated to require the latest
      toolbox and fetcher modules. All Res files updated for hotlists etc. and
      sprites files updated appropriately. All Messages, Choices and Controls
      files brought in sync., and an Customer build has been added (based on the
      Desktop build binary with different resources).
      
      That's all for now...
      532155bd
  15. 18 Aug, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Updated Makefile to work better in folding text editors. More or less rewrote · c46c55b2
      Andrew Hodgkinson authored
      Limits.h, and ensured consistent comment styling throughout all sources.
      Fetch.c/h split to Fetch, FetchHTML and URLveneer. URLstat.c/h produced to
      cope with this. OpenURL and Find sources created from bits in the Windows
      source file that shouldn't have been there... These will get filled out
      shortly. Note that a few functions in Fetch are due to be renamed and moved;
      probably to Tokenutils.
      c46c55b2
  16. 08 Aug, 1997 1 commit
    • Andrew Hodgkinson's avatar
      Checking in mostly because its Friday... Quite a few little bug fixes · b4491718
      Andrew Hodgkinson authored
      (adding up to a greater whole), which include removal of the dastardly
      'invalid image number' errors that trace builds would raise from time to
      time. Frame highlights are now better controlled (releaseably so).
      Generally, this build represents the first genuinely promising version
      of the browser for quite some time, despite the known library problems
      with comment handling etc.
      b4491718
  17. 18 Jul, 1997 1 commit