- 20 Mar, 1998 1 commit
-
-
Andrew Hodgkinson authored
Some compile-time hacks in place to use MemLib, a dynamic area based malloc replacement which shrinks its heap when possible. All builds have these switched off at the moment. Seemed to work with just Browse, though there would be problems with message blocks stored in dynamic areas because of the Wimp's '&3800000' check - however, it failed when HTMLLib was made to use it, too. Don't know why yet. ItemInfo.[c/h] source added, with Res file additions for testbed Browse and Phoenix. Small fetch windows now work properly regardless of toolbar settings in the Choices. Reload now reloads all images too, rather than only reloading them for as long as the main page was being fetched. Added a simple 'Find' facility. Realised that event handlers in eventlib are called in reverse order of registration, so the miscellaneous event handler is now registered first rather than last. Multiuser code added (most only active if SINGLE_USER is undefined). As part of this, hotlist code now knows about read-only items (done for the Customer-style 'Resources' file, but works generally anyway). handle_add_hotlist doesn't try to save the hotlist itself anymore (the hotlist_add function does all that through hotlist_modified anyway). Customer build Choices and Controls updated slightly (e.g. ClaimHelp off, hotlist to save on quit only). Customer build now uses Phoenix-style buttons. Sprites files which worked at the time (but will probably be out of date now) and included most of the original Customer-style sprites are in 'Utils.Icons.Customer'. Choices, Messages and Res files for all builds now stripped down to only single user items or single plus multiuser for Customer build and testbed build. Before, all contained a few multiuser bits in at least the Choices file if not more. Grammatical error ("Fetching frames contents" (sic.)) corrected in default message, Toolbars.c, and all of the Messages files. Customer build brought back to a servicable level (including implementation of the Find dialogue box with animation and fixing up authorisation and 'Stop' state in the tristate). Quite a few missing #ifndef REMOTE_HOTLIST bits from hotlist code added... Customer build will not use <Choices$Write> or Boot:Choices for any file finding now. UseProxy defaults to 'yes', MaxImages to 2. Res file includes Proxy Address setting (save_save_choices() now writes the ProxyAddress line).
-
- 31 Jan, 1998 1 commit
-
-
Andrew Hodgkinson authored
Check for WindowManager 3.97 and ensure Unicode$Path is set in all !Run[D] files, don't set the Alias$@PrintType_FF4 variable, and updated Customer build ROM obey file variants. Various other changes to the Run files for new module versions, updated paths to support new positions of choices, hotlist and histories (see later), etc. !Sprites[22] files hold small !app icons for some variants, and an ic_browse sprite. Some variants now have a Sprites and Sprites22 file instead of just Sprites, with the former containing various mode 12 or 15 specific sprites. Text files dragged to the URL writable are treated as ANT URL files. This relies on URLBarWrit (Toolbars.h) being a unique ID, which it should be, but beware of the Hotlist and Choices numberspaces... INPUT TYPE=BUTTON supported. Form items without a FORM tag are now shown (as MSIE 4, but not NN 4). '*', '-', '@', '_' and '.' are not escaped when submitting forms now. The Web interface to the IMDb now works. INPUT TYPE=HIDDEN items will not affect the line height anymore - so http://www.hotmail.com/ now has correctly aligned writable icons, for example. Similarly, TAG_FORM and TAG_FORM_END items could push up line height and don't anymore. HRs with a specified pixel width will now influence the size of a table cell (they didn't before). BRs now checked by tagno field when the browser needs to know something was an actual BR tag rather than just a line break signal, and by the style bit entry when only the indication of a line break is required. Table widths of 0 or 0% are ignored. Trace.c updated to report height and background fields in a table_stream. fm_putsl() writes a terminator into the string; the Forms.c routines were calling this for displaying INPUT TYPE=PASSWORD fields using the FE_PassCode literal string (a line of stars). This write into a read only data area would make the debugger fault the access. A local char array is now used instead, to get round this (note the use of var[]=literal rather than var[sizeof(literal)]; strcpy(var, literal) due to some weird compiler bug that copies the wrong thing into 'var' under some (undefined...) circumstances). Text areas don't scroll back to the top line when clicked in anymore; single line writables don't scroll back to the left either. When reentering a text area from 'above', the caret appears at the top line rather than 'somewhere further down'... ARROWS_MOVE_OUT compile time option at the top of Forms.c defines whether you must press Tab/Shift+Tab to move between writable fields in forms or if up/down will drop out of them, though if keyboard control is on this is enforced (or you get trapped inside the form!). urlutils_filetype_from_url now uses MimeMap module. If fetcher is told a page is text, it'll check for a filename extension and may choose to use this instead (e.g. it may find it's HTML instead). This is to try and get around duff servers... (e.g. http://www.batalarms.co.uk/). Save dialogues shouldn't flicker when options that don't change the filetype are selected (before, the draggable sprite was always reset for each selection). Noticed the erroneous setting of a static variable in SaveFile.c by a call to this by SaveObject.c, and so added a flag to savefile_set_filetype to deal with this - would have been possible to get the wrong filetype sent to applications or at best the wrong filetype sprite in the dialogue without that. The caret shouldn't jump out of a form back to the URL writable if the page reformats now. Table background colours now supported (as in the colour you see in the border space if the cellspacing is large enough; this is as in MSIE, not as in Navigator). Drawfile output routines updated accordingly. Corrected erroneous use of wimpt_dx() / wimpt_dy() in a couple of places in Images.c, which meant that (say) 1x1 images didn't work correctly in medium resolution display modes. Now have support for save as text (component ID and event 0x12) and save as Draw (component ID and event 0x13) buttons. Dubious conditions for greying and ungreying the print, save source and view source buttons and menu options sorted out as part of implementing the same for the two new buttons; added greying out of their associated menu items in passing. Turned kerning on in draw file objects (does mean a rather heinous increase in file size, but this is the only way to ensure the draw file matches the visible page). Comments before functions in SaveDraw.c are now complete and up to date. Image and visit histories now generate a crude hash number to speed up searching for items. It does give a speed increase, though it's a disappointingly small one. Issue of left/right margins and cellpaddings sorted out. Now have redraw_left/right_margin for finding out the basic gap you must leave. redraw_left/right_gap then gives any extra indentation for LI, BLOCKQUOTE or whatever. The last two can be subtracted from the display width to get an available page width for any section of text. Note that redraw_left_gap replaces redraw_margin. The redraw_start_x function uses the above to work out where a line's left hand edge should be, taking account of left/right/centre alignment. HRs have been fixed now (they were quite broken in v1.30, I think) based on this new model and the behaviour of MSIE/NN 4. Fixed width of cells with no contents - cell padding values wouldn't have worked properly as the reformatter returns 0 rather than the left hand margin size if given no stream. Removed FM_Absolute flags for Font_Paint (spotted by DBrown) - sets bit 2, which is reserved...? IMG width and height in % terms now works correctly; a % of available width (after margins and indents) or height on the main page or for a table cell, if the image lies in one. Because of the chicken-and-egg problem with the latter, the cell must specify a width and/or height for things to work properly. If this is not done, you'll usually end up with a 1:1 scaled image (as in Navigator 4, rather than ending up with no image or even no cell (!), as in MSIE 4). HEIGHT attribute on a TABLE tag is supported, but only in a crude fashion; the extra height (if there is any) is distributed over the rows in a linear fashion. This is probably all you have to do in practice, but I haven't checked. To maintain a notion of min/max height as well as width would of course require a great deal more work... If using client pull to reload a page with a fragment ('...#name') specified, then the reload wouldn't work on the same page; it'd just jump to the fragment position. This won't happen if b->reloading is set now (so works in conjunction with client pull on the same page forcing a non-cached fetch). Similarly, if POSTing to such a URL, a fetch will proceed (both these fixes done originally for http://jupiter.beseen.com/chat/rooms/g/1678/). browser_inherit split to browser_inherit and browser_inherit_post_data; the code for the latter didn't clear any post_data in the child before copying from the parent either, and could cause flex errors (now fixed). Res file for Ursula ('Desktop' Browse) build tweaked - bits in the font choices dialogue renamed, and button bar rearranged to hold the new Save As Draw button. Other builds have had Save As Draw and Save As Text buttons added, or not, depending upon availability of suitable sprites, required UI simplicity, etc. Now have: Browse$ChoicesFile Browse$ControlsFile Browse$ChoicesSave Browse$ControlsSave (the last two are new) for loading and saving of the Choices or Controls files. If unset, <App$Dir>.Choices or <App$Dir>.Controls will be set. E.g., you could set Browse$ChoicesFile to be: <App$Dir>.Choices,Choices:WWW.(app).Choices for loading and <Choices$Write>.WWW.(app).Choices for saving. (The browser never saves Controls at the moment, so the relevant variable above isn't effectively implemented, but could be in future). Similarly, to support asymetric loading/saving of the Hotlist, there are HotlistSave, HistorySave and ImageHistorySave entries in Choices to complement HotlistPath, HistoryPath and ImageHistoryPath (which are used for loading). save_save_choices will create directories as needed to obtain the given path (and has also been fixed in various areas that hadn't been tested out until now; e.g. zero termination of the AppName$ChoicesFile variable expansion...). !Run[D] files updated appropriately. Table widthing code rewritten. Slower, but a lot better on the whole. Still has some problems - still needs a final 'make sure nothing is below minimum width' scan, which it should be possible to do without. No time to fix this at present! The reformatter will now 'glue together' an LI token followed by any non-LI token; so a bullet point followed by an item should not be able to have a line break inserted after the bullet because of very tight width constraints (it could before - yuk...). 'about:' brings up a page about the browser and any Plug-Ins, as with Navigator (for example). URI files support titles, as per spec. version 8. Saving a current location to the Hotlist will thus give a sensible title now (unless you're in a frame, so there's no title to get...). Of course, v1.00 files without a title still work. Note that NOBR is *not* supported in this build and this combined with the new table widther may cause problems on some sites (e.g. Microsoft's home page!).
-
- 18 Dec, 1997 1 commit
-
-
Andrew Hodgkinson authored
Not all resources are up to date in this check-in, and documentation both within source and stuff in 'Docs' is out of date or missing - I was very pushed for time on this one... Hopefully will do another 'tidy up' check-in before close on Friday; until then, beware of anything other than the Ursula (Desktop browser) build. Anyway... Export As Draw done. As part of this, FONT SIZE and SUP / SUB adjustment of font size is done in fm_token_font_info rather than fm_find_token_font. Bullets and switches are plotted as indirected sprite items, rather than indirected text + sprite items - this relied on being in a redraw loop to pick the sprites up from the local pool (failed during printing). URI files now have a LF line ending rather than CR... '*' recognised as an empty field when loading via. RAM transfer now (only worked for loading from disc before). Gave placeholder bounding boxes 4 OS units more minimum extra gap vertically and reduced horizontal addition to this value * 1.5, rather than * 2 (see reformat_get_placeholder_size). Background image tiling starts at ymax - h + 4, rather than ymax, so there isn't the bottom line of pixels from the top tile always present at the top of the window. The '+4' is for caution's sake. Can now save a frame's HTML source, that of its parent or its ancestor, and the same for the URI pointing to those documents - see Menus.h for the relevant component IDs that should lead to the SaveFile dialogue. Have hopefully fixed timeout = 0 values (i.e. 'forever') on things like LinkTo; before, image fetches could override the state (so you'd only ever see brief flickers of a given URL as the pointer went over a link). Save File dialogue will remember the state of option or radio buttons for a given parent component origin and restore that state when the dialogue is next opened from the same place (stops turning on saving as a URL file also turning on 'save background images' for Draw file export, etc.). Use of a META tag to reload the *same* page now sets the 'reloading' flag in the browser so that it doesn't go through a proxy - otherwise pages which are meant to update periodically through client pull don't work, as they keep coming out of the cache. Can now handle images specifying just a width or height in the HTML (other dimension is scaled accordingly, but note that the placeholder size must still be 'dumb' until the image data comes in). An image will now override an image history size entry for the same entry with a different size.
-
- 12 Dec, 1997 1 commit
-
-
Andrew Hodgkinson authored
There are a few known significant problems with this code but it's being checked in so the Choices can be worked on. Note that Res files etc. are not up to date across all builds. Progress is as follows... Bug report prompted me to do this - now ignore <p> tags straight after <li> tags, so '<ul><li><p>Some text' works as the author (or automatic generator, more commonly) intended. A <p> tag before a table will be acted upon now (it was ignored before). Something like <li><p><table...> will give a line break and paragraph space after the <li> despite the changes mentioned above, as in other browsers. Both browsers differ from Navigator, where the table appears alongside the <li> tag. Multiple BR tags work as in MSIE / Navigator (they don't collapse to zero height anymore). For the above, line height (and so, <br><br> or <p> spacing) is now calculated inside reformat_text_line_height, and is used with either a token to get the text height at a given size (e.g. for general line spacing or multiple BR tags) or NULL for normal size text (e.g. for P spacing, though this value is in practice later scaled by 7/8ths in reformat_check_height). Note this behaviour is exhibited by MSIE 4; v3 gave two BRs the same spacing as one P (i.e. not font size dependent). Save dialogues can have an option button or couple of radios to switch between various formats (e.g. URI or URL, sprite or original format). See 'Docs.Notes' for more. The back-end to this is now implemented (i.e. at the moment, save as URI or URL, save as original image format). Note that when saving background images, a leafname based on the original fetch URL is now offered rather than a generic 'Background'. Internal URL scheme changed to be all lower case, so relativisation through URL_Fetcher still makes sense... :-/ Holding down 'shift' when clicking on stop reverses the interpretation of the Controls file 'StopWebServe' entry. Fixed row / column count for exporting tables as text; fixed a few bits and pieces of internal URL scheme stuff which got broken when HTMLLib started using URL_Fetcher's relativisation.
-
- 04 Dec, 1997 1 commit
-
-
Andrew Hodgkinson authored
Fixed some glitches in the modified status bar code (e.g. status inference wasn't working properly). Shift+Toggle size always opened to not obscure the icon bar. If CMOS is set to always show the icon bar, then Shift+Toggle size is meant to reverse sense and open to absolute full size. It now does this. !Run[D] files now require URL 0.22, HTTP 0.64, FTP 0.22, Gopher 0.08 and File 0.32. Minor overhaul of 'Docs.Notes' (with 'Docs.User' similarly updated) to include a few new bits and pieces. Timeout values of 0 now mean 'forever'. Plug-in status messages now have their own timeout setting. New Messages token 'Actv' for extra info when a status message times out and the status line drops to 'Viewing' or 'Ready' when there is still a Busy state registered by the Plug-in. Small Fetch windows don't become visible briefly for Plug-in fetches when the fetch is complete (for SeeFetches:no, where these windows should be hidden all the time). WebServe may be controlled through the Browse front-end via. Wimp_MAppControl reason code 4 (Wimp_MAppControl_Configure). Note the renaming internally of 'WebServ' or 'WebServe' has been changed to 'Proxy' (with lower case equivalents where relevant); proxy name and starting details come from the Messages file 'ProxyName' and 'ProxyComm' tokens. More in 'Docs.Notes'. Res files updated for image history and PRE/TT font aspect ratio choices. 'Don't expire' labels changed to 'Expire' (oops, didn't notice the change in the development Browse's Res file when I updated all of the others until now...). When printing, Wimp_PlotIcon appears to ignore R4 and R5, plots 'somewhere' on the page, and tries to get the sprite from the global pool. This latter part normally causes an error to be raised; though on my machine I just get a corrupted error message. The Desktop font gets lost at this point too. All have yet to be fixed; as an interim work around, Wimp_PlotIcon objects are never drawn at all if the global 'printing' flag is set.
-
- 26 Nov, 1997 1 commit
-
-
Andrew Hodgkinson authored
Image history - sizes of images are remembered for future reference (if the sizes aren't specified in the HTML, they can be looked for in the image history instead to minimise reformatting requirements). Choices file options ImageHistoryPath, ImageExpiryAge, ImageMaxSize and SaveImageHistory added to support this (all have a direct analogy to the global History items of the same name after removing 'Image'). Text area items are now the correct height for the number of rows specified in the HTML, don't scroll a line too early, and have the caret placed at the start of the text when moved into from above or at the end when moved into from below (rather than always at the end, which was behaviour inherited from single line writables, where this is desirable). The top of the text area is aligned to the top of any line of text on the same line, with the text area dropping below the text, rather than the bottom of the area matching the text baseline and extending upwards. Filename extensions for download files are only stripped if an attempt to convert to a RISC OS filetype through the Mime Mapper module does not return an error or Data (0xffd) filetype. '.cgi' is a special case which is always stripped. Altered heading styles - all are bold, none are italic, H3 is as big as H2 was, H2 is a little larger, and others scale down to H6 being the size as normal text (but, as I say, bold). Sorted out tables and forms. We can just look for tagno=TAG_FORM, and get rid of the wobbly form_flag; also discarded the redundant reprocess_table flag in fetch_preprocess_token. Two separate forms in consecutive table cells (for example) which used to fail - they were submitted as one single form - will now work correctly. Fixed nasty bug in FontManage.c where font size 7 would intermittently fail. The stupid font sizes that it could ask the Font Manager for may be responsible for the occasional Font Manager crashes that have been noticed. Array for font sizes was declared as [Limits_FontSizes], but indices 1 to Limits_FontSizes are actually used - so needed a '+ 1' in the declaration... :-/ Replaced the case insensitive string comparison functions in Utils.c with more efficient versions by S.Brodie. MAXLENGTH specifier in INPUT tags is now supported. If unspecified or specifically zero, the browser overrides and allows any length.
-
- 19 Nov, 1997 1 commit
-
-
Andrew Hodgkinson authored
This is an intermediate check-in to allow work on Choices for the new table options and History choices as detailed below. Res files are not up to date except where indicated and there are several known bugs that will be fixed before the 'final' v1.27 is created. Any work on resources should only be done for the testbed !Browse. Client side image maps implemented. There is code to draw highlighted borders in CSIM.c, but this is not wired in yet; other than that, the implementation is functionally complete. As part of this, centralised the fetching of a targetted URL taking into account user request of a new view and full screen mode, in fetchpage_fetch_targetted. The forms library now uses this too, so form buttons respond to both adjust-clicks and TARGET attributes. Fixed APPLET handling where '.class' isn't present in the CODE attribute. Paragraphs squashed at the top of cells/pages - browser would insert white space before. Now append a ' ' to the end of History menu items to prevent the Wimp thinking the end of entries represents a keyboard shortcut (e.g. 'Home'). Netscape's handling of 'meta http-equiv="refresh"' is to start counting when the fetch has completed and everything else has died down. The browser will now not start counting until the animation handler is deregistered (so formatting is complete) to show similar behaviour (note that this checks the main handler, not the 'idle but returning to first frame' drift handler). URLs from requests for fetches by Plug-Ins are now relativised. Page width change tolerance prior to reformat upped from 16 to 32 OS units. Hoping to provoke a loosely connected bug with this change! TableOuter, TableInner and SeeFetches choices added to all Choices files, with appropriate loading and saving code in Main.c and Save.c. AuthorFTP and AuthorFSh messages added for FTP authentication, and dialogue handling code (the component in FetchHTML.c) updated to recognise an FTP fetch and alter the dialogue presentation appropriately. All Messages file version numbers taken up to 1.27 (20 Nov 1997). Following a UseNet suggestion, Ctrl+Toggle Size will increase the window size to fill the screen vertically only; horizontal size/positioning is not changed. Shift+Tab in the URL writable will cycle through alternative fetcher protocols (from both the Controls file and checking the fetcher modules are actually present). Hotlist doesn't require '://' in URLs when loading HTML, just ':/' - so 'file:/' URLs now will be reloaded correctly. History system rewritten completely. GHistSize and VHistSize options removed, and replaced by MaxSize and ExpiryAge. Now have global history menus with most recently visited items at the top, and local history menus which reflect the path that forward/back buttons would take. Browsers are robust to background expiry of the History though this is not implemented - date expiry and size checks are carried out on history_record only. This does mean that with two windows open one could have the history expired underneath it whilst another fetched, though; the code handles this and update toolbars (greying items) as necessary. It is possible to have the history limits so tight that even one entry will not fit and again the code copes with this, though values read from Choices are limit checked to ensure rather more useful results! Implemented 'Save' button in save dialogues. Remembers pathnames and just replaces the leaf now (hard coded exceptions for <Wimp$Scrap>... and <Wimp$ScrapDir>...) - it did before, but only if you'd typed the path in. Not many people did, given that you couldn't press Return or click on a Save button to use that path... In a similar vein, files of type Data or DOS will be checked for a '/xxx' type extension and the MimeMap module will be used to find a more meaningful filetype. If this can be handled, the file is loaded. This only works for files dragged to the browser - the behaviour with inline data in web pages will depend on the File module, and similarly, if File doesn't spot what is going on and claims that the object is data, the browser will just open a save dialogue for it. !RunD files taken up to 3072K WimpSlot. Hotlist's saved HTML page title wasn't internationalised - is now. This opened up a significant can of worms; on file write error, the file would never be closed, and if a caller of the save or load functions passed in a filename held in the global Messages lookup buffer then subsequent lookups in the callees would corrupt that filename. All sorted out now. Local (not very useful) or global (useful) histories can be saved as HTML, which opens up the possibility of sending your history to the hotlist by saving to it. Local and global histories can also be emptied, though this is probably not a feature that current release Desktop browsers need. Inheritance of local history and certain UI features is now done more or less for all cases where one browser window spawns another, too. Vertical alignment on images is rather less ropey than it was (e.g. ALIGN=TOP stands half a chance of working) but is still far from perfect. This was part of fixing a nasty little bug in Redraw.c's setting of an image position via. image_set_token_image_position, which was making (amongst possibly many other things) client side image maps fail. Image update where images had large borders was affected by a similar problem too (more cans with more worms...). Fixed image background filler functions; two problems. When cross referenced images were replaced by base images in a browser because the original owner was closing down, the original owner browser would stay registered with ImageLib. Fixed; secondly, when images were deleted from the image array causing those above to be renumbered, images registered with ImageLib did not have their numbers updated (this was the one that lead to the visible drop out of background images with PNGs on the Acorn Internet home page when there were two views of the page and the first was closed). This is now also sorted out.
-
- 05 Nov, 1997 1 commit
-
-
Kevin Bracey authored
Stopped UNIFONT forcing system font use and added calls to Font_WideFormat. Made sure the system font option is read before fm_init is called! User agent string now set if Netscape faking is disabled (format used is "Acorn Browse/1.26 (RISC OS 3.71)".
-
- 30 Oct, 1997 1 commit
-
-
Andrew Hodgkinson authored
Removed 'The Onion' link from some Hotlist files. Time showed that the site wasn't entirely Family Friendly (TM)... Removed Shift Control (it's gone offline now), and corrected the Telegraph URL from ...the-telegraph... to just ...telegraph... StrongHelp manual generator now tries to work out the number of lines in the table on the root page more intelligently. Plug-in support extended to handle Shockwave. Quite a lot of underlying work for this, including a pseudo cache system for temporary files. Bug in redraw routines: they plotted background images within table cells, when nothing should have been drawn. Oops. When background images in cells are properly supported, this can get sorted out. Tweaked vertical plot position of HRs (up to 4 OS units too high before due to rounding). Various Res file bits and pieces, Ursula build taken up to v1.26 beta for release on the Browser site. *Note* not all resources are up to date! This will be done after AW97.
-
- 22 Oct, 1997 1 commit
-
-
Andrew Hodgkinson authored
fetch_get_raw_data will notice if up->fetching is zero and return a 'finished' status rather than trying to continue reading data for the fetch. Fetches should never fall through that far but at least it will cope if they do. 3D table borders are now supported. 2D borders are used if the inter-cell spacing is too small to fit the borders in (display resolution dependent) - the external table border is 2D if the internal borders are, else 3D. For cellspacing of 0, internal table borders must plot over the outer edge of pixels inside the cell; for all greater spacings, the borders take up all or part of the gap between them. The external border will always fit around the outside of the cells, including the cellspacing value in the gap between the outer cells and the border. Anti-alias colour for placeholder ALT text was incorrect. Fixed. I'd changed 'point' to 'points' in some of the Font Choices dialogues; now changed back to 'point'. The routine to find out how large an otherwise unsized object or image placeholder based on its ALT text has been centralised in Reformat.c, so that the image and object routines can both access it without code duplication (this means non-image objects will now have the correct size if they contain ALT text, rather than assuming a standard default size as before). ALT text in images that were also objects was never plotted either, though the placeholder size would have been correct. This has been fixed.
-
- 20 Oct, 1997 1 commit
-
-
Andrew Hodgkinson authored
Main.c, so the last log was incorrect; Navigate menu items wouldn't have been greyed out. Probably a(nother?) CVS update screw up on my part; now fixed. This sort of thing is happening far too often... Font manager would crash in system font or if a font face was not found in the previous release - that hacky business of returning weird font handles when system font is to be used instead ensured a rather less than valid array reference on behalf of fm_claim_basic_typefaces. Added in a few more calls to the 'check the button bar' routines, to ensure that things like Stop are greyed/ungreyed when needed. Cellpadding code could lead to rmarg overlapping lmarg, or the sum being greater than dwidth, or something like that (!) in the reformatter. Anyway the results were unpleasant; this has been sorted out by range checking right and left margins w.r.t. display width in the relevant section of the code. People who specify 'td width = 2000' in tables expecting to get something sensible now do, though I was half inclined to leave it alone... I can only assume that they don't know about % specification or it didn't work in their browser at authorship time, and the huge width served as an attempt to get the table to fill the available window width. Anyway, the table reformatter spots when the maximum width a cell requires is less than half of what it asks for, and ignores the width specifier if this is the case.
-
- 18 Oct, 1997 1 commit
-
-
Andrew Hodgkinson authored
Sorted out Res files, including fixing position of 'bytes' label in one of the Choices dialogues (I'd missed it out of a selection when everything else got moved down a bit). Unfaded Enc_Chinese menu entries, made sure text labels were wide enough for system font, changed 'Apply' on Choices dialogue to 'Set', and added ^K to hotlist keyboard shortcut lists. Print Setup (i.e. Print dialogue) buttons all set to 'local', so the stupid Toolbox doesn't close the dialogue and lose the caret before I can see if it was in there to start with... 256 colour hotlist sprites taken back to standard 16 colour versions, since there's a significant speed penalty on slower machines. The testbed browser still has the 256 colour versions so the designs aren't completely lost. Changed access settings to exported builds to wr/r - lr/r was really getting on my nerves whenever I wanted to try something temporary out. View source, save source and print handlers would all try to work if there was no source to act on - despite the fact that toolbar buttons would be greyed out form them. This is fixed. The Navigate menu has components greyed to match the toolbar state, when opened. It isn't kept up to date dynamically, though this shouldn't really be a problem (reopen the submenu...). As part of this, finally sorted out conditions for the Stop button to be greyed, or the GoTo/Go/Stop tristate to be at 'Stop' versus 'GoTo'. Deferred reformatting is now disabled for external image fetches. Browser-local client pull flag removed; hitting the Stop button simply cancels any null handlers working for it. That way, client pull switches back on in passing at the next fetch (it was never really switched off). So to stop client pull, hit the stop button at any point. Done CELLPADDING attribute; cellpadding field in reformat_cell (Global.h) is redundant since the table token is accessible from there, and so it has been removed. CELLSPACING support also added.
-
- 03 Oct, 1997 1 commit
-
-
Andrew Hodgkinson authored
Updated Res files in appropriate builds to hold various (similar) Choices designs. Choices related menus were flagged as Shared, but none of the dialogues (including ColourDBox) were - potential future problems, though shouldn't cause any leaks at present. This has been sorted out anyway. Encoding function encoding_init no longer returns an error from toolbox_create_object, so the Encoding menu and all those attached to it do not have to be present (e.g. the Customer build). SUB, SUP, STRIKE and U supported. U underlines the baseline of the body text font, whilst STRIKE will go through roughly the middle of the lower case chars even if the font is SUP or SUB. Note that Navigator appears to shift the underline point for SUB and SUP; it may be necessary to copy this behaviour, but testing on real sites must proceed before that. There could also be a problem with the automatic lowering of font size, which Navigator doesn't do, so any FONT SIZE = -n commands could make it too small. Again, this needs testing on real sites. 'http://' is added to URLs with no protocol specified, unless they start with 'ftp.', in which case the new behaviour is to add 'ftp://'. Choices code altered to do less error checking on components! They should be able to be missing without raising errors. Referencing of the subwindow array changed from *(subwindows + number) to subwindows[number]. Made trace_tag_name code look pretty... reformat_useless_token now checks tagno is non-zero. User Agent string setting now done through URL_GetURL, on a per-session basis. Ellipsis character removed from all Messages files, replaced with '...'. There's little difference between the two in an outline font, and in System font the latter looks much better. Smart quotes left in, as they look better in all cases.
-
- 18 Sep, 1997 1 commit
-
-
Andrew Hodgkinson authored
Image deletion routines rewritten; nasty animated GIF bug now gone (it kept trying to update the cross-referenced image in the browser that no longer existed, and I've no idea how animated GIFs ever managed to *not* blow up if a cross referencing browser was shut down; and I've tested this...). There are now as many image structures as there are total images in the visible browsers, and no more; cross referenced images in the to-be-deleted browser have their ownership moved to the cross referencer before the cross referencee is wiped, with any required fetches being transferred with them. Reformatter sped up a bit by getting rid of strlen on the main text field of tokens in all places bar one, where it is called extremely rarely. This means direct app-to-app transfer of, say, a 359K text file to the browser won't run like a drain as it tries to do strlen on a 359K string over and over again! Most of the time the performance benefits won't really be noticable, but on the above text file, formatting time went down from 290 seconds before the change to just under 7 seconds, a 41 fold speed increase or thereabouts (SA110 228MHz). MakeFile changed to force function name compilation on for debug builds (-fn in the DD...FLAGS); useful for certain functions such as register_null_handler, which can now output the name of the function being registered. ...Which helped show up some nasties in the animation handler and animation drift handler registration/deregistration process, which have been fixed (callers of fetchpage_release_nulls were unaware that the drift handler could be installed, and fragments of old code checking choices.anim_drift had a value other than 1 or 0 were still hanging around - bit tricky for a single bit item). Added support for VALIGN in table cells. Spotted a bug or two in the 'what token is the pointer over' routines as a result, and fixed them - the worst was in browser_line_at_y, which checked the y coordinate was below the given one [the mouse], but didn't check the line height to see if the given y coordinate was *within* the line, rather than just above it. Never used to matter pre-tables, but a definite concern once multiple line arrays can exist on one page.
-
- 03 Sep, 1997 1 commit
-
-
Andrew Hodgkinson authored
File fetches now set DEADDEAD during the fetch, Data if it is aborted, or an appropriate filetype when finished. If the fetcher routines return a zero or data filetype, the browser looks at a set of hard coded filename extensions to try and determine if there's a better filetype to use (urlutils_filetype_from_url) - since this is a centralised routine it can use a Mime mapping system (or be removed entirely) as and when one becomes available. You can now drag URI / URL files to the Hotlist window to add them to the list. They are added roughly where dragged to. (NB, note that I renamed the function to return the window ID - just being picky; it matches other similar functions now). Oh, and hotlist_add_position actually works now ;-) The global history will save when titles are added, as well as when a URL is added. Before, a browser crash could mean a title got dropped out of the history file even if SaveHistory was set to 'always'. SaveObject sources have been added but nothing references them or links them in yet - they're not finished. Mostly checking this one in because of the hotlist changes.
-
- 02 Sep, 1997 1 commit
-
-
Andrew Hodgkinson authored
This version is being checked in because the Hotlist manager in the test build provokes a Wimp bug. All the variant resource files are out of sync and there are several outstanding bugs in the main code, so I'd personally avoid this build like the plague unless you're mad enough to want to examine the Wimp problem ;-)
-
- 31 Aug, 1997 1 commit
-
-
Andrew Hodgkinson authored
Created Protocols source file and moved a lot of message handling from handle_messages - the latter now serves as a high level distributor to lower level functions in Protocols. Incidentally, URL files (as used by the ANT suite) can be loaded by dragging to the browser in the same way as URI files - Not A Lot Of People Know That, etc. Merged new hotlist display type Res file to existing resources, added support for DataSave message so items can be dragged from the hotlist to a specific window (RAM transfer for URI and URL files; ScrapFile for HTML and Text but deleted afterwards and there are appropriate guards to stop Reload just saying 'not found'; images run through ScrapFile and there is no choice but to leave them there and do a conventional fetch). All !RunD files now give a WimpSlot of 2304K. Some small changes to the Argo and Ursula build Res files to make the menu trees more sensible. Controls files now take 'file:/' instead of 'file://' in Protocols section. Definitions at top of URLutils.c *not* altered, as then you end up with invalid URLs - so it will accept 'file:/', but always generate 'file://'. This is because some browsers exports 'file:/'. Sigh. make_no_[..._]memory_error functions now return a _kernel_oserror * rather than void. It's always &erb returned, but it enables users to use a more elegant 'return make_no_memory_error(1);', say, rather than something like 'make_no_memory_error(1); return &erb;'. I obviously should've written it like that at the outset, but never mind. All callers have been appropriately updated. The urlutils_leafname_from_url function now replaces illegal characters (A7000 Welcome Guide p54...) in the leaf with legal alternatives. Internal URL scheme is now a bit cleaner, with everything properly defined in URLutils.h. All references to http:, file: and ftp:, with or without a following '//' use the definitions in here now. More tidying and some reorganising of Hotlist source. Auto-open delay is now a Choices item. Some dependencies on statics removed (e.g. the counting functions don't accumulate into the global item_number now). The redraw functions used Wimp_TextOp - oops, so this has been amended to use whatever is supported on your Wimp. This is now in a new function (utils_text_width()), which the History menu routines also use (there was a bug in the width routine there anyway, which is therefore fixed in passing). Several other routines used Wimp_TextOp directly too, and they have been altered to use the new function as well. In hotlist code, one of the larger changes is in the API to hotlist_draw_r() (formerly _hotlist_draw()) which now takes item widths and heights as parameters - discovering these is quite slow, so doing it every time the function calls itself recursively is a little less efficient than passing the values in from elsewhere. Note that underscore prefixed functions are being slowly renamed to _r suffixed functions, to match the convention established by Tony Cheal with is table routines. This makes it much more obvious when something is recursive, as the same naming convention is used in every browser source file. Finally, note that I intend to ditch SaveDBox and use an alternate window with manual control of the messaging in Protocols.c. This will allow various improvements which at present the SaveDBox operational methods preclude. I'm going to have to do at least an alternate Window object for the SaveDBox module to use soon in any case. Getting rid of SaveDBox will help reduce, if only slightly, demands on the RMA.
-
- 28 Aug, 1997 1 commit
-
-
Andrew Hodgkinson authored
Open URL implementation more or less complete, though may undergo UI revision at a later date to allow named frames to be targetted. Hope to use the ideas in this code as the foundation for other general dialogues. In token stream dump for TRACE builds, table head items were not indented as far as they should have been - this is fixed; and manual toolbar redraw routines have been removed. They never worked, were commented out, and would never be used in that form anyway. DragBox source added, but it isn't at all complete and won't work - this is an 'in spare time' thing. We need custom drag boxes constrained to windows for the hotlist, and unconstrained for frame border resizing... Hey ho. Ancestor window extents match visible areas if there are frames (no more scrolling framesets...!). Frame resizing works whilst new documents fetch without pulling the extent down now. However, frame horizontal extents never shrink until a reload which is nasty, and this is all due for a rewrite. Frames border redrawing routine moved out of Redraw.c and into Frames.c. Bug regarding the mouse rectangle and frame border widths (rectangle was too large, so you could squash the edges) for edge-drag frame resizes fixed. Window width change reformat tolerance fixed; you could creep the window width down or up forever without any reformat, and centred objects would move but not be redrawn (thereby giving rise to subsequent redraw errors). Filetype on objects saved through Shift+Click correct. Save Source dialogue recognises if that source is plain text, rather than assuming HTML. A browser that fetches a file remembers the old store size it had before the save, so even though the data is now ditched, it reports the same amount of data fetched afterwards (looked awful when this could, for example, suddenly say '0' after a file save). Progress indicator is now fully aware of one or many file saves inside a frameset and reports the number of saves, a colon, and the cumulative saved data count, instead of reporting the sum total of fetched data in all frames, including non-file save stuff (note that for just 1 save, '1:' is not shown as a special case for the most common condition). A bug related to this, where you could in fact only do one fetch per frame*set*, has been corrected (only one fetch allowed per frame still, this is unlikely to ever change). Hotlist support added (D.Brown's source), with various bits of integration and modification still in progress there. Note additions to the Messages files. On the subject of Messages, the whole mucky business about what goes in Messages or Choices (and a few bugs where lookup_choice was used instead of lookup_token or vice versa) has been sorted out. Messages contains, more or less, just that. Choices contains user configurable stuff which generally can't mess things up too badly. A new file, Controls, is a Messages file holding the non-user configurable choices, which can generally make things go badly wrong if misused. A lot of these are tied to the Res file. StrongED users can get these to automatically fold out the various sections (EMail me for details). Sorry, but at the time of writing, Zap doesn't do folding... =8*P Two bugs with images. Asking for images to be shown in browser B when browser A uses the same ones and was loaded first didn't work correctly, and now does (a bit weird - browser A does the fetch and browser B does the display...). Second one occurred when the background image was also used on the page as a foreground image. This has been fixed by flagging background images in the image_info structure, and checking this before cross referencing. This bit also allowed the image_restart_fetches API to be extended, so that just background or foreground images may be fetched if they weren't already and the user asked the browser to show them. Before, the whole lot had to be fetched together (so turning on 'display backgrounds' will now kick off an image fetch if required, you don't need to reload the page anymore). Makefile copy options tweaked to be 'newer' (so if you're testing with some temporary Choices file or something, it won't write over it at the end of every export), and REMOTE_HOTLIST flag added for Customer builds - means the Hotlist.c functions aren't needed; the old, hotlist-by-file method is used. Added support for Customer build (see later), though there were very few additions needed in practice. Table printing fixed - in many ways it wasn't broken, it was image printing causing the oddities ever since the global image pool was introduced (this is, again, fixed). The 'reformat to fit page' option didn't work as coded any more; tables store cell addresses in the HStreams, so you can't then do a background reformat in a different browser. Hence, it now has to reformat to the page width, print, then put the page back again, all in the actual displayed browser. This doesn't feel as slow in use as it perhaps should, considering what is going on... Note that a line of a defined fraction (see Print.h) of page height will now split over page boundaries, so tall images or tall tables don't cause problems now (aside from the obvious problem of having the line split over a page at all!). There was a bug in the routine to print from a given start point until 'n' pages had been filled, in that it always filled 'n + 1' - now fixed. Finally, as part of the printing tweaks, a new dialogue exists - PrintStyle - with a similarly named source file added to deal with it. Global history auto save / load done, but only to the Choices file path - the whole browser is still strictly single user at present, with all the extra work for a multiuser Customer environment yet to be done. This has shown up a global history corruption problem which I haven't fixed yet. Rationalising TBEvents.h - things are migrating out of it, and into more appropriate sources (e.g. definitions relating to the Open URL dialogue are going into OpenURL.h, etc.). Event codes were at one stage deliberately diverged in numberspace from the component IDs of typical gadgets raising the events, to avoid anyone getting confused and thinking the IDs and event codes must match. However, this is in fact unlikely and it is much easier to remember the fewer numbers that result from tying the two together where possible. This has resulted in changes to event codes raised in the following objects of all Res files: Authorise, Find, OpenURL, and PrintStyle. And finally - !Run[D] files for all variants updated to require the latest toolbox and fetcher modules. All Res files updated for hotlists etc. and sprites files updated appropriately. All Messages, Choices and Controls files brought in sync., and an Customer build has been added (based on the Desktop build binary with different resources). That's all for now...
-
- 18 Aug, 1997 1 commit
-
-
Andrew Hodgkinson authored
Limits.h, and ensured consistent comment styling throughout all sources. Fetch.c/h split to Fetch, FetchHTML and URLveneer. URLstat.c/h produced to cope with this. OpenURL and Find sources created from bits in the Windows source file that shouldn't have been there... These will get filled out shortly. Note that a few functions in Fetch are due to be renamed and moved; probably to Tokenutils.
-
- 08 Aug, 1997 1 commit
-
-
Andrew Hodgkinson authored
(adding up to a greater whole), which include removal of the dastardly 'invalid image number' errors that trace builds would raise from time to time. Frame highlights are now better controlled (releaseably so). Generally, this build represents the first genuinely promising version of the browser for quite some time, despite the known library problems with comment handling etc.
-
- 30 Jul, 1997 1 commit
-
-
Andrew Hodgkinson authored
-
- 25 Jul, 1997 1 commit
-
-
Andrew Hodgkinson authored
-
- 18 Jul, 1997 1 commit
-
-
Ben Laughton authored
-