Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
HTTP HTTP
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • RiscOS
    • SSources
    • NNetworking
  • Fetchers
  • HTTPHTTP
  • Merge requests
  • !10

Merged
Created Jan 30, 2022 by Matthew Phillips@mphillipsDeveloper

Corrections to domain and path processing when storing and sending cookies

  • Overview 2
  • Commits 10
  • Changes 3

This merge request includes fixes for various bugs, some of which have been detailed on the forum.

  • Failure to load cookie path from file
  • Unexpected meddling with path parameter in HTTP_AddCookie
  • Inadequate substring matching for domains and paths when selecting cookies to send
  • Faulty code when checking if domain and path are valid when handling Set-Cookie in responses
  • Correction to path sort order of cookies

In preparation for adding fuller support for RFC6265, this merge request removes support for the following deprecated cookie attributes:

  • Version
  • Port
  • Comment and support for the following deprecated request/response headers:
  • Cookie2
  • Set-Cookie2 These changes simplify the code in a number of areas where further changes will be required for RFC6265 support.
Edited Feb 01, 2022 by Matthew Phillips
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: FixPathDomainBugs