Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
RISC_OSLib RISC_OSLib
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • RiscOS
    • SSources
  • Lib
  • RISC_OSLibRISC_OSLib
  • Merge requests
  • !28

Merged
Created Jan 23, 2023 by Jeffrey Lee@jleeDeveloper

Remove side-effects of failed SWP detection

  • Overview 1
  • Commits 1
  • Pipelines 6
  • Changes 1

CheckIfSwpAvailable currently uses an error environment handler to detect the case where SWP isn't available. However there are a number of things the OS does before it invokes the error handler which could have unwanted effects - e.g. issuing Service_Error & ErrorV, clearing the hourglass, closing redirection file handles, and setting the CAO to point to the error handler. In particular the latter was found to cause the current disc image + PlingSystem to get fatally stuck on ARM2 machines - when Boot.Desktop runs any *Repeat command, application space was being shrunk to zero when Repeat calls Wimp_Initialise.

Fix these problems by changing the SWP detection to directly hook on to the undefined instruction vector.

See also https://www.riscosopen.org/forum/forums/4/topics/17688#posts-137994

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: FixNoSWP