Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Percussion Percussion
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • RiscOS
    • SSources
    • HHWSupport
    • SSound
  • Voices
  • PercussionPercussion
  • Merge requests
  • !1

Merged
Created Feb 24, 2021 by Jeffrey Lee@jleeDeveloper

Channel 8 RMA corruption fix

  • Overview 0
  • Commits 1
  • Changes 1

Adjust the workspace definitions so that Instance0 has the same address/offset as End_Of_Code, and so that WorkSpaceSize has the value Instance0 + 8*4.

The previous version of the code made the false assumption that the AmountToCopy and WorkSpaceSize definitions wouldn't add anything to the output binary. This resulted in WorkSpaceSize being 4 bytes larger than strictly necessary (due to AmountToCopy before it), but more dangerously, Instance0 was placed 8 bytes after End_Of_Code, causing the code to write off the end of the heap block if the voice is assigned to channel 8.

Fixes https://www.riscosopen.org/tracker/tickets/505 (Percussion variant)

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: FixRMACorruption