Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
ADFSFiler ADFSFiler
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • RiscOS
    • SSources
    • FFileSys
  • ADFS
  • ADFSFilerADFSFiler
  • Merge requests
  • !3

Merged
Created Aug 23, 2019 by Ben Avison@bavisonDeveloper

Correctly detect errors returned from Service_EnumerateFormats

  • Overview 0
  • Commits 1
  • Changes 3

SWI OS_ServiceCall has never propagated the PSR flags from callees back to the caller, so testing the V flag is the wrong way to detect failures. Check whether the service call has been claimed instead, since that is documented as being part of the process of a callee returning an error.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: EnumFormatsErrors