Skip to content

GitLab

Switch branch/tag
History Find file
Clone
Don't access 0xFFFFFFFE if window vanished
Robert Sprowson authored 
The pointer left/entered window logic calls int_get_pointer_info which can return a window (and/or icon) handle of -1 if the pointer is over no window, such as might occur if the window has been deleted.
The check for a duff window handle (in R3) was unfortunately made *after* it'd been dereferenced. Move this check up beforehand.

Fixes issue reported on Usenet https://groups.google.com/forum/#!topic/comp.sys.acorn.programmer/iR0_TNekiKg

Version 5.63. Tagged as 'Wimp-5_63'
87ea8ac2
Name Last commit Last update
..
!Palette Import from cleaned 360 CD
AutoScroll Given a good thrashing.
Iconbar Fix invalid AMB node handle being used when low on memory
Memory Slacken pointer checks
NewSWIs Implement sprite translation table caching
Notes Spinner branch merged.
ProgErrs Import from cleaned 360 CD
RosMod Adapted assembly process so that the choice of Options file (previously based purely on the "System" variable) can be overridden by passing "OPTIONS=foo" as an argument to either MkRom, or to amu/amu_machine directly, or indirectly, by specifying it in the components file for a build. To accomplish this, it was necessary to switch from using aasm to objasm - hence the large number of source files affected in this commit.
Tiling Implement sprite translation table caching
Tiling3D Fix for missing window backgrounds/scroll bars when tiled sprite op not supported
Trace Add support for wide translation tables for window tool furniture
Watchdog Replace OS_SpriteOp reason code magic numbers with definitions. Add support for new screen modes.
Wimp Remove redundant GET
Wimp01 Remove startup delay from power saving code
Wimp02 Remove startup delay from power saving code
Wimp03 Don't access 0xFFFFFFFE if window vanished
Wimp04 Fix for bad error pointer deleting non existent sprite
Wimp05 [399] Menu shortcuts misplaced if the menu has a scroll bar
Wimp06 Slacken pointer checks
Wimp07 Fix crashes when a Wimp_Poll post-filter causes the Wimp to postpone switching to a VFP-enabled task
Wimp08 Slacken pointer checks
Wimp08s Fix invalid AMB node handle being used when low on memory
Wimp09 Implement sprite translation table caching
Wimp10 Fix handling of tool sprite palettes in alpha-blended screen modes