GitLab

* When closing menus, set_caret_position is called to remove the caret from the menu tree
  which tries to redraw the icon without a caret as the window is still defined and valid
* This happens after clearing the menutaskhandle though, so the redraw can't page in the
  right task
* The redraw then fails badly trying to access memory from the wrong task

Version 5.84. Tagged as 'Wimp-5_84'

During destruction of the menu tree, if set caret position fails when resetting the caret to the old position (ie. illegal window handle as the window has been deleted) then destroying the menu tree also fails with catastrophic results.
Therefore
* Do not fault SetCaretPosition to invalid window handle, just change it to -1
* Do not try to redraw areas of an invalid window when moving caret

Version 5.82. Not tagged

Version 5.79. Tagged as 'Wimp-5_79'

When clicking in window to move caret to another icon, remove any selection from other icons in the window to prevent unwanted user deletion of text in the selected icon.

Version 5.70. Tagged as 'Wimp-5_70'

Detail:
  If R0=valid window handle, R1<0 (not an icon) and R4=-1 then R4 is internally set to 'invisible caret' to ensure that we get the full input focus event and visible cues.
  Ref: https://www.riscosopen.org/forum/forums/5/topics/14945?page=2#posts-97886
Admin:
  Submission for Clipboard Support bounty.

Detail:
  Summary of how non-CnP Wimp treats the window handle for Wimp_SetCaretPosition
  R0 = valid window handle
    or invalid window handle (mapped to -1)
    or any negative number or 0 (mapped to -1)

  With this change, the CnP Wimp does
  R0 = valid window handle
    or invalid window handle (throws error)
    or any negative number or 0 if pre RISC OS 5 (mapped to -1)
    or 0 for RISC OS 5 (mapped to -1)

  Noting the use of AcceptLoosePointer macro if built for a 26 bit target.

Detail:
  In CnPCaret.s
    * Clear any invalid window handles currently stored in caret blocks on Wimp_SetCaretPosition entry
    * Clear R2 on exit if R0=-1,R2=TASK on entry to Wimp_SetCaretPosition
    * If window is not open or able to receive a focus, then return WimpFocus error rather than causing an alignment exception
  In CBTask.s
    A drag to writeable with invalid (eg.rejection due to validation string mismatch or overlong insert) caused ghost caret to be left behind and still deletes the source text.
    * Changed LDR R2,=cbtask_TASK to LDR r2,cbtask3_TASK
    * Ensure cbtask_insert_text_into_icon returns V set on error
    Drag and drop text from icon to non-d&d application, the last message was erroneously sent as DataSaveAck, not Dataload
Admin:
  Submission for Clipboard Support bounty.

Version 5.66. Tagged as 'Wimp-5_66'

Detail:
  The text in writable icons can now be manipulated using the familiar keyboard shortcuts, or using Drag and Drop in conjunction with any compliant applications.
  Further details are in Doc/DragAndDrop along with information on API extensions which are implemented.
Admin:
  Submission for Clipboard Support bounty.

Version 5.65. Tagged as 'Wimp-5_65'