Commit 80a42a8c authored by Jeffrey Lee's avatar Jeffrey Lee
Browse files

Update checkhandle to check that window pointers are word aligned

Detail:
  s/Wimp04 - The checkhandle* routines now checks that the window pointer is word aligned before attempting to load any data from it.
  This prevents alignment faults on ARMv6+, and should result in more accurate sanity checks in general.
Admin:
  Tested on rev C2 beagleboard.
  Fixes issue reported on forums:
  http://www.riscosopen.org/forum/forums/5/topics/517


Version 5.10. Tagged as 'Wimp-5_10'
parent b68b72d7
......@@ -11,13 +11,13 @@
GBLS Module_HelpVersion
GBLS Module_ComponentName
GBLS Module_ComponentPath
Module_MajorVersion SETS "5.09"
Module_Version SETA 509
Module_MajorVersion SETS "5.10"
Module_Version SETA 510
Module_MinorVersion SETS ""
Module_Date SETS "26 Nov 2010"
Module_ApplicationDate SETS "26-Nov-10"
Module_Date SETS "04 Dec 2010"
Module_ApplicationDate SETS "04-Dec-10"
Module_ComponentName SETS "Wimp"
Module_ComponentPath SETS "castle/RiscOS/Sources/Desktop/Wimp"
Module_FullVersion SETS "5.09"
Module_HelpVersion SETS "5.09 (26 Nov 2010)"
Module_FullVersion SETS "5.10"
Module_HelpVersion SETS "5.10 (04 Dec 2010)"
END
/* (5.09)
/* (5.10)
*
* This file is automatically maintained by srccommit, do not edit manually.
* Last processed by srccommit version: 1.1.
*
*/
#define Module_MajorVersion_CMHG 5.09
#define Module_MajorVersion_CMHG 5.10
#define Module_MinorVersion_CMHG
#define Module_Date_CMHG 26 Nov 2010
#define Module_Date_CMHG 04 Dec 2010
#define Module_MajorVersion "5.09"
#define Module_Version 509
#define Module_MajorVersion "5.10"
#define Module_Version 510
#define Module_MinorVersion ""
#define Module_Date "26 Nov 2010"
#define Module_Date "04 Dec 2010"
#define Module_ApplicationDate "26-Nov-10"
#define Module_ApplicationDate "04-Dec-10"
#define Module_ComponentName "Wimp"
#define Module_ComponentPath "castle/RiscOS/Sources/Desktop/Wimp"
#define Module_FullVersion "5.09"
#define Module_HelpVersion "5.09 (26 Nov 2010)"
#define Module_LibraryVersionInfo "5:9"
#define Module_FullVersion "5.10"
#define Module_HelpVersion "5.10 (04 Dec 2010)"
#define Module_LibraryVersionInfo "5:10"
......@@ -5825,6 +5825,8 @@ checkhandle
; Check the window structure for being inside valid memory
;
Abs handle,handle
TST handle,#3
BNE errhandle ; If it's not word aligned, it's definitely invalid
MOV R0,handle
ADD R1,R0,#w_size
Debug valid,"WIMP validating: ",r0,r1
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment