GitLab

If an error occurs during an operation (for example, during a copy move where the source is on a read only medium) the status window changes to an error window with "Abort/Skip/Retry". The skip and retry options call read_next_node_parameters() to peek the next queued item, but would attempt to OS_File 5 of a NULL filename if the error happens when there are no more.
Check the next_nodename isn't NULL to avoid an abort in OS_GSInit with zero page protection enabled.

Version 0.62. Tagged as 'FilerAct-0_62'

Detail:
  c/listfiles - If the first call to enumerate the contents of a directory fails (e.g. when trying to step into a bad image file), next_entry_to_return will be left at a value >= entries_in_buffer. This doesn't impact the operation of the state machine, but it will cause a null/bad pointer dereference in the user interface code when switch_buttons() calls read_next_node_parameters() and the code attempts to construct the path name of the current object. Fix the issue by terminating the path if an invalid cache entry index is found.
Admin:
  Tested on Iyonix with zero page relocation


Version 0.61. Tagged as 'FilerAct-0_61'

Message_FilerOpenDir renamed.

Version 0.60. Tagged as 'FilerAct-0_60'

An else clause was being run for both the "write not complete" case but also when an error had occurred in an earlier step. The error would generally be a failure to create and hence a file size of zero. Bang.
Steps to recreate (other, more obscure and hard to catch cases exist)
 1. Open ResourceFS
 2. Copy Resources:$.Resources to Resources:$.Apps
 3. As ResourceFS is read only the reads all buffer OK but the first write (should return 'read only') gives divide-by-zero

Version 0.59. Tagged as 'FilerAct-0_59'

Detail:
  c/memmanage - An earlier fix to prevent directory filetypes being applied to image files had the unintended side-effect of stopping image file types being applied to anything other than an existing image file.
  Check has now been revised to only limit the application of directory types to image files; there's no need to worry about image file types being applied to directories, as the filer won't let you copy a (image) file over a directory in the first place.
Admin:
  Tested on Raspberry Pi with high processor vectors


Version 0.58. Tagged as 'FilerAct-0_58'

Detail:
  Was doing a cimple copy of the load/execution and attribute words from the
  source to the destination. However, for directories the filetype bits in the
  load address are always &FFD (data) and the user access bits are always 0
  (even though all directories actually have user read/write access). Now
  these bits are left alone when updating an image file from a directory.
Admin:
  Tested on a Raspberry Pi, doing a partial update of !Boot.Loader image file.

Version 0.57. Tagged as 'FilerAct-0_57'

Version 0.56. Not tagged

Version 0.56. Tagged as 'FilerAct-0_56'

Detail:
  c/actionwind - start_operation() wasn't checking if there's any info field text for the current operation, leading to a null pointer dereference when it attempts to look up the right message token via msgs_lookup()
Admin:
  Tested on Raspberry Pi with high processor vectors


Version 0.55. Tagged as 'FilerAct-0_55'

A good rake over the code to change filesizes to be uint32_t not ints.
Change makefile to use StdTools.
Shuffle icon clipping in the templates to allow for maximal numbers by moving the text a bit to the right, still fits even in system font.
A couple more ints swapped for BOOLs.
The memmanage code is largely unchanged and makes extensive use of signed numbers, partly because the wimpslot setting API does. This will all fall over in a big mess if the wimpslot ever gets >2G, but then the API would need changing for that to happen anyway.
Function count_objects_in_dir swapped to use os_gbpb.
Structure search_nest_level gains a 'counted' flag rather than signalling counting is needed by setting the filesize to -1.
Should now be good for up to 4 billion files each of 4 billion bytes.

Version 0.54. Tagged as 'FilerAct-0_54'

OS_FSControl, OS_File, OS_GBPB, OS_Args, OS_Find now use HighFSI.h.
Indentation made more consistent.
Variety of DEBUG macros changed to allow them to be enabled and disabled on a per-file basis.
Put USE_RED_ERROR box switch into options.h (undefined though).
Functionally equivalent to 0.52, but lots of diffs.

Version 0.53. Tagged as 'FilerAct-0_53'

Basically the same as version 0.51 otherwise.

Version 0.52. Tagged as 'FilerAct-0_52'

Was doing a widening cast of a signed number to 64 bits, so showed 16 trillion bytes remaining.
Fix templates to not say "stuff" by default in the name, as this was left on screen if an error occured before processing began.
Things that read from clock() now use clock_t.
Uncurled some "} else {" to match all the other files.
Deleted the USE_LONG_LONG switch, it's been needed ever since harddiscs got bigger than 4G anyway.
Anything assigned 'Yes' or 'No' changed to type BOOL.
Variable 'source_of_finished_file' was signalling that a directory had been copied by setting the length to a -ve number. This has been refactored to use a BOOL instead, so files can have top bit set sizes.
Fix bug in stack grab in count_objects_in_dir(), was grabbing an array of 2048 pointers (=8k) not 2048 bytes.
Functions bytes_left_to_read() and bytes_left_to_write() reprototyped to return uint32_t not signed numbers.
Still falls over copying files > 2G, but at least it gets the display right!

Version 0.51. Tagged as 'FilerAct-0_51'

Rationalised all the switches a bit.
Not tagged.

Progress bar was wrong during a CopyMove operation that required more
memory than the available wimp slot.

Version 0.50. Tagged as 'FilerAct-0_50'

Added progress bar.
Performance improvements, especially in 'slower' mode.
Fixed 'count summary' bug.
Fixed various compiler warnings.

Version 0.49. Tagged as 'FilerAct-0_49'

Detail:
  UK templates updated, Germany templates added
Admin:
  Changes by Detlef Thielsch

Version 0.48. Tagged as 'FilerAct-0_48'

MkClean also cleans dependancies.

Version 0.47. Tagged as 'FilerAct-0_47'

Added functionality from RISC OS 4.02 (Faster button, 64-bit display, number separators). This implementation does not use the Netscape libraries, and looks up the number separation scheme from the current territory.

Now copies directory datestamps, as per the command-line *Copy.

Version 0.46. Tagged as 'FilerAct-0_46'

  Links using -rmf and not -bin and truncate.

Version 0.45. Tagged as 'FilerAct-0_45'

Detail:
  If the system variable Filer_Action$Skip is set (to anything - even the
    null string), then during a Copy operation, Filer_Action will skip
    directories called "CVS" and files called "/cvstag".  Variable is read
    whenever Filer_Action desktop task starts (ie. at the start of each
    copy).  This dramatically reduces the time it takes to copy a checkout
    tree from NFS->RISC OS.
Admin:
  Tested in desktop build.

Version 0.44. Tagged as 'FilerAct-0_44'

Version 0.43. Tagged as 'FilerAct-0_43'