GitLab

Detail:
  s.Commands: Filer_Truncation code to parse OS_ReadArgs output block was
    written on the assumption that LDR allows unaligned accesses - this is
    only true as of ARMv6! We got away with it as long as all the truncation
    widths were <= 65535 OS units - which in practice is easily as wide as
    any screen anyone might use. Nevertheless, this is now fixed to use the
    LDW macro.
  s.DragEnd - d_filesperrow is a 1-byte variable, yet it was loaded using
    LDR. This is clearly wrong and may in part be responsible for offsets
    48-63 of Message_FilerSelection being nonsense (though they are still
    incorrect after this fix).
  s.Redraw - loaded colour values to pass to Wimp_SetColour from 1-byte
    variables using LDR, and hence was setting undefined bits. Harmless with
    current Wimps, but probably not a good idea.
Admin:
  Builds but untested.

Version 2.18. Tagged as 'Filer-2_18'

Detail:
  Uses suffixed file extensions for compatiblity with both objasm and asasm.
Admin:
  Supplied by Peter Naulls, tested at ROOL

Version 2.17. Not tagged

Detail:
  fix for Alt-Select filer renamimg intermittant failure.

  s.msgsin .. replaced EXIT NE after SWI. as NE state not held through 32bit SWI
  file access permissions sub menu window now initialises again
Admin:
  Untested

Version 2.17. Tagged as 'Filer-2_17'

Detail:
  The RO3 style guide states a main menu should be opened at x-64,y.
  Instead the filer was opening it's menu at x-192,y+16.
  This has now been fixed.
Admin:
  Tested on RiscPC RO402.
Notes:
  Changes by James Lampard.

Version 2.16. Tagged as 'Filer-2_16'

Detail:
  Opening a viewer, iconising it then reopening it from its parent viewer or
  the iconbar doesn't remove the iconised viewer icon from the pinboard.
  Sending the message Wimp_WindowClosed (&400CC) when reopening an existant
  viewer fixes this.
Admin:
  Tested on Iyonix RO5.11
Changes by:
  Fred Graute

Version 2.15. Tagged as 'Filer-2_15'

Detail:
  Changed handling of doubleclicks so that after checking for Shift-doubleclick,
  and Shift isn't pressed, it checks if the mouse button is depressed for at
  least 0.2s.
  Implements a loop that runs for 0.2s whilst checking mouse button status, so
  will starve background processes for that time but this is by far the easiest
  way to implement this.
  Also there's no option to turn it off, adding one should be easy though.
Admin:
  Tested on Iyonix RO5.11
Changes by:
  Fred Graute

Version 2.14. Tagged as 'Filer-2_14'

Detail:
  Changed redraw.s so that the largest name in filer window in large icon mode
  doesn't have the text clipped. Added 8 OS unit error margin (line 1844) that
  had already been added in other modes.
Admin:
   Tested on Iyonix RO5.10
   Programmer tested only.
Notes:
  Changes by Colin Granville.

Version 2.13. Tagged as 'Filer-2_13'

Detail:
  When viewing directories on some network filing systems it is possible
  for the directory contents to change without the client knowing, and
  therefore the filer window becomes out of date. This refresh option
  can be used by the user to bring the window up to date without having
  to close and reopen it.
  It matches the same option provided on later versions of RISC OS 4.
Admin:
  Tested on Iyonix RISC OS 5.11
Notes:
  Changed by Alex Waugh.

Version 2.12. Tagged as 'Filer-2_12'

Detail:
  Scroll request used to make the directory viewer scroll with
  a wheel mouse.
Admin:
  Tested on Iyonix RO510. Not sure how this will interact with !HID.
Note:
  Changes by Colin Granville

Version 2.11. Tagged as 'Filer-2_11'

ensure neither large icon or small icon app name exceeds 12 chars even when app name is much longer. Re-enabled Alt-Select for icons whilst leaving Alt-Select renaming active.

Detail:
Admin:
     castle added ip.
     tested in iyonix rom


Version 2.10. Tagged as 'Filer-2_10'

Detail:
         s.Redraw used strncat in 1 place, but didnt initialise the count(n)
         resulted in potential lockup looking for a small app sprite when
         the full app sprite name was the max sprite name length (12)
         .. (i.e. with an app whose name was longer than 12 chars.
Admin:
         castle added IP


Version 2.09. Tagged as 'Filer-2_09'

Fixed abort when dragging a file to another directory display - merging fault in No16bitOffsets merge.

Retagged as 'Filer-2_08'

Version 2.08. Not tagged

Detail:
  * Mered in RISCOS Ltd's fix for directory displays with more than 65536
    bytes of leafnames.
  * Tries to use Wimp_TextOp 4 to do ellipsis truncation. As a result, it
    can now cope properly with:
    + multibyte UTF-8 characters in leafnames (previously this caused
      problems even if not truncated)
    + WimpSymbol character substitution in leafnames
    + alphabets without an ellipsis character
    + fonts without an ellipsis character
  * Sprite icons in 'Copy as' and 'New directory' dialogue boxes are no
    longer filled.
Admin:
  Tested on Tungsten.

Version 2.08. Tagged as 'Filer-2_08'

Reception of message OpenDir was ignoring the flag bit which said whether or not the pathname given in the block was canonicalised - RamFSFiler 0.38 relies on this to expand its root dir viewer.Fixed that.

Adjust dragging dirs to the iconbar was opening them very low on the
screen as GetWindowCoords was just reading the iconbar top left corner -
now a special case overrides GetWindowCoords so it opens in a more
sensible default place.

Version 2.07. Tagged as 'Filer-2_07'

Regressed the name of the "Set work directory" menu item back to "Set directory" in the interests of not widening the menu.

Retagged as 'Filer-2_06'

  * "Directory" string removed from "New directory" dialogue box template.
    Unlike the version shipped in 5.00 and 5.01, this template file doesn't
    have its "Recurse" option button in the "Access details" dialogue box
    deselected.
  * When "New directory" dialogue box is opened, contents of the writable
    icon is now set to a null string, rather than the uninternationalised
    "Directory" that was used previously.
  * Uses OS_HeapSort32 instead of OS_HeapSort when the RMA is high.
  The following are new since then:
  * Fixed rubber dragboxes to use exclusive maximum coordinates, stops you
    dragging the box off the left hand side of the window.
  * Enabled SetDirectory option. Merged in 4.02's SetDirectoryComesFirst
    option, changed token in Messages file to read "Set work directory"
    instead of "Set directory" to match 4.02, and added the missing token
    MH?7? for interactive help.

Version 2.06. Tagged as 'Filer-2_06'

Picked up bug fix from ROL,in 2.04 you could select a file in one viewer and then adjust select a group in another viewer without the first file becoming unselected.

Added test so you're less likely to lose the "rename" writeable icon
when someone's updating filer windows.Now,only if the window being
reopened also has the writeable in it will you lose it.
Adjust dragging dirs to the icon bar will now close the parent (was
only files and apps before).
Create dir and Copy as templates tweaked for 3d borders in UK only as
the German ones are very out of date anyway.

Version 2.05. Tagged as 'Filer-2_05'

Detail:
  * Can now build versions compatible with RISC OS 3.5 or earlier (non-
    internationalised commands were missing)
  * Fixed a mistake in the Messages file that caused suboptimal tokenisation
  * Added a MkRam TaskObey file to ease standalone builds
Admin:
  Tested on Virtual A5000!

Version 2.04. Tagged as 'Filer-2_04'

Version 2.03. Tagged as 'Filer-2_03'

Version 2.02. Tagged as 'Filer-2_02'

  Updated to build using objasm instead of aasm.
  Sources changed to be objasm-compatible.
Admin:
  Requires Library 0.71 or later.
  Requires BuildSys 3.06 or later.
  Requires Env 0.65 or later.

Version 2.01. Tagged as 'Filer-2_01'

Detail:
  This should stop random tags being looked up when file information
    cannot be read for the item over which the Menu button has been
    clicked.
Admin:
  Not tested.

Version 2.00. Tagged as 'Filer-2_00'

Detail:
  * People using ShareFS to write to remote discs will find that they
    annoy the person on the remote machine because their directories
    update randomly. ShareFS, unlike most other parts of the system, uses
    EnsureSize when creating files. This causes an upcall for the modified
    file. Filer was blindly assuming that it understood the format of
    /every/ file modified upcall > 8 (ensure file is one of those) and
    that they had a filename in a particular register. For ensure size,
    that register contains a file handle and would cause Filer to go
    "What ? /Where/ ?! Oh, I'll mark all the windows as dirty because I've
    no idea what's going on any more". But then it only marks one window
    as dirty.
Admin:
  Fix tested extensively in ROL version 4.01 and later.

Version 1.99. Tagged as 'Filer-1_99'

Detail:
  Rename routine gets away with Push "r15" because it has only been
    tested on a StrongARM - probably blows the system away if not SA.
  Incorrect condition reversed in DoOSCLIInBox - if the command window
    opens, then the routine exits without doing the command.  Now the
    exit occurs if that SWI failed.
Admin:
  Not tested.

Version 1.98. Tagged as 'Filer-1_98'

Version 1.97. Tagged as 'Filer-1_97'

Moved to srccommit.

Version 1.96. Tagged as 'Filer-1_96'