Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
ChangeFSI ChangeFSI
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • RiscOS
    • SSources
  • Apps
  • ChangeFSIChangeFSI
  • Merge requests
  • !3

Merged
Created Sep 19, 2021 by Robert Sprowson@rsprowsonDeveloper

Raise the image line/area limits to 8k

  • Overview 0
  • Commits 1
  • Changes 3

Increase the max next slot to process lines to > 8k. Increase the max work area for internal images to allow 8k x 8k. Given a choice of creating a large dynamic area or using the app slot, prefer the latter. Fix bug reusing a stale area address when trying to process an image > max work area:

  1. ChangeFSI switches to buffer via file mode
  2. On completion of processing the buffer is freed, but the area address returned anyway
  3. Desktop front end tries to read the sprite name from the (now absent) area, leading to an abort in ReturnName in the kernel's sprite handler this would complete correctly if done via the command line.

Tested with a 7200x5400 PNG. Now loads correctly on a large memory machine, and reports "Can't get enough memory to process image" on a 64MB Risc PC. Fixes https://www.riscosopen.org/forum/forums/1/topics/3977?page=5#posts-125179

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: biggerimg