1. 27 Nov, 2016 1 commit
  2. 26 Nov, 2016 1 commit
  3. 11 Nov, 2016 2 commits
    • Robert Sprowson's avatar
      Add ARMv8 AArch32 disassembly · 0715cd51
      Robert Sprowson authored
      Opcodes for CRC32/HLT/SEVL/LDA/STL/LDAEX/STLEX and DMB/DSB options.
        Add ARMv8_AArch32 actions and encodings to dis2.
        Extend the DMS/DSB decoding to warn about ARMv8 specific ones (previously undefined)
        Slot in decode.
        New token for "ARMv8 or later" warnings.
      Tested by brute force all 256M instructions in NV space and 256M conditionals, comparing the output against dis2.
      Currently missing the new VFP and SIMD opcodes.
      Version 1.98. Tagged as 'Debugger-1_98'
    • Robert Sprowson's avatar
      Add XScale DSP disassembly · 3d2718aa
      Robert Sprowson authored
      Three instructions, MIA/MAR/MRA, 14 years late.
      Version 1.97. Tagged as 'Debugger-1_97'
  4. 24 Jul, 2016 3 commits
    • Robert Sprowson's avatar
      Express wacky shifts as the ARMARM says we should · d8cf3817
      Robert Sprowson authored
      Reinstate the check that an immediate value that doesn't use the preferred encoding is disassembled to #value,ror such that reassembling it would give you back the original op code.
      Tested with a handful of values, plus inspected all duplicates possible in Excel.
      Version 1.96. Tagged as 'Debugger-1_96'
    • Robert Sprowson's avatar
      Split 6k line source file · c8be9de2
      Robert Sprowson authored
      Move the disassembler bits out of the main debugger module.
      Built, but not tested.
      Version 1.95. Not tagged
    • Robert Sprowson's avatar
      Build fix · 012dae05
      Robert Sprowson authored
      Module_Title->Module_TitleStr from Kernel-5_54.
      Version 1.95. Tagged as 'Debugger-1_95'
  5. 11 Jun, 2016 2 commits
    • Robert Sprowson's avatar
      ARMv6/v7 disassembly accuracy improvements, ARMv7MP ARMv7VE additions · fb639a5b
      Robert Sprowson authored
        Add missing conditionals on DBG.
        Add ERET (v7VE).
        Add MRS/MSR banked (v7VE), and its funky encoding of the banked register.
        Check bit 22 of SRS/RFE properly, otherwise some undefined instructions get wrongly decoded as SRS/RFE.
        Use prefix 'A' for arch warnings, so they can be kept together in the messages file.
        Around line 990, refactor up front decoding to pick out NV instruction space like the ARM ARM says to do. This makes subsequent decoding much simpler to follow, and removes lots of backdoor checks on bits 28-31 scattered later on in the decode - fixes problem with CPS #mode being wrong when bit 4 set.
        Add HVI (v7MP). Note this is a made up pre-UAL form of HVC (cf. SWI->SVC, SMI->SMC) for now.
        Add PLDW (v7VE).
        Put back flags preservation on Conditions routine, otherwise TestStr preserves flags if no conditions are wanted, but doesn't if they are - was causing some of the Saturates family to be misclassified as undefined.
        Add samples of each of the extra instructions.
      Resources/UK/Messages, Resources/Germany/Messages
        Messages files updated.
      Tested with 'testbed' over the 256M EQ condition code, plus 256M NV condition code, with no unexplained mismatches.
      Version 1.94. Tagged as 'Debugger-1_94'
    • Robert Sprowson's avatar
      dis2 corrective actions util.c · 9350c823
      Robert Sprowson authored
        Line 332: Fix typo in R13_hyp table entry (was R12)
        Line 158: A missing comma meant the arch warning table was one entry too short, so any XScale media instructions would cause a NULL pointer access
        Add missing pre-UAL forms of LDRHT LDRSBT LDRSHT STRHT, assuming they take the form [LD|ST]RccSUFFIX
        Fix decoding of banked MRS/MSR SYSm field, this is defined as m:m1, so m needs shifting up more
        Fix opcode for banked MSR, copy paste fumble
      Tested using 'testbed', not tagged.
  6. 06 Apr, 2016 1 commit
    • Jeffrey Lee's avatar
      Fix truncated error messages in annotated exception dumps. Fix Debugger$DumpOptions syntax error. · 98350188
      Jeffrey Lee authored
        c/exc - The error message was being shoved into a 64 byte buffer, causing truncation. Rather than making the buffer bigger (trying to keep stack usage to a minimum), bypass the buffer and write the message straight to the output. Also add an extra newline at the end of DescribeBlocks so that the output doesn't run directly into the annotated R15/R14 that are output by AnnotateAll.
        Resources/Germany/Messages, Resources/UK/Messages - Update EXC_MSG_ERROR (X18) for the above. Remove Debugger$RawFile and Debugger$AnnotatedFile hint text from Debugger$DumpOptions syntax error message - CopyError wasn't causing the magic newline codes to be translated, and the error buffer (aka StringBuffer) is too small for such a long message anyway.
        Tested on Raspberry Pi
      Version 1.93. Tagged as 'Debugger-1_93'
  7. 05 Apr, 2016 1 commit
    • Jeffrey Lee's avatar
      Add exception dump generation and processing facilities · 5e1d6cfb
      Jeffrey Lee authored
        This set of changes adds support for the following features:
        * A new code system variable, Debugger$DumpOptions, to control whether exception/crash dumps are collected from SeriousErrorV and where they should be output
        * Dump output can be in raw (binary) or annotated (text) form.
        * Annotated form provides detailed annotation of the stack(s), detecting certain constructs such as SWI invocations, IRQsema frames, CMHG veneers, APCS stack frame chains, and most forms of assembler function calls. The output isn't as easy to understand as a proper stack backtrace would be, but the low-level nature allows it to cope with corrupt or partially-overwritten stack frames, and avoids making invasive changes to components in order to make them backtrace-friendly
        * Stack annotation is able to make use of embedded ROM debug symbols (to be supported by romlinker 0.06) and Norcroft-style embedded function names in order to provide function-level location information for most ROM components and applications
        * System variables Debugger$RawFile and Debugger$AnnotatedFile to specify where to save raw and annotated exception dumps (preliminary, approach may change in future)
        * As well as supporting saving to file, the exception dumps can also be sent to the HAL via HAL_DebugTX, or if a program is driving SeriousErrorV directly it can use SeriousErrorV_CustomReport to have it fed to a custom callback function
        The code is structured in such a way that the core dump annotation code can potentially be built into a standalone application to allow offline processing of dumps (offline application not part of this checkin)
        File changes:
        c/exc, h/exc - Core code for producing the annotated exception dumps
        hdr/ExcDump - Header detailing the format of the binary dump
        s/ExceptionDump - Code variable and SeriousErrorV handling. Several support calls (used by c/exc) are also implemented here, in order to separate the dump processing from any interrogation of the originating machine
        Makefile - Updated for c/exc inclusion, and C header generation from hdr/ExcDump
        Resources/UK/Messages, Resources/Germany/Messages - New messages used by exception dump code
        c/support - Add a strcmp implementation, and extend vsprintf to be vsnprintf. Add support for string width format specifier.
        s/Debugger - Workspace definitions and init/shutdown hooks for exception dump code. Refactor *Where so that the locate logic is separate from the message output logic, to allow the locate logic to be used by the exception dump code.
        Tested on Raspberry Pi
        German messages in need of translation
      Version 1.92. Tagged as 'Debugger-1_92'
  8. 03 Mar, 2016 1 commit
  9. 22 Jul, 2015 1 commit
    • Robert Sprowson's avatar
      Add *Where to debugger's armoury · be5b800a
      Robert Sprowson authored
      Largely inspired/ripped off from the DebugTools module, but using OS_DynamicArea 20 for the bulk of area searching. The address to lookup goes through the usual parser for Debugger commands so can be a hex address/register/implied exception PC if no arguments given.
      Removed limited lookup from *ShowRegs command; this wasn't especially useful being hardwired to PC since only data aborts have a valid PC, normally the other registers are more interesting.
      Fix miscapitalisation of ShowVFPRegs syntax (presumably to avoid it using Token0) by adding a DictTokens directive, since the syntax is used by code in the module which doesn't work with Token0.
      Split German messages out into CmdHelp/Messages.
      Tested in an IOMD ROM build with various edge cases.
      Version 1.90. Tagged as 'Debugger-1_90'
  10. 08 Feb, 2015 1 commit
    • Jeffrey Lee's avatar
      Fix annotation of FPSCR LEN & STRIDE fields · 34aa3112
      Jeffrey Lee authored
        s/Debugger - Fix some broken logic in *ShowVFPRegs that was causing the FPSCR vector length fields to be reported incorrectly if vector stride was enabled
        Tested on Raspberry Pi
      Version 1.89. Tagged as 'Debugger-1_89'
  11. 21 Jan, 2015 1 commit
    • John Ballance's avatar
      Added module name and offset to *ShowRegs command · d2d75ad1
      John Ballance authored
        *Showregs now indicated module name and offset if address is
        in a module
        (highlight level of testing that has taken place)
        (bugfix number if appropriate)
      Version 1.88. Tagged as 'Debugger-1_88'
  12. 16 Jan, 2015 1 commit
    • Jeffrey Lee's avatar
      Escape some dollars · 8d473fbe
      Jeffrey Lee authored
        s/CodeVar - Escape some dollars contained in strings to avoid warnings from objasm
        Resulting binary unchanged
      Version 1.87. Retagged as 'Debugger-1_87'
  13. 24 Oct, 2014 1 commit
    • Robert Sprowson's avatar
      Build fix · 52057416
      Robert Sprowson authored
      Update for BuildSys-6_60. No need to force things in ModuleLibs to blank now.
      Version 1.87. Tagged as 'Debugger-1_87'
  14. 08 Feb, 2014 1 commit
    • Jeffrey Lee's avatar
      Add *ShowVFPRegs command · e2274470
      Jeffrey Lee authored
        This adds support for the *ShowVFPRegs command, which is basically VFP equivalent of *ShowFPRegs. However unlike *ShowFPRegs it allows for any arbitrary VFP context to be viewed, not just the last context that caused an exception:
        *ShowVFPRegs [E] for showing the exception context
        *ShowVFPRegs A <address> for showing a context at a specific address
        *ShowVFPRegs C for showing the current context
        File changes:
        - HelpSrc, Resources/UK/CmdHelp - Added *ShowVFPRegs help text
        - Resources/Germany/Messages, Resources/UK/Messages - New message tokens for *ShowVFPRegs output
        - s/Debugger - *ShowVFPRegs implementation
        - actions/ARMv7_VFP - VPUSH or VPOP of >16 singleword registers were incorrectly being flagged as unpredictable; it's only the doubleword version which should have that restriction.
        Tested on Raspberry Pi
        German messages are in need of translation
      Version 1.86. Tagged as 'Debugger-1_86'
  15. 28 Nov, 2013 1 commit
    • Jeffrey Lee's avatar
      Add a new, machine-generated VFP/NEON disassembler. Fix some ARMv6/v7 disassembly bugs. · 027eaf81
      Jeffrey Lee authored
        This change adds up-to-date VFP & NEON disassembly to the module, by way of a partially machine-generated disassembler written in C.
        It's also possible to build a standalone disassembler utility (dubbed 'dis2') which is 100% C and has support for all ARM instructions (including some obscure stuff the assembler disassembler currently lacks, e.g. XScale DSP instructions). One day this may completely replace the assembler disassembler, but at the moment it's a bit bulky and probably has a few bugs left to squash. The disassembler is also fairly flexible, supporting various output formatting options.
        Main changes:
        - Makefile - Rewritten to switch over to using the CModule makefile fragment instead of AAsmModule, to allow the C code to be included in the component. Also added 'dis2' as an alternative component to build as.
        - Resources/UK/Messages, Resources/Germany/Messages - Updated with new disassembler messages
        - s/Debugger - Add new UseCVFPNEON switch to allow control over whether the module builds with the C VFP/NEON disassembler or the original assembler VFP disassembler
        - s/CGlue - Glue code used with the C disassembler to bridge the gap between the assembler world and the C world
        - actions/* - A set of decgen action files describing what to do for each instruction the new disassembler supports. These are basically just blocks of C code - although they need to match up with the encoding names in Library/Misc/decgen/encodings
        - cache/* - Folder for decgen to cache decision trees in. Building the decision tree for the disassembler is currently a lengthy process, but caching the trees reduces the build time to a fraction of the full time.
        - c/head - Stub C file that decgen prepends to the code it generates
        - c/main - main frontend for the standalone version of the disassembler
        - c/support - Reimplementation of the standard C library functions required for the disassembler. This allows us to avoid a runtime dependency on the shared C library, and also allows us to deal with control-terminated strings from messagetrans where relevant. For convenience this file also has the main entry point that's called from assembler.
        - c/util - Utility code for outputting various forms of instruction, decoding immediate constants, etc.
        - h/dis2 - Header file for the C code
        - Test/c/testbed - Simple C testbed app to allow the output of dis2 to be compared against the Debugger module and decaof
        - !MkDis2,fd7 - Script to allow easy building of the standalone 'dis2' disassembler
        - s/ARMv6 - Change 'ROR#' to 'ROR #' for UXTAB, etc. disassembly. Fix bitfield extract & clear instructions to detect unpredictable/invalid bitfield definitions
        Misc other changes:
        - s/* - Source files updated so s/Debugger contains a list of GETs instead of each source file LNK'ing to the next
        Tested in ROM form on BB-xM, and as softload on Iyonix
        German messages are in need of translation
        Requires Library-1_65 and BuildSys-6_34
      Version 1.85. Tagged as 'Debugger-1_85'
  16. 19 Oct, 2013 1 commit
    • Robert Sprowson's avatar
      Add in disassembly of ARMv6 and ARMv7 instruction sets · b364ec48
      Robert Sprowson authored
      The debugger had some embryonic ARMv6 knowhow, switched out due to being incomplete.
      Enabling and finishing off ARMv6, then adding ARMv6K, ARMv6T2, ARMv6 security extensions, and ARMv7.
      That just leaves
       - ARMv7MP (multiprocessor extensions: PLDW)
       - ARMv7VE (virtualisation extensions: ERET, MRS copro, MSR copro)
       - Advanced SIMD (probably worth thinking about)
       - Thumb2 (questionable why Thumb is supported at all as the tools & OS don't use it)
      The syntax follows the pre UAL spirit for the new instructions (cf. ADDCCS versus ADDSCC).
      Removed binary V6test binary, replaced with more comprehensive v6/v7 source.
      Tested softloaded inspecting the output in StrongEd.
      Version 1.84. Tagged as 'Debugger-1_84'
  17. 24 Sep, 2011 1 commit
    • Jeffrey Lee's avatar
      Fix objasm 4 warnings. Fix breakclr <addr> when addr is >=64M · cc5b363d
      Jeffrey Lee authored
        s/Debugger - Tweaked a few LDM/STM instructions to fix some objasm 4 warnings. Disabled some 26bit code in 32bit configs to avoid more warnings. Fix BreakClr to work on 32bit systems if the breakpoint address is >=64M.
        Tested on rev A2 BB-xM
      Version 1.83. Tagged as 'Debugger-1_83'
  18. 04 Aug, 2011 1 commit
    • Jeffrey Lee's avatar
      Update to work with zero page relocation · dd8ac1d9
      Jeffrey Lee authored
        s/Debugger - Try reading DebuggerSpace location using OS_ReadSysInfo 6 before falling back on legacy address. Compute appropriate MOV PC,DebuggerSpace instruction instead of using hard-coded one.
        Tested on rev A2 BB-xM
      Version 1.82. Tagged as 'Debugger-1_82'
  19. 22 Mar, 2010 1 commit
    • Jeffrey Lee's avatar
      Rework *memoryi implementation to avoid alignment faults during Thumb disassembly on ARMv6+ · 73fbcc05
      Jeffrey Lee authored
        s/Debugger - Reworked MemoryI_Code:
        * Avoid alignment faults when disassembling Thumb instructions by using LDRH or LDR-and-shift depending on compile-time architecture
        * Split ARM & Thumb disassembly into two seperate paths to (perhaps) increase readability
        * Cleaned up the code so it only reads each memory location once
        Tested on rev C2 beagleboard.
        Current thumb disassembler looks like it could do with a bit of an overhaul when full support for the 32bit encodings is added.
        *memoryi code could also be made a bit nicer if we don't mind thumb disassembly failing if attempted on a CPU that can't (reliably) LDRH.
      Version 1.81. Tagged as 'Debugger-1_81'
  20. 30 Jan, 2010 1 commit
    • Jeffrey Lee's avatar
      Fix code to be fully aware of 64bit parameter flags, fix accidental alignment... · e06a1f48
      Jeffrey Lee authored
      Fix code to be fully aware of 64bit parameter flags, fix accidental alignment exceptions on ARMv6/v7
        s/Debugger - All code which calls ReadOneParm, ReadParm, etc. now correctly sets r10 to the correct value depending on whether they want to parse 64bit numbers or not. This was the cause of *InitStore malfunctioning and (presumably) trashing whatever R11 pointed to (bug #232)
        Also fixed MemoryHeader causing an unintentional alignment exception when testing if rotated or unaligned loads are in use. The CP15 registers are now interrogated instead.
        Tested on rev C2 beagleoard. *Memory with unaligned addresses no longer aborts, and *InitStore <val> now uses the correct value, and seems to no longer trash memory
        Fixes bug #232
      Version 1.80. Tagged as 'Debugger-1_80'
  21. 26 Jun, 2009 1 commit
    • Ben Avison's avatar
      Now has a standalone build variant · d316b11b
      Ben Avison authored
        Debugger now handles registering and deregistering its messages file with
        ResourceFS when you build a RAM (standalone) variant. This obsoletes the
        DbgMess module.
        Tested briefly
      Version 1.79. Tagged as 'Debugger-1_79'
  22. 16 Jun, 2009 1 commit
    • Ben Avison's avatar
      Build change · 6cf22fc8
      Ben Avison authored
        CPU version is no longer specified in the makefile - it's better to inherit
        it from the build environment now that we actually set it appropriately.
        Built but not tested. Binary should be unchanged - this only affects the
        warnings generated during assembly.
      Version 1.78. Not tagged
  23. 17 May, 2009 1 commit
    • Ben Avison's avatar
      Changes to make Debugger more useful on ARMv6/v7 · d437ee15
      Ben Avison authored
        * Added knowledge of the ARMv5TEJ / ARMv6 CPSR flags J, GE[3:0], E and A,
          plus Monitor mode
        * *Memory, *Memory H, *MemoryA and *MemoryA H can now access unaligned
          addresses; the header line in unaligned cases adapts depending on whether
          the CPU natively rotates or does unaligned loads
        * Added *Memory D and *MemoryA D for accessing 64-bit words using LDRD / STRD
        * Removed check for 32-bit mode before doing LDRH - this is nonsensial now
          that there are 32-bit builds for IOMD-class machines. I've decided to let
          it attempt LDRH even on platforms where it might not work or might be an
          undefined instruction - this gets us "closer to the metal", and it's not
          like *Memory couldn't already throw exceptions in normal use
        * Removed redundant clauses of a few build options, it was getting
          impractical to maintain the alternate build variants
        Tested on rev B7 beagleboard. Requires an updated kernel in order to be
        able to specify 64-bit values on the command line or interactively (but
        even on older kernels you can enter a value less than 2^32 to *MemoryA D)
      Version 1.78. Tagged as 'Debugger-1_78'
  24. 30 Jul, 2004 1 commit
    • Kevin Bracey's avatar
      Modified ASCII display in *Memory etc to read memory using the same access... · c8f22aa6
      Kevin Bracey authored
      Modified ASCII display in *Memory etc to read memory using the same access size as the main output. This helps with some hardware registers that only support, say, word-sized accesses. Note that the memory locations are still read a second time for the ASCII display, so it's still not ideal for read-sensitive hardware.
      Added some ARMv6 support to disassembly, but this is incomplete and switched
      out at the moment.
      Version 1.77. Tagged as 'Debugger-1_77'
  25. 03 Dec, 2002 2 commits
    • Ben Avison's avatar
      A new feature and a bugfix. · 302102ca
      Ben Avison authored
        * Added 'H' flag to *Memory and *MemoryA to allow half-word memory accesses.
          On 26-bit machines, this is emulated using 32-bit reads and read-modify-
          writes; on 32-bit machines, LDRH and STRH are used. Address header in
          *Memory byte mode changed to be only one digit per byte for consistency
          with word and half-word modes. *MemoryA H in interactive mode gives a
          Thumb disassembly.
        * STM Rn!,{reg_list_including_Rn} is actually allowed, provided Rn is the
          lowest register in the list. Warning code adjusted accordingly.
        Tested on Risc PC and Tungsten.
      Version 1.76. Tagged as 'Debugger-1_76'
    • Ben Avison's avatar
      Merged in Kevin's latest version, as featured in OS release 5.00. · 0af8a6fe
      Ben Avison authored
        * Added Q bit to *ShowRegs
        * Added FMSRR, FMRRS, FMDRR and FMRRD to VFP support
        * Shortened lots of VFP literals by treating common "F" prefix separately
        * Cirrus DSP support (switched out)
        * Piccolo support (not even linked in)
        * ARM/Thumb disassembly test programs added
        * Bugfix: code variable init code was trashing the flags that indicated
          whether zero page branch table (used for breakpoints in 32-bit mode) needs
        Builds identical binary to 5.00 release, repository changes were build-
        related only.
      Version 1.75. Tagged as 'Debugger-1_75'
  26. 01 Jun, 2001 1 commit
    • David Cotton's avatar
      Header exports now work. · 814317cd
      David Cotton authored
          Build would not build with this version of the module as the last change
      to the makefile did not include the line needed to export the Debugger
      header. This line has now been added.
          Added an !MkExport to enable testing of the export.
          Converted the existing Mk... obey files to !Mk... files.
          Some basic testing.
      Version 1.74. Tagged as 'Debugger-1_74'
  27. 10 May, 2001 1 commit
    • Kevin Bracey's avatar
      * Fixed register clash warnings on SWP. · 80d99af3
      Kevin Bracey authored
      * Changes to message files to correct syntax errors.
      * *MemoryX P works on IOMD-based systems is OS_Memory 13 fails.
      * Changed to use ObjAsm and centralised Makefiles.
      Version 1.73. Tagged as 'Debugger-1_73'
  28. 09 May, 2001 1 commit
  29. 01 May, 2001 1 commit
  30. 30 Apr, 2001 1 commit
    • Steve Revill's avatar
      * Added a couple of tweaks to the MakeMess and MkClean files. · 2a735e83
      Steve Revill authored
        * Added the Disassemble$Options system variable.
        * MakeMess now does a CDir command (in case you run it before
          running MkRom). MkClean now includes a 'stripdepnd' call.
        * There is a new system (code) variable created on module init
          called Disassemble$Options. This controls (at the moment)
          register naming for disassembly.
        Tested on RiscOS 4 and 3.70.
      Version 1.72. Tagged as 'Debugger-1_72'
  31. 18 Apr, 2001 1 commit
  32. 21 Mar, 2001 3 commits
    • Steve Revill's avatar
      Optimisation of SWI stuff. · bde08062
      Steve Revill authored
        Changed wacky immediate format.
        SWI number stuff now uses an internal routine rather than a call
        to SWI OS_ConvertHex...
        When someone disassembles a wacky immediate, it is represented as
        "<OP> Rd,Rn,#&xx,x" rather than the non-standard
        "<OP> Rd,Rn,#&xx,ROR #x" format. This can then be assembled and
        conforms to ARM's standards.
        Tested on RiscPC
        My editor blew-up in the middle of srccommit on Debugger-1_69 so
        don't use that version!
      Version 1.70. Tagged as 'Debugger-1_70'
    • Steve Revill's avatar
      Optimisation of SWI stuff. · 1a5cd5a5
      Steve Revill authored
        Changed wacky immediate format.
        SWI number stuff now uses an internal routine rather than a call
      Version 1.69. Tagged as 'Debugger-1_69'
    • Steve Revill's avatar
      Modified SWI number output. · 3ab7e167
      Steve Revill authored
        SWI number stuff also implemented in Thumb mode.
        Unknown SWIs were dissasembled as an 8 nibble hexadecimal number.
        This has been reduced to a six nibble number (as the top byte is
        always zero).
        The unknown SWI disassembled as a number stuff has also been added
        to Thumb mode disassembly. Only two nibbles are displayed in this
        Tested on a RiscPC.
      Version 1.68. Tagged as 'Debugger-1_68'
  33. 15 Feb, 2001 1 commit