1. 21 Jan, 2023 1 commit
    • Jeffrey Lee's avatar
      Initial SMP support · 19649acb
      Jeffrey Lee authored
      Use SMP_Special 0 to switch in/out of SMP processes when
      suspending/resuming tasks
  2. 14 Jan, 2023 4 commits
    • Robert Sprowson's avatar
      Fix for zombie task preventing desktop exit after shutdown · 5ea3f800
      Robert Sprowson authored
      When the last task closes down have the clipboard manager task go dormant rather
      than pending. Otherwise, we get stuck in a race condition wanting to start back
      up again when the Task Manager's shutdown dialogue quits (Ctrl-Shift-F12 then
      Define symbolic names for the special values if clipboard_taskhandle for states
      pending/run now/dormant.
      When the final task closes down, *now* it is safe to go to the pending state.
      Tidy up runthetask, and use Wimp version of 200 for the temporary task initialised
      rather than pass an undefined R3 to Wimp_Initialise. Share a common OS_CLI tail.
      When asked to quit via user message 0, set the state to dormant.
      Version 5.85. Tagged as 'Wimp-5_85'
    • Robert Sprowson's avatar
      [509] Fix abort autoscrolling off a window with no icons · 3f8f8581
      Robert Sprowson authored
      When looking up the user icon button type passed in R3/R4, use the window handle
      in R3 rather than 'handle' which is the window in which autoscrolling started.
      This caused an abort if that window contained no icons (because w_icons = -1, and
      R4 != -1 leading to R5 = 15 and invariably an address in zero page somewhere).
    • Robert Sprowson's avatar
      [519] Wimp crash on bad title bar validation · 13316dc0
      Robert Sprowson authored
      Reset the redrawhandle when creating a new window, so an empty title validation string
      doesn't cause an unwanted page in of another task. This could lead to a subsequent abort
      if the wrongly paged in task had a smaller slot when attempting to dereference the
    • Robert Sprowson's avatar
      [555] Fix for corrupt registers in Service_ModeChange · 131bd90b
      Robert Sprowson authored
      Service_ModeChange -> recalcmodevars -> readvduvars2
      but readvduvars2 uses r5 and r6.
  3. 29 Dec, 2021 1 commit
    • Andy Vawer's avatar
      Fix crash on closing menu containing a writeable icon with focus as part of the menu tree · a3b6237a
      Andy Vawer authored
      * When closing menus, set_caret_position is called to remove the caret from the menu tree
        which tries to redraw the icon without a caret as the window is still defined and valid
      * This happens after clearing the menutaskhandle though, so the redraw can't page in the
        right task
      * The redraw then fails badly trying to access memory from the wrong task
      Version 5.84. Tagged as 'Wimp-5_84'
  4. 15 Dec, 2021 1 commit
  5. 13 Sep, 2021 2 commits
    • Robert Sprowson's avatar
      Fix to invalidate entire tile cache · be34ad90
      Robert Sprowson authored
      A hardwired 18 in reset_all_tiling_sprites meant that one slot was never cleared, so a change in the Wimp's sprite pool could leave a cached sprite pointer pointing to something invalid.
      Ref https://www.riscosopen.org/forum/forums/5/topics/16708
      Version 5.83. Tagged as 'Wimp-5_83'
    • Andy Vawer's avatar
      Abandon set caret position if the window or menu isn't there · 0148e0ea
      Andy Vawer authored
      During destruction of the menu tree, if set caret position fails when resetting the caret to the old position (ie. illegal window handle as the window has been deleted) then destroying the menu tree also fails with catastrophic results.
      * Do not fault SetCaretPosition to invalid window handle, just change it to -1
      * Do not try to redraw areas of an invalid window when moving caret
      Version 5.82. Not tagged
  6. 14 Jul, 2021 2 commits
    • Jeffrey Lee's avatar
      Crunch ROM icon sprites · e62f3580
      Jeffrey Lee authored
      Save around 50KB of ROM space by converting the icon sprites to use RISC
      OS 3.5 mode words instead of numbered modes, reducing the size of the
      mask data to around a quarter of its old value.
      Tested in IOMD ROM, with boot sequence disabled (to ensure the ROM
      sprites get used).
      Version 5.82. Tagged as 'Wimp-5_82'
    • Jeffrey Lee's avatar
      Fix Message_TaskInitialise reporting wrong slot size · be560349
      Jeffrey Lee authored
      Message_TaskInitialise was reporting that MemoryLimit was the slot size
      of the application, which was resulting in the task manager showing the
      wrong slot size if for some reason MemoryLimit had been artificially
      reduced below ApplicationSpaceSize (e.g. due to the task being a child
      of a C system() call). And because MemoryLimit is lower than
      ApplicationSpaceSize, any attempt the task makes to grow/shrink its wimp
      slot is denied, so task manager will be stuck showing the wrong value
      for the entire lifetime of the task.
      Fix Message_TaskInitialise to use ApplicationSpaceSize instead, so that
      the total size of the slot is reported instead of just the usable area.
      This fixes task manager incorrectly showing that Fat32Fs has a slot size
      of 0 on some of my Raspberry Pis, when really it has a size of 256K.
      This discrepancy was also causing the "System memory allocation" numbers
      to not total up correctly (the sum was 256K lower than the displayed
  7. 10 Jul, 2021 2 commits
    • Robert Sprowson's avatar
      Add themeable icon bar tiles · 5958a073
      Robert Sprowson authored
      Allow theme designers to use a different sprite for the background tile of the iconbar, distinct from the other windows. This looks for 'tile_i' before falling back to 'tile_1' as before, in addition to the existing 'tile_m' for menus.
      Version 5.81. Tagged as 'Wimp-5_81'
    • Robert Sprowson's avatar
      [378] Extra switches to set button true colours · 583685c0
      Robert Sprowson authored
      WimpVisualFlags gains -ButtonColour -ButtonWellColour -ButtonHighlightColour to allow a theme designer to set the button/well/pressed colours for R1-R7 slabbing to some other colour, and -ButtonBorderFaceColour -ButtonBorderOppColour -ButtonBorderShallowColour for the outlines.
      The given colours are only used when there is no 'C' validation.
  8. 17 Oct, 2020 1 commit
    • Andy Vawer's avatar
      Fixes for dropping text into writable icons · 30c0dbf5
      Andy Vawer authored
      * If dragging text from a writable icon and the source text or selection disappears during the drag, an ofla error occurs. Change to abort quietly (ie no text copied as nothing to copy) and remove the ghost caret from view.
      * Remove ghost caret on invalid dropped drags
      * Either use correct insert point from ghost caret when receiving a drag, or use current mouse coords for the destination if no ghost caret present.
      * Change datasave handling to check ghost caret presence for the destination rather than trying to check the enhanced datasave state.
      * Use window X coord for drop rather than screen Xcoord to ensure correct insert point.
      Fixes dragging multiline text areas from Draw leaving a ghost caret when it failed, and dragging a basic text object from Draw now inserts at the correct place.
      Version 5.80. Tagged as 'Wimp-5_80'
  9. 12 Sep, 2020 2 commits
  10. 26 Aug, 2020 1 commit
  11. 20 Jul, 2020 1 commit
    • Robert Sprowson's avatar
      Rename clashing CLI macro · 85171512
      Robert Sprowson authored
      The name clashes with the recently added clear IRQ flag macro, CLI, but is only used in a debug case.
      Version 5.77. Not tagged
  12. 08 Jul, 2020 2 commits
  13. 29 Jun, 2020 2 commits
  14. 23 May, 2020 1 commit
  15. 11 May, 2020 1 commit
  16. 02 May, 2020 1 commit
    • Jeffrey Lee's avatar
      Fix delivery of extended scroll requests · b752d15a
      Jeffrey Lee authored
      Extended scroll requests and regular scroll requests share the same
      reason code, but are different sizes. Update calcmessagesize to
      calculate the size of extended scroll messages correctly, so that the
      icon number won't get chopped off when the message is being passed to
      the target task.
      Version 5.73. Tagged as 'Wimp-5_73'
  17. 11 Apr, 2020 1 commit
    • Andy Vawer's avatar
      Allow text to be dragged from writable icons to icon bar icons · 791a168f
      Andy Vawer authored
      Check destination window handle and add destination icon handle if sending message to window handle -2.
      Improve window handle validation (not assuming all -ve handles are invalid, should the RMA move to have top bit set).
      Version 5.72. Tagged as 'Wimp-5_72'
  18. 30 Jan, 2020 1 commit
    • Andy Vawer's avatar
      Fix issue where dragging text from icon caused a crash in foreground task · 1475387a
      Andy Vawer authored
      When releasing claim, use of stale register meant that the foreground task wasn't correctly bouncing Message_Dragging when the pointer moved out of range. Also added a sanity check in get_selected_text so that if for some reason the selection window disappears mid action it will be caught and not cause a crash.
      Version 5.71. Tagged as 'Wimp-5_71'
  19. 25 Jan, 2020 1 commit
  20. 18 Jan, 2020 1 commit
    • Andy Vawer's avatar
      Fix zero page access looking for ptr_ sprite validation · 384a1ec5
      Andy Vawer authored
      On mouse click, check for icon type was incorrect, so trying to apply tests for 'P' validation string/ptr_write on inappropriate icons (eg. sprites), leading to invalid validation string accesses. Correct the test performed.
      Also add 3 further AcceptLoosePointer checks to validation string pointers.
      Version 5.69. Tagged as 'Wimp-5_69'
  21. 04 Jan, 2020 5 commits
    • ROOL's avatar
      Fix lost menu clicks on icons when window partly off screen · 28d1efb9
      ROOL authored
        Don't trap menu clicks on icons when the window isn't fully on-screen.
        Ref https://www.riscosopen.org/forum/forums/4/topics/14961?page=1
        Submission for Clipboard Support bounty.
      Version 5.68. Tagged as 'Wimp-5_68'
    • ROOL's avatar
      Fix for abort on pasting into writeable menus · 14056f15
      ROOL authored
        Menu windows don't store the task handle in their datablock, so an incorrect one was used as part of the data transfer sequence.
        Also, minor fix for Message_ClaimEntity when bit 2 was clear (bits 0,1 set). The response meant that, for example, Alt-click to rename, select text in writeable and press ^C - copied to clipboard, but writeable is removed.
        Submission for Clipboard Support bounty.
    • ROOL's avatar
      Fix for lack of input focus clicking on no icon · 11d21750
      ROOL authored
        If R0=valid window handle, R1<0 (not an icon) and R4=-1 then R4 is internally set to 'invisible caret' to ensure that we get the full input focus event and visible cues.
        Ref: https://www.riscosopen.org/forum/forums/5/topics/14945?page=2#posts-97886
        Submission for Clipboard Support bounty.
    • ROOL's avatar
      Apply same vetting to SetCaretPosition window handle as non cut & paste Wimp · 091831e4
      ROOL authored
        Summary of how non-CnP Wimp treats the window handle for Wimp_SetCaretPosition
        R0 = valid window handle
          or invalid window handle (mapped to -1)
          or any negative number or 0 (mapped to -1)
        With this change, the CnP Wimp does
        R0 = valid window handle
          or invalid window handle (throws error)
          or any negative number or 0 if pre RISC OS 5 (mapped to -1)
          or 0 for RISC OS 5 (mapped to -1)
        Noting the use of AcceptLoosePointer macro if built for a 26 bit target.
    • Jeffrey Lee's avatar
      Add Wimp_Extend 15, "read slot size" · 4610877c
      Jeffrey Lee authored
      Wimp_Extend 15 is equivalent to Wimp_SlotSize,-1,-1, with the exception
      that the sizes returned in R0-R2 are now measured in pages instead of
      bytes. This allows code to accurately read the amount of free memory on
      machines with >2GB of RAM, and provides some future-proofing should we
      ever wish to support tasks with >2GB of RAM (e.g. via a future
      super-jumbo wimpslot, or more likely via sparse/PMP wimpslots, where
      the physical size is larger than the logical size).
      Currently there's no need to provide a page-based call to set the slot
      size (~2GB is fine for the forseeable future), so this call only
      focuses on reading the sizes.
      Version 5.67. Tagged as 'Wimp-5_67'
  22. 18 Dec, 2019 1 commit
    • ROOL's avatar
      Clipboard caret/task fixes · 9cc627ac
      ROOL authored
        In CnPCaret.s
          * Clear any invalid window handles currently stored in caret blocks on Wimp_SetCaretPosition entry
          * Clear R2 on exit if R0=-1,R2=TASK on entry to Wimp_SetCaretPosition
          * If window is not open or able to receive a focus, then return WimpFocus error rather than causing an alignment exception
        In CBTask.s
          A drag to writeable with invalid (eg.rejection due to validation string mismatch or overlong insert) caused ghost caret to be left behind and still deletes the source text.
          * Changed LDR R2,=cbtask_TASK to LDR r2,cbtask3_TASK
          * Ensure cbtask_insert_text_into_icon returns V set on error
          Drag and drop text from icon to non-d&d application, the last message was erroneously sent as DataSaveAck, not Dataload
        Submission for Clipboard Support bounty.
      Version 5.66. Tagged as 'Wimp-5_66'
  23. 14 Dec, 2019 3 commits
    • ROOL's avatar
      Add copy & paste and drag & drop operations to the Wimp · 0fb14a00
      ROOL authored
        The text in writable icons can now be manipulated using the familiar keyboard shortcuts, or using Drag and Drop in conjunction with any compliant applications.
        Further details are in Doc/DragAndDrop along with information on API extensions which are implemented.
        Submission for Clipboard Support bounty.
      Version 5.65. Tagged as 'Wimp-5_65'
    • ROOL's avatar
      Messages additions · 5a8c8508
      ROOL authored
        3 extra tokens in support of clipboard operations.
        Submission for Clipboard Support bounty.
    • Timothy E Baldwin's avatar
      Zip non-ascii filename [⇐⇒£⇓⇑] · cddecfe6
      Timothy E Baldwin authored
      This solves difficulty in handling on other operating systems,
      including being an illegal filename in macOS.
      Fixes https://www.riscosopen.org/tracker/tickets/473
      Version 5.64. Not tagged
  24. 17 Aug, 2019 1 commit
  25. 22 Jun, 2019 1 commit
    • ROOL's avatar
      New Wimp_Extend subreason · 32f2e389
      ROOL authored
        Subreason 14 gives a means to read the validation string from a window/icon that is not in the current task. This is useful for determining whether clipboard operations should be allowed.
        Submission for Clipboard Support bounty.
      Version 5.64. Tagged as 'Wimp-5_64'