1. 23 Aug, 2014 1 commit
    • Robert Sprowson's avatar
      Minor rlib cleanups · dc7ea073
      Robert Sprowson authored
      dbox.c: address of cancelled by dereference
      event.c: spelling
      txtar.c: don't grab the caret when clicking toggle size
      txtedit.c: use BOOL for a boolean
      win.c: when looking at the behind window handle we want -1 not 'DUD' (which happens to be -1)
      wimp.h: add comment about window handle -3
      Retagged as RISC_OSLib-5_83.
      
      Version 5.83. Not tagged
      dc7ea073
  2. 31 Jul, 2014 1 commit
    • Robert Sprowson's avatar
      Some RISC_OSLib rlib enhancements · 5b7cef10
      Robert Sprowson authored
      menu.c/menu.h:
      Add a new menu_setcolours() function to allow the fore/background colour bits to be set on a menu entry.
      colourmenu.c:
      Use the new menu_setcolours() function instead of making assumptions about menu's internal structure layout.
      dbox.c/dbox.h:
      New functions dbox_hidefield and dbox_unhidefield added to complement the fade/unfade ones.
      As dbox_findicon/findiconbefore are only ever used to find writables, rename them as such. Also, make them find writable (type 15) AND writable draggable (type 14) icons.
      Allow navigation by tab/shift tab through icons like the Style Guide chapter 16 says we should. In fact it's a little odd that dbox is emulating 'Ktar' validation itself manually when the Wimp has done this since version 2.92, but maintaining it is less effort than going and checking all the templates.
      Fix bug when looking for leading capital letter matches to complete a dbox, the previous code was looking at the cached copy of the icon flags in d->window rather than the ones the Wimp is actually showing on screen (as might have been modified by dbox_fadefield() for example), so it was possible to complete a dbox for an icon which wasn't visible or selectable.
      Fix bug when looking for leading capital letter matches when the icon doesn't have any text - the template file format is defined as being 0x0D terminated. This would then lead to 'R' and 'S' being accepted as matches having run off the end of the text buffer and into the validation string (which usually contains an 'R' or 'S' validation first). Changed to accept any control terminator.
      event.c:
      When force closing the current menu, don't forget to set the two state variables back to 0.
      fileicon.c/resspr.c/txt1.c/txtundo.c/wimp.c:
      Use existing pointer type definitions.
      flex.c:
      Treat bools as bools and pointers as pointers.
      Say something useful in an error box if flex fails its internal consistency check, rather than just data aborting.
      font.c:
      Remove ROM conditionals from around font_readdef() function, always include the function.
      fontselect.c:
      Use font_readdef() rather than local copies of the exact same function.
      txtedit.c/txtfile.c/txtfind.c/txtedit.h:
      Remove redundant 'deletepending' state variable, and confusion over 'selectrecent' being a bool.
      Call os_byte directly rather than passing to os_cli("*FX").
      Other minor tidy ups.
      wimpt.c:
      Mark messages list as a constant.
      xferrecv.c:
      Also preserve the size member while recycling the xferrecv_ack message block, rather than corrupting it as 256.
      xfersend.c/xfersend.h:
      Take out the leaf name formulator as a common function for the two places to use it. This also allows the function to return the length of the leaf name so the correct message block size can be used. Inspection with MsgMon/!Reporter was showing that all xfersend initiated saves were passing the leaf name padded to 256 with garbage.
      Reindent a few functions.
      Make the draggable sprite replacement follow the same validation string rules as the Wimp, previously only ";s" was accepted, so upper case 'S' and validation strings that start with the sprite validation didn't work.
      xfersend_pipe() function prototype changed to match xfersend() more closely - not being able to respond to the context of a wimp_eventstr made this function practically unusable.
      akbd.h:
      Windows logo and menu keys defined.
      flex.h/help.h/wimpt.h
      Some typos in comments.
      wimp.h:
      Missing wimp message action codes and structure defs added for completeness.
      
      
      Version 5.83. Not tagged
      5b7cef10
  3. 08 Jul, 2014 1 commit
  4. 24 Oct, 2013 1 commit
    • Robert Sprowson's avatar
      Some library fixes · c9b6d7f3
      Robert Sprowson authored
      Fix for problem passing long command lines via system(), while there are good arguments to leave the threshold at 255, non DDEUtils aware programs get brutally truncated command strings, and since the old threshold of 255 applied when the kernel handled 256 command lines, upping the limit to 1k is no worse than before.
      Fix for Edit failing to draw lines of text longer than 192 characters (ticket #350). Several factors were conspiring here: on a mode change the window width in characters wasn't being clamped, whereas user entered limits in the menu were, then the internal buffer ("PAINTBUFSIZE") was too short so lines got truncated, and when larger than 256 got wrapped modulo 256 due to the use of an array of chars. Now set at compile time with BIG_WINDOW_SIZE_LIMIT with a new theoretical maximum of 8192. Currently limited to 480 since it uses stack variables.
      
      In the C library:
       armsys.c: adapt the threshold at which to use DDEUtils based on the kernel version number
       scanf.c: squash a warning
       time.c: mark the table of month lengths as constant so we can claw back 13 words of static workspace without having to change the stubs
      
      In RISC OS lib:
       bbc.c: remove local definitions of some SWI numbers
       template.c: squash a warning
       txt.c: delete Modula-2 support
       txt1.c: compare pointer with NULL not an integer
       txtar.c: introduce BIG_WINDOW_SIZE_LIMIT, rationalise a few sprintf's, mark private functions as static
       txtundo.c/txtedit.c: squash old style function warnings
       txtoptmenu.c: clamp the window width read from Edit$Options properly, delete long disabled code
       txtscrap.c: dead function deleted
      
      
      Version 5.78. Tagged as 'RISC_OSLib-5_78'
      c9b6d7f3
  5. 25 Sep, 2012 1 commit
    • Robert Sprowson's avatar
      Style guide ammendment · 6fbe9ace
      Robert Sprowson authored
      While the txtedit part of RISC_OSLib has never been famed for its adherence this brings the delete operation (^K ref Style Guide p38, !ResEd, and the drag & drop protocol specification) into line.
      
      Version 5.73. Tagged as 'RISC_OSLib-5_73'
      6fbe9ace
  6. 21 Aug, 2012 1 commit
  7. 26 Nov, 2010 1 commit
    • Jeffrey Lee's avatar
      Fix alignment fault when reporting the "This file doesn't contain a BASIC program" error · 38fd341c
      Jeffrey Lee authored
      Detail:
        rlib/c/txtedit - Rather than generating a proper error block to send to Wimp_ReportError, txtedit__validbasicfile was just subtracting 4 from the pointer to the error string.
        The resulting address isn't guaranteed to be aligned properly, resulting in an alignment fault on ARMv7 when Wimp_ReportError examines the error number.
        The new code just reuses the 'buff' array to build a temporary error block.
      Admin:
        Fixes alignment fault on beagleboard when attempting to load a detokenized BASIC file into !Edit.
      
      
      Version 5.57. Tagged as 'RISC_OSLib-5_57'
      38fd341c
  8. 31 May, 2009 1 commit
    • Peter Naulls's avatar
      Normalise C and assembler include paths · ca954eea
      Peter Naulls authored
      Detail:
       This changes all the C and assembler includes to be a canoncial Unix format.
       Also match include paths to previous commit for EditIntern/DrawIntern/VerIntern
       Finally, also include some minor type fixes (NULL vs 0)
      Admin:
       May be some other paths elsewhere in the source I'm not immediately able to fix.  Will address any issues ASAP, since this is a huge change.
      
      Version 5.54. Not tagged
      ca954eea
  9. 23 Jan, 2004 1 commit
    • Kevin Bracey's avatar
      <ctype.h> * isblank() added. · 8f9cfb8a
      Kevin Bracey authored
                * isprint() now true for non-breaking spaces
      <math.h>  * FP_INFINITY corrected to FP_INFINITE
                * fma(), fmal(), llrint(), llrintf(), llrintl(),
                  llround(), llroundf(), llroundl(),
                  remquo(), remquof(), remquol() added.
                * added inlining for remainder() and fmaf() and various
                  float functions.
                * math_errhandling removed pending overhaul - it was misleading.
                * expm1() and log1p() now provide decent (< 1 ulp) accuracy,
                  rather than only being marginally better than exp(x)-1 and
                  log(1+x).
                * new version of copysign() with standard calling conventions.
                * some C99 functions changed to use infinity/NaNs and exceptions
                  for error handling - see comments in header file about the
                  changes in progress.
      <stdio.h>  * output from %a now correctly rounded
      <stdlib.h> * strtof() and strtold() added.
      <string.h> * strerror() no longer clears _kernel_last_oserror().
      
      Version 5.49. Tagged as 'RISC_OSLib-5_49'
      8f9cfb8a
  10. 15 Nov, 2002 1 commit
    • Kevin Bracey's avatar
      ROM build fixed for 64-bit stuff. · f207fcb2
      Kevin Bracey authored
      PCI added to swis.h
      alloc.c updated to handle bigger slots (new code merged from ARM libraries)
      Various 32-bit fixes for backtracing, and general trap handling.
      Polite "Application is not 32-bit compatible" message.
      Headers <stdint.h> and <inttypes.h> fixed to work in non-C99 mode.
      txt changed to do new-style Delete behaviour
      
      Version 5.44. Tagged as 'RISC_OSLib-5_44'
      f207fcb2
  11. 05 Nov, 1996 1 commit