1. 26 Jan, 2019 1 commit
    • Robert Sprowson's avatar
      Various fixes · a8f233bb
      Robert Sprowson authored
      colourtran.c: Swap round arg names to colourtran_colournumbertoGCOL to match prototype.
      txtar.c: Avoid incorrect use of strncat buffer limit, and possible unterminated string after strncpy, by reexpressing using snprintf.
      txtedit.c: Avoid incorrect use of strncat buffer limit by reexpressing using snprintf. Avoid potential NULL pointer dereference by moving the filename copy inside the 'if' which confirms it's non-NULL.
      txtfind.c: Remove repeated check of repls being valid. Free repls on error. Free pat on error.
      xfersend.c: Fix potential out of bounds array access (of leaf[]) if the leafname length exceeds the space in the Wimp message.
      Found by cppcheck static analysis.
      
      txtopt.c/h: Sprinkle in some consts.
      event.c: Open menu at the Style Guide approved offset of 64.
      xfersend.c: Remove redundant check of xfersend__filename being NULL in xfersend__suggest_leaf() as all paths leading to it being called ensure the allocation exists (also, it would have strcpy'd garbage due to malloc not clearing the allocation).
      
      Removed unused header txtover.h.
      
      Version 5.98. Tagged as 'RISC_OSLib-5_98'
      a8f233bb
  2. 23 Aug, 2014 1 commit
    • Robert Sprowson's avatar
      Minor rlib cleanups · dc7ea073
      Robert Sprowson authored
      dbox.c: address of cancelled by dereference
      event.c: spelling
      txtar.c: don't grab the caret when clicking toggle size
      txtedit.c: use BOOL for a boolean
      win.c: when looking at the behind window handle we want -1 not 'DUD' (which happens to be -1)
      wimp.h: add comment about window handle -3
      Retagged as RISC_OSLib-5_83.
      
      Version 5.83. Not tagged
      dc7ea073
  3. 31 Jul, 2014 1 commit
    • Robert Sprowson's avatar
      Some RISC_OSLib rlib enhancements · 5b7cef10
      Robert Sprowson authored
      menu.c/menu.h:
      Add a new menu_setcolours() function to allow the fore/background colour bits to be set on a menu entry.
      colourmenu.c:
      Use the new menu_setcolours() function instead of making assumptions about menu's internal structure layout.
      dbox.c/dbox.h:
      New functions dbox_hidefield and dbox_unhidefield added to complement the fade/unfade ones.
      As dbox_findicon/findiconbefore are only ever used to find writables, rename them as such. Also, make them find writable (type 15) AND writable draggable (type 14) icons.
      Allow navigation by tab/shift tab through icons like the Style Guide chapter 16 says we should. In fact it's a little odd that dbox is emulating 'Ktar' validation itself manually when the Wimp has done this since version 2.92, but maintaining it is less effort than going and checking all the templates.
      Fix bug when looking for leading capital letter matches to complete a dbox, the previous code was looking at the cached copy of the icon flags in d->window rather than the ones the Wimp is actually showing on screen (as might have been modified by dbox_fadefield() for example), so it was possible to complete a dbox for an icon which wasn't visible or selectable.
      Fix bug when looking for leading capital letter matches when the icon doesn't have any text - the template file format is defined as being 0x0D terminated. This would then lead to 'R' and 'S' being accepted as matches having run off the end of the text buffer and into the validation string (which usually contains an 'R' or 'S' validation first). Changed to accept any control terminator.
      event.c:
      When force closing the current menu, don't forget to set the two state variables back to 0.
      fileicon.c/resspr.c/txt1.c/txtundo.c/wimp.c:
      Use existing pointer type definitions.
      flex.c:
      Treat bools as bools and pointers as pointers.
      Say something useful in an error box if flex fails its internal consistency check, rather than just data aborting.
      font.c:
      Remove ROM conditionals from around font_readdef() function, always include the function.
      fontselect.c:
      Use font_readdef() rather than local copies of the exact same function.
      txtedit.c/txtfile.c/txtfind.c/txtedit.h:
      Remove redundant 'deletepending' state variable, and confusion over 'selectrecent' being a bool.
      Call os_byte directly rather than passing to os_cli("*FX").
      Other minor tidy ups.
      wimpt.c:
      Mark messages list as a constant.
      xferrecv.c:
      Also preserve the size member while recycling the xferrecv_ack message block, rather than corrupting it as 256.
      xfersend.c/xfersend.h:
      Take out the leaf name formulator as a common function for the two places to use it. This also allows the function to return the length of the leaf name so the correct message block size can be used. Inspection with MsgMon/!Reporter was showing that all xfersend initiated saves were passing the leaf name padded to 256 with garbage.
      Reindent a few functions.
      Make the draggable sprite replacement follow the same validation string rules as the Wimp, previously only ";s" was accepted, so upper case 'S' and validation strings that start with the sprite validation didn't work.
      xfersend_pipe() function prototype changed to match xfersend() more closely - not being able to respond to the context of a wimp_eventstr made this function practically unusable.
      akbd.h:
      Windows logo and menu keys defined.
      flex.h/help.h/wimpt.h
      Some typos in comments.
      wimp.h:
      Missing wimp message action codes and structure defs added for completeness.
      
      
      Version 5.83. Not tagged
      5b7cef10
  4. 16 Jan, 2003 1 commit
    • Ben Avison's avatar
      Misc changes. · aa313346
      Ben Avison authored
      Detail:
        * Improved lookup of application Sprites file: uses Wimp_Extend 13 (in
          Wimps that support it) to work out the appropriate resolution suffix,
          and prefixes with "<Wimp$IconTheme>" to allow a future Theme Manager
          to operate.
        * Preserves attributes of any existing file when saving sprite or text
          files.
        * Changed two null menu handles from 0 to (doucmented) -1. Despite the
          fact that the Wimp is actually happy with 0 as a null handle here,
          this was reported as a fault.
        * Changed rlib.c.version to use VersionNum, deleted thereby-obsoleted
          rlib.h.VerIntern.version file. Not that rlib.c.version seems to be used
          at the moment.
        * Added Kevin's additions to the test directory.
      Admin:
        Tested briefly.
      
      Version 5.44. Not tagged
      aa313346
  5. 23 Aug, 2001 1 commit
  6. 05 Nov, 1996 1 commit