GitLab

The Crosshatch sprite wasn't quite tall enough for the swatch when plotted in an EY0 mode, and didn't account for the icon being inset from the window border. For width, we now tile the sprite as needed (rather than enlarge the one in Resources).

Version 0.59. Tagged as 'Picker-0_59'

Detail:
  When message_COLOUR_PICKER_COLOUR_CHOICE or message_COLOUR_PICKER_COLOUR_CHANGED were sent the size of the Wimp message was set based on the model's private state structure size, rather than the extension field size.
  Update the message calculation to use the model's info_size value.
Admin:
  Discovered during Toolbox Unification bounty work.

Version 0.58. Tagged as 'Picker-0_58'

Detail:
  SWI ColourPicker_UpdateDialogue allows the possibility of changing both colour and transparency state by setting bits 1 and 6 of the input flags.
  However, bit 6 has the side effect of using the Set_Values entry point which calls the colour changed model SWI which unsets the 'None' flag because the colour was set. Swap around the order of actioning the flags such that the colour is set before considering the new 'None' setting.
Admin:
  Discovered during Toolbox Unification bounty work.

Detail:
  SWI ColourPicker_ReadDialogue claims to return the current state (and does so for the colour) but was returning the cached copy of the flags word. Ensure this is always up to date whenever the colour is changed by copying the 'none' state into the cached flags.
Admin:
  Discovered during Toolbox Unification bounty work.

If the current directory is not it's root these are not equivalent.

Version 0.57. Tagged as 'Picker-0_57'

Flagged by cppcheck static analysis.
Tagged as Picker-0_56-1 as no net code change.

Detail:
  * Makefile rewritten
  * Language-dependent resource files moved into Resources.UK
  * Four header files (in "icons" subdirectory) that are autogenerated by
    running WinEd are now committed to CVS, to aid with cross-compilation.
    These icon number definitions haven't changed in over 21 years, and
    if they were to do so, it would be a one-off job to run WinEd on a
    RISC OS machine to regenerate them: the original rules have been retained
    for this purpose. Since the only other component that uses WinEd like
    this is ResEd, it seems unlikely that it will ever be worth the effort to
    create a cross-compiling version of WinEd!


Version 0.56. Not tagged

Retagged as Picker-0_56.

Detail:
  Support011/c/steppable - The fix for issue #339/flickery redraw, combined with the way that Colour_Changed() in dialogue.c filters out colour change events being passed to the colour picker client, meant that if a slider was dragged then a client which is only interested in click events (e.g. Paint) wouldn't receive a message once the drag was complete. Fix this by adding an extra flag to Set_Position(), to allow Set_Position()'s lazy update logic to be suppressed when End_Drag() sets the final position at the end of the drag. This ensures a message will get as far as Colour_Changed(), which will then forward it on to the client due to the drag no longer being in progress.
Admin:
  Tested on BB-xM
  Fixes selected colour in Paint not updating correctly when dragging sliders


Version 0.56. Tagged as 'Picker-0_56'

Only call value_changed_fn when the value has changed during null poll events, in line with the check for change logic in Increment().
Note that steppable_set_value() still sends one event per call as mentioned in the cautionary note at line 535, so when called programmatically the behaviour is unchanged.

Tested on a Raspberry Pi, no more shimmering colour swatches.

Version 0.55. Tagged as 'Picker-0_55'

Detail:
  c/rgb - Dither the RGB colourspace image in 4096 colour modes; to me this looks better than leaving it undithered
  c/tables, h/tables - Cache the NColour value so that RGB code can detect 4K colour modes
Admin:
  Tested on BB-xM
  Part of an implementation of the Extended Framebuffer Format Spec:
  http://www.riscosopen.org/wiki/documentation/show/Extended%20Framebuffer%20Format%20Specification


Version 0.54. Tagged as 'Picker-0_54'

Version 0.53. Tagged as 'Picker-0_53'

Which is which is known at compile time so the makefile can select which is needed and make the merged messages if needed.

Version 0.52. Tagged as 'Picker-0_52'

Add ability to pass in OPTION to CMHG to allow version with no international help text to be generated.

Fix spurious null at the end of the messages file entry for "ModelListHelp", although not used when NO_INTERNATIONAL_HELP is in force the whacky lookup function in Support011 was failing because MessageTrans in RISC OS 3.10 sees that as a token delimiter and the lookup gets out of sync.

Version 0.51. Tagged as 'Picker-0_51'

Detail:
  No code changes
Admin:
  Tested in a Tools CD build.

Retagged as 'Picker-0_50'

Detail:
  Some users reported problems building the sources if they had other
  installations of perl on their build machine. The build system was using a
  mixture of "perl" and "<Perl$Dir>.perl" to invoke the interpreter, and
  sometimes but not always using "do" to expand system variables on the
  command line. This has now been standardised to use "do <Perl$Dir>.perl in
  all cases, and where possible, to use the makefile macro ${PERL}.
Admin:
  Checked that a Tungsten build still works on a build machine with no other
  perl installation. "perl" was aliased to an error to ensure it wasn't used.

Version 0.50. Not tagged

Version 0.50. Tagged as 'Picker-0_50'

Created a BBE export rule, because the entire Resources directory needs to be exported in this component.

Retagged since this won't affect code generation for existing builds.

No longer assumes the location of the SVC stack.

Version 0.49. Tagged as 'Picker-0_49'

Detail:
  message_PREQUIT has become message_PRE_QUIT in OSLib 6.  This module
    now detects the non-definition of message_PREQUIT and defines it
    to be message_PRE_QUIT itself.
Admin:
  Will allow builds with either OSLib 4 or 6.


Version 0.48. Tagged as 'Picker-0_48'

  Removed assembler that can be imported from AsmUtils
Admin:
  Built.

Version 0.47. Tagged as 'Picker-0_47'

Fixed ROM and debug builds of this module to remember to link against OSLib - otherwise the rom_link fails.

Admin:
  Not caught previously since only Ursula actually includes the
    module image in ROM, and I only updated Ursula to use the latest
    version last month.
  Now builds.

Version 0.46. Tagged as 'Picker-0_46'

Detail:
  Receipt of that service call causes this module to trample over
    Wimp state that applications may be relying on (eg. template
    file handle).
Admin:
  Tested on desktop Risc PC.

Version 0.45. Tagged as 'Picker-0_45'

  CPFLAGS added to header export.
Detail:
  STANDALONE builds no longer exist - they are equivalent to
    non-ROM builds.
  In non-ROM builds, all the resources to be registered in
    ResourceFS are built into a single structure since ResourceFS
    can handle this more efficiently, and it saves initialisation
    time - MessageTrans has a fit when Picker tries to register
    NINE different things in ResourceFS.
Admin:
  Tested as softload.
  ROM build unaffected.

Version 0.44. Tagged as 'Picker-0_44'

Detail:
  As much as possible of the junk has been removed.
  Standard build structure replaces it.
  Unused code removed.
  Support for RISC OS pre-3.60 removed (remove the int'l
    stuff in the CMHG file to reverse this - it must save
    all of 100 bytes!)
  RAM builds now contain the resources for registering in
    ResourceFS (NOTE: this build does not register them yet
    but that's the same as current versions!)  When this is
    fixed, the RAM builds will be the standalone builds.
  RAM build contains a single ResourceFS area which is to be
    registered instead of NINE that it used to register.
  Shame I can't remove all traces of the other directories.
  WinEdit is now invoked from the makefile instead of having
    several silly one-liner Obey scripts to do it.  However, this
    necessitates the perl script to fix the trigraphs (cannot
    use # in makefiles) unless you like 1000s of warnings about
    ANSI trigraphs in the (valid) generated headers.
  Unable to extract it from OSLib or Support011 - it's too
     heavily dependent on them.  Sorry.
Admin:
  RAM builds seem to work.

Version 0.43. Tagged as 'Picker-0_43'

Detail:
  - Merged branches.
  - Added srccommit suppport to cmhg header
  - Added ${THROWBACK} and -p to cmhg flags
  - Added stripdepend call to clean target
  - Stripped dynamic dependencies
Admin:
  Built and tested on RPC.

Version 0.42. Tagged as 'Picker-0_42'

No longer trashes the task's flags to Wimp_Poll. It used to ANT the flags with a word that only preserved specific bits; notably, it would clear the pollword high priority (23) and preserve/save FP (24) bits.

The latter means the FPSR gets reset, which is a bit of a pain if you
are relying on it being preserved (e.g. any task using the Mozilla
sourced JS interpreter...!).

Tested on RISC OS 3.71 and 3.11. Version number incremented to 0.40
for the Risc PC build (assumes resources are present in ResourceFS) and
0.37 for the stand-alone build (makes no such assumptions).