1. 09 Aug, 2015 1 commit
    • ROOL's avatar
      Add support for NTLM authenticated logins · f1009949
      ROOL authored
      SMB.c:
      Line 875 don't free chain pB that early it is (and was being) used later on.
      Fixes to correct which SMB_RxWords the Sesskey and bloblen are retrieved from, for each of the dialects supported.
      Call the new auth code when the protocol flags require it.
      Don't uppercase passwords all the time, the server may require case sensitivity.
      md5c.c/md4c.c:
      Verbatim copies of the RSA reference implementations of MD4 and MD5 from the respective RFC's.
      Auth.c:
      Implementation of the hash/mash/reply that Microsoft requires. Define AUTHTEST of this file to build a simple application that verifies the algorithms.
      
      Tested against a Win7 install, inspecting in Wireshark that the passwords are no longer sent in the clear.
      Implements ticket #332.
      Submission from Colin Granville.
      
      Version 2.52. Tagged as 'LanManFS-2_52'
      f1009949
  2. 12 Jul, 2015 1 commit
    • ROOL's avatar
      Be more efficient with buffers · 44df7e69
      ROOL authored
      Take note of, and use, the MaxBufferSize that the server tells us during negotiation rather than a fixed value.
      If the server doesn't say, use 1k as the default as before.
      Submission from Colin Granville.
      
      Version 2.50. Tagged as 'LanManFS-2_50'
      44df7e69
  3. 05 Jul, 2015 1 commit
  4. 14 Mar, 2015 1 commit
    • Robert Sprowson's avatar
      Add a quick exit for the timeout=0 case · e5ce78dc
      Robert Sprowson authored
      Careful analysis of packet captures by Colin Granville reveals that LanManFS waits for at least 1cs when no timeout was requested, so add a quick exit for that case. Timeouts of >= 1cs still delay for at least the requested time, and up to 0.999cs longer as before.
      This reduces the turn around time which is most beneficial for interfaces faster than 10baseT.
      
      Version 2.48. Tagged as 'LanManFS-2_48'
      e5ce78dc
  5. 06 Aug, 2014 1 commit
    • Robert Sprowson's avatar
      Get version number from messages file · e03efcd9
      Robert Sprowson authored
      Also, rationalise the two Omni_RegisterClient calls to both use _swix since they're virtually the same function repeated twice.
      
      Version 2.47. Tagged as 'LanManFS-2_47'
      e03efcd9
  6. 14 Jul, 2014 1 commit
    • Robert Sprowson's avatar
      Sync up the error messages · 52ed32eb
      Robert Sprowson authored
      Due to an inability to count to 10 accurately, all the error tokens were wrong, leading to some inappropriate error messages.
      Fixes problem "Message token E13 not found" when the SMB server gives a DOS error back.
      
      Version 2.46. Tagged as 'LanManFS-2_46'
      52ed32eb
  7. 31 May, 2014 1 commit
    • Robert Sprowson's avatar
      Ammendments to short name translation table · 478370c8
      Robert Sprowson authored
      The table was ambiguously translating () to () and also [] to (). Now, we error names containing ,[] in the same manner as DOSFS.
      The substitutions for ^% have also been changed to match DOSFS so copying from one to the other doesn't give two representations if viewed on a PC.
      Marked both tables as const to save 512B of RMA.
      This change is slightly academic since most of the time the long filename resolution is in use.
      
      Tested against WinXP SP3 with a build with long filename support turned off.
      
      Version 2.45. Tagged as 'LanManFS-2_45'
      478370c8
  8. 19 Jan, 2014 1 commit
    • Robert Sprowson's avatar
      Make name cache flush unconditional · 22f3ec34
      Robert Sprowson authored
      CoreFn.c:
      The size returned by OS_File 5 might not match the size shown in the Filer viewer (or via *EX) because the last cached version was being returned. This would manifest itself as an error from !Edit if the file on the server had grown since last queried, when loading the file the amount of memory reserved was for the smaller (stale cache copy size).
      The name cache is now always flushed on exit from the FileSwitch functions, this doesn't alter performance because the size was already being queried across the network, it was just that the result was overridden by the cached copy.
      LanMan.c:
      Be more robust and only capture the default driver name when it starts up.
      This could be a problem if LanManFS starts after the ethernet driver, and the value of Inet$EtherType is unset. When the driver dies LanManFS would have taken that name as the default - leading to "Bad parameter" when trying to connect to a share.
      
      Tested on IOMD with WinXP SP3.
      
      Version 2.44. Tagged as 'LanManFS-2_44'
      22f3ec34
  9. 22 Nov, 2013 1 commit
  10. 04 Oct, 2013 1 commit
  11. 03 Oct, 2013 3 commits
    • Robert Sprowson's avatar
      Wrap stats report in DEBUG switch · 55ce84d9
      Robert Sprowson authored
      Missed in earlier internationalisation but spotted in the binary - the stats report function is only called from a debug command, but the linker wasn't spotting that and removing the table of stats names.
      Translate the descriptive text in debug_err in RPC.c.
      Retagged as LanManFS-2_41.
      55ce84d9
    • Robert Sprowson's avatar
      Removed verbose mode · 8a3f55c4
      Robert Sprowson authored
      With LanManFS in ROM it's not actually possible to enable verbose mode, since it relies on command arguments being passed to it on initialisation. Since RMREINIT doesn't allow that you can't ever pass '-v'. Even the RAM loaded case isn't that useful, since the verbose text is output via printf() which doesn't appear in the desktop (with OmniClient).
      Swap the few uses of verbose mode to route via DebugLib instead, controlled via the 'DEBUG' predefine.
      Also
        Makefile ammended so debug version has a rule to make the resources area.
      Built, but not tested.
      
      Version 2.41. Tagged as 'LanManFS-2_41'
      8a3f55c4
    • Robert Sprowson's avatar
      Internationalised · e3559214
      Robert Sprowson authored
      Unused LMFiler put in the attic.
      As LanMan has historically put its resources into ThirdPart/OmniClient this component has no ROM resources phase - it still registers the resources at run time.
      
      Version 2.40. Tagged as 'LanManFS-2_40'
      e3559214
  12. 30 Sep, 2013 1 commit
    • Robert Sprowson's avatar
      Makefile recreated from fragments · 95372462
      Robert Sprowson authored
      Fixed up a couple of trivial warnings with the stricter checking.
      Removed OmniS_FastMultiply64 and rewrote the function in C, this allows the compiler to spot and use UMULL on architectures supporting that instruction.
      Tested in a RAM build against a WinXP SP3 server with a drive > 4GB.
      
      Version 2.39. Tagged as 'LanManFS-2_39'
      95372462
  13. 11 Nov, 2012 1 commit
    • Robert Sprowson's avatar
      Fix and speed up EXT#handle=number doing nothing when number is beyond 2GB · 18a0315a
      Robert Sprowson authored
      Internally LanManFS was representing file offsets and data lengths as signed numbers, while in general this doesn't matter (they are passed through opaquely as just numbers and not manipulated) in a couple of places they were being used as while () loop exit conditions.
      Function WriteZeroes (used when extending a file via OS_Args) therefore never performed the call to SMB_Write when beyond 2G because the loop condition was never met.
      Additionally, it was literally transferring buffers of zeros across the network which is unnecessary as the server is documented as doing a zero fill itself, this represents at least a x40 speed up (on a slow 1MB/s drive write speed at the server end) or more.
      Changed offset & lengths from int to uint.
      Added the earlier CIFS spec (the later copy is missing section 5 for some reason) to docs.
      
      Version 2.38. Tagged as 'LanManFS-2_38'
      18a0315a
  14. 21 Sep, 2012 1 commit
    • Robert Sprowson's avatar
      Fix reporting of unstamped file info · db8c11e7
      Robert Sprowson authored
      When a file ended in ',xxx' (unfinished DEADDEAD) or ',lxa' (load/execution addresses) LanManFS was correctly identifying these internally but at the last moment OR'd the result unconditionally with 0xFFF00000 when calculating the date stamp/access attributes.
      Now, an unstamped file will propagate the load & exec addresses properly.
      Tested with WinXP SP3 and a variety of hand constructed examples, plus copying a large file with the filer showed the incomplete file icon until done.
      
      Version 2.37. Tagged as 'LanManFS-2_37'
      db8c11e7
  15. 14 Apr, 2012 1 commit
  16. 14 Dec, 2011 1 commit
  17. 15 Oct, 2011 1 commit
    • Robert Sprowson's avatar
      Fix for *INFO dates not matching *EX dates · a0fb97c2
      Robert Sprowson authored
      These two displays take different code paths, and *INFO goes via a check to workaround a bug in Win98 servers. Unfortunately, the check no longer works because Microsoft don't return the '.' and '..' entries in SMB Trans2 FIND_FIRST, and the logic previously always set the "need to frig the dates" flag. Now, the flag is only set if something comes back and after doing a test swap the results are also correct.
      Turned on the 'auto close Trans2 FIND_FIRST' flag in the request block to save having to do a second transaction to close it.
      Swapped the LDMFD/STMFD for Push and Pull in the assembler.
      Tested against WinXP SP3, dates are no longer bonkers.
      
      Version 2.35. Tagged as 'LanManFS-2_35'
      a0fb97c2
  18. 01 Aug, 2009 1 commit
    • Robert Sprowson's avatar
      Fix for renames where only the case has changed. · 0dabebbd
      Robert Sprowson authored
      Detail:
       Added an extra check after the Xlate path resolution code so that
       the case of the path given to resolve is honoured. This now means that
       the strcmp() done in SMB_Rename fails and the rename is actually sent to
       the server. Before "*rename test Test" would have the path resolved and
       since 'test' already existed both names would be the same, in this example
       something like "*rename A:\test A:\test" would result.
      Admin:
       Made the non LONGNAMES version compile again (not tested).
       Removed local definitions of FSControl reason codes, uses Interface header
       now.
       Made the case of #includes match CVS to allow future compilation on a case
       sensitive system.
       Deleted unused "Version" header.
      
      Version 2.34. Tagged as 'LanManFS-2_34'
      0dabebbd
  19. 19 Jul, 2009 1 commit
    • Robert Sprowson's avatar
      Workaround for NTFS returning resume keys of zero. · d1ca5496
      Robert Sprowson authored
      Detail:
        When the underlying FS is NTFS, eg. WinXP Pro, the requested
        resume keys for a directory search are always zero - this is passed
        back via OSGBPB and on the next call it triggers a new search. So
        we get stuck in an infinite loop.
        Now checks for a resume key stuck at zero, and makes a fake one static
        to the search context then sets the continuation bit in the SMB_FIND_NEXT
        call because the server returning the duff key remembers the position.
        Dir_CallbackFn could return with "taken" undefined. Move a few lines
        higher.
        Missing "#else" added to CHECK_ARMBOOT_EXISTS so if this is disabled
        no further attempt is made to find !ArmBoot.
        Couple of typos corrected.
        Spelling of "disk" changed to "disc" in an error message.
      Admin:
        Tested with XP Pro SP3 with NTFS, directories which previously hung
        the filer now open correctly. Checked with XP Home SP3 with FAT32 to
        verify behaviour unchanged from 2.32.
        Note, with large directories the initial path translation triggers a
        dir search too which takes ages compared with the actual number of
        entries returned. This could be cached to make counting far faster.
      
      Version 2.33. Tagged as 'LanManFS-2_33'
      d1ca5496
  20. 15 Apr, 2009 2 commits
    • Ben Avison's avatar
      Multiple fixes. · 186192a3
      Ben Avison authored
      Detail:
        Too many to list here: see doc/RPSChanges.
      Admin:
        Received from Rob Sprowson approx 2009-02-08. Builds, but not tested by ROOL.
      
      Version 2.32. Tagged as 'LanManFS-2_32'
      186192a3
    • Ben Avison's avatar
      Compatibility change for Microsoft security fix MS09-001. · 3ba506cd
      Ben Avison authored
      Detail:
        Security fix MS09-001 (detailed in Microsoft Knowledge base article KB958687)
        fixes some vulnerabilities in the SMB protocol which LanManFS uses. This
        highlighted an error in SMB_WriteRaw which reported zero data bytes but then
        supplied an offset to the non existant bytes: this is now faulted by Windows.
        As there are no data bytes, the offset should also be zero.
      Admin:
        Fix received from Rob Sprowson 2009-01-19.
      
      Version 2.31. Tagged as 'LanManFS-2_31'
      3ba506cd
  21. 16 Feb, 2004 1 commit
  22. 09 Jan, 2004 1 commit
    • Ben Avison's avatar
      Changes from John. · ac44a2cf
      Ben Avison authored
      Detail:
        > Default filetype now text
        >
        > Default type given to any file that has neither a dos extent, nor a
        > ',xxx' riscos extent at the server
        >
        > Ensure that files given the default type never have a ',xxx' riscos
        > extent appended.
        >
        > Add environment variable 'LMDefaultType' which checked for a default
        > type on module initialisation .. thus setting this to (e.g.) dos, then
        > rmreinitting LanManFS will change the default type to (e.g.) dos.
      Admin:
        Not tested here yet.
      
      Version 2.29. Tagged as 'LanManFS-2_29'
      ac44a2cf
  23. 07 Jan, 2004 1 commit
    • Ben Avison's avatar
      Update from John: · 18f575db
      Ben Avison authored
      > Further mods to make sure that directory naming/renaming cannot attach
      > the ,xxx filetyping.
      
      Version 2.28. Tagged as 'LanManFS-2_28'
      18f575db
  24. 19 Dec, 2003 1 commit
  25. 11 Mar, 2003 1 commit
    • Kevin Bracey's avatar
      Tightened up checking of when sockets get opened and closed in an attempt to... · 527b760b
      Kevin Bracey authored
      Tightened up checking of when sockets get opened and closed in an attempt to work out why Freeway gets upset when LanManFS is configured in IP mode.
      
      Changed app date that OmniClient shows to be dd-mmm-yy
      Added ability to include slimmer ROMSPRITES and deleted the resources
      phase from the makefile: the sprites were being included once in
      ResourceFS and again embedded in the module.
      If the FS is unset it says so in *status rather than a blank line.
      
      Version 2.26. Tagged as 'LanManFS-2_26'
      527b760b
  26. 16 Jan, 2003 1 commit
    • Robert Sprowson's avatar
      Directory rename fixed - the mask being passed by the rename routine didn't... · 99169885
      Robert Sprowson authored
      Directory rename fixed - the mask being passed by the rename routine didn't have the ATTR_DIR bit set.Discovered this after reading lots of the spec which is also now included here in /doc.
      
      Copying files out of LanManFS filer "forgot" their filetype even though
      they appeared right in the filer,fixed.
      A stray debugging printf removed,along with one compiler warning.
      New sprites (yuck) to match !Omni.
      Reordered the shutdown in two places,first Omni_Shutdown bins the mounts
      lists which SMB_Shutdown uses.Second in NetBEUI mode the announcement that
      a protocol has terminated goes *after* the shutdown - otherwise you sit
      around for about 20s wondering where the link has gone.
      
      Version 2.25. Tagged as 'LanManFS-2_25'
      99169885
  27. 16 Dec, 2002 1 commit
    • Robert Sprowson's avatar
      Removed some dubious filetyping logic. · fb9dd3be
      Robert Sprowson authored
      On saving a file if the type was text no filetype information was
      saved and instead it relied on the default for unknown filetypes being
      text.
      The default unknown filetype is now &FE4,plus the above logic would
      have conflicted with the MimeMap code if for example a file of type
      text was saved but which had an extension which was in the mimemap of
      type something other than text.
      
      Version 2.24. Tagged as 'LanManFS-2_24'
      fb9dd3be
  28. 14 Dec, 2002 1 commit
    • Robert Sprowson's avatar
      LanmanFS help syntax corrected and tidied · 49aac30b
      Robert Sprowson authored
      Change lmls command to ListFS in line with NFS
      Supress LF when ListFS is issued but there are no servers present.
      Cast a few things to shut some compiler warnings up.
      Addition of MimeMap lookups where the file has no ",ttt" style type
      appended.Previously any such files were all reported as text files so
      viewing a machine would typically show whole directories full of
      identical filetypes.
      
      Version 2.23. Tagged as 'LanManFS-2_23'
      49aac30b
  29. 08 Jun, 2001 1 commit
  30. 15 Jan, 2001 1 commit
    • Stewart Brodie's avatar
      Experimental change to handle Internet modules in flash. · ddf40c33
      Stewart Brodie authored
      Detail:
        This module was ignoring the possibility of the Internet module being
          re-initialised underneath it - something which can happen if there
          is an Internet module in flash as well as main ROM.  This is an
          experimental fix for this problem.
      Admin:
        Not tested.
      
      Version 2.18. Tagged as 'LanManFS-2_18'
      ddf40c33
  31. 09 Jan, 2001 1 commit
    • Stewart Brodie's avatar
      Fixed bug in parsing of the protocol negotiation. · 4b49606e
      Stewart Brodie authored
      Detail:
        The wrong bit was being checked to see if we were using the extended
          security model (CAP_EXTENDED_SECURITY).  Thus the wrong format was
          being used in SMBsesssetup, which meant that we couldn't connect
          to Windows 2000.
        Much better debugging added to the name resolution code - this helped
          diagnose the faulty photocopier problem and is left in case anything
          like that happens again!
      Admin:
        Tested - I can now connect to Win 2000 shares.
      
      Version 2.17. Tagged as 'LanManFS-2_17'
      4b49606e
  32. 25 Aug, 2000 1 commit
    • Stewart Brodie's avatar
      Fixed some incorrect symbol names. · c0fd0009
      Stewart Brodie authored
      Detail:
        Some symbol names were wrong which only showed up in ROM builds.
      Admin:
        Tested in Ursula ROM build, and tested RAM build.
      
      Version 2.15. Tagged as 'LanManFS-2_15'
      c0fd0009
  33. 11 Aug, 2000 1 commit
    • Stewart Brodie's avatar
      New build option to exclude NetBEUI support. · 61345d56
      Stewart Brodie authored
      Detail:
        Pass OPTIONS=-DNO_NETBEUI from the Components file if you do not need
          NetBEUI support, and LanManFS will be 12K smaller.
        In NetBEUI mode, LanManFS sends Service_DCIProtocolStatus as required.
        In IP mode, LanManFS notices Service_DCIProtocolStatus from the Internet
          module when it dies and marks all its sockets as needing reconnection.
        Booting behaviour changed to look for !ArmBoot again and not attempt
          the boot if it is missing.  Removed lots of grotty backdoor hacks
          that used to be used to determine this.
      Admin:
        Not tested at all.  This will need very thorough testing before it can
          be considered for release.
      
      Version 2.14. Tagged as 'LanManFS-2_14'
      61345d56
  34. 08 Aug, 2000 2 commits
    • Stewart Brodie's avatar
      Calls LLC_Shutdown if NetBIOS's _NB_Startup is going to fail. · 6adc491d
      Stewart Brodie authored
      Detail:
        NB_Startup was failing to stop the LLC timers if the function
          was going to fail after hooking onto TickerV.  This meant that
          if LanManFS never found an appropriate driver for NetBIOS use,
          then killing the module resulted in repeated aborts when the
          TickerV handler has invoked.
      Admin:
        Untested.
        Fixes Bugzilla bug #26
      
      Version 2.13. Tagged as 'LanManFS-2_13'
      6adc491d
    • Stewart Brodie's avatar
      Fixed machine stiff if connection left idle too long. · 4fc58c21
      Stewart Brodie authored
      Detail:
        SVC stack overflow occurred due to the recursive method used to
          discard the idle-out prevention responses.  This no longer
          happens.
        Fixed a bit of debugging which caused data aborts!
        Optimised a select() call to pass s + 1 as the first parameter to
          save Internet time in processing the fd_set.
      Admin:
        Tested on desktop build, with the idle timers set to send idle outs
          every second (so we don't have to wait 100 hours for the problem
          to occur).  No longer get problems with the machine stiffing.
      
      
      Version 2.12. Tagged as 'LanManFS-2_12'
      4fc58c21
  35. 04 Apr, 2000 1 commit
    • Stewart Brodie's avatar
      Fixed use of uninitialised pointer. · 01a3f774
      Stewart Brodie authored
        Now doesn't require that the !ArmBoot object is a directory
      Detail:
        The code in Omni.c was carefully checking that !ARMBOOT existed
          before attempting to run the boot file.  Unfortunately, it was
          using a method which bypassed the filename resolution (that does
          the ,xxx filetype name mapping), so it did not find the new Obey
          file in the 400 series baseline.  The check has been removed.
        The code in SMB.c was being caught out on an uninitialised variable
          usage when the attribute cache already held details of the object
          being sought.  The variable would have been initialised on a non-
          cached lookup, but the special case of booting a machine via LanManFS
          manages to get a cached lookup without having run through the routine
          before, resulting in a strcpy() with a destination of 0.
      Admin:
        Tested on Risc PC.
        Fixes fault 1511 (STB-400 Generic)
      
      Version 2.11. Tagged as 'LanManFS-2_11'
      01a3f774
  36. 21 Jan, 2000 1 commit
    • Stewart Brodie's avatar
      More tolerance has been added of files found on the remote server which have unexpected extensions. · 36543191
      Stewart Brodie authored
      Detail:
        LanManFS does not like it if you create (independently, using a PC or
          otherwise) files with names like "myfile,fff" which you intend to
          be displayed as files with type &FFF (ie. Text) on a RISC OS machine.
          If you tried to access the file for reading it, such as loading it
          into an editor, that worked due to the name matching resolution.
          However, any attempt to update the file caused LanManFS to attempt
          to write the file without the extension and not notice that a file
          with a ,fff extension already existed (Text files are special cased
          in the current implementation of name translation - see LanManFS
          Functional Specification for details and rationale).  Attempts to
          save typically succeed (giving you two files: myfile and myfile,fff)
          but generate "Operation not permitted" or such like.  This stemmed
          from the attempt being made by LanManFS to rename a file to the same
          name.  SMB_Rename now traps that and tells its caller that the rename
          succeeded.  The Xlate.c code now indicates correctly that the filename
          extension has been altered when a ,fff extension has to be chopped off.
      Admin:
        Tested briefly on desktop build against art-work's SAMBA server.
        Bug reported by TopCat engineers.
      
      Version 2.10. Tagged as 'LanManFS-2_10'
      36543191