Detail: The SMB protocol requires the timesstamp to be in the server's timezone. The serverTimeZone returned by SMB_Negotiate is used to convert the RISC OS timestamp to SMB timestamp.
Fixes Ticket #613
Modifief files: Corefn.c SMB.c Xlate.c SMB.h Xlate.h
Tests: Tested by reading the filestamp of a saved file on Windows, Linux and RISC OS.
Tested with AMU. Compiling from a linux
server AMU now sees mods to files made from
other OS as newer.
Note: Connecting to a local server in the winter in the UK will not show the timestamp problem as the server timezone will be 0.
ROOL (5f676135) at 02 Oct 20:07
[613] Use server timezone in timestamp conversion
Some leftover brackets - don't forget to check your diffs!
Isn't the hS
from line 534 still in scope? No need to look it up again.
This looks like a dead variable, it's only ever set or ineffectively cleared to NULL.
Minor stylistic: *
stuck to the variable not the type; spaces either side of ()
; uppercase g
on Get
.
Could also go for a const char *
to be explicit it's only ever read.
Detail: The SMB protocol requires the timesstamp to be in the server's timezone. The serverTimeZone returned by SMB_Negotiate is used to convert the RISC OS timestamp to SMB timestamp.
Fixes Ticket #613
Modifief files: Corefn.c SMB.c Xlate.c SMB.h Xlate.h
Tests: Tested by reading the filestamp of a saved file on Windows, Linux and RISC OS.
Tested with AMU. Compiling from a linux
server AMU now sees mods to files made from
other OS as newer.
Note: Connecting to a local server in the winter in the UK will not show the timestamp problem as the server timezone will be 0.
Detail: Drop COMPAT_INET4 switch, not needed as OmniClient only links with InetLib. Change the requirements for the Startup script to want Internet 5 or later. Use Push/Pull so single word stack operations turn into LDR/STR. Enable CI job. Admin: Submission for TCP/IP bounty.
ROOL (746dde33) at 25 Aug 19:45
Drop COMPAT_INET4 support
Detail: Drop COMPAT_INET4 switch, not needed as OmniClient only links with InetLib. Change the requirements for the Startup script to want Internet 5 or later. Use Push/Pull so single word stack operations turn into LDR/STR. Enable CI job. Admin: Submission for TCP/IP bounty.
ROOL (2986cfa2) at 06 Apr 16:39
Restore original indentation of tag 'NetFiler-1_17'
... and 2 more commits
ROOL (9c782d13) at 06 Apr 16:36
Restore original indentation of commit d9774fb2
... and 1 more commit
Detail: Fill in the sockaddr_in address length, cater for varying ifconf entry size. Use agnostic TCPIPLibs: include path, so CI works. Admin: Submission for TCP/IP bounty.
ROOL (e9f63a58) at 22 Mar 21:26
Drop COMPAT_INET4 support
Detail: Fill in the sockaddr_in address length, cater for varying ifconf entry size. Use agnostic TCPIPLibs: include path, so CI works. Admin: Submission for TCP/IP bounty.
ROOL (246a5dbf) at 22 Mar 21:15
Makefile recreated from fragments
Detail: Fill in the sockaddr_in address length. Use agnostic TCPIPLibs: include path, so CI works. Admin: Submission for TCP/IP bounty.
ROOL (ccac337f) at 01 Mar 08:53
Drop COMPAT_INET4 support