GitLab

Don't leak pchBuffer on error.
Found by cppcheck static analysis.
Tagged as DualSerial-0_25-4_8_2_16-1 since DualSerial itself is unchanged.

Detail:
 (handshake reported back was inconsistent with handshake requested)
Admin:
tested on iMx6


Version 0.25, 4.8.2.16. Tagged as 'DualSerial-0_25-4_8_2_16'

Detail:
  s/serialhal - Adjust IRQ handler so that both line status interrupts and RX interrupts are handled via HAL_UARTReceiveByte (with line status return), so that the module can deal with controllers where the IRQ state doesn't correspond to the top byte in the FIFO (e.g. PL011), and so it can avoid the ambiguity around HAL_UARTLineStatus.
  s/main - Fix CloseMessages to take into account the possibility of the workspace pointer being null
Admin:
  Tested on Raspberry Pi 1


Version 0.25, 4.8.2.15. Tagged as 'DualSerial-0_25-4_8_2_15'

Detail:
  s/main, s/serialhal - For threshold-based transmitter empty IRQs, make UpdateDTRRTSTXI710 transmit as many bytes as possible until we either hit the FIFO upper limit or decide to stop. This is required to "prime" the interrupt because it may only update when the FIFO level crosses the threshold (e.g. PL011)
Admin:
  Tested on Raspberry Pi


Version 0.25, 4.8.2.14. Tagged as 'DualSerial-0_25-4_8_2_14'

Comments now reflect what they do rather than where they were copied & pasted from.
Retagged as DualSerial-0_25-4_8_2_13.

Added HAL_UARTFeatures bit to report that the chip does hardware RTS/CTS handshaking, and use chip RTS/CTS if available in Seria

Detail:

Admin:
  tested on iMx6


Version 0.25, 4.8.2.13. Tagged as 'DualSerial-0_25-4_8_2_13'

Detail:
  s/serialhal - Fixed HAL_UARTModemControl being called with r2 uninitialised, causing modem control lines to be set to unpredictable values
  s/main - Fixed UAL syntax warning caused by typo
Admin:
  Tested on rev A2 BB-xM
  HAL now reports correct modem control line states when control lines are poked via OS_SerialOp


Version 0.25, 4.8.2.12. Tagged as 'DualSerial-0_25-4_8_2_12'

Detail:
  In order to act as a client of SerialSupport, DualSerial needs to support the set of device calls that SerialSupport uses to talk to the serial driver.
  This set of device calls operates at a lower level than the IOCtl interface which DualSerial already supports.
  Therefore simply adding the new device call interface ontop of DualSerial (or modifying SerialSupport to add IOCtl support) would have been a risky venture, due to the many complexities hidden in the Serial module sources.
  So to reduce the amount of risk inherent in the change, I've instead taken the Serial module, stripped out 6551 support, rewritten the 710 interface to use HAL calls, and then bolted the IOCtl interface on top.
  This should ensure the SerialSupport/OS_SerialOp interface is identical to that provided by the Serial module, and only the simpler to understand DualSerial/IOCtl interface is the one likely to contain any bugs.
  File changes:
  - Docs/serial.htm - Added a copy of the IOCtl interface docs, from the Ursula branch
  - s/common, s/errors, s/init, s/macros, s/main - New implementation of the module, based around modified Serial sources
  - s/serialhal - The business end of the module, based around s/Serial710 in the Serial sources
  - s/ioctl - New file containing reimplemented IOCtl interface
  - s/devicecall, s/hardware, s/interrupts, s/standalone - Deleted redundant files from old implementation
  - Makefile - Trimmed somewhat redundant comment
  - resources/UK/messages - Added new error messages
Admin:
  Tested in OMAP3 & Tungsten ROMs


Version 0.25, 4.8.2.11. Tagged as 'DualSerial-0_25-4_8_2_11'

Detail:
  Uses suffixed file extensions for compatiblity with both objasm and asasm.
Admin:
  Supplied by Peter Naulls, tested at ROOL

Version 0.25, 4.8.2.10. Tagged as 'DualSerial-0_25-4_8_2_10'

Admin:
  Tested in STB Baseline build

Version 0.25, 4.8.2.9. Tagged as 'DualSerial-0_25-4_8_2_9'

Changes from Kevin: support for clearing the interrupt when it has been serviced using HAL_IRQClear.

Version 0.25, 4.8.2.8. Tagged as 'DualSerial-0_25-4_8_2_8'

Change to use objasm (the non HAL one already has): fixes report that it blew messagetrans away when rmkilled.

Change to have a zero in the command table word: fixes report that
serialinfo and serialtest don't do anything,indeed they don't in this
HAL version!

Version 0.25, 4.8.2.7. Tagged as 'DualSerial-0_25-4_8_2_7'

Version 0.25, 4.8.2.6. Tagged as 'DualSerial-0_25-4_8_2_6'

Version 0.25, 4.8.2.5. Tagged as 'DualSerial-0_25-4_8_2_5'

Detail:
  IOCtl wasn't dividing the returned value from the HAL by 16.

Admin:
  Assembles, not tested.

Version 0.25, 4.8.2.4. Tagged as 'DualSerial-0_25-4_8_2_4'

Detail:
  The function hardware_ctrl_lines which is called from the modem ioctl,
wasn't preserving r3, which points to the ioctl data buffer, hence modem
ioctls weren't functioning correctly.  r3 was being corrupted by a HAL call,
which must be ATPC compliant i.e. r0-r3 are corrupted.

Admin:
  Tested on customer L board by RMFastering the serial module and patching it with
memorya.  The ioctl calls then worked and the dialler worked.



Version 0.25, 4.8.2.3. Tagged as 'DualSerial-0_25-4_8_2_3'

Version 0.25, 4.8.2.2. Tagged as 'DualSerial-0_25-4_8_2_2'

Actually authored by DEllis.

Version 0.25, 4.8.2.1. Tagged as 'DualSerial-0_25-4_8_2_1'

Detail:
  This version represents the merge of the 32-bit conversion of the DualSerial
    module.
Admin:
  This module has received a modest amount of testing, however, it has not
    been exhaustively tested.  Projects taking this version should be careful
    of it as it may contain bugs.

Version 0.25. Tagged as 'DualSerial-0_25'

Reading would return a copy of the last known state.
Reading now really reads the contol lines so you can do stuff like polling
them or whatever.

Version 0.24. Tagged as 'DualSerial-0_24'

Version 0.23. Tagged as 'DualSerial-0_23'

Version 0.22. Tagged as 'DualSerial-0_22'

Version 0.21. Tagged as 'DualSerial-0_21'

Version 0.18. Tagged as 'DualSerial-0_18'

Changed to use srccommit.
Spinner branch merged.

Version 0.17. Tagged as 'DualSerial-0_17'