GitLab

Detail:
  s/Module - Fix null pointer dereference in drive detection code if an ATAPI device is found which failed to respond to ADFS's identify packet
Admin:
  Untested
  Should fix issue reported on forums:
  https://www.riscosopen.org/forum/forums/5/topics/3929


Version 1.40. Tagged as 'ATAPI-1_40'

The ReadData function already has 2 workarounds for some quirks with Sony and Panasonic drives, using READ_CD to emulate the behaviour of READ_DATA because the latter didn't work on the particular models Acorn shipped. However, with DVD drives some firmware vendors have been a bit literal about what READ_CD does, so you end up in a situation of being able to read a CD but not a DVD in an otherwise identical setup.
Change the retry loop from 2 goes to 3. On the 3rd attempt just try using READ_DATA(12) like the standard intended, so we retain the former workarounds and only use that command last. Note that READ_DATA(2) only has a 2 byte block count which would be a truncation from READ_CD's 3, so using READ_DATA(12) with a 4 byte block count keeps the command block shuffling simpler.
Tested on a HP branded TS-H653 and Pioneer DVR-TD11RS with an ISO9660 DVD-R.

Version 1.39. Tagged as 'ATAPI-1_39'

When CDFS wants to change the drive's data mode to mount a DVD it does so via CD_SetParameters. As a side effect of that call, the read retry count is written too.
Some drives return illegal request errors when trying to set the read retry count (even though they're marked as changeable), so just swallow the error like CDFSSoftSCSI does (driver.c revision 1.4 line 566).
Fixes "Compact disc is faulty" error with Samsung SH-S223B drive - the error message was spurious as it's just the default the error handler assumes when it can't look up error 0x50.

Version 1.38. Tagged as 'ATAPI-1_38'

Use Hdr:SWIs to get our SWI base, not the two local defines, similarly error base.
Correct a handful of misleading comments.
Same binary, not tagged.

Now we're using CVS, the switches from 1997 and earlier are just clutter.
Built same binary, not tested.

Version 1.37. Tagged as 'ATAPI-1_37'

Detail:
  A couple of the routines relied on pre-ARMv6 style LDM functionality, and
  would abort on ARMv7+ (or ARMv6 in ARMv7 mode, if we ever get an ARMv6
  platform with ATAPI). Also took the opportunity to replace a lot of byte
  swizzling code fragments with REV instructions if only targeting ARMv6 or
  later. Bit of a shame they weren't macroised considering how many times
  they were used...
Admin:
  Untested

Version 1.36. Tagged as 'ATAPI-1_36'

Hdr:ATA needs an error base from Hdr:NewErrors. Also, be explicit about the no data transfer ATAPI case (even though the define is 0).
Retagged as ATAPI-1_35.

Detail:
  The physical ID by which ATA and ATAPI drives are address has been expanded
  in ADFS 4 from 2 bits to 12. For now, CDFSSoftATAPI is still limited to 4
  drives, and scans the first 4 physical IDs returned by SWI ATA_Enumerate
  (falling back to the 4 legacy physical IDs if the SWI isn't found). This
  will fail on boards with more than 4 physical SATA ports, but caters for
  all current hardware. Also sneaked in the use of LDRH in the SWI dispatcher.
Admin:
  Tested on a Titanium board.

Version 1.35. Tagged as 'ATAPI-1_35'

When no drives are detected (but some are configured) CDFSSoftATAPI goes dormant by setting its private word to 0. However, when the module finalises (eg. an RMReinit) that NULL value is then used to call CD_Unregister, and attempting to free the same NULL value with OS_Module.
Also replaced magic numbers from Hdr:ModHand and Hdr:OsBytes.

Version 1.34. Tagged as 'ATAPI-1_34'

Disassembly unchanged apart from the single register STM's which now use STR ith writeback.

Version 1.33. Tagged as 'ATAPI-1_33'

Changed debugging to run with DebugIt prior to possible code changes.  No actual code changes, so module version not changed.

Detail:
Admin:  built in test tungsten rom. works


Version 1.32. Not tagged

Now responds to "Driver in use" errors returned from ADFS_ATAPIOp by retrying up to the specified timeout (or 10 seconds for internally generated

SCSI_Ops). If the timeout is reached, the CD_SCSIUserOp entry point will
return a SCSI-compatible "ATAPI driver reservation error" error pointer;
other entry points pass "Driver in use" through unchanged.
Also added GPA generation capability, for what it's worth.

Version 1.32. Tagged as 'ATAPI-1_32'

Speed setting tweaked one more time. Now asks for 176.4 * speed - this works a bit better on some drives (eg Sony) which round down. Nominal basic CD rate is 176400 bytes/second.

Version 1.31. Tagged as 'ATAPI-1_31'

Detail:
  * Byte sex swap fix applied to the code to set the drive speed
  * SCSI-3 spec says that ATAPI packets have to be padded with 0 bytes;
    routines changed accordingly (though this does mean we now have to do
    a tedious copy onto the stack for every operation)
  * All disc errors returned from ADFS_ATAPIOp were accidentally ignored!
  * Internal disc number wasn't being shifted left by 15 bits before being
    used to do a REQUEST SENSE command packet, resulting in it doing a
    reset of any slave devices instead of sending a PACKET command
  * TARGETERROR error numbers weren't being correctly constructed in
    ATAPI_Op (it was using the error pointer instead of the sense key)
  * Worked round another assumption of flag preservation in CD_ SWIs
  * Fixed pathname of messages file to include $
Admin:
  Tested on Tungsten.

Version 1.30. Tagged as 'ATAPI-1_30'

Detail:
  * Removed IOMD dependency - reimplemented to use ADFS_ATAPIOp and
    ADFS_IDEDeviceInfo
  * Supports 4 drives (previously 2)
  * Support for SCSIUserOp entry included
Admin:
  Requires ADFS 3.34 (or intermediate version after 3.33).

Version 1.29. Tagged as 'ATAPI-1_29'

Detail:
  * Moved resources here from CDFSResources - allows tokenisation
  * Uses objasm, shared makefiles and global headers
  * 32-bit compatible
Admin:
  Not tested. Still IOC/IOMD-centric.

Version 1.28. Tagged as 'ATAPI-1_28'

Detail:
  This module had sets of defines for what options to have in what
   version of the module, instead of just using different versions out
   of a source control system...very odd.  Changed code to say
   "if version is over 1.24, use these standard flags".  Also removed
   check for a "too high" version number.
Admin:
  Built.


Version 1.27. Tagged as 'ATAPI-1_27'

Detail:
  Merged Ursula branch, only change was removal of dynamic dependencies
   from Makefile.

  Moved to srccommit usage, changed some occurences of "Version" to
   "ModuleVersion", as defined in VersionASM. Removed obsolete "Version"
   file.
Admin:
  Added stripdepend call to clean rule
  Additionally added a "GET Hdr:Machine.<Machine>" into s.Main to
   make it assemble correctly.


Version 1.26. Tagged as 'ATAPI-1_26'

Sprout from master 1996-11-05 09:35:05 UTC Neil Turton <nturton@gitlab.riscosopen.org> 'Import from cleaned 360 CD'
Delete:
    s/ATAPIstuff