1. 13 Jan, 2013 1 commit
    • Jeffrey Lee's avatar
      Automatically adjust wimpslot when running AIFs via FSControl 4 · 1c07c7cd
      Jeffrey Lee authored
        s/FSCommon - Adjust ValidateR2R5_WriteToCoreCodeLoad to try and increase the wimpslot if it isn't already big enough to contain the region being validated (i.e. the program being loaded)
        s/FSControl - FSControl 4 now checks AIF memory limts and tries to extend wimpslot as necessary both before and after decompression. An extra 8K is added to the calculated memory requirements to take into account memory which isn't declared in the header (root stack chunk?) which is required by SCL initialisation.
        Tested in Iyonix ROM softload
        This should eliminate most/all of the "No writeable memory at this address", abort on data transfer, and "Not enough memory for C library" errors users receive due to the wimpslot being too small when all they want to do is run a program
      Version 2.81. Tagged as 'FileSwitch-2_81'
  2. 05 Jan, 2013 1 commit
  3. 09 Dec, 2012 1 commit
  4. 02 Dec, 2012 1 commit
    • Robert Sprowson's avatar
      Fix dereference of duff FS control block when resolving badly formed paths · f9d6deff
      Robert Sprowson authored
      In OS_Find there is a call to TopPath_DoBusinessToPath in DoTheOpen, any V set exits from this are propagated to the user correctly.
      Non V set exits (ie. the object type is returned) are passed to DoTheOpen_Common which in turn calls TryToOpenFile. TryToOpenFile (if fscb is not Nowt) dereferences it to get at the info word.
      A problem exists where TopPath_DoBusinessToPath fails the policing check - when multipart paths are permitted (such as OS_Find) it swallows the error, steps the path, and eventually exits with an object type 0. However, this code path never sets up the fscb.
      So when TryToOpenFile dereferences it (in testing it seemed to have some address in the kernel lingering) depending on your luck the fsinfo_alwaysopen bit might be set. This in turn triggers a forced call to the low level FS entry point, and the entry point is some garbage address leading to an abort.
      The minimalist test cases were
      both of which fail the policing step because the incorrect use of the path type bits mean the attempted name becomes MyPath$MyName and you can't have '$' in the middle of a filename. Other more complex examples exist, including having a multipart path where one of the path elements in invalid.
      Solved here by setting fscb up to a default (valid) value.
      Fixes ticket #287.
      Version 2.80. Tagged as 'FileSwitch-2_80'
  5. 19 Nov, 2012 2 commits
    • Robert Sprowson's avatar
      Make internal calls to EnsureFileSize saturate at 0xFFFFFFFF rather than error · 2ebf3e19
      Robert Sprowson authored
      The corresponding external interface, OS_Args 6, takes a byte size in R2 which is passed on verbatim. However, when FileSwitch wants to do the same operation it rounds up to the nearest buffer size and complains the operation can't complete ("File too big") when the same operation through OS_Args would succeed.
      Internally FileSwitch doesn't actually use the allocated size for anything (other than to avoid unnecesary ensures, and to cache the value for read back via OS_Args 4), so the full byte range of R2 is now allowed internally as well as externally.
      FSEntry_Open may also pass back 0xFFFFFFFF as the allocated size on opening similarly.
      FSEntry_Args 7 and FSEntry_Args 4 are the corresponding low level API, these are unchanged in meaning.
      The FSEntry_Args 8, write 0s to file (usually triggered by extending with EXT#handle=number), is defined as always passing the file offset as a multiple of the buffer size, and the number of 0s to write as a multiple of the buffer size. To allow this to write up to 4G of 0s while not spilling over R3, FileSwitch now splits such a call into one buffer, followed by the remainder.
      Tested with LanManFS 2.38, checking operations are split appropriately.
      Version 2.79. Tagged as 'FileSwitch-2_79'
    • Robert Sprowson's avatar
      Tabs expanded in IOCtl OS_Arg · 48bc2294
      Robert Sprowson authored
      Not tagged.
  6. 15 Jul, 2012 1 commit
    • Ben Avison's avatar
      Bugfix to *Copy · 9367a4d8
      Ben Avison authored
        With *Copy A, and the related SWI OS_FSControl 26 with R3 bit 9 clear, if
        a directory was copied over an image file, the contents of the directory
        would be copied (assuming recursive) but then when the attributes were
        copied over, the directory's filetype (usually FFD, Data) and user access
        bits (both 0) were copied to the destination image file, rendering it
        Tested on a Raspberry Pi with the DOS partition in the standard disc image.
      Version 2.78. Tagged as 'FileSwitch-2_78'
  7. 09 Jul, 2012 1 commit
    • Jeffrey Lee's avatar
      Fix a couple of null/bad pointer dereferences · d9c7abb7
      Jeffrey Lee authored
        s/FSControl - faff_boot_option_startup (OS_FSControl 47/48) was acting as if it was given a path variable in r3, but neither of those calls use path variables, leading to aborts in some situations due to random bits of memory being peeked at.
        s/FSUtils - When CopyWildObject performs a single object copy, it wasn't taking into account the fact that the src/dest leafname pointers could be null, potentially causing a crash if high processor vectors are in use.
      Since I'm not 100% sure what the correct course of action is (in the case I saw it crash, both src and dest leafnames were null), and there aren't any bugs I know of with file copies using the wrong names, the code now uses the dest leafname if the dest leafname is null.
      This sounds wrong, but matches the behaviour of the old code, since byte &00000000 is highly unlikely to contain a '*' character
        Tested on BB-xM with high processor vectors
      Version 2.77. Tagged as 'FileSwitch-2_77'
  8. 09 Apr, 2012 1 commit
    • Jeffrey Lee's avatar
      Fix TopPath_DoBusinessToPath leaking memory on error · 1f3b4bd6
      Jeffrey Lee authored
        s/TopPath - Code which attempted to free the cleaned up user's path incorrectly assumed that it could find the string via the stacked R0. However stacked regs R0-R6 get updated with the found objects details, so we need to store a copy of the users R0 elsewhere and free the string via that instead.
        Fixes OS_FSControl 37 (and other operations?) filling the system heap if given paths which will generate errors (e.g. if drive empty/missing)
      Version 2.76. Tagged as 'FileSwitch-2_76'
  9. 18 Mar, 2012 1 commit
  10. 20 Feb, 2012 2 commits
  11. 27 Nov, 2011 4 commits
  12. 22 Oct, 2011 1 commit
  13. 20 Oct, 2011 1 commit
    • Robert Sprowson's avatar
      Fix for *COPY finishing too early with files > 2G · bd64d61d
      Robert Sprowson authored
      Same drill, V was being set or not preserved when it shouldn't or should be. In light of this all locations that do CMP/SUBS/ADDS involving fileptr/extent/anything ending in size or length have been reviewed and ammended where needed.
      Trim some dead code.
      Discard 'Version' file.
      Version 2.70. Tagged as 'FileSwitch-2_70'
  14. 16 Oct, 2011 2 commits
    • Robert Sprowson's avatar
      Put back a debug line, deleted in error. · d815ac29
      Robert Sprowson authored
      Retagged as FileSwitch-2_69.
    • Robert Sprowson's avatar
      Fix OS_Args 1 and OS_GBPB 3/4 for files > 2G. · cce1584b
      Robert Sprowson authored
      In OS_Args 1 a compare was followed by a conditional store, but with files > 2G some circumstances end up with VS so the store wasn't taken.
      In OS_GBPB 3/4 the assessment of how much could be done was based on adding the current fileptr to the request but not respecting the carry out. Reordered the equation to get this calculation right.
      Changed a signed compare of a byte variable to use unsigned so auditing of signed condition codes is clearer.
      Corrected spelling of 'openning'.
      Fix copy_srchandle and copy_dsthandle to not assume handles fit in 1 byte.
      Tested on a variety of contrived file sizes at the boundaries of 2G and 4G.
      Version 2.69. Tagged as 'FileSwitch-2_69'
  15. 04 Aug, 2011 1 commit
    • Jeffrey Lee's avatar
      Update to work with zero page relocation · 0b0a3063
      Jeffrey Lee authored
        s/FileSwBody, s/FileSwHdr - Try getting DomainId pointer via OS_ReadSysInfo 6 before falling back on legacy address. Store result in workspace for speedy lookup.
        s/FSCommon - Use workspace DomainId pointer
        s/CtrlUtils - Update int_ConstructFullPathWithoutFSAndSpecial to not attempt to append the contents of null string pointers.
        s/FSControl - Update AppendStringIfNotNull to ignore null pointers
        s/LowLevel - Update CallFSFile_Given to not try copying from null special field strings
        Tested on rev A2 BB-xM.
        AFAIK the null pointer bugs are all FileSwitch bugs and not bugs in whatever called FileSwitch, although I may be wrong. Not entirely sure how some of the code managed to read strings from null pointers without creating garbage filenames as a result!
      Version 2.68. Tagged as 'FileSwitch-2_68'
  16. 15 Jun, 2009 1 commit
    • Ben Avison's avatar
      Bugfix to OS_File 5 · 389710f2
      Ben Avison authored
        s.LowLevel: STRNE should have been STRNEB. Looks like this meant that
        OS_File 5 was broken if the object name contained a filing system special
        Added ENTRY directive to permit building of GPA debug listing.
        Built but not tested (should be a safe change).
      Version 2.67. Tagged as 'FileSwitch-2_67'
  17. 11 Jun, 2009 1 commit
    • Ben Avison's avatar
      GET file pathnames changed · 5d90bec5
      Ben Avison authored
        Uses suffixed file extensions for compatiblity with both objasm and asasm.
        Supplied by Peter Naulls, tested at ROOL
      Version 2.66. Not tagged
  18. 01 Jul, 2004 1 commit
  19. 12 Dec, 2002 1 commit
  20. 20 Aug, 2001 1 commit
    • Dan Ellis's avatar
      Fixed bug in memory allocation check code. · 0c40540e
      Dan Ellis authored
        Code has been added to fileswitch to detect whether there is sufficient
      memory for a program to execute, and report a sensible error rather than
      aborting in it's initialistion code.  This implicitly relied on R12 in
      the error routines, which was being corrupted.  R12 register usage has now
      replaced by other safe registers.
        This was exacerbated by incorrectly formed AIF headers, such as those
      generated by at least some versions of the Easy C Linker, which don't have
      correct entries for the size of the data areas of the file.
        Tested on a RPC.  The system appears to work correctly, and malformed AIF
      headers cause the error to be raised without other harm.
      Version 2.64. Tagged as 'FileSwitch-2_64'
  21. 04 Jun, 2001 1 commit
    • Stewart Brodie's avatar
      Third time lucky. · 58496303
      Stewart Brodie authored
        Tested - and it doesn't result in FileCore in use errors any more.
      Version 2.63. Tagged as 'FileSwitch-2_63'
  22. 02 Jun, 2001 1 commit
    • Stewart Brodie's avatar
      The check I added in the previous version didn't work :-( · 701872a3
      Stewart Brodie authored
        R12 cannot be corrupted until FileSwitch is committed to starting the
          new application.  Changed code to not use R12 any more until it is
          100% sure that the application is going to be launched come what may.
        Not built; not tested - but version 2.61 is not useful.  Should work now.
      Version 2.62. Tagged as 'FileSwitch-2_62'
  23. 30 May, 2001 1 commit
    • Stewart Brodie's avatar
      AIF image header checks improved. · 71bf193a
      Stewart Brodie authored
        AIF headers declare how much space they are going to need in addition
          to the size of the executable on the filesystem.  This information
          is now extracted by FileSwitch to validate that the memory limit
          will not be exceeded.
        Built.  Not tested.
      Version 2.61. Tagged as 'FileSwitch-2_61'
  24. 14 May, 2001 1 commit
    • Dan Ellis's avatar
      Closing a file now allows the underlying filing system to object, preventing... · 4b9cb9e9
      Dan Ellis authored
      Closing a file now allows the underlying filing system to object, preventing the file from being closed.
        The error return from the underlying filing system wasn't being used to
      prevent the fileswitch record for the open file being removed.  This resulted
      in the underlying filing system not being able to prevent closure of a file
      handle.  This behaviour is relied upon by PipeFS when it returns an error
      from the Sleep No More UpCall.
        Tested on RPC.  Note that the 32 bit build doesn't work on the 26 bit
      desktop for no identified reason.
      Version 2.60. Tagged as 'FileSwitch-2_60'
  25. 10 May, 2001 1 commit
  26. 17 Apr, 2001 2 commits
    • David Cotton's avatar
      Now works. · 081332d6
      David Cotton authored
          The version of Stewart's notes that I was using to convert the component
      to support ObjAsm was out of date, and hence missed out a couple of sections
      on converting Asm headers to C headers and tokenisation. This would only have
      been picked up when building straight out of CVS. A classic case of RTLM
      (read the latest manual). However, doing this work showed up a bit missing
      from Stewart's notes, so it is really a case of RTLMWSHWI, or read the latest
      manual when Stewart has written it). ;-)
          The makefile has been altered to ensure that the correct operations occur.
          Not tested in a build. Checked the logs from running export headers,
      libs, resources and rom phases against a pre-objasm build and verified that
      all the same steps are occuring.
      Version 2.58. Tagged as 'FileSwitch-2_58'
    • David Cotton's avatar
      Altered to use shared makefiles and ObjAsm. · 8d9ceeb7
      David Cotton authored
          As above. No other changes.
          Tested in a Lazarus build.
      Version 2.57. Tagged as 'FileSwitch-2_57'
  27. 04 Apr, 2001 1 commit
    • Dan Ellis's avatar
      Fixed some data aborts on OS_Args calls · dc300ea2
      Dan Ellis authored
        OS_Args 8 and 9 (ImageStampIS and IOCtl) didn't check that the file handle
      passed to them was legitimate and hence would cause data aborts as they tried
      to access non existant structures.
        Not tested.  Two lines of assembler copied into each function to test
      whether the file handle is valid from other similar calls.
      Version 2.56. Tagged as 'FileSwitch-2_56'
  28. 03 Apr, 2001 1 commit
    • Ben Avison's avatar
      Minor bugfix. · 7285fc6d
      Ben Avison authored
        UpCall 3 (ModifyingFile) is no longer issued by OS_File 24 (ReadBlockSize).
        Not tested.
      Version 2.55. Tagged as 'FileSwitch-2_55'
  29. 19 Mar, 2001 1 commit
    • Stewart Brodie's avatar
      hdr/LowFSI was not objasm-compatible! · f9694709
      Stewart Brodie authored
        It is not legal for lines to end in \ unless the intention is that the
          line be rejoined.  This caused a structure member to be missing in the
          filing system header file which could have caused absolute havoc.
        Assertions are dead useful ...
        Required by SystemDevices 1.30 or later (and other components)
      Version 2.54. Tagged as 'FileSwitch-2_54'
  30. 01 Mar, 2001 2 commits
    • Simon Forrest's avatar
      Should've removed StripDepnd support from Makefile, since I moved the support... · 0d3e47c5
      Simon Forrest authored
      Should've removed StripDepnd support from Makefile, since I moved the support to MkClean.  Now removed.
      Retagged as FileSwitch-2_53.
    • Simon Forrest's avatar
      * Removed dependency on obsolete STB flag. · 999979db
      Simon Forrest authored
        * No longer relies on the STB flag; instead utilises "Hdr:UserIF.<UserIF>"
          to provide the Embedded_UI flag.
          The only difference between Desktop and Embedded builds is that the
          filing system name is NOT printed on Embedded builds upon Service_Reset.
        * Built and tested on Lazarus 32-bit build.  Code is binary identical to
          previous versions the relied on the STB flag in both the Desktop and
          Embedded cases.
        * Requires HdrSrc 1.17 or later.
      Version 2.53. Tagged as 'FileSwitch-2_53'
  31. 20 Mar, 2000 2 commits
    • Kevin Bracey's avatar
      32-bit compatible. · a6c7a3b0
      Kevin Bracey authored
        Tested on a 32-bit system; untested on 26-bit, and merge with Ursula branch
      Version 2.52. Tagged as 'FileSwitch-2_52'
    • Kevin Bracey's avatar
      RISC OS Ltd changes merged onto trunk. · af0badf9
      Kevin Bracey authored
        (extracted from BuffyLog)
        * Fixed problem with > 67 character filenames in OS_FSControl 26-28.
          buffer now fixed at 256 characters but lengths are now checked.
        * Paths may now be of any length without crashing fileswitch. On some
          occasions errors will be returned for long filenames (usually
          buffer overflow), but it will never crash. This does not stop other
          code (usually upcall handlers) from crashing the machine.
        Not tested (TM). Shout at me if it doesn't work.
      Version 2.51. Tagged as 'FileSwitch-2_51'