GitLab has been upgraded to 13.7.4 If you encounter any issues mail

Commit 1bce8e2c authored by Julie Stamp's avatar Julie Stamp Committed by ROOL

Fix check-byte for laying out defect list on big discs

Calculate the checkbyte for the second defect list (>512M) in accordance with the PRM:
"The byte yy is a check-byte calculated from the previous words in the second defect list"
Currently the code includes all of the first defect list including its terminator when calculating the check-byte for the second defect list.

As a result an empty defect list goes from



I do not believe this code would ever have been used before, since FileCore_LayoutStructure
is only used in the OS
1) To format floppies, which are smaller than 512MB and
2) To format the RAM disc, which up till now has been smaller than 512MB.

FileCore never looks at the >512M defect list outside of FileCore_LayoutStructure, the defect command is not able to add defects to the second list.

HForm already calculates the checkbyte in accordance with the PRM, and this change ensures
that large RAM discs will conform.

Tested by examining 600MB RamDisc0.

Version 3.76. Tagged as 'FileCore-3_76'
parent 04030b45
; This file is automatically maintained by srccommit, do not edit manually.
; Last processed by srccommit version: 1.1.
GBLS Module_MajorVersion
GBLA Module_Version
......@@ -10,14 +9,12 @@
GBLS Module_ApplicationDate
GBLS Module_HelpVersion
GBLS Module_ComponentName
GBLS Module_ComponentPath
Module_MajorVersion SETS "3.75"
Module_Version SETA 375
Module_MajorVersion SETS "3.76"
Module_Version SETA 376
Module_MinorVersion SETS ""
Module_Date SETS "06 Jul 2017"
Module_ApplicationDate SETS "06-Jul-17"
Module_Date SETS "21 Nov 2020"
Module_ApplicationDate SETS "21-Nov-20"
Module_ComponentName SETS "FileCore"
Module_ComponentPath SETS "castle/RiscOS/Sources/FileSys/FileCore"
Module_FullVersion SETS "3.75"
Module_HelpVersion SETS "3.75 (06 Jul 2017)"
Module_FullVersion SETS "3.76"
Module_HelpVersion SETS "3.76 (21 Nov 2020)"
/* (3.75)
/* (3.76)
* This file is automatically maintained by srccommit, do not edit manually.
* Last processed by srccommit version: 1.1.
#define Module_MajorVersion_CMHG 3.75
#define Module_MinorVersion_CMHG
#define Module_Date_CMHG 06 Jul 2017
#define Module_MajorVersion_CMHG 3.76
#define Module_MinorVersion_CMHG
#define Module_Date_CMHG 21 Nov 2020
#define Module_MajorVersion "3.75"
#define Module_Version 375
#define Module_MajorVersion "3.76"
#define Module_Version 376
#define Module_MinorVersion ""
#define Module_Date "06 Jul 2017"
#define Module_Date "21 Nov 2020"
#define Module_ApplicationDate "06-Jul-17"
#define Module_ApplicationDate "21-Nov-20"
#define Module_ComponentName "FileCore"
#define Module_ComponentPath "castle/RiscOS/Sources/FileSys/FileCore"
#define Module_FullVersion "3.75"
#define Module_HelpVersion "3.75 (06 Jul 2017)"
#define Module_LibraryVersionInfo "3:75"
#define Module_FullVersion "3.76"
#define Module_HelpVersion "3.76 (21 Nov 2020)"
#define Module_LibraryVersionInfo "3:76"
......@@ -447,7 +447,6 @@ LayoutBootBlock ROUT
BEQ %FT30 ; no second defect list
MOV r1, #0
MOV r5, r4
LDR lr, [r5], #4
TSTS lr, #DefectList_BigMap_End
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment