1. 29 Dec, 2021 1 commit
    • Andy Vawer's avatar
      Fix crash on closing menu containing a writeable icon with focus as part of the menu tree · a3b6237a
      Andy Vawer authored
      * When closing menus, set_caret_position is called to remove the caret from the menu tree
        which tries to redraw the icon without a caret as the window is still defined and valid
      * This happens after clearing the menutaskhandle though, so the redraw can't page in the
        right task
      * The redraw then fails badly trying to access memory from the wrong task
      Version 5.84. Tagged as 'Wimp-5_84'
  2. 13 Sep, 2021 1 commit
    • Andy Vawer's avatar
      Abandon set caret position if the window or menu isn't there · 0148e0ea
      Andy Vawer authored
      During destruction of the menu tree, if set caret position fails when resetting the caret to the old position (ie. illegal window handle as the window has been deleted) then destroying the menu tree also fails with catastrophic results.
      * Do not fault SetCaretPosition to invalid window handle, just change it to -1
      * Do not try to redraw areas of an invalid window when moving caret
      Version 5.82. Not tagged
  3. 12 Sep, 2020 1 commit
  4. 08 Jul, 2020 1 commit
  5. 25 Jan, 2020 1 commit
  6. 04 Jan, 2020 2 commits
  7. 18 Dec, 2019 1 commit
    • ROOL's avatar
      Clipboard caret/task fixes · 9cc627ac
      ROOL authored
        In CnPCaret.s
          * Clear any invalid window handles currently stored in caret blocks on Wimp_SetCaretPosition entry
          * Clear R2 on exit if R0=-1,R2=TASK on entry to Wimp_SetCaretPosition
          * If window is not open or able to receive a focus, then return WimpFocus error rather than causing an alignment exception
        In CBTask.s
          A drag to writeable with invalid (eg.rejection due to validation string mismatch or overlong insert) caused ghost caret to be left behind and still deletes the source text.
          * Changed LDR R2,=cbtask_TASK to LDR r2,cbtask3_TASK
          * Ensure cbtask_insert_text_into_icon returns V set on error
          Drag and drop text from icon to non-d&d application, the last message was erroneously sent as DataSaveAck, not Dataload
        Submission for Clipboard Support bounty.
      Version 5.66. Tagged as 'Wimp-5_66'
  8. 14 Dec, 2019 1 commit
    • ROOL's avatar
      Add copy & paste and drag & drop operations to the Wimp · 0fb14a00
      ROOL authored
        The text in writable icons can now be manipulated using the familiar keyboard shortcuts, or using Drag and Drop in conjunction with any compliant applications.
        Further details are in Doc/DragAndDrop along with information on API extensions which are implemented.
        Submission for Clipboard Support bounty.
      Version 5.65. Tagged as 'Wimp-5_65'