1. 29 Dec, 2021 1 commit
    • Andy Vawer's avatar
      Fix crash on closing menu containing a writeable icon with focus as part of the menu tree · a3b6237a
      Andy Vawer authored
      * When closing menus, set_caret_position is called to remove the caret from the menu tree
        which tries to redraw the icon without a caret as the window is still defined and valid
      * This happens after clearing the menutaskhandle though, so the redraw can't page in the
        right task
      * The redraw then fails badly trying to access memory from the wrong task
      Version 5.84. Tagged as 'Wimp-5_84'
  2. 15 Dec, 2021 1 commit
  3. 13 Sep, 2021 2 commits
    • Robert Sprowson's avatar
      Fix to invalidate entire tile cache · be34ad90
      Robert Sprowson authored
      A hardwired 18 in reset_all_tiling_sprites meant that one slot was never cleared, so a change in the Wimp's sprite pool could leave a cached sprite pointer pointing to something invalid.
      Ref https://www.riscosopen.org/forum/forums/5/topics/16708
      Version 5.83. Tagged as 'Wimp-5_83'
    • Andy Vawer's avatar
      Abandon set caret position if the window or menu isn't there · 0148e0ea
      Andy Vawer authored
      During destruction of the menu tree, if set caret position fails when resetting the caret to the old position (ie. illegal window handle as the window has been deleted) then destroying the menu tree also fails with catastrophic results.
      * Do not fault SetCaretPosition to invalid window handle, just change it to -1
      * Do not try to redraw areas of an invalid window when moving caret
      Version 5.82. Not tagged
  4. 14 Jul, 2021 1 commit
    • Jeffrey Lee's avatar
      Crunch ROM icon sprites · e62f3580
      Jeffrey Lee authored
      Save around 50KB of ROM space by converting the icon sprites to use RISC
      OS 3.5 mode words instead of numbered modes, reducing the size of the
      mask data to around a quarter of its old value.
      Tested in IOMD ROM, with boot sequence disabled (to ensure the ROM
      sprites get used).
      Version 5.82. Tagged as 'Wimp-5_82'
  5. 10 Jul, 2021 1 commit
    • Robert Sprowson's avatar
      Add themeable icon bar tiles · 5958a073
      Robert Sprowson authored
      Allow theme designers to use a different sprite for the background tile of the iconbar, distinct from the other windows. This looks for 'tile_i' before falling back to 'tile_1' as before, in addition to the existing 'tile_m' for menus.
      Version 5.81. Tagged as 'Wimp-5_81'
  6. 17 Oct, 2020 1 commit
    • Andy Vawer's avatar
      Fixes for dropping text into writable icons · 30c0dbf5
      Andy Vawer authored
      * If dragging text from a writable icon and the source text or selection disappears during the drag, an ofla error occurs. Change to abort quietly (ie no text copied as nothing to copy) and remove the ghost caret from view.
      * Remove ghost caret on invalid dropped drags
      * Either use correct insert point from ghost caret when receiving a drag, or use current mouse coords for the destination if no ghost caret present.
      * Change datasave handling to check ghost caret presence for the destination rather than trying to check the enhanced datasave state.
      * Use window X coord for drop rather than screen Xcoord to ensure correct insert point.
      Fixes dragging multiline text areas from Draw leaving a ghost caret when it failed, and dragging a basic text object from Draw now inserts at the correct place.
      Version 5.80. Tagged as 'Wimp-5_80'
  7. 12 Sep, 2020 1 commit
  8. 26 Aug, 2020 1 commit
  9. 20 Jul, 2020 1 commit
    • Robert Sprowson's avatar
      Rename clashing CLI macro · 85171512
      Robert Sprowson authored
      The name clashes with the recently added clear IRQ flag macro, CLI, but is only used in a debug case.
      Version 5.77. Not tagged
  10. 08 Jul, 2020 1 commit
  11. 29 Jun, 2020 1 commit
  12. 23 May, 2020 1 commit
  13. 11 May, 2020 1 commit
  14. 02 May, 2020 1 commit
    • Jeffrey Lee's avatar
      Fix delivery of extended scroll requests · b752d15a
      Jeffrey Lee authored
      Extended scroll requests and regular scroll requests share the same
      reason code, but are different sizes. Update calcmessagesize to
      calculate the size of extended scroll messages correctly, so that the
      icon number won't get chopped off when the message is being passed to
      the target task.
      Version 5.73. Tagged as 'Wimp-5_73'
  15. 11 Apr, 2020 1 commit
    • Andy Vawer's avatar
      Allow text to be dragged from writable icons to icon bar icons · 791a168f
      Andy Vawer authored
      Check destination window handle and add destination icon handle if sending message to window handle -2.
      Improve window handle validation (not assuming all -ve handles are invalid, should the RMA move to have top bit set).
      Version 5.72. Tagged as 'Wimp-5_72'
  16. 30 Jan, 2020 1 commit
    • Andy Vawer's avatar
      Fix issue where dragging text from icon caused a crash in foreground task · 1475387a
      Andy Vawer authored
      When releasing claim, use of stale register meant that the foreground task wasn't correctly bouncing Message_Dragging when the pointer moved out of range. Also added a sanity check in get_selected_text so that if for some reason the selection window disappears mid action it will be caught and not cause a crash.
      Version 5.71. Tagged as 'Wimp-5_71'
  17. 25 Jan, 2020 1 commit
  18. 18 Jan, 2020 1 commit
    • Andy Vawer's avatar
      Fix zero page access looking for ptr_ sprite validation · 384a1ec5
      Andy Vawer authored
      On mouse click, check for icon type was incorrect, so trying to apply tests for 'P' validation string/ptr_write on inappropriate icons (eg. sprites), leading to invalid validation string accesses. Correct the test performed.
      Also add 3 further AcceptLoosePointer checks to validation string pointers.
      Version 5.69. Tagged as 'Wimp-5_69'
  19. 04 Jan, 2020 2 commits
    • ROOL's avatar
      Fix lost menu clicks on icons when window partly off screen · 28d1efb9
      ROOL authored
        Don't trap menu clicks on icons when the window isn't fully on-screen.
        Ref https://www.riscosopen.org/forum/forums/4/topics/14961?page=1
        Submission for Clipboard Support bounty.
      Version 5.68. Tagged as 'Wimp-5_68'
    • Jeffrey Lee's avatar
      Add Wimp_Extend 15, "read slot size" · 4610877c
      Jeffrey Lee authored
      Wimp_Extend 15 is equivalent to Wimp_SlotSize,-1,-1, with the exception
      that the sizes returned in R0-R2 are now measured in pages instead of
      bytes. This allows code to accurately read the amount of free memory on
      machines with >2GB of RAM, and provides some future-proofing should we
      ever wish to support tasks with >2GB of RAM (e.g. via a future
      super-jumbo wimpslot, or more likely via sparse/PMP wimpslots, where
      the physical size is larger than the logical size).
      Currently there's no need to provide a page-based call to set the slot
      size (~2GB is fine for the forseeable future), so this call only
      focuses on reading the sizes.
      Version 5.67. Tagged as 'Wimp-5_67'
  20. 18 Dec, 2019 1 commit
    • ROOL's avatar
      Clipboard caret/task fixes · 9cc627ac
      ROOL authored
        In CnPCaret.s
          * Clear any invalid window handles currently stored in caret blocks on Wimp_SetCaretPosition entry
          * Clear R2 on exit if R0=-1,R2=TASK on entry to Wimp_SetCaretPosition
          * If window is not open or able to receive a focus, then return WimpFocus error rather than causing an alignment exception
        In CBTask.s
          A drag to writeable with invalid (eg.rejection due to validation string mismatch or overlong insert) caused ghost caret to be left behind and still deletes the source text.
          * Changed LDR R2,=cbtask_TASK to LDR r2,cbtask3_TASK
          * Ensure cbtask_insert_text_into_icon returns V set on error
          Drag and drop text from icon to non-d&d application, the last message was erroneously sent as DataSaveAck, not Dataload
        Submission for Clipboard Support bounty.
      Version 5.66. Tagged as 'Wimp-5_66'
  21. 14 Dec, 2019 2 commits
  22. 17 Aug, 2019 1 commit
  23. 22 Jun, 2019 1 commit
    • ROOL's avatar
      New Wimp_Extend subreason · 32f2e389
      ROOL authored
        Subreason 14 gives a means to read the validation string from a window/icon that is not in the current task. This is useful for determining whether clipboard operations should be allowed.
        Submission for Clipboard Support bounty.
      Version 5.64. Tagged as 'Wimp-5_64'
  24. 05 Jun, 2019 1 commit
  25. 01 Jul, 2018 1 commit
    • Jeffrey Lee's avatar
      Fix handling of tool sprite palettes in alpha-blended screen modes · 39485b7c
      Jeffrey Lee authored
        s/Wimp10 - Update mastertoactive to force the palette/translation table to be sent through ColourTrans if either &RGB component ordering or alpha blending is in use for the current screen mode. Otherwise, for alpha modes, the alpha channel would typically be left at zero.
        Tested on Raspberry Pi 3
      Version 5.62. Tagged as 'Wimp-5_62'
  26. 18 Mar, 2018 1 commit
    • Robert Sprowson's avatar
      Fix for bad error pointer deleting non existent sprite · 431bcb1a
      Robert Sprowson authored
      Doing *WimpKillSprite _not_there_  had the following behaviour
      Priority   | Sprite exists  Sprite doesn't  Sprite is ROM
      Lo then Hi | Deletes        Bad error ptr   Silence
      Hi then Lo | Deletes        Silence         Silence
      The bad error pointer was caused by an early return if the high priority pool is the ROM sprites (because the earlier failure to find it in the low priority pools set V, and the early return used TEQ, so the error pointer in R0 was the SpriteOp reason code).
      Proceed to try to look up the sprite, even if there's no hope of deleting it, in order to get a valid error message.
      Version 5.61. Tagged as 'Wimp-5_61'
  27. 17 Feb, 2018 1 commit
    • Jeffrey Lee's avatar
      Fix crashes when a Wimp_Poll post-filter causes the Wimp to postpone switching... · 2fb1a8bf
      Jeffrey Lee authored
      Fix crashes when a Wimp_Poll post-filter causes the Wimp to postpone switching to a VFP-enabled task
        s/Wimp07 - In ExitPoll, swap around the order of restoring the FP context and calling the poll post-filter so that the FP context is restored after the post-poll filter has been invoked. Previously, the VFP(+FPA) context would be restored, then the post-poll filter would be invoked. If the post-poll filter was claimed, the Wimp would then scan the pollwords again and most likely decide to switch to a different task. The appslot will then be switched over, and ExitPoll will be invoked again, attempting to restore the VFP/FPA context for that task - potentially causing a crash or other bad things because the VFP context used by the original choice of task is no longer paged in. For FPA this was never really a problem, since the context is stored in the RMA rather than being potentially stored in appspace.
        s/Wimp03 - Add some extra debug out for tracking VFP context management
        Tested on wandboard
        Fixes issue reported on forums, where using the numpad in VFP SciCalc would cause a crash if KeyExtend was loaded:
      Version 5.60. Tagged as 'Wimp-5_60'
  28. 24 Jul, 2017 1 commit
    • Jeffrey Lee's avatar
      Remove startup delay from power saving code · 74a6db0a
      Jeffrey Lee authored
        s/Wimp02 - Get rid of the magic ~30 second delay before the Portable_Speed/Portable_Idle power saving kicks in. The fast/slow thresholds are self-adjusting, and any non-null poll event will kick the system into high speed, so removing the startup delay isn't likely to have any adverse affect on desktop startup time.
        s/Wimp01 - MaxIdleEvents is now redundant, remove it
        Tested on Raspberry Pi 3
        Should resolve issue reported on the forums where RPCEmu thrashes the hosts's CPU for 30 seconds after entering the desktop:
      Version 5.59. Tagged as 'Wimp-5_59'
  29. 11 Apr, 2017 1 commit
    • Robert Sprowson's avatar
      Gate the recache of currentmode · 50eea7b2
      Robert Sprowson authored
      The operations at module init and at Service_PreReset are both implicitly pre desktop, however it is valid to have Service_ModeFileChanged while in the desktop (for example, if selecting a different MDF from !ScrnSetup).
      Gate the one hanging off Service_ModeFileChanged to only act when there are no tasks active (ie. outside the Wimp).
      Fixes problem reported https://www.riscosopen.org/forum/forums/4/topics/9206 with NetSurf redraw.
      Version 5.58. Tagged as 'Wimp-5_58'
  30. 08 Apr, 2017 1 commit
    • ROOL's avatar
      Recache currentmode at the right time · 121acd27
      ROOL authored
        Modification to make the Wimp reread 'currentmode' by calling OS_ReadSysInfo 1 in the following circumstances
        1. On module init (accounts for being softloaded off disc)
        2. At Service_Reset (accounts for any graphics driver starting after it in ROM module order)
        3. When Service_ModeFileChange (new, this catches the new mode selected by an MDF or EDID during !Boot)
        Commoned up these 3 cases into 1 function.
        This restores the design intent that to get the monitor's native resolution it is *not* required to configure the MonitorType=EDID, indeed doing so wouldn't have helped loading EDID off disc if the monitor's data is found to be incorrect and needing overriding.
        Tested on a Pandaboard with MonitorType=Auto and resolution chosen as "Native", resulting in a desktop at the panel resolution.
      Version 5.57. Tagged as 'Wimp-5_57'
  31. 25 Mar, 2017 1 commit
    • Jeffrey Lee's avatar
      Fix use of uninitialised pointer · 4d355e68
      Jeffrey Lee authored
        s/Wimp01 - initwcfda tries to look up the dynamic area name using MsgTrans, so make sure the 'messages' pointer is initialised before we call it
        Tested on iMx6
      Version 5.56. Tagged as 'Wimp-5_56'
  32. 16 Sep, 2016 1 commit
  33. 28 May, 2016 1 commit
    • Jeffrey Lee's avatar
      Remove redundant GET · d336b82f
      Jeffrey Lee authored
        s/Wimp - IO header doesn't appear to be necessary for build, so don't get it
        Tested with PlingSystem build (new "26" machine type aims to be machine-independent, so doesn't define $GetIO)
        Untested at runtime
      Version 5.54. Tagged as 'Wimp-5_54'
  34. 23 May, 2016 1 commit
    • Jeffrey Lee's avatar
      Fix invalid AMB node handle being used when low on memory · 7212561d
      Jeffrey Lee authored
        s/Wimp08s - If OS_AMBControl allocate is asked for a AMB node with a size > 0, but no pages can be claimed, it frees the node and returns an invalid handle (0). Make sure that the Wimp's allocateslot routine is aware of this, so that we don't try passing that bad handle back to AMBControl later on
        s/Iconbar - Use nullptr constant instead of -1 when checking task_slotsize (aka AMB node handle on modern machines)
        Tested on BB-xM
        Fixes abort seen when attempting to start a task with no pages in the free pool
      Version 5.53. Tagged as 'Wimp-5_53'
  35. 08 May, 2016 1 commit
    • Jeffrey Lee's avatar
      Avoid unnecessary remainder calculations · ace2e66f
      Jeffrey Lee authored
        s/Wimp01, s/Wimp02, s/Wimp05, s/Wimp08s, s/Wimp10 - Avoid unnecessary remainder calculations in DivRem macro. Also make more use of DivRem's ability to accept a constant (not a register) as the divisor.
        Tested on Cortex-A15
      Version 5.52. Tagged as 'Wimp-5_52'
  36. 29 Nov, 2015 1 commit
  37. 10 Oct, 2015 1 commit
    • Jeffrey Lee's avatar
      Reinstate Wimp_ClaimFreeMemory · 503570de
      Jeffrey Lee authored
        This restores support for Wimp_ClaimFreeMemory, via having the Wimp manage a small-ish (4MB) DA that is used to satisfy Wimp_ClaimFreeMemory requests. The Wimp will only ever grow the DA, but the DA is shrinkable, so the system should shrink it as necessary should the free pool run too low.
        Options/s/!Default, Options/s/32, Options/s/Ursula - Add DynamicAreaWCF option to control support for the Wimp_ClaimFreeMemory DA. Enable the option for any builds of the module destined for RISC OS 5.
        Options/s/!Debug - New debug option for Wimp_ClaimFreeMemory debugging (mainly DynamicAreaWCF code path)
        Wimp/s/Wimp01 - Add calls to create/destroy DA on startup/shutdown
        Wimp/s/Wimp08s - DA create/destroy implementation. DA is only used if the free pool is a PMP or the Wimp expects kernel free pool locking but the kernel doesn't support it. Modify Wimp_ClaimFreeMemory to use the DA if it's present.
        Tested on Raspberry Pi
        Restores compatibility with software which relies on Wimp_ClaimFreeMemory, e.g. GDraw module (cause of "No free memory" errors reported by many)
        Note that Wimp_ClaimFreeMemory is still considered deprecated and support may be removed in future OS versions.
      Version 5.50. Tagged as 'Wimp-5_50'