Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Open sidebar
RiscOS
S
Sources
Desktop
Wimp
Commits
5e0e65cc
Commit
5e0e65cc
authored
Sep 06, 2020
by
Andy Vawer
Committed by
ROOL
Sep 12, 2020
Browse files
Fix stack imbalance in Wimp_SetCaretPosition if called with invalid icon handle & flags
Version 5.79. Tagged as 'Wimp-5_79'
parent
56afccc6
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
17 additions
and
18 deletions
+17
-18
VersionASM
VersionASM
+6
-6
VersionNum
VersionNum
+10
-10
s/CnPCaret
s/CnPCaret
+1
-2
No files found.
VersionASM
View file @
5e0e65cc
...
@@ -9,12 +9,12 @@
...
@@ -9,12 +9,12 @@
GBLS Module_ApplicationDate
GBLS Module_ApplicationDate
GBLS Module_HelpVersion
GBLS Module_HelpVersion
GBLS Module_ComponentName
GBLS Module_ComponentName
Module_MajorVersion SETS "5.7
8
"
Module_MajorVersion SETS "5.7
9
"
Module_Version SETA 57
8
Module_Version SETA 57
9
Module_MinorVersion SETS ""
Module_MinorVersion SETS ""
Module_Date SETS "
26 Aug
2020"
Module_Date SETS "
12 Sep
2020"
Module_ApplicationDate SETS "
26-Aug
-20"
Module_ApplicationDate SETS "
12-Sep
-20"
Module_ComponentName SETS "Wimp"
Module_ComponentName SETS "Wimp"
Module_FullVersion SETS "5.7
8
"
Module_FullVersion SETS "5.7
9
"
Module_HelpVersion SETS "5.7
8
(
26 Aug
2020)"
Module_HelpVersion SETS "5.7
9
(
12 Sep
2020)"
END
END
VersionNum
View file @
5e0e65cc
/* (5.7
8
)
/* (5.7
9
)
*
*
* This file is automatically maintained by srccommit, do not edit manually.
* This file is automatically maintained by srccommit, do not edit manually.
*
*
*/
*/
#define Module_MajorVersion_CMHG 5.7
8
#define Module_MajorVersion_CMHG 5.7
9
#define Module_MinorVersion_CMHG
#define Module_MinorVersion_CMHG
#define Module_Date_CMHG
26 Aug
2020
#define Module_Date_CMHG
12 Sep
2020
#define Module_MajorVersion "5.7
8
"
#define Module_MajorVersion "5.7
9
"
#define Module_Version 57
8
#define Module_Version 57
9
#define Module_MinorVersion ""
#define Module_MinorVersion ""
#define Module_Date "
26 Aug
2020"
#define Module_Date "
12 Sep
2020"
#define Module_ApplicationDate "
26-Aug
-20"
#define Module_ApplicationDate "
12-Sep
-20"
#define Module_ComponentName "Wimp"
#define Module_ComponentName "Wimp"
#define Module_FullVersion "5.7
8
"
#define Module_FullVersion "5.7
9
"
#define Module_HelpVersion "5.7
8
(
26 Aug
2020)"
#define Module_HelpVersion "5.7
9
(
12 Sep
2020)"
#define Module_LibraryVersionInfo "5:7
8
"
#define Module_LibraryVersionInfo "5:7
9
"
s/CnPCaret
View file @
5e0e65cc
...
@@ -375,8 +375,7 @@ wscp_workarea
...
@@ -375,8 +375,7 @@ wscp_workarea
; is the icon handle valid?
; is the icon handle valid?
LDR
R14
,[
handle
,#
w_nicons
]
LDR
R14
,[
handle
,#
w_nicons
]
CMP
R1
,
R14
; icon handle out of range?
CMP
R1
,
R14
; icon handle out of range?
Pull
"R0-R7,R11,R14"
,
HS
; abort if so
BHS
exitsetcaret
; abort if so
BHS
exitsetcaret
LDR
R14
,[
handle
,#
w_taskhandle
]
LDR
R14
,[
handle
,#
w_taskhandle
]
Task
R14
,,
"SetCaret"
; page in window owner task
Task
R14
,,
"SetCaret"
; page in window owner task
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment